e5371253cb
New work on Raid invite with a invitor having a group
2022-01-09 11:24:59 -04:00
1c57e5b898
A few more use cases working
2022-01-08 20:39:47 -04:00
8fc3ac1e50
Work on usecase 5
2022-01-08 10:06:36 -04:00
947fb239a9
Use Case 1, 2, 3,4,7 working.
...
Need to fix 5, 6, 8
2022-01-08 00:03:05 -04:00
b8b5ca0e67
Before VS Crash
2022-01-07 20:09:38 -04:00
40e3484bb4
Some Bot Raid working
2022-01-07 18:57:26 -04:00
ec26281ad5
Updated Raid::VerifyRaid
2022-01-06 19:54:06 -04:00
fdb23f1a5f
Update to Client::QueuePacket to not attempt to send a packet to a BoT. Not clean, but a broad solution.
2022-01-06 17:18:34 -04:00
42ef4a2891
End of day Jan 5
...
Working Raid Invite to a Bot.
2022-01-05 22:46:06 -04:00
d85646b637
Basement Jan 5
2022-01-05 17:33:52 -04:00
6802681abe
Jan 4
...
Basic structure in place for Raid::AddBot though not working
2022-01-04 23:40:00 -04:00
ba0c03af08
Bot Group Work
...
Fixed botid=charid spawn on zone issue
Added a group_list update on zone to refresh from database to fix a dangling pointer to a Bot object that was camped but was previously in a group within the zone being entered.
Modified Bot::ProcessBotGroupInvite to use the client of the bot when doing the Bot initialization so that a leader can invite another owner's Bot
2022-01-03 11:52:08 -04:00
bcf28bc35c
BOT work
...
Added BOT logging damage/heals to owner
Added BOT message to owner for harmony fails
Made var Critical global to remove duplicate crit messages
Added a NULL check to Mob:GetCleanname()
2021-12-30 15:42:03 -04:00
bcf0677656
2021-03-25 11L04pm
...
Spell and Heal Rule added to allow for Bot spell and heal damage to be sent to the Bot Owner's Group. Also added a check to remove duplicate message for #damage on self.
2021-03-25 23:05:37 -03:00
dd1ce19d4f
Add Bot Heal Message Display
...
Creates a new rule to display Bot heal messages to the Bot Owner
2021-03-25 21:18:52 -03:00
76812e2051
Fix for GENERIC_9_STRINGS
2021-03-25 21:10:45 -03:00
d202695e88
[Cleanup] Only link Lua with zone ( #1288 )
...
Only zone requires to be linked to lua, so let's not link EVERYTHING.
There is probably more clean up we could do, but I know for a fact Lua
is only used by zone.
This probably has some measurable benefits that probably don't really
matter that much :)
2021-03-19 00:12:46 -05:00
323f5ea92e
[Bug Fix] Add Bounds Checking to OP_LFGCommand Comment Processing
...
Theoretically this could be used to corrupt memory, but they would have
to get extremely lucky to actually execute a successful attack
2021-03-18 23:43:13 -05:00
5b74f1e756
[Expeditions] Refactor expedition requests ( #1301 )
...
Move ExpeditionLockoutTimer to common
This simplifies expedition request conflict checks and uses repository
for the queries instead of processing the query result directly.
2021-03-18 23:42:41 -05:00
ee4af65268
[Expeditions] Cleanup client dz safe return methods ( #1300 )
...
This changes Zone::GetDynamicZone to return a pointer instead of a copy
and also lets DynamicZone be forward declared in zone.h
2021-03-18 23:42:20 -05:00
739b975cad
[Expeditions] [Quest API] Add expedition IsLocked to Quest API ( #1292 )
2021-03-16 00:04:08 -05:00
5035451af7
[Crash] Bugfix for zone crash caused by #flymode -1 ( #1291 )
...
* Update command.cpp
Fixed typo in the command description.
* Bugfix for #flymode zone crash
Bugfix for #flymode zone crash when invalid values are passed. Also, when entering #flymode without parameters, the correct syntax is now displayed.
* Changed as requested
2021-03-16 00:03:35 -05:00
18a3ff5f12
Throttle auto expedition leader changes ( #1293 )
...
This fixes unnecessary leader processing on mass dzquits
Also marks leader dirty for empty expeditions in case something goes
wrong (shouldn't be possible after 62e480fe
2021-03-16 00:01:48 -05:00
0d12bf0b1f
[Expeditions] Store description and leader name on dz ( #1294 )
...
* Rename dynamic zone source files
* Store description and leader name on dz
Removes the DynamicZoneInfo struct used for switch list window. This
data can be stored on DynamicZone and kept updated by its owning system
* Separate create compass packet method
Cleanup MarkSingleCompassLoc
2021-03-16 00:00:55 -05:00
b3fbe1b015
add quest::get_spell_level(uint16 spell_id, uint8 class_id) ( #1295 )
2021-03-15 23:59:09 -05:00
e9cd0b15a2
setting spawn2.version to -1 will now properly spawn mobs in all zone versions ( #1299 )
2021-03-15 23:57:54 -05:00
cd08c96fa4
[Quest API] Add secondstotime(duration) to Perl and Lua. ( #1281 )
...
- Add quest::converttime(duration) to Perl.
- Add eq.convert_time(duration) to Lua.
2021-03-11 21:38:47 -05:00
ac4a993259
Remove unneeded calls to DoAnim() for spells/bardsong ( #1290 )
...
* Removed DoAnim() call from spells and bard song. Tested on rof2 and titanium
Co-authored-by: Noudess <noudess@gmail.com >
2021-03-10 00:07:30 -05:00
435bac5599
Update command.cpp ( #1289 )
...
Fixed typo in the command description.
2021-03-07 14:40:50 -05:00
d5d6b911b0
Merge pull request #1286 from EQEmu/bug_fix/petonspawn_copypasteerror
...
Fix copy and paste error
2021-03-06 20:09:12 -05:00
29cdca380f
Fix copy and paste error
2021-03-06 19:58:18 -05:00
e5f5db69b4
Merge pull request #1280 from EQEmu/bug_fix/strcpy_overlap_GetGroupLeadershipInfo
...
[ASan] Fix strcpy-param-overlap with GetGroupLeadershipInfo calls
2021-03-05 19:24:42 -08:00
d635e69ee3
Merge pull request #1283 from EQEmu/cleanup/Wformat-overflow
...
[Cleanup] Make code -Wformat-overflow safe
2021-03-05 19:23:48 -08:00
a1531aa057
Merge pull request #1282 from EQEmu/bug_fix/spawngroup_leak_repop
...
[Leak] Port SpawnGroup stuff to unique_ptr to fix leak
2021-03-05 19:23:00 -08:00
b24ba221e9
Merge pull request #1279 from EQEmu/bug_fix/group_delete
...
[ASan] Fix heap-use-after-free issue with groups
2021-03-05 19:20:34 -08:00
253f0594e4
Merge pull request #1278 from EQEmu/akkadius/fix-skill-caps-loading-consistency
...
[Bugfix] Fix Skill Caps Loading References
2021-03-05 19:20:11 -08:00
02517bf6ab
Merge pull request #1276 from EQEmu/cleanup/uv_handle_cast_deletes
...
[ASan] Use casts to silence ASan complaints
2021-03-05 19:19:42 -08:00
184128a79b
Merge pull request #1275 from EQEmu/bug_fix/stack-buffer-overflow_StopLFP
...
[ASan] Fix stack-buffer-overflow thanks to StopLFP
2021-03-05 19:17:12 -08:00
93869dbef6
Merge pull request #1273 from EQEmu/hate_list_quest_api
...
[Quest API] Add GetHateClosest() and GetHateListByDistance(distance) to Perl and Lua.
2021-03-05 19:16:38 -08:00
af82a6c5d5
Merge pull request #1272 from noudess/master
...
[Bug Fix] Do not summon pet or set new pet state when PC summoned by a mob
2021-03-05 19:16:03 -08:00
fdca333280
Merge pull request #1271 from EQEmu/cleanup/world_client_clearance
...
[ASan] Make Client::Clearance less gross
2021-03-05 19:14:26 -08:00
c954c08c07
Merge pull request #1267 from EQEmu/bug_fix/realodquest_encounter_crash
...
[Crash] Fix ReloadQuest on Shutdown crash related to encounters
2021-03-05 19:13:58 -08:00
0b8220be32
Clean up last name handling in NPC::PetOnSpawn
...
Same as last time
2021-03-05 15:51:59 -05:00
f7d40ec88e
Clean up Merc::LoadMerc lastname processing
...
This is still less than ideal, but client's name restrictions should
prevent this from being an actual problem
2021-03-05 15:43:06 -05:00
316336d1cf
Nuke ZoneDatabase::GetEventLogs
...
This wasn't called anywhere and was throwing format-overflow warnings
2021-03-05 15:25:32 -05:00
224c26620e
Clean up MOTD processing
2021-03-05 15:24:40 -05:00
c6d5864aa9
Port SpawnGroup stuff to unique_ptr to fix leak
...
This was leaking on #repop, unsure of other cases, smart pointers should
cover us though.
Direct leak of 3600 byte(s) in 18 object(s) allocated from:
#0 0x7f2b3dbe0d30 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.5+0xead30)
#1 0x5645dc7c9dff in ZoneDatabase::LoadSpawnGroups(char const*, unsigned short, SpawnGroupList*) ../zone/spawngroup.cpp:241
#2 0x5645dc9db3f5 in Zone::Depop(bool) ../zone/zone.cpp:1746
#3 0x5645dca1ba6b in Zone::Repop(unsigned int) ../zone/zone.cpp:1777
#4 0x5645db4624b7 in command_repop(Client*, Seperator const*) ../zone/command.cpp:5683
Indirect leak of 6552 byte(s) in 273 object(s) allocated from:
#0 0x7f26f2ff8d30 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.5+0xead30)
#1 0x558d00490bc6 in __gnu_cxx::new_allocator<std::_List_node<SpawnEntry*> >::allocate(unsigned long, void const*) /usr/include/c++/8/ext/new_allocator.h:111
#2 0x558d00490bc6 in std::allocator_traits<std::allocator<std::_List_node<SpawnEntry*> > >::allocate(std::allocator<std::_List_node<SpawnEntry*> >&, unsigned long) /usr/include/c++/8/bits/alloc_traits.h:436
#3 0x558d00490bc6 in std::__cxx11::_List_base<SpawnEntry*, std::allocator<SpawnEntry*> >::_M_get_node() /usr/include/c++/8/bits/stl_list.h:450
#4 0x558d00490bc6 in std::_List_node<SpawnEntry*>* std::__cxx11::list<SpawnEntry*, std::allocator<SpawnEntry*> >::_M_create_node<SpawnEntry* const&>(SpawnEntry* const&) /usr/include/c++/8/bits/stl_list.h:642
#5 0x558d00490bc6 in void std::__cxx11::list<SpawnEntry*, std::allocator<SpawnEntry*> >::_M_insert<SpawnEntry* const&>(std::_List_iterator<SpawnEntry*>, SpawnEntry* const&) /usr/include/c++/8/bits/stl_list.h:1903
#6 0x558d00490bc6 in std::__cxx11::list<SpawnEntry*, std::allocator<SpawnEntry*> >::push_back(SpawnEntry* const&) /usr/include/c++/8/bits/stl_list.h:1220
#7 0x558d00490bc6 in SpawnGroup::AddSpawnEntry(SpawnEntry*) ../zone/spawngroup.cpp:122
#8 0x558d00490bc6 in ZoneDatabase::LoadSpawnGroups(char const*, unsigned short, SpawnGroupList*) ../zone/spawngroup.cpp:291
#9 0x558d006a1465 in Zone::Depop(bool) ../zone/zone.cpp:1746
#10 0x558d006e1adb in Zone::Repop(unsigned int) ../zone/zone.cpp:1777
2021-03-02 12:39:04 -05:00
c45395be95
Fix strcpy-param-overlap with GetGroupLeadershipInfo calls
...
==1810==ERROR: AddressSanitizer: strcpy-param-overlap: memory ranges [0x7ffef04baf90,0x7ffef04baf98) and [0x7ffef04baf90, 0x7ffef04baf98) overlap
#0 0x7f163bb9509e (/lib/x86_64-linux-gnu/libasan.so.5+0x4f09e)
#1 0x5652caed27b3 in Client::Handle_Connect_OP_ZoneEntry(EQApplicationPacket const*) ../zone/client_packet.cpp:1535
==1918==ERROR: AddressSanitizer: strcpy-param-overlap: memory ranges [0x7ffddc8057c0,0x7ffddc8057c8) and [0x7ffddc8057c0, 0x7ffddc8057c8) overlap
#0 0x7fc61ee0e09e (/lib/x86_64-linux-gnu/libasan.so.5+0x4f09e)
#1 0x56023c149698 in WorldServer::HandleMessage(unsigned short, EQ::Net::Packet const&) ../zone/worldserver.cpp:1055
2021-02-28 21:42:51 -05:00
6d47351d15
Fix heap-use-after-free issue with groups
...
==2317==ERROR: AddressSanitizer: heap-use-after-free on address 0x6170000633c0 at pc 0x55ed1d8e8d8b bp 0x7ffda4bef580 sp 0x7ffda4bef578
WRITE of size 8 at 0x6170000633c0 thread T0
#0 0x55ed1d8e8d8a in Group::SetLeader(Mob*) ../zone/groups.h:80
#1 0x55ed1d8e8d8a in Group::DisbandGroup(bool) ../zone/groups.cpp:1016
ASan didn't like this
2021-02-28 21:40:50 -05:00
450c748299
Fix database connection pointer bucket consistency
2021-02-28 19:31:46 -06:00
neckkola
Neckkola
Michael Cook (mackal)
hg
Thalix
splose
Alex
Paul Coene
Alex
Akkadius