Michael Cook (mackal)
f9f3a8f3bd
Expendable Arrows ignore EQ
2016-08-17 01:10:37 -04:00
Michael Cook (mackal)
5a0d2b527b
Add a StopCasting function and make some use of it
...
Unsure if all of these cases should use interrupt or stop casting
2016-08-16 17:52:14 -04:00
Michael Cook (mackal)
3d64878e60
Skip OP_BeginCast for discs
2016-08-15 15:23:37 -04:00
Michael Cook (mackal)
26772b721c
Fix overhaste stack check
2016-08-15 14:21:39 -04:00
Michael Cook (mackal)
3c95545ea3
Remove IsCasting check from Client::SendManaUpdatePacket
2016-08-15 01:23:47 -04:00
Michael Cook (mackal)
ae5689ffb4
Clean up OP_ManaChange
2016-08-15 01:17:53 -04:00
Michael Cook (mackal)
e894e96404
Implement Linked Spell Reuse Timers
...
They started linked spells at OoW launch (I think)
At least canni was linked then.
This is rather user unfriendly, but that's live like.
Ex. the spells aren't actually put on cool down so you can attempt to cast them
still but you will be interrupted.
Titanium is particularly unfriendly with large differences in reuse times
2016-08-14 23:32:27 -04:00
Michael Cook (mackal)
fd1e425abc
Fix potential crash in ucs/clientlist.cpp
2016-08-13 17:19:20 -04:00
Michael Cook (mackal)
35c1eccbe1
Fix potential crash in zone/worldserver.cpp
2016-08-13 17:15:57 -04:00
Michael Cook (mackal)
69f06f736c
Fix potential crashes in zone/spells.cpp
2016-08-13 17:15:00 -04:00
Michael Cook (mackal)
48fb483de6
Fix typo
2016-08-13 17:05:48 -04:00
Michael Cook (mackal)
8ce2921e3d
Fix potential crashes in Mob::SpellEffect
2016-08-13 16:45:32 -04:00
Michael Cook (mackal)
f06a9b3dce
use std::abs in Map::FindClosestZ
2016-08-13 15:58:02 -04:00
Michael Cook (mackal)
3efc925264
And another
2016-08-13 15:47:44 -04:00
Michael Cook (mackal)
a8db4532d0
Fix potential crash in #iteminfo
2016-08-13 15:46:35 -04:00
Michael Cook (mackal)
ab35f8b842
Fix memset in QuestReward
2016-08-13 15:39:08 -04:00
Michael Cook (mackal)
ef3cf099b8
Fix potential crash in Sacrifice
2016-08-13 15:35:28 -04:00
Michael Cook (mackal)
00cfe2d25f
Fix potential crashes in attack.cpp
2016-08-13 15:26:07 -04:00
Michael Cook (mackal)
7a4c9b36a8
Fix logic issue in SendAlternateAdvancementRank
2016-08-13 15:20:48 -04:00
Michael Cook (mackal)
488c4941d2
Fix potential crash
2016-08-13 15:19:10 -04:00
Michael Cook (mackal)
97dc0a84dd
Fix logic paren issue
2016-08-13 15:14:31 -04:00
Michael Cook (mackal)
f01c890966
Crash fix
...
The other thing needs to be looked at too, but I guess we never run
into an issue where this actually is a nullptr because bad things
would happen here ...
2016-08-13 15:09:43 -04:00
Michael Cook (mackal)
4e4d82857c
Move OP_BeginCast above instant cast shortcut
...
For casted seplls, we should always see this. Mostly this shortcut breaks
spell awareness for NPC spells. (most of them are instant cast)
2016-08-12 22:07:03 -04:00
Michael Cook (mackal)
039e0fbb83
NPC innate procs overwrite TargetType to ST_Target
2016-08-12 21:53:14 -04:00
Michael Cook (mackal)
e1a02455d8
Merge pull request #539 from clucksoft/crash_fix
...
Prevent crash in spell casting when group doesn't exist
2016-08-11 14:22:51 -04:00
Michael Cook (mackal)
e90e141a79
std::unordered_map::count is much slower than find
2016-08-10 23:51:06 -04:00
Michael Cook (mackal)
38d3f9b7c0
Client checks song flag first
...
This fixes bugs with buffs marked as disc and song (they go to the song window now)
Before the client got confused and gave up displaying them at all!
2016-08-10 13:16:32 -04:00
Michael Cook (mackal)
7d62b208ca
Revert "Rate limit saving to at most once a second"
...
This reverts commit f26dce39c3 .
No easy mode I guess
2016-08-09 21:30:10 -04:00
Michael Cook (mackal)
27f6826fd3
Add rule Spells:AllowItemTGB for custom servers
2016-08-08 20:21:38 -04:00
Michael Cook (mackal)
051f9ffab9
fix bard song mods on instant spells (nukes, procs)
2016-08-08 15:22:26 -04:00
Michael Cook (mackal)
bdb083eac7
Previous disc buff check incorrectly excluded Savage Spirit AA line
...
This still doesn't fix Untamed Rage ... unsure on that one :(
2016-08-07 18:55:02 -04:00
Michael Cook (mackal)
4b93ef0a98
Fix SE_CastOnFadeEffect
2016-08-07 18:17:39 -04:00
Michael Cook (mackal)
e86d11250b
Actually remove expendable AAs from the DB
2016-08-07 14:32:30 -04:00
Michael Cook (mackal)
e5746c3b2e
Fix EVENT_LOOT broken by b43cfa126
2016-08-05 22:14:20 -04:00
Michael Cook (mackal)
6a7ea65dd0
Ask water map if we're in a zoneline to prevent false positives
...
I don't think this should open up any chance to exploit
Trying to use a ZL to go somewhere else is still detected etc
This should really cut down on false positives and we really can't
see real cheater from all the noise this creates
2016-08-05 01:07:12 -04:00
Michael Cook (mackal)
68df09a570
Implement PVP regions
2016-08-04 23:56:08 -04:00
Michael Cook (mackal)
d53d569020
Port EQMacEmu's improved NPC stat scaling formula
...
Old formula can be used by setting NPC::NewLevelSacling to false
2016-08-04 22:12:33 -04:00
Michael Cook (mackal)
1d12f92934
Level 50+ NPCs will now respond to yells for help regardless of con color
2016-08-04 20:36:15 -04:00
Michael Cook (mackal)
e89fa01d89
Port Aggro:UseLevelAggro from EQMacEmu
...
This will make level 18+ mobs braver
2016-08-04 20:33:29 -04:00
Michael Cook (mackal)
8dc8e53218
Added some more comments to PassCastRestrictions
2016-08-04 13:50:20 -04:00
Michael Cook (mackal)
33407ee0da
Forgot divination
2016-08-03 23:14:02 -04:00
Michael Cook (mackal)
c81a5e0783
Limit casting skill ups to casting skills
2016-08-03 23:06:00 -04:00
Michael Cook (mackal)
66fec40169
Move Enrage check to after the immune ripo check
2016-08-03 22:38:33 -04:00
Michael Cook (mackal)
60f2d14caa
Rework bash/kick stun based on client
...
This is what the client is doing. It doesn't reuse all the old rules, so those
can't be tweaked unless someone wants to add them back in
2016-08-03 17:37:09 -04:00
Michael Cook (mackal)
538d6a2a33
Hack to fix RNG Nature Veil line
2016-08-03 01:44:33 -04:00
Michael Cook (mackal)
f26dce39c3
Rate limit saving to at most once a second
...
There are A LOT of unneeded saves ...
This will prevent a lot of excessive database hits at least
with very little room to exploit
2016-08-03 01:13:51 -04:00
Michael Cook (mackal)
acb5bb3e3e
If this flag is set, we JUST saved
...
Also saved due to an OP_Save very recently ...
2016-08-03 00:33:22 -04:00
Michael Cook (mackal)
16125c38af
Lets not save here if we're zoning
2016-08-03 00:13:47 -04:00
Michael Cook (mackal)
69db67efe5
Remove extra save
2016-08-02 23:32:37 -04:00
Michael Cook (mackal)
37ecc69088
Update UF packet stuff to have 30 BUFF_COUNT
2016-08-02 21:10:32 -04:00
Michael Cook (mackal)
d68a3b191e
Give pets 30 buff because that's what they got
2016-08-02 21:08:05 -04:00
Michael Cook (mackal)
64cf613189
Update GetCurrentBuffSlots() for TSS free slots
...
The client also checks if you have any bonus from spells and items
so why not check that as well
2016-08-02 19:00:33 -04:00
Michael Cook (mackal)
2bae779a9b
NPCs don't have separate buff windows
2016-08-02 16:48:58 -04:00
Michael Cook (mackal)
e862994716
RoF/RoF2 spell gem refresh in PP
...
This fixes issues with long recast spells
2016-07-31 18:09:04 -04:00
Michael Cook (mackal)
f612f8be42
Fix typo
2016-07-31 17:35:33 -04:00
Michael Cook (mackal)
ef2c17748e
Implement extra spell gems!
...
New limits:
Tit: 9
SoF: 9
SoD: 10
UF: 12
RoF: 12
RoF2: 12
The SoF client doesn't actually support 10 like SoF should
RoF/RoF2 actually have 4 extra broken spell gems in the UI. They don't work and
will likely crash your client
Quest stuff assumes you are passing in valid slots.
(note the old default of 10 should be 22)
There are still somethings to do like clean up the memmed spells if one switches
to an older client that doesn't support as many as their previous client.
2016-07-31 17:16:23 -04:00
Michael Cook (mackal)
4c4b0aba0c
Switch trading to call CommonBreakInvisible()
2016-07-30 12:51:17 -04:00
Michael Cook (mackal)
3a4b341ad6
Allow quest controlled TS to have no returns
2016-07-29 15:29:28 -04:00
Michael Cook (mackal)
2a2ce6da5d
Fix item clicks being TGBable
2016-07-29 15:14:26 -04:00
Michael Cook (mackal)
239c478f31
Add some comments to target types [skip ci]
2016-07-29 02:55:43 -04:00
Michael Cook (mackal)
f6c62af82e
Update comment [skip ci]
2016-07-29 02:26:26 -04:00
Michael Cook (mackal)
345f3d6301
Fix Tit OP_Buff decode
2016-07-27 19:58:24 -04:00
Michael Cook (mackal)
de5170c5cb
Fix mana burn
2016-07-26 17:10:06 -04:00
Michael Cook (mackal)
7674b3a077
Fix some same spell stacking issues
2016-07-26 16:25:19 -04:00
Michael Cook (mackal)
11e017ccb9
Fix bard mod in PP for UF
2016-07-25 16:37:27 -04:00
Michael Cook (mackal)
bda4fcfb26
Fix up SpellBuff struct
...
Please report any bugs you find. There shouldn't be unless I messed up the struct
for a client I didn't throughly test for
2016-07-25 16:22:48 -04:00
Michael Cook (mackal)
a7fd9312d0
Fix syntax error
2016-07-24 22:58:48 -04:00
Michael Cook (mackal)
3963897fe4
There is a different rez spell depending on race
2016-07-24 22:53:57 -04:00
Michael Cook (mackal)
f42b0351fd
Improve list of skipped effects in stacking code
...
This is the list according to the client (RoF2)
Please report any stacking anomalies
2016-07-24 22:24:53 -04:00
Michael Cook (mackal)
343b781e74
Implement cast_not_standing and fix Cazic Touch
...
No idea why this spell field does this, but that's what the client
is doing with it ...
2016-07-23 18:40:17 -04:00
Michael Cook (mackal)
f428a8a56a
Add a CastWhileInvis check and fix some issues
2016-07-23 18:07:56 -04:00
Michael Cook (mackal)
cd9a7f1d5d
Cap tic diff to 0 for duration based calcs
...
This will match Splurt with the double 191
2016-07-23 17:52:30 -04:00
Michael Cook (mackal)
83548ee405
Fix buff tics
...
This will not fade buffs at 6s :P
2016-07-23 17:41:16 -04:00
Michael Cook (mackal)
5f588934a9
Make decaying spell bonuses not depend on CaclBonuses being called some other way
...
This just sets a flag that will tell us we need to recalc bonuses every tick
Before these kind of depended on it being caused some other way
2016-07-23 13:55:36 -04:00
Michael Cook (mackal)
1f5dcb6965
Make SE_SpellResistReduction not complain
2016-07-21 20:27:08 -04:00
Michael Cook (mackal)
5f111f159b
Update comment [skip ci]
2016-07-21 14:05:29 -04:00
Michael Cook (mackal)
527ee56fb2
Fix Distance Mod scaling
...
The client clamps the distance between the min/max
2016-07-20 17:49:33 -04:00
Michael Cook (mackal)
8396f19e85
Add buff level restrictions for pets
2016-07-20 16:27:22 -04:00
Michael Cook (mackal)
ccb5427b45
Make VS debug mode happy
...
This actually hurts microbenchmarking
I couldn't get the ModelEntry::polys vector to play nice with benchmarking
so it will just be using push_back so I don't have write a new ctor
(writing a new ctor and using emplace_back vs push_back were equal)
2016-07-18 21:57:25 -04:00
Michael Cook (mackal)
8983f3c5dc
Merge pull request #537 from noudess/master
...
Fix for BuffDurationPacket on movement speed buffs.
2016-07-18 16:05:28 -04:00
Michael Cook (mackal)
aeff31ba7a
Fix error with /setstartcity
2016-07-18 13:57:14 -04:00
Michael Cook (mackal)
f431e820ef
Optimize Map::LoadV2 a bit
...
Microbenchmarking showed ~33% increase in loading moors
Real world testing showed ~48%
2016-07-17 23:35:18 -04:00
Michael Cook (mackal)
c41521c310
Fix saving binds on charcreate
2016-07-17 22:50:00 -04:00
Michael Cook (mackal)
7cd613e5f2
Comment spell struct with official names for each field
2016-07-17 02:13:13 -04:00
Michael Cook (mackal)
921136c987
Exclude in other Perma Illusion spot
2016-07-16 19:40:20 -04:00
Michael Cook (mackal)
d4df2e7351
Exclude Minor Illusion and Illusion: Tree from perma
2016-07-16 19:33:36 -04:00
Michael Cook (mackal)
9cf553232d
Tweak spell dot stacking exempt based on client
2016-07-16 18:18:41 -04:00
Michael Cook (mackal)
bbf4d19de3
Revert "Changed tuple use to struct in maps.cpp (LoadV2) (should help in client drops where slow zone boot-ups are a factor)"
...
This reverts commit 02cedce54e .
This is breaks moors!
2016-07-15 15:20:36 -04:00
Michael Cook (mackal)
a9ff407657
Optimize Mapp:RotateVertex()
...
This function can get rather expensive and waste a surprisingly
large amount of time. Using moors as a test zone simply switching
from the C math API cos/sin to std::cos/std::sin seemed to help
11.11% Map::RotateVertex(glm::tvec3<float, (glm::precision)0>&, float, float, float)
4.16% Map::RotateVertex(glm::tvec3<float, (glm::precision)0>&, float, float, float)
2016-07-10 23:18:26 -04:00
Michael Cook (mackal)
4b57f69cba
Fix illusions on zone
2016-07-07 16:17:13 -04:00
Michael Cook (mackal)
860ee81a38
Break invis for AA casts
2016-06-30 21:59:50 -04:00
Michael Cook (mackal)
bcec9501b7
Fix issue with invis not dropping for new item clicks
...
Clients using OP_ItemVerifyRequest couldn't break the invis
themselves, so we gotta for them
2016-06-30 21:49:20 -04:00
Michael Cook (mackal)
37b46d1289
Make more usage of CancelSneakHide
2016-06-30 21:49:00 -04:00
Michael Cook (mackal)
54de212214
Implement OP_CancelSneakHide
...
Didn't test every client, but they should all work
2016-06-30 17:50:31 -04:00
Michael Cook (mackal)
a64343689c
Refactor loot response a bit
...
Invis is dropped after ALL error checking now
Identified all the response types
2016-06-30 14:00:18 -04:00
Michael Cook (mackal)
3e0af2928b
Remove duped code from CommonBreakInvisibleFromCombat
2016-06-30 01:30:51 -04:00
Michael Cook (mackal)
59ec184208
Merge pull request #533 from noudess/master
...
Res effects now block certain buffs like on live. Blocked spells generate message like on live.
2016-06-28 13:34:39 -04:00
Michael Cook (mackal)
30b516e7bd
Merge pull request #530 from EQEmu/luarocks
...
Add luarocks support
2016-06-17 21:09:40 -04:00
Michael Cook (mackal)
57ebfd2675
Merge pull request #532 from noudess/master
...
Changed personal faction earned min/max values to -2000/2000.
2016-06-13 14:30:39 -04:00
Michael Cook (mackal)
af99db7287
Merge pull request #531 from noudess/master
...
Fix for detrimental/beneficial spell overwrite and/or block.
2016-06-13 13:27:41 -04:00