RekkasGit
fa55fd1664
[Bug Fix] Fix Heroic INT/WIS Bonuses ( #3341 )
...
* fix for heroic int/wis for hybrids
* Update classes.cpp
* Update classes.cpp
---------
Co-authored-by: Kinglykrab <kinglykrab@gmail.com>
2023-05-15 10:52:53 -04:00
Chris Miles
8814ab26cd
[Hotfix] Fix mob item bonus calc ( #3334 )
2023-05-07 18:23:22 -05:00
Chris Miles
4a5559022f
[Memory Leak] Fix large memory leak introduced in CalcItemBonuses ( #3331 )
2023-05-07 09:47:03 -04:00
Paul Coene
e19b8d3056
[Bug Fix] Fix issue with NPCs no longer using some armor. ( #3318 )
...
* [BugFix/NPCs] Fix issue with NPCs no longer using some armor.
* Removed redundant memory clear
2023-04-24 17:05:29 -04:00
Alex King
a40e1cf893
[Cleanup] Add missing breaks and returns in bonuses.cpp ( #3231 )
...
# Notes
- Many spots were missing a `break;` or a `return` for their value.
2023-04-05 11:15:22 -04:00
Alex King
c81ab00764
[Cleanup] Set bonuses to use spell ID instead of boolean ( #3230 )
...
# Notes
- Spell bonuses `Illusion` is the spell ID, not a boolean.
2023-04-05 11:14:55 -04:00
Alex King
025ef5e1d6
[Cleanup] Move unreachable code in ApplySpellsBonuses() ( #3229 )
...
# Notes
- This code was unreachable since it was inside the switch and should have been checked on its own in the condition where we verify we are using AISpellEffects.
2023-04-05 11:14:28 -04:00
Alex King
1f29a40e6d
[Cleanup] Remove extraneous check for NegateAttacks in SE_NegateAttacks ( #3228 )
...
# Notes
- We checked both, we only need to check one.
2023-04-05 11:12:02 -04:00
Alex King
66cadd599b
[Cleanup] Remove extraneous parentheses around math in Mob::ApplySpellsBonuses() ( #3227 )
...
# Notes
- Extra parentheses.
2023-04-05 11:11:41 -04:00
Alex King
aa0345c1f1
[Cleanup] Cleanup duplicate conditions in negate bonuses in bonuses.cpp ( #3226 )
...
# Notes
- Lots of duplicate conditions.
2023-04-05 11:11:22 -04:00
Alex King
73b11c5036
[Cleanup] SE_StrikeThrough and SE_StrikeThrough2 are the same in bonuses.cpp ( #3223 )
...
# Notes
- These were the same code duplicated.
2023-04-05 11:05:59 -04:00
Alex King
efbeb2dbb7
[Cleanup] SE_AttackSpeed3 effect_value is always less than 0 ( #3222 )
...
# Notes
- This was always false.
2023-04-05 11:05:44 -04:00
Alex King
26fd52fb06
[Cleanup] Fix SEResist array settings duplicate code ( #3225 )
...
# Notes
- These conditions did the same thing, combining them is simpler.
2023-04-03 16:53:48 -04:00
Alex King
cb129efcad
[Cleanup] Fix loop and code duplication for SE_ProcOnKillShot ( #3224 )
...
* [Cleanup] Fix loop for SE_ProcOnKillShot
# Notes
- We were doing `e = 3` instead of doing `e += 3`.
* Update bonuses.cpp
2023-04-03 16:28:15 -04:00
Aeadoin
7f7ba2e6c2
[Cleanup] Remove unused Includes under zone files ( #3162 )
2023-04-01 22:55:28 -04:00
Aeadoin
6927177291
[Fix] Correct SE_SlayUndead & SE_HeadShotLevel limit Value when applied. ( #3171 )
2023-04-01 13:31:13 -04:00
Aeadoin
0df84e1ee6
[Crash] Fix out of bound arrays, other potential crashes ( #3166 )
2023-04-01 12:44:41 -04:00
Alex King
26c267db1b
[Cleanup] "equipped" not "equiped", "dual" not "duel". ( #3149 )
...
* [Cleanup] "equipped" not "equiped", "dual" not "duel".
# Notes
- These are spelled incorrectly.
* Update spdat.h
* Formatting further.
* Update api_service.cpp
2023-03-27 17:55:37 -04:00
Alex King
9d1ace627c
[Feature] Add support for -1 extradmgskill to allow all skills to be scaled. ( #3136 )
...
* [Feature] Add support for -1 extradmgskill to allow all skills to be scaled.
- `$mob->GetSkillDmgAmt(skill_id)` now uses `int` instead of `uint16`.
- `statbonuses:GetSkillDamageAmount(skill_id)` now uses `-1` properly.
- `mob:GetSkillDmgAmt(skill_id)` now uses `int` instead of `uint16`.
- A `-1` value in `extradmgskill` denotes the ability to scale all skills at once.
- Consolidated `AddItemBonuses()`, `AdditiveWornBonuses()`, `CalcItemBonuses()`, and `CalcRecommendedLevelBonus()` to mob-based methods to avoid code duplication.
- Bots, NPCs, and Mercs can now use additive worn effects if the rule is enabled, as well as all other proper stat bonuses that only clients had before.
- No SQL update required to change `extradmgskill` and `extradmgamt` to `int` as they already are this type in the database, just had to adjust `item_data.h` and `shareddb.cpp`.
* Update mob.cpp
* Cleanup.
* Cleanup.
* Move #include <vector> to header.
* Add method for GetExtraDamageSkills
* fix additembonuses
* Update bonuses.cpp
* Update mob.cpp
* Out of bounds.
* Update bonuses.cpp
---------
Co-authored-by: Aeadoin <109764533+Aeadoin@users.noreply.github.com>
2023-03-25 20:26:01 -04:00
Aeadoin
59ad91a140
[Feature] Add Data Bucket support for scaling of Heroic Stats. ( #3058 )
...
* [Feature] Add Data Bucket support for scaling of Heroic Stats.
* update
* fixes, still reworking logic
* fixes, still reworking logic
* logic done
* logic done
* fixes
* Cleanup
* Cleanup
* Cleanup naming, verify behaviors
* formatting
* formatting
* fix issue with endurance and mana.
* update rule desc
* cleanup
* DataBucket Struct
* Cleanup data_bucket.cpp and add constants
* cleanup
* changes
* formatting
* fix from merge
* escape keyword `key`
* Add `key` to generator, run repository-generator.pl
* fix for change to key
* cleanup
* formatting
* formatting
* typo
2023-03-23 21:42:13 -04:00
Alex King
2f4c91824e
[Feature] Add Item Extra Skill Damage Percent Modifier ( #3127 )
...
* [Feature] Add Item Extra Skill Damage Percent Modifier
# Notes
- Allows `Character:ItemExtraDmgCap` to be disabled if set to `-1` or lower.
- Allows operators to set `Character:ItemExtraSkillDamageCalcAsPercent` to `true` to allow skill damage for Frenzy, Backstab, Bash, Slam, Kick, and all Monk attacks to scale with a percentage based on `extradmgamt` values from items and spells.
* > 0
2023-03-19 09:59:13 -04:00
Aeadoin
5ee2856133
[Bug Fix] Replace uses of SPELL_UNKNOWN with IsValidSpell() ( #2938 )
2023-02-15 21:01:35 -06:00
Alex King
bc6efd5f74
[Quest API] (Performance) Check equip or scale item events exist before export and execute ( #2898 )
...
* [Quest API] Optional parse equip and scale item events
# Notes
- Optionally parse `EVENT_SCALE_CALC`, `EVENT_ITEM_ENTER_ZONE`, `EVENT_UNEQUIP_ITEM_BOT`, `EVENT_EQUIP_ITEM_BOT`, `EVENT_EQUIP_ITEM`, `EVENT_UNEQUIP_ITEM`, `EVENT_EQUIP_ITEM_CLIENT`, `EVENT_UNEQUIP_ITEM_CLIENT`
* Cleanup
2023-02-12 22:15:54 -06:00
Aeadoin
fb1467284c
[Bots] Add Additional HeroicStr modifiers. ( #2837 )
2023-02-06 21:07:38 -05:00
Alex King
3335cacac1
[Bots] Cleanup and remove preprocessors. ( #2757 )
...
* [Bots] Cleanup and remove preprocessors.
- Removes every `#ifdef BOTS` we have and locks bots behind `Bots:AllowBots` rule.
- Bot updates are now done by default similar to regular database updates.
- Modify `CMakeLists.txt`, `.drone.yml`, and `BUILD.md` to match the removal of `EQEMU_ENABLE_BOTS`.
* Cleanup
- Add SQL for enabling bots for servers with bots.
- Add message that tells players/operators bots are disabled.
* Suggested changes.
* Bot injection stuff
* Change SQL to bot SQL.
* Tweaks
* Remove `is_bot`
* Update version.h
* Update main.cpp
* Update database.cpp
* Fix name availability crash
* Remove bots from update script
Co-authored-by: Akkadius <akkadius1@gmail.com>
2023-01-20 12:35:33 -06:00
Aeadoin
2587a7fed5
out of bound ( #2723 )
2023-01-11 17:54:42 -05:00
Kinglykrab
7160aa651e
[Cleanup] Cleanup Haste references and Lua API calls for unsigned to signed. ( #2240 )
2022-06-04 14:00:21 -04:00
Chris Miles
5b4aeaa457
[Code Cleanup] Remove this-> in code where its implied ( #2088 )
2022-05-01 10:22:09 -04:00
KayenEQ
bbe2db7c0f
[Bug Fix] Bard Invisible causing display issues. ( #2067 )
...
* [Bug Fix] Bard Invisible causing display issues.
Error occurring due to bard modifiers being applied to invisible spell effect value.
* [Bug Fix] Bard Invisible causing display issues.
2022-04-02 00:01:38 +02:00
KayenEQ
5fd62d82db
Update bonuses.cpp ( #2002 )
2022-02-15 08:57:53 -05:00
KayenEQ
b938e6223c
[Spells] Invisibility updates and rework ( #1991 )
...
* updates pre merge
* update
* Update spell_effects.cpp
* Update mob.h
* test
* test
* updates
* updates
* save
* update
* working solid
* animal and undead start
* progress
* updates
* rename
* set invis appearance on bonus
* remove fade buff state check
* update IsViisble check
* optimizing
* don't break bots
* debug remover
* Update ruletypes.h
* perl adds
* Update client_packet.cpp
* update
* done
* remove debugs
* Update client_packet.cpp
* update
* [Spells] Invisibility updates and rework
lua support
* [Spells] Invisibility updates and rework
lua
2022-02-15 00:18:02 -05:00
KayenEQ
51c8771bd2
bug fix ( #2001 )
2022-02-15 00:17:23 -05:00
KayenEQ
d300e78b39
[Spells] Illusions will now persist onto the corpse when mob is killed. ( #1960 )
...
* illusion applies to corpse
* Update spell_effects.cpp
* [Spells] Illusions will now persist onto the corpse when mob is killed.
addressed comments
2022-02-04 21:14:29 -05:00
KayenEQ
5ce2889210
[Bug Fix] Illusions will now properly display armor to other clients when they zone in. ( #1958 )
...
* Fix for illusion wear change
On zone in, mobs with illusions were not displaying correct armor.
* [Bug Fix] Illusions will now properly display armor to other clients when they zone in
better looping
2022-02-03 22:04:15 -05:00
JJ
613066976d
[Bug Fix] Update to #1893 ( #1926 )
...
* Update to #1893
* Missed bonuses.cpp
2022-01-12 22:04:58 -05:00
KayenEQ
323b35989c
[Spells] Implemented SPA 281 SE_PetFeignMinion ( #1900 )
...
* start
* update
* debugs in
* test
* clean up
* debugs removed
* Update mob_ai.cpp
* Update spdat.h
* [Spells] Implemented SPA 281 SE_PetFeignMinion
debug remoevd
* [Spells] Implemented SPA 281 SE_PetFeignMinion
npc forget timer
* [Spells] Implemented SPA 281 SE_PetFeignMinion
2021-12-27 11:33:57 -05:00
KayenEQ
886b321e66
[Spells] Rework of SPA 288 SE_SkillAttackProc ( #1893 )
...
* start
* updated 288
2021-12-20 09:47:32 -05:00
KayenEQ
d460fb3db8
[Spells] Update to SPA 440 SE_FinishingBlowMaxLevel limit value sets HP ratio for FB ( #1890 )
...
* fb max level update
* Update to SPA 440 SE_FinishingBlowMaxLevel limit value sets HP ratio for FB
2021-12-15 22:00:34 -05:00
KayenEQ
119b2d023f
[Spells] Throwing procs fixed and other proc updates ( #1871 )
...
* first updating sbindex defines
* updates
* updates
* proctypes added for organization
* debug
* updates
* range procs cleaned up
* skill proc clean up
* fix
* remove debugs
* [Spells] Throwing procs fixed and other proc updates
* [Spells] Throwing procs fixed and other proc updates
bot fix
* [Spells] Throwing procs fixed and other proc updates
proctype updates
2021-12-14 12:34:51 -05:00
KayenEQ
73acc3310c
[Spells] Updates and fixes to targeted focus effects ( #1870 )
2021-12-14 12:31:38 -05:00
KayenEQ
26b21673ad
[Spells] Implemented SPA 245 SE_TrapCircumvention ( #1885 )
...
* implemented
* [Spells] Implemented SPA 245 SE_TrapCircumvention
2021-12-13 20:33:22 -05:00
KayenEQ
7cf66a2daa
[Spells] Update SPA 238 SE_IllusionPersistence allow illusions to persist through deaths at higher AA ranks. ( #1884 )
...
* start
* working
2021-12-13 18:49:33 -05:00
KayenEQ
e9fc80815a
[Spells] Support for SPA 161 and 450 to give percent spell or dot mitigation from Items or AA's. ( #1793 )
...
* spell dot shield item AA support
* Update spdat.h
* Update attack.cpp
2021-11-21 10:16:55 -05:00
KayenEQ
f1bfd6bc2a
[Spells] Implemented SPA 512 SE_Proc_Timer_Modifier, Fixed AA procs not working ( #1646 )
...
* update for SPA 511
* remove debugs, AA implemented
* update
* twinprocfix
* AA procs added
* format update
* update
* proctimer limits
* update
* rename function
renamed function
only check for buffs value > 0, don't need to check for AA's which are negative ID's
* pre merge
* variable updates
* Update spell_effects.cpp
* var rename
update var name to better represent its function.
* updated proc struct
added reuse timer
* reuse timer to spell procs
* updates
* debug remove
* Update mob.cpp
* fix
* merge
2021-11-05 14:14:11 -04:00
Kinglykrab
17aaab1f9d
[Quest API] Add Spell methods to Perl. ( #1631 )
...
* [Quest API] Add Spell methods to Perl.
- Add quest::getspell(spell_id) to Perl.
- Add eq.get_spell(spell_id) to Lua.
These methods return a spell object.
Exports $spell object references to spell events.
* Formatting.
* Remove comment.
* Update spdat.cpp
* Amplication typo.
* Fix conflicts.
* Remove repository changes.
* Fix typing.
* Update spell_effects.cpp
2021-11-03 17:47:15 -04:00
KayenEQ
987de17e93
[Spells] Rework for SPA 413 SE_FcBaseEffects and Bard updates ( #1629 )
...
* baseline start
* update1
* updates
* base effect implemented for bard
* instrument mod updates
amplification amps itself
* updates
* updates
* debug
* base effect updates
* baseeffects for spell focus updated
* update skill attack baseeffects
* focus will remain for quest functions
* song cap mod added back in
* remove debugs1
* fix cr
* base effects functionalish
* remove debug
* Update client_mods.cpp
* spdat instrumentmod
* Update spell_effects.cpp
* Update spdat.h
* remove new instrument mod check
split PR
2021-10-24 18:38:28 -05:00
KayenEQ
6a962f2591
[Spells] Update SPA158 Reflect ( #1590 )
...
* update
* updates
* updates
* update
* update
* Update ruletypes.h
* Apply extra spell dmg
Mob with the reflect effect apply its Extra Spell Damage from item stat to the reflected spell.
Updated portion of formula for extra damage based on live parsing.
* correct formula
2021-10-12 15:30:36 -04:00
KayenEQ
55d45f9a98
updates
2021-10-05 15:50:26 -04:00
KayenEQ
71870cbd1c
[Spells] Update to SPA 442 and 443 (SE_TriggerOnReqTarget, SE_TriggerOnReqCaster) ( #1543 )
...
* Update to SPA 442 and 443
Use SpellRestriction Id's and updated PassCastRestriction code
* Update mob.cpp
2021-09-19 15:16:56 -05:00
KayenEQ
46edd56acc
[Spells] Update SPA 101 SE_CompleteHeal ( #1544 )
...
Fixed buff stacking issue
2021-09-19 15:16:21 -05:00
