[Memory Leak] Fix large memory leak introduced in CalcItemBonuses (#3331)

This commit is contained in:
Chris Miles 2023-05-07 08:47:03 -05:00 committed by GitHub
parent 5be2041085
commit 4a5559022f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -146,18 +146,7 @@ void Mob::CalcItemBonuses(StatBonuses* b) {
int16 i;
for (i = EQ::invslot::BONUS_BEGIN; i <= EQ::invslot::BONUS_SKILL_END; i++) {
const EQ::ItemInstance* inst = nullptr;
if (IsOfClientBotMerc()) {
inst = GetInv().GetItem(i);
} else {
const auto* item = CastToNPC()->GetItem(i);
if (!item) {
continue;
}
inst = database.CreateItem(item->item_id);
}
const EQ::ItemInstance* inst = m_inv[i];
if (!inst) {
continue;
}