[Cleanup] Fix loop and code duplication for SE_ProcOnKillShot (#3224)

* [Cleanup] Fix loop for SE_ProcOnKillShot

# Notes
- We were doing `e = 3` instead of doing `e += 3`.

* Update bonuses.cpp
This commit is contained in:
Alex King 2023-04-03 16:28:15 -04:00 committed by GitHub
parent d653989b03
commit cb129efcad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -5043,20 +5043,27 @@ void Mob::NegateSpellEffectBonuses(uint16 spell_id)
case SE_ProcOnKillShot:
{
for (int e = 0; e < MAX_SPELL_TRIGGER * 3; e = 3)
for (int e = 0; e < MAX_SPELL_TRIGGER * 3; e += 3)
{
if (negate_spellbonus) { spellbonuses.SpellOnKill[e] = effect_value; }
if (negate_spellbonus) { spellbonuses.SpellOnKill[e + 1] = effect_value; }
if (negate_spellbonus) { spellbonuses.SpellOnKill[e + 2] = effect_value; }
if (negate_spellbonus) {
spellbonuses.SpellOnKill[e] = effect_value;
spellbonuses.SpellOnKill[e + 1] = effect_value;
spellbonuses.SpellOnKill[e + 2] = effect_value;
}
if (negate_aabonus) { aabonuses.SpellOnKill[e] = effect_value; }
if (negate_aabonus) { aabonuses.SpellOnKill[e + 1] = effect_value; }
if (negate_aabonus) { aabonuses.SpellOnKill[e + 2] = effect_value; }
if (negate_aabonus) {
aabonuses.SpellOnKill[e] = effect_value;
aabonuses.SpellOnKill[e + 1] = effect_value;
aabonuses.SpellOnKill[e + 2] = effect_value;
}
if (negate_itembonus) { itembonuses.SpellOnKill[e] = effect_value; }
if (negate_itembonus) { itembonuses.SpellOnKill[e + 1] = effect_value; }
if (negate_itembonus) { itembonuses.SpellOnKill[e + 2] = effect_value; }
if (negate_itembonus) {
itembonuses.SpellOnKill[e] = effect_value;
itembonuses.SpellOnKill[e + 1] = effect_value;
itembonuses.SpellOnKill[e + 2] = effect_value;
}
}
break;
}