pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-13 10:31:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
10,739 Commits 88 Branches 159 Tags
Commit Graph

10739 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alex King
3a1e88f9ed
[Cleanup] Remove unused SetConfigFile in common/eqemu_config.h (#3208) 
# Notes
- This is unused.
 2023-04-05 12:15:10 -04:00
Alex King
4e101aa6d6
[Cleanup] Use default dtor instead of empty dtor for EQTime in eqtime.cpp/eqtime.h (#3210) 
# Notes
- This is better than using an empty dtor.
 2023-04-05 12:15:02 -04:00
Alex King
ef411ee154
[Cleanup] Use default ctor instead of an empty ctor. (#3206) 
# Notes
- Use `= default;` instead of an empty ctor.
- https://pvs-studio.com/en/docs/warnings/v832/
 2023-04-05 12:14:22 -04:00
Alex King
93b3f97f24
[Cleanup] Cleanup discord.cpp and discord_manager.cpp (#3205) 
# Notes
- Unused variables in `discord.cpp`.
- Use `.clear()` instead of setting to `""` in `discord_manager.cpp`.
 2023-04-05 12:14:14 -04:00
Alex King
c1d4cb90b9
[Cleanup] Cleanup cheap-to-copy reference to use value instead in eq_stream_ident.cpp/eq_stream_ident.h (#3209) 
# Notes
- More performant to pass by value than by reference.
 2023-04-05 12:14:01 -04:00
Alex King
e939c82717
[Cleanup] Convert equipable_slot_list to std::vector from std::list in bot_command.cpp (#3253) 
# Notes
- No need to use a `std::list` here.
 2023-04-05 11:35:04 -04:00
Alex King
7d03479f41
[Cleanup] Use constant reference and check for empty string properly in dbcore.cpp (#3203) 
# Notes
- Passing by constant reference is more performant.
- Checking for empty string with `!= '\0'` is more performant.
- https://pvs-studio.com/en/docs/warnings/v805/
- https://pvs-studio.com/en/docs/warnings/v813/
 2023-04-05 11:27:50 -04:00
Alex King
ff440e16b6
[Cleanup] Use .clear() and .empty() instead of comparing to empty string or setting to empty string in CheckDatabaseConvertPPBlob() (#3201) 
# Notes
- Use these methods to increase performance.
 2023-04-05 11:27:12 -04:00
Alex King
c6bb0f6495
[Cleanup] Move variable definition to more relevant scope in DatabaseDumpService::Dump() (#3200) 
# Notes
- This was unused except for in this one spot, move to scope of condition where it's used.
- https://pvs-studio.com/en/docs/warnings/v821/
 2023-04-05 11:26:21 -04:00
Alex King
d142bc552a
[Cleanuo] Only define row if we have results in Database::GetCharacterID() (#3199) 
# Notes
- This is more performant and we don't unnecessarily define a variable we can't use.
- https://pvs-studio.com/en/docs/warnings/v821/
 2023-04-05 11:25:28 -04:00
Alex King
7dc57c3b05
[Cleanup] Utilize .empty() instead of checking for an empty string in Database::ReserveName() (#3198) 
# Notes
- This is more performant.
- https://pvs-studio.com/en/docs/warnings/v815/
 2023-04-05 11:24:54 -04:00
Alex King
ea9b09cf1f
[Cleanup] Remove unused variable in Database::CopyCharacter() (#3197) 
# Notes
- This variable was created but never used.
- https://pvs-studio.com/en/docs/warnings/v808/
 2023-04-05 11:24:27 -04:00
Alex King
968278d8f8
[Cleanup] Use .clear() instead of setting string to empty in eqemu_command_handler.cpp (#3195) 
# Notes
- `x = ""` has less performance than `x.clear()`.
- https://pvs-studio.com/en/docs/warnings/v815/
 2023-04-05 11:24:12 -04:00
Alex King
aa910864c8
[Cleanup] Remove unused macros in common/types.h (#3194) 
# Notes
- These are unused.
 2023-04-05 11:23:37 -04:00
Alex King
1499f3338e
[Cleanup] Remove always true condition in Strings::Commify() (#3193) 
# Notes
- `i < 0` was always true.
 2023-04-05 11:23:24 -04:00
Alex King
fef2f9fc61
[Cleanup] Fix shared_tasks.cpp/shared_tasks.cpp variable named same as class member (#3192) 
* [Cleanup] Fix shared_tasks.cpp/shared_tasks.cpp variable named same as class member

# Notes
- This variable was named `m_db_shared_task` which is the same as `SharedTask:;m_db_shared_task`.

* Single letter receiver of complex type.
 2023-04-05 11:22:42 -04:00
Alex King
8afbc585da
[Cleanup] Remove bool return from GetSharedPlatinum() (#3191) 
# Notes
- This was returning `false` and implicitly converting it to an integer.
 2023-04-05 11:22:23 -04:00
Alex King
457ce85746
[Cleanup] Cleanup always true/false statements in shareddb.cpp (#3189) 
# Notes
- `parent_index < EQ::invslot::SLOT_BEGIN` was always `false`.
- `item->LoreGroup != -1` was always `true`.
 2023-04-05 11:21:43 -04:00
Alex King
49c093dc62
[Cleanup] Remove always true statement in say_link.cpp (#3188) 
# Notes
- This is always true since we check `!saylinks.empty()` prior to this.
 2023-04-05 11:20:52 -04:00
Alex King
beccd557a8
[Cleanup] Cleanup item_instance.cpp always true statements and reassigning of same values (#3187) 
# Notes
- Some things were always true.
- Some values were reassigned to the value they already were.
 2023-04-05 11:20:36 -04:00
Alex King
e11610b9fa
[Cleanup] Remove unnecessary check for IsStackable() in DeleteItem() (#3186) 
# Notes
- We check the opposites therefore we don't need either.
- https://pvs-studio.com/en/docs/warnings/v728/
 2023-04-05 11:20:13 -04:00
Alex King
3e652b98bc
[Cleanup] Cleanup macros in features.h (#3185) 
# Notes
- These needed to either be wrapped in parentheses or simplified to their values.
- https://pvs-studio.com/en/docs/warnings/v1003/
 2023-04-05 11:18:22 -04:00
Alex King
d43af28de4
[Cleanup] Multiple cases with same outcome in GetDiscordPayloadFromEvent() (#3184) 
# Notes
- All 4 of these use `FormatWithNodata`.
 2023-04-05 11:17:52 -04:00
Alex King
f5106b6af6
[Cleanup] Remove unused code in eq_packet.cpp/eq_packet.h (#3183) 
# Notes
- These are unused.
 2023-04-05 11:17:29 -04:00
Alex King
3386d13d2d
[Cleanup] results variable is assigned but never used in SaveCharacterCreate() (#3180) 
# Notes
- This was unnecessary since `QueryDatabase()` runs regardless.
 2023-04-05 11:17:10 -04:00
Alex King
d1b7c675f9
[Cleanup] Validate for nullptrs in bot.cpp (#3232) 
* [Cleanup] Validate for nullptrs in bot.cpp

# Notes
- Validate for nullptrs in these spots in bot.cpp before using the variable.

* Update bot.cpp
 2023-04-05 11:15:46 -04:00
Alex King
a40e1cf893
[Cleanup] Add missing breaks and returns in bonuses.cpp (#3231) 
# Notes
- Many spots were missing a `break;` or a `return` for their value.
 2023-04-05 11:15:22 -04:00
Alex King
c81ab00764
[Cleanup] Set bonuses to use spell ID instead of boolean (#3230) 
# Notes
- Spell bonuses `Illusion` is the spell ID, not a boolean.
 2023-04-05 11:14:55 -04:00
Alex King
025ef5e1d6
[Cleanup] Move unreachable code in ApplySpellsBonuses() (#3229) 
# Notes
- This code was unreachable since it was inside the switch and should have been checked on its own in the condition where we verify we are using AISpellEffects.
 2023-04-05 11:14:28 -04:00
Alex King
1f29a40e6d
[Cleanup] Remove extraneous check for NegateAttacks in SE_NegateAttacks (#3228) 
# Notes
- We checked both, we only need to check one.
 2023-04-05 11:12:02 -04:00
Alex King
66cadd599b
[Cleanup] Remove extraneous parentheses around math in Mob::ApplySpellsBonuses() (#3227) 
# Notes
- Extra parentheses.
 2023-04-05 11:11:41 -04:00
Alex King
aa0345c1f1
[Cleanup] Cleanup duplicate conditions in negate bonuses in bonuses.cpp (#3226) 
# Notes
- Lots of duplicate conditions.
 2023-04-05 11:11:22 -04:00
Alex King
73b11c5036
[Cleanup] SE_StrikeThrough and SE_StrikeThrough2 are the same in bonuses.cpp (#3223) 
# Notes
- These were the same code duplicated.
 2023-04-05 11:05:59 -04:00
Alex King
efbeb2dbb7
[Cleanup] SE_AttackSpeed3 effect_value is always less than 0 (#3222) 
# Notes
- This was always false.
 2023-04-05 11:05:44 -04:00
Alex King
8c97c20727
[Cleanup] Fix skill_used being used as boolean in Mob::CommonDamage() (#3220) 
# Notes
- This is unnecessary as we always have a skill value.
 2023-04-05 11:03:28 -04:00
Alex King
f2d07e5c69
[Cleanup] Remove unnecessary break in while loop in Mob::AddToHateList() (#3219) 
# Notes
- This is unnecessary and breaks the loop for no reason.
 2023-04-05 10:31:57 -04:00
Alex King
64d5b54e65
[Cleanup] Fix filter condition in attack.cpp (#3218) 
# Notes
- This condition was causing them to be used as `booleans` versus being checked individually.
 2023-04-05 10:31:34 -04:00
Alex King
89b3a04eb3
[Cleanup] Identical conditions right beside each other in aa.cpp (#3213) 
# Notes
- These conditions were identical and could be consolidated.
 2023-04-05 10:30:27 -04:00
Alex King
1bafe0b6b3
[Cleanup] other is always defined in these cases in attack.cpp (#3217) 
# Notes
- `other` is always defined since we check it prior to checking here.
 2023-04-05 10:30:13 -04:00
Alex King
82762c3f5a
[Cleanup] Use variable for character instead of a loop (#3268) 
# Notes
- Store character in a variable instead of looping a list of 1 entry.
 2023-04-05 10:29:16 -04:00
Alex King
2742eca119
[Cleanup] Remove unnecessary conditions in Client::SendFactionMessage() (#3267) 
# Notes
- `faction_value < this_faction_max` and `faction_value > this_faction_min` are always true if they get to that point in the code.
 2023-04-05 10:27:15 -04:00
Alex King
8fc7f3a732
[Cleanup] Cleanup unnecessary condition in Client::SendAlternateCurrencyValue() (#3266) 
# Notes
- `value == 0` is unnecessary as it can only be 0 if we fail the `value > 0` check.
 2023-04-05 10:27:01 -04:00
Alex King
39ce0178f9
[Cleanup] Remove unnecessary conditions in Client::Consume() (#3265) 
# Notes
- We check `increase < 0` prior to this, so this can't ever happen.
 2023-04-05 10:26:32 -04:00
Alex King
3d2f560436
[Cleanup] Fix GetLastName() length check in Client::SendWindow() (#3263) 
# Notes
- `target->GetLastName()` was always true, we need to make sure the target has a last name.
 2023-04-05 10:23:54 -04:00
Alex King
a0768d2d28
[Cleanup] Remove unnecessary conditions in Client::FilteredMessageCheck() (#3262) 
# Notes
- We check `FilterHide` prior to the secondary conditions, so it can never show up.
 2023-04-05 10:23:33 -04:00
Alex King
9009a7aa23
[Cleanup] Remove extra assignment of current_endurance in Client ctor (#3261) 
# Notes
- We already assign `current_endurance` to `0`, no need to do it again.
 2023-04-05 10:23:20 -04:00
Alex King
67b03b4e31
[Cleanup] Combine similar cases in Client::InitInnates() (#3260) 
# Notes
- These cases were the same, consolidating them is better.
 2023-04-05 10:23:05 -04:00
Alex King
b08975aefb
[Cleanup] Use .empty() in Client::ScribeSpells() and Client::LearnDisciplines() (#3259) 
* [Cleanup] Use .empty() in Client::ScribeSpells() and Client::LearnDisciplines()

# Notes
- Use `.empty()` instead of using a variable storing size in condition.

* Update client.cpp
 2023-04-05 10:22:36 -04:00
Alex King
ea3a7cae0b
[Cleanup] Remove always true conditions and unreachable code in Client::SendMercPersonalInfo() (#3258) 
* [Cleanup] Remove unreachable code in Client::SendMercPersonalInfo()

# Notes
- This cannot be reached due to prior returns.

* Update client.cpp

* Update client.cpp
 2023-04-05 10:14:07 -04:00
Alex King
81314a3315
[Cleanup] Fix check for !this in Client::SendHPUpdateMarquee() (#3257) 
# Notes
- `!this` isn't valid, as `this` can never be nullptr.
 2023-04-05 10:13:24 -04:00