497d20512a
[Crash] Fix UCS crash that occurs during log reloading ( #3324 )
2023-04-29 19:39:13 -05:00
db916e946e
[Bug Fix] Fix issue with spawning Mercs ( #3327 )
2023-04-29 18:45:35 -04:00
958549b407
[Bug Fix] Possible issues with SummonItem in Client::QuestReward() methods ( #3325 )
...
# Notes
- These methods were ignoring the sixth augment slot and could cause item to be summoned attuned being `EQ::invslot::slotCursor` is a non-zero value.
2023-04-26 21:28:24 -04:00
71ebf1b2d4
[Messages] Remove duplicate you have lost a level message ( #3323 )
2023-04-25 17:42:31 -04:00
e19b8d3056
[Bug Fix] Fix issue with NPCs no longer using some armor. ( #3318 )
...
* [BugFix/NPCs] Fix issue with NPCs no longer using some armor.
* Removed redundant memory clear
2023-04-24 17:05:29 -04:00
8b1d64a043
[Cleanup] quest::createBot() unnecessary check against nullptr ( #3302 )
...
# Notes
- We initialize this variable, so it can never be a nullptr.
2023-04-23 15:08:50 -04:00
576f99f292
[Cleanup] Add initiator/owner checks to various methods in questmgr.cpp ( #3306 )
...
* [Cleanup] Add initiator/owner checks to various methods in questmgr.cpp
# Notes
- Add `initiator` check to `quest::permaclass()`.
- Add `initiator` check to `quest::permarace()`.
- Add `initiator` check to `quest::permagender()`.
- Add `initiator` check to `quest::scribespells()`.
- Add `initiator` check to `quest::traindiscs()`.
- Add `initiator` check to `quest::unscribespells()`.
- Add `initiator` check to `quest::untraindiscs()`.
- Cleanup `initiator` check in `quest::pvp()`.
- Cleanup `initiator` check in `quest::movepc()`.
- Cleanup `initiator` check in `quest::gmmove()`.
- Cleanup `initiator` check in `quest::movegrp()`.
- Add `owner` check to `quest::doanim()`.
- Cleanup `initiator` check in `quest::addskill()`.
- Cleanup `initiator` check in `quest::setlanguage()`.
- Cleanup `initiator` check in `quest::setskill()`.
* Update questmgr.cpp
* Update questmgr.cpp
* Update questmgr.cpp
* Update questmgr.cpp
2023-04-23 15:08:32 -04:00
e3761cf2a3
[Cleanup] Add check for owner in quest::resumetimer() ( #3305 )
...
# Notes
- We didn't check for owner before doing `owner->GetName()`.
2023-04-23 15:07:49 -04:00
ad1764b464
[Cleanup] Add cehck for owner in quest::pausetimer() ( #3304 )
...
# Notes
- We didn't check for `owner` before doing `owner->GetName()`.
2023-04-23 15:07:09 -04:00
1c9ea57a4e
[Cleanup] Fix possible nullptr in quest::addloot() ( #3303 )
...
# Notes
- We didn't check for `owner` before calling `owner->IsNPC()`.
2023-04-23 15:06:53 -04:00
03c158b674
[Crash] Fix possible nullptr in Client::GetCharMaxLevelFromQGlobal() ( #3317 )
...
# Notes
- We could possibly not have a `zone` here, causing a crash.
- http://spire.akkadius.com/dev/release/22.9.1?id=3051
- http://spire.akkadius.com/dev/release/22.9.1?id=3052
- http://spire.akkadius.com/dev/release/22.9.1?id=3073
- http://spire.akkadius.com/dev/release/22.9.1?id=3102
- http://spire.akkadius.com/dev/release/22.9.1?id=3103
- http://spire.akkadius.com/dev/release/22.9.1?id=3104
- http://spire.akkadius.com/dev/release/22.9.1?id=3107
- http://spire.akkadius.com/dev/release/22.9.1?id=3108
- http://spire.akkadius.com/dev/release/22.9.1?id=3109
- http://spire.akkadius.com/dev/release/22.9.1?id=3110
- http://spire.akkadius.com/dev/release/22.9.1?id=3111
- http://spire.akkadius.com/dev/release/22.9.1?id=3112
- http://spire.akkadius.com/dev/release/22.9.1?id=3113
- http://spire.akkadius.com/dev/release/22.9.1?id=3114
2023-04-23 15:05:47 -04:00
39b5374e92
[Crash] Fix possible dereference of nullptr in Client::CalcHPRegen ( #3316 )
2023-04-23 14:27:43 -04:00
2d3ddcb574
[Release] 22.10.0 ( #3300 )
2023-04-22 10:17:20 -04:00
ed09281f66
[Bug Fix] Camping was causing player to leave raid, causing unexpected behavior ( #3299 )
2023-04-22 10:03:40 -04:00
8e51bf8b19
Fix crash when Removing empty password protected channel. ( #3298 )
2023-04-22 08:49:34 -04:00
844efa7e20
[Cleanup] Breaks in wrong spot in cases in spell_effects.cpp ( #3297 )
...
* [Cleanup] Breaks in wrong spot in cases in spell_effects.cpp
# Notes
- These breaks were inside conditions, meaning the case wasn't always broken.
* Update spell_effects.cpp
2023-04-22 08:49:13 -04:00
fa3a5c7a72
[Feature] Make ornamentations work with any augment type ( #3281 )
...
* [Feature] Make ornamentations work with any augment type
# Notes
- On Live there are augments that are not type 20/21 and are ornamentations.
- We also only allow a singular augment type to be ornamentation augment types, this will allow you to use any augment type as an ornamentation if it has a proper Hero's Forge model or a non-IT63/non-IT64 idfile.
* Update ruletypes.h
* Update client_packet.cpp
* Update item_instance.cpp
* Cleanup.
2023-04-16 10:26:19 -04:00
93db35658a
[Crash] Add additional raid integrity checks on Bot Spawn. ( #3295 )
...
* simple cleanup before changes
* can't be in a raid yet
* change to sizeof
* change to use sizeof
2023-04-16 10:06:19 -04:00
d45a57056a
[Cleanup] Remove getd(), geti(), InUse(), lasterr(), my_get_sv(), and VarExists() in embperl.cpp/embperl.h ( #3283 )
...
* [Cleanup] Remove getd(), geti(), InUse(), lasterr(), and VarExists() in embperl.cpp/embperl.h
# Notes
- These are unused.
* Update embperl.h
* Update embperl.cpp
2023-04-15 13:20:18 -04:00
ff40dbc710
[Cleanup] Utilize IsTaunting(), SetPetPower(), SetPetType(), and SetTaunting() ( #3275 )
...
* [Cleanup] Utilize SetPetPower() in zone/pets.cpp
# Notes
- This wasn't used before.
* Utilize other methods.
* Update special_attacks.cpp
2023-04-15 13:20:04 -04:00
7523c972fa
[Crash] Fix crash with uninitialized item instance, and Bot timeout ( #3296 )
2023-04-15 13:12:48 -04:00
4320c1429e
[Cleanup] Remove _GetMovementSpeed() from mob.h ( #3276 )
...
# Notes
- This is unused.
2023-04-14 19:42:48 -04:00
dc8bfddd7a
[Cleanup] Remove IsFullHP from mob.cpp/mob.h ( #3277 )
...
# Notes
- This is unused.
2023-04-14 19:42:39 -04:00
a8cdfb07e6
[Cleanup] Remove pendinggroup from mob.h ( #3278 )
...
# Notes
- This is unused.
2023-04-14 19:42:27 -04:00
011de2692e
[Cleanup] Remove IsMeleeDmg() from skills.cpp/skills.h ( #3279 )
...
# Notes
- This is unused.
2023-04-14 19:42:14 -04:00
0cc76ab489
[Cleanup] Remove position_same_update_count from client.cpp/client.h ( #3280 )
...
# Notes
- This is unused.
2023-04-14 19:42:01 -04:00
c5c9985e0d
[Cleanup] Remove ExportVarComplex() from embparser.cpp/embparser.h ( #3282 )
...
# Notes
- This is unused.
2023-04-14 19:41:23 -04:00
a7e95d7818
[Cleanup] Delete embxs.cpp/embxs.h ( #3284 )
...
* [Cleanup] Delete embxs.cpp/embxs.h
# Notes
- These files and the one method in them are unused.
* Update embperl.cpp
2023-04-14 19:40:51 -04:00
933d856b5b
[Cleanup] Remove GetQGlobal() from qglobals.cpp/qglobals.h ( #3285 )
...
# Notes
- This is unused.
2023-04-14 19:40:35 -04:00
285cc3af29
[Cleanup] Remove item_timers from questmgr.cpp/questmgr.h ( #3286 )
...
* [Cleanup] Remove item_timers from questmgr.cpp/questmgr.h
# Notes
- This is unused.
* Update questmgr.h
2023-04-14 19:40:21 -04:00
de8ae7afa6
[Cleanup] Cleanup zone/zoning.cpp ( #3289 )
...
# Notes
- Duplicate outcome cases in `Client::Handle_OP_ZoneChange`.
- Use `.length()` over `strlen` in array defintition.
- Remove unnecessary `else if` in `Client::ZonePC`
2023-04-14 19:40:01 -04:00
1b272cba50
[Cleanup] Remove unused ctor and use default dtor in xtargetautohaters.h ( #3290 )
...
* [Cleanup] Remove unused ctor and use default dtor in xtargetautohaters.h
# Notes
- Utilize default dtor.
- Remove unused ctor.
* Update zone_event_scheduler.cpp
2023-04-14 19:39:25 -04:00
e35e38b039
[Cleanup] Remove unused variables and use reference in task_manager.cpp ( #3291 )
...
# Notes
- Remove unused `query` and `item` variable.
- Use a reference for task data instead of calling `cts->m_completed_tasks[task_index]` over and over.
2023-04-14 19:39:07 -04:00
9215ba7a8a
[Cleanup] Remove always true statements in task_client_state.cpp ( #3292 )
...
# Notes
- `!tasks_enabled.empty()` is always true.
- `tasks_disabled.size()` is always true.
2023-04-14 19:38:35 -04:00
3f4334985b
[Cleanup] Remove unnecessary condition and cleanup variable name in tasks.cpp ( #3293 )
...
# Notes
- `task_state` is verified by `safe_delete`.
- `size` is the name of a member variable, we should just use `sizeof(uint32_t)` instead.
2023-04-14 19:38:28 -04:00
21002c2e8a
[Quest API] Fix LDoN Methods in Perl/Lua ( #3287 )
...
# Perl
- Add `quest::removeldonloss(theme_id)`.
- Add `quest::removeldonwin(theme_id)`.
# Lua
- Fix `eq.remove_ldon_win(theme_id)` as it was using `quest_manager.addldonwin(theme_id)` instead of `quest_manager.removeldonwin(theme_id)`.
2023-04-10 16:16:54 -04:00
445f967ed6
[Quest API] Add ApplySpellRaid() and SetSpellDurationRaid() to Bots in Perl/Lua ( #3274 )
...
# Perl
- Add `$bot->ApplySpellRaid(spell_id)`.
- Add `$bot->ApplySpellRaid(spell_id, duration)`.
- Add `$bot->ApplySpellRaid(spell_id, duration, allow_pets)`.
- Add `$bot->ApplySpellRaid(spell_id, duration, allow_pets, is_raid_group_only)`.
- Add `$bot->SetSpellDuration(spell_id)`.
- Add `$bot->SetSpellDuration(spell_id, duration)`.
- Add `$bot->SetSpellDuration(spell_id, duration, allow_pets)`.
- Add `$bot->SetSpellDuration(spell_id, duration, allow_pets, is_raid_group_only)`.
# Lua
- Add `bot:ApplySpellRaid(spell_id)`.
- Add `bot:ApplySpellRaid(spell_id, duration)`.
- Add `bot:ApplySpellRaid(spell_id, duration, allow_pets)`.
- Add `bot:ApplySpellRaid(spell_id, duration, allow_pets, is_raid_group_only)`.
- Add `bot:SetSpellDuration(spell_id)`.
- Add `bot:SetSpellDuration(spell_id, duration)`.
- Add `bot:SetSpellDuration(spell_id, duration, allow_pets)`.
- Add `bot:SetSpellDuration(spell_id, duration, allow_pets, is_raid_group_only)`.
# Notes
- These methods weren't added initially as we did not support bots in raid groups until recently.
2023-04-09 12:00:12 -04:00
57a15d473f
[Quest API] Add GetBuffSpellIDs() to Perl/Lua ( #3273 )
...
# Perl
- Add `$mob->GetBuffSpellIDs()`.
# Lua
- Add `$mob->GetBuffSpellIDs()`.
# Notes
- These methods allow operators to get a list of a mob's buff IDs without having to loop through their buffs themselves.
2023-04-09 10:58:35 -04:00
df92c578d2
[Rules] Optional summoning when already in melee range ( #3204 )
...
* Add summon melee range rule
* Fix compilation
* Remove redundant range check for HateSummon
2023-04-08 18:04:17 -04:00
3af43a8e8d
[Hotfix] Resolve loading of inventory ( #3272 )
2023-04-08 17:45:06 -04:00
647bcce30b
[Crash] Resolve crash due to uninitialized pointer. ( #3271 )
2023-04-08 17:21:53 -04:00
25b527156c
[Cleanup] Fix possible nullptr inst in GetSharedBank() ( #3190 )
...
* [Cleanup] Fix possible nullptr inst in GetSharedBank()
# Notes
- We weren't continuing if we had a `nullptr`.
* Update shareddb.cpp
* Fix.
2023-04-08 09:42:10 -04:00
b3ab7deb80
[Bots] Cleanup GetBotTables() ( #3270 )
2023-04-06 17:43:57 -05:00
4a9cb07132
[Cleanup] Remove unnecessary setting of reuse variable in Bot::DoClassAttacks() ( #3233 )
...
# Notes
- Bash, Kick, and Taunt have the same reuse time, no reason to set it to the same value.
2023-04-05 19:17:15 -04:00
8f1b62d166
[Cleanup] Remove always true/false conditions from bot.cpp ( #3237 )
...
* [Cleanup] Remove always true/false conditions from bot.cpp
# Notes
- Some of these conditions were always true or false based on previous conditions.
* Update bot.cpp
2023-04-05 19:05:49 -04:00
7e9994b5d4
[Cleanup] Fix ornamentation augment icons in inspect requests ( #3264 )
...
* [Cleanup] Fix ornamentation augment icons in inspect requests
# Notes
- We were not setting `aug_item` to the ornamentation augment when we found one.
* Update client.cpp
2023-04-05 19:04:32 -04:00
f2f8fae58b
[Telnet] Telnet encoding fix ( #3269 )
2023-04-05 12:16:25 -04:00
3a1e88f9ed
[Cleanup] Remove unused SetConfigFile in common/eqemu_config.h ( #3208 )
...
# Notes
- This is unused.
2023-04-05 12:15:10 -04:00
4e101aa6d6
[Cleanup] Use default dtor instead of empty dtor for EQTime in eqtime.cpp/eqtime.h ( #3210 )
...
# Notes
- This is better than using an empty dtor.
2023-04-05 12:15:02 -04:00
ef411ee154
[Cleanup] Use default ctor instead of an empty ctor. ( #3206 )
...
# Notes
- Use `= default;` instead of an empty ctor.
- https://pvs-studio.com/en/docs/warnings/v832/
2023-04-05 12:14:22 -04:00
Chris Miles
Aeadoin
Alex King
Paul Coene
Trent