pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-03-05 05:12:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Memory Leak] Fix large memory leak introduced in CalcItemBonuses (#3331)

Browse Source
This commit is contained in:
Chris Miles 2023-05-07 08:47:03 -05:00 committed by GitHub
parent 5be2041085
commit 4a5559022f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
zone/bonuses.cpp
View File

@ -146,18 +146,7 @@ void Mob::CalcItemBonuses(StatBonuses* b) {
int16 i; int16 i;
for (i = EQ::invslot::BONUS_BEGIN; i <= EQ::invslot::BONUS_SKILL_END; i++) { for (i = EQ::invslot::BONUS_BEGIN; i <= EQ::invslot::BONUS_SKILL_END; i++) {
const EQ::ItemInstance* inst = nullptr; const EQ::ItemInstance* inst = m_inv[i];
if (IsOfClientBotMerc()) {
inst = GetInv().GetItem(i);
} else {
const auto* item = CastToNPC()->GetItem(i);
if (!item) {
continue;
}
inst = database.CreateItem(item->item_id);
}
if (!inst) { if (!inst) {
continue; continue;
} }