From 4a5559022f02547f9aa2c340612bbb1934ebb3ee Mon Sep 17 00:00:00 2001 From: Chris Miles Date: Sun, 7 May 2023 08:47:03 -0500 Subject: [PATCH] [Memory Leak] Fix large memory leak introduced in CalcItemBonuses (#3331) --- zone/bonuses.cpp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/zone/bonuses.cpp b/zone/bonuses.cpp index 4a9d556b9..76bd970da 100644 --- a/zone/bonuses.cpp +++ b/zone/bonuses.cpp @@ -146,18 +146,7 @@ void Mob::CalcItemBonuses(StatBonuses* b) { int16 i; for (i = EQ::invslot::BONUS_BEGIN; i <= EQ::invslot::BONUS_SKILL_END; i++) { - const EQ::ItemInstance* inst = nullptr; - if (IsOfClientBotMerc()) { - inst = GetInv().GetItem(i); - } else { - const auto* item = CastToNPC()->GetItem(i); - if (!item) { - continue; - } - - inst = database.CreateItem(item->item_id); - } - + const EQ::ItemInstance* inst = m_inv[i]; if (!inst) { continue; }