pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-13 10:31:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Convert equipable_slot_list to std::vector from std::list in bot_command.cpp (#3253)

Browse Source 
# Notes
- No need to use a `std::list` here.
This commit is contained in:
Alex King 2023-04-05 11:35:04 -04:00 committed by GitHub
parent 7d03479f41
commit e939c82717
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zone/bot_command.cpp
View File

@ -3590,10 +3590,10 @@ void bot_command_item_use(Client* c, const Seperator* sep)
return; return;
} }
std::list<int16> equipable_slot_list; std::vector<int16> equipable_slot_list;
for (int16 equipable_slot = EQ::invslot::EQUIPMENT_BEGIN; equipable_slot <= EQ::invslot::EQUIPMENT_END; ++equipable_slot) { for (int16 equipable_slot = EQ::invslot::EQUIPMENT_BEGIN; equipable_slot <= EQ::invslot::EQUIPMENT_END; ++equipable_slot) {
if (item_data->Slots & (1 << equipable_slot)) { if (item_data->Slots & (1 << equipable_slot)) {
equipable_slot_list.push_back(equipable_slot); equipable_slot_list.emplace_back(equipable_slot);
} }
} }
@ -3623,7 +3623,7 @@ void bot_command_item_use(Client* c, const Seperator* sep)
bot_iter->GetCleanName() bot_iter->GetCleanName()
); );
for (auto slot_iter : equipable_slot_list) { for (const auto& slot_iter : equipable_slot_list) {
// needs more failure criteria - this should cover the bulk for now // needs more failure criteria - this should cover the bulk for now
if (slot_iter == EQ::invslot::slotSecondary && item_data->Damage && !bot_iter->CanThisClassDualWield()) { if (slot_iter == EQ::invslot::slotSecondary && item_data->Damage && !bot_iter->CanThisClassDualWield()) {
continue; continue;