From e939c82717575bd6d12ed50fa7e206a5ae3ac940 Mon Sep 17 00:00:00 2001 From: Alex King <89047260+Kinglykrab@users.noreply.github.com> Date: Wed, 5 Apr 2023 11:35:04 -0400 Subject: [PATCH] [Cleanup] Convert equipable_slot_list to std::vector from std::list in bot_command.cpp (#3253) # Notes - No need to use a `std::list` here. --- zone/bot_command.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/zone/bot_command.cpp b/zone/bot_command.cpp index 224a7bd0a..3ccd3a702 100644 --- a/zone/bot_command.cpp +++ b/zone/bot_command.cpp @@ -3590,10 +3590,10 @@ void bot_command_item_use(Client* c, const Seperator* sep) return; } - std::list equipable_slot_list; + std::vector equipable_slot_list; for (int16 equipable_slot = EQ::invslot::EQUIPMENT_BEGIN; equipable_slot <= EQ::invslot::EQUIPMENT_END; ++equipable_slot) { if (item_data->Slots & (1 << equipable_slot)) { - equipable_slot_list.push_back(equipable_slot); + equipable_slot_list.emplace_back(equipable_slot); } } @@ -3623,7 +3623,7 @@ void bot_command_item_use(Client* c, const Seperator* sep) bot_iter->GetCleanName() ); - for (auto slot_iter : equipable_slot_list) { + for (const auto& slot_iter : equipable_slot_list) { // needs more failure criteria - this should cover the bulk for now if (slot_iter == EQ::invslot::slotSecondary && item_data->Damage && !bot_iter->CanThisClassDualWield()) { continue;