[Commands] Cleanup #gender Command. (#1832)

- Cleanup message and logic.
- Cleanup other spots using similar logic so they're all uniform.

zone/gm_commands/gender.cpp

@@ -2,16 +2,45 @@
 
 void command_gender(Client *c, const Seperator *sep)
 {
-	Mob *t = c->CastToMob();
+	int arguments = sep->argnum;
+	if (!arguments || !sep->IsNumber(1)) {
+		c->Message(Chat::White, "Usage: #gender [Gender ID]");
+		c->Message(Chat::White, "Genders: 0 = Male, 1 = Female, 2 = Neuter");
+		return;
+	}
 
-	if (sep->IsNumber(1) && atoi(sep->arg[1]) >= 0 && atoi(sep->arg[1]) <= 500) {
-		if ((c->GetTarget()) && c->Admin() >= commandGenderOthers) {
-			t = c->GetTarget();
-		}
-		t->SendIllusionPacket(t->GetRace(), atoi(sep->arg[1]));
+	Mob *target = c;
+	if (c->GetTarget() && c->Admin() >= commandGenderOthers) {
+		target = c->GetTarget();
 	}
-	else {
-		c->Message(Chat::White, "Usage: #gender [0/1/2]");
+
+	auto gender_id = std::stoi(sep->arg[1]);
+	if (gender_id < 0 || gender_id > 2) {
+		c->Message(Chat::White, "Usage: #gender [Gender ID]");
+		c->Message(Chat::White, "Genders: 0 = Male, 1 = Female, 2 = Neuter");
+		return;
 	}
+
+	target->SendIllusionPacket(
+		target->GetRace(),
+		gender_id
+	);
+
+	c->Message(
+		Chat::White,
+		fmt::format(
+			"Gender changed for {} to {} ({}).",
+			(
+				c == target ?
+				"yourself" :
+				fmt::format(
+					"{} ({})",
+					target->GetCleanName(),
+					target->GetID()
+				)
+			),
+			GetGenderName(gender_id),
+			gender_id
+		).c_str()
+	);
 }
-