Minor code and compiler warning fixes.

This commit is contained in:
KayenEQ
2014-11-02 20:14:44 -05:00
parent c9073b10a1
commit d754e24a02
5 changed files with 44 additions and 26 deletions
+37 -19
View File
@@ -1392,7 +1392,7 @@ void Mob::CalcSpellBonuses(StatBonuses* newbon)
newbon->AggroRange = -1;
newbon->AssistRange = -1;
uint32 buff_count = GetMaxTotalSlots();
int buff_count = GetMaxTotalSlots();
for(i = 0; i < buff_count; i++) {
if(buffs[i].spellid != SPELL_UNKNOWN){
ApplySpellsBonuses(buffs[i].spellid, buffs[i].casterlevel, newbon, buffs[i].casterid, false, buffs[i].ticsremaining,i);
@@ -1477,7 +1477,7 @@ void Mob::ApplySpellsBonuses(uint16 spell_id, uint8 casterlevel, StatBonuses* ne
// redundant to have level check here
if(newbon->AggroRange == -1 || effect_value < newbon->AggroRange)
{
newbon->AggroRange = effect_value;
newbon->AggroRange = static_cast<float>(effect_value);
}
break;
}
@@ -1489,7 +1489,7 @@ void Mob::ApplySpellsBonuses(uint16 spell_id, uint8 casterlevel, StatBonuses* ne
// take the one with less range in any case
if(newbon->AssistRange == -1 || effect_value < newbon->AssistRange)
{
newbon->AssistRange = effect_value;
newbon->AssistRange = static_cast<float>(effect_value);
}
break;
}
@@ -2808,7 +2808,7 @@ void Mob::ApplySpellsBonuses(uint16 spell_id, uint8 casterlevel, StatBonuses* ne
|| ((effect_value < 0) && (newbon->AlterNPCLevel > effect_value))
|| ((effect_value > 0) && (newbon->AlterNPCLevel < effect_value))) {
int16 tmp_lv = GetOrigLevel() + effect_value;
int tmp_lv = GetOrigLevel() + effect_value;
if (tmp_lv < 1)
tmp_lv = 1;
else if (tmp_lv > 255)
@@ -3092,7 +3092,7 @@ void Client::CalcItemScale() {
bool Client::CalcItemScale(uint32 slot_x, uint32 slot_y) {
// behavior change: 'slot_y' is now [RANGE]_END and not [RANGE]_END + 1
bool changed = false;
int i;
uint32 i;
for (i = slot_x; i <= slot_y; i++) {
if (i == MainAmmo) // moved here from calling procedure to facilitate future range changes where MainAmmo may not be the last slot
continue;
@@ -3186,7 +3186,7 @@ void Client::DoItemEnterZone() {
bool Client::DoItemEnterZone(uint32 slot_x, uint32 slot_y) {
// behavior change: 'slot_y' is now [RANGE]_END and not [RANGE]_END + 1
bool changed = false;
for(int i = slot_x; i <= slot_y; i++) {
for(uint32 i = slot_x; i <= slot_y; i++) {
if (i == MainAmmo) // moved here from calling procedure to facilitate future range changes where MainAmmo may not be the last slot
continue;
@@ -3380,15 +3380,15 @@ void Mob::NegateSpellsBonuses(uint16 spell_id)
break;
case SE_ChangeFrenzyRad:
spellbonuses.AggroRange = effect_value;
aabonuses.AggroRange = effect_value;
itembonuses.AggroRange = effect_value;
spellbonuses.AggroRange = static_cast<float>(effect_value);
aabonuses.AggroRange = static_cast<float>(effect_value);
itembonuses.AggroRange = static_cast<float>(effect_value);
break;
case SE_Harmony:
spellbonuses.AssistRange = effect_value;
aabonuses.AssistRange = effect_value;
itembonuses.AssistRange = effect_value;
spellbonuses.AssistRange = static_cast<float>(effect_value);
aabonuses.AssistRange = static_cast<float>(effect_value);
itembonuses.AssistRange = static_cast<float>(effect_value);
break;
case SE_AttackSpeed:
@@ -4347,11 +4347,11 @@ void Mob::NegateSpellsBonuses(uint16 spell_id)
break;
case SE_TriggerMeleeThreshold:
spellbonuses.TriggerMeleeThreshold = effect_value;
spellbonuses.TriggerMeleeThreshold = false;
break;
case SE_TriggerSpellThreshold:
spellbonuses.TriggerSpellThreshold = effect_value;
spellbonuses.TriggerSpellThreshold = false;
break;
case SE_DivineAura:
@@ -4377,7 +4377,7 @@ void Mob::NegateSpellsBonuses(uint16 spell_id)
break;
case SE_DistanceRemoval:
spellbonuses.DistanceRemoval = effect_value;
spellbonuses.DistanceRemoval = false;
break;
case SE_ImprovedTaunt:
@@ -4480,7 +4480,7 @@ void Mob::NegateSpellsBonuses(uint16 spell_id)
break;
case SE_Sanctuary:
spellbonuses.Sanctuary = effect_value;
spellbonuses.Sanctuary = false;
break;
case SE_FactionModPct:
@@ -4496,10 +4496,28 @@ void Mob::NegateSpellsBonuses(uint16 spell_id)
break;
case SE_IllusionPersistence:
spellbonuses.IllusionPersistence = effect_value;
itembonuses.IllusionPersistence = effect_value;
aabonuses.IllusionPersistence = effect_value;
spellbonuses.IllusionPersistence = false;
itembonuses.IllusionPersistence = false;
aabonuses.IllusionPersistence = false;
break;
case SE_SkillProcSuccess:{
for(int e = 0; e < MAX_SKILL_PROCS; e++)
{
spellbonuses.SkillProcSuccess[e] = effect_value;
itembonuses.SkillProcSuccess[e] = effect_value;
aabonuses.SkillProcSuccess[e] = effect_value;
}
}
case SE_SkillProc:{
for(int e = 0; e < MAX_SKILL_PROCS; e++)
{
spellbonuses.SkillProc[e] = effect_value;
itembonuses.SkillProc[e] = effect_value;
aabonuses.SkillProc[e] = effect_value;
}
}
}
}
}