pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-04-27 16:32:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Gate DDL rollback test behind --run-ddl-tests flag to avoid table locks on production databases

Browse Source 
Co-authored-by: Valorith <76063792+Valorith@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-03-09 00:52:49 +00:00
parent 62bde14552
commit cd23894b80
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
zone/cli/tests/cli_zone_state.cpp
View File

@ -936,8 +936,19 @@ inline void TestClientBuffPersistence()
);
}
inline void TestClientBuffPersistenceRollback()
inline void TestClientBuffPersistenceRollback(bool run_ddl)
{
// DDL on the live character_buffs table can lock it and disrupt running servers.
// Only run when the caller explicitly opts in via --run-ddl-tests.
if (!run_ddl) {
RunTest(
"Client Buff Persistence > Rollback: skipped (pass --run-ddl-tests to enable)",
true,
true
);
return;
}
constexpr uint32 test_character_id = 99999992;
constexpr uint16 preexisting_spell_id = 6824; // stable, widely-used spell present in all data sets
constexpr int suppressed_tics = 99;
@ -1344,7 +1355,7 @@ void ZoneCLI::TestZoneState(int argc, char **argv, argh::parser &cmd, std::strin
TestZoneVariables();
TestHpManaEnd();
TestClientBuffPersistence();
TestClientBuffPersistenceRollback();
TestClientBuffPersistenceRollback(cmd["--run-ddl-tests"]);
TestBuffs();
TestLocationChange();
TestEntityVariables();