From cb129efcad62ef6ef475e36284d9081e2a311dba Mon Sep 17 00:00:00 2001 From: Alex King <89047260+Kinglykrab@users.noreply.github.com> Date: Mon, 3 Apr 2023 16:28:15 -0400 Subject: [PATCH] [Cleanup] Fix loop and code duplication for SE_ProcOnKillShot (#3224) * [Cleanup] Fix loop for SE_ProcOnKillShot # Notes - We were doing `e = 3` instead of doing `e += 3`. * Update bonuses.cpp --- zone/bonuses.cpp | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/zone/bonuses.cpp b/zone/bonuses.cpp index fd4f7c133..ff350277b 100644 --- a/zone/bonuses.cpp +++ b/zone/bonuses.cpp @@ -5043,20 +5043,27 @@ void Mob::NegateSpellEffectBonuses(uint16 spell_id) case SE_ProcOnKillShot: { - for (int e = 0; e < MAX_SPELL_TRIGGER * 3; e = 3) + for (int e = 0; e < MAX_SPELL_TRIGGER * 3; e += 3) { - if (negate_spellbonus) { spellbonuses.SpellOnKill[e] = effect_value; } - if (negate_spellbonus) { spellbonuses.SpellOnKill[e + 1] = effect_value; } - if (negate_spellbonus) { spellbonuses.SpellOnKill[e + 2] = effect_value; } + if (negate_spellbonus) { + spellbonuses.SpellOnKill[e] = effect_value; + spellbonuses.SpellOnKill[e + 1] = effect_value; + spellbonuses.SpellOnKill[e + 2] = effect_value; + } - if (negate_aabonus) { aabonuses.SpellOnKill[e] = effect_value; } - if (negate_aabonus) { aabonuses.SpellOnKill[e + 1] = effect_value; } - if (negate_aabonus) { aabonuses.SpellOnKill[e + 2] = effect_value; } + if (negate_aabonus) { + aabonuses.SpellOnKill[e] = effect_value; + aabonuses.SpellOnKill[e + 1] = effect_value; + aabonuses.SpellOnKill[e + 2] = effect_value; + } - if (negate_itembonus) { itembonuses.SpellOnKill[e] = effect_value; } - if (negate_itembonus) { itembonuses.SpellOnKill[e + 1] = effect_value; } - if (negate_itembonus) { itembonuses.SpellOnKill[e + 2] = effect_value; } + if (negate_itembonus) { + itembonuses.SpellOnKill[e] = effect_value; + itembonuses.SpellOnKill[e + 1] = effect_value; + itembonuses.SpellOnKill[e + 2] = effect_value; + } } + break; }