[Code Cleanup] Optimization Code Cleanup (#4489)

* Initial push

* More

* More

* Further simplify

* More cleanup

* More consolidation

* Fix

* Update

* Update npc.cpp

---------

Co-authored-by: Kinglykrab <kinglykrab@gmail.com>
This commit is contained in:
Chris Miles
2024-09-30 17:34:42 -05:00
committed by GitHub
parent 56608e84bd
commit bcd943a964
17 changed files with 309 additions and 486 deletions
+4 -4
View File
@@ -1036,7 +1036,7 @@ void EntityList::AETaunt(Client* taunter, float range, int bonus_hate)
float range_squared = range * range;
for (auto& it: entity_list.GetCloseMobList(taunter, range)) {
for (auto& it: taunter->GetCloseMobList(range)) {
Mob *them = it.second;
if (!them) {
continue;
@@ -1120,7 +1120,7 @@ void EntityList::AESpell(
distance
);
for (auto& it: entity_list.GetCloseMobList(caster_mob, distance)) {
for (auto& it: caster_mob->GetCloseMobList(distance)) {
current_mob = it.second;
if (!current_mob) {
continue;
@@ -1256,7 +1256,7 @@ void EntityList::MassGroupBuff(
float distance_squared = distance * distance;
bool is_detrimental_spell = IsDetrimentalSpell(spell_id);
for (auto& it: entity_list.GetCloseMobList(caster, distance)) {
for (auto& it: caster->GetCloseMobList(distance)) {
current_mob = it.second;
if (!current_mob) {
continue;
@@ -1306,7 +1306,7 @@ void EntityList::AEAttack(
float distance_squared = distance * distance;
int current_hits = 0;
for (auto& it: entity_list.GetCloseMobList(attacker, distance)) {
for (auto& it: attacker->GetCloseMobList(distance)) {
current_mob = it.second;
if (!current_mob) {
continue;