pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-05-16 22:58:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Quest API] Cleanup string copies and push_backs. (#2807)

Browse Source 
# Notes
- Several places use `push_back` instead of `emplace_back`.
- Several places use `std::string` instead of `const std::string&`.
This commit is contained in:
Alex King
2023-01-29 15:14:49 -05:00
committed by GitHub
parent 0fef46a6c1
commit bcc2e022dc
21 changed files with 372 additions and 397 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/lua_parser.h
+20 -20
View File
@@ -40,7 +40,7 @@ public:
QuestEventID evt,
NPC* npc,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -48,21 +48,21 @@ public:
QuestEventID evt,
NPC* npc,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
virtual int EventPlayer(
QuestEventID evt,
Client *client,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
virtual int EventGlobalPlayer(
QuestEventID evt,
Client *client,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -71,7 +71,7 @@ public:
Client *client,
EQ::ItemInstance *item,
Mob *mob,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -80,14 +80,14 @@ public:
Mob* mob,
Client *client,
uint32 spell_id,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
virtual int EventEncounter(
QuestEventID evt,
std::string encounter_name,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -95,7 +95,7 @@ public:
QuestEventID evt,
Bot *bot,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -103,7 +103,7 @@ public:
QuestEventID evt,
Bot *bot,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -140,14 +140,14 @@ public:
QuestEventID evt,
NPC* npc,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
virtual int DispatchEventPlayer(
QuestEventID evt,
Client *client,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -156,7 +156,7 @@ public:
Client *client,
EQ::ItemInstance *item,
Mob *mob,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -165,7 +165,7 @@ public:
Mob* mob,
Client *client,
uint32 spell_id,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -173,7 +173,7 @@ public:
QuestEventID evt,
Bot *bot,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -207,7 +207,7 @@ private:
QuestEventID evt,
NPC* npc,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers,
luabind::adl::object *l_func = nullptr
@@ -216,7 +216,7 @@ private:
std::string package_name,
QuestEventID evt,
Client *client,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers,
luabind::adl::object *l_func = nullptr
@@ -227,7 +227,7 @@ private:
Client *client,
EQ::ItemInstance *item,
Mob *mob,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers,
luabind::adl::object *l_func = nullptr
@@ -238,7 +238,7 @@ private:
Mob* mob,
Client *client,
uint32 spell_id,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers,
luabind::adl::object *l_func = nullptr
@@ -247,7 +247,7 @@ private:
std::string package_name,
QuestEventID evt,
std::string encounter_name,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
);
@@ -256,7 +256,7 @@ private:
QuestEventID evt,
Bot *bot,
Mob *init,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers,
luabind::adl::object *l_func = nullptr