pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-05-17 23:58:25 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[Quest API] Cleanup string copies and push_backs. (#2807)

Browse Source 
# Notes
- Several places use `push_back` instead of `emplace_back`.
- Several places use `std::string` instead of `const std::string&`.
This commit is contained in:
Alex King
2023-01-29 15:14:49 -05:00
committed by GitHub
parent 0fef46a6c1
commit bcc2e022dc
21 changed files with 372 additions and 397 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/lua_general.cpp
+6 -6
View File
@@ -76,9 +76,9 @@ void load_encounter_with_data(std::string name, std::string info_str) {
entity_list.AddEncounter(enc);
lua_encounters[name] = enc;
lua_encounters_loaded[name] = true;
std::vector<std::any> info_ptrs;
info_ptrs.push_back(&info_str);
parse->EventEncounter(EVENT_ENCOUNTER_LOAD, name, "", 0, &info_ptrs);
std::vector<std::any> args;
args.emplace_back(&info_str);
parse->EventEncounter(EVENT_ENCOUNTER_LOAD, name, "", 0, &args);
}
void unload_encounter(std::string name) {
@@ -138,9 +138,9 @@ void unload_encounter_with_data(std::string name, std::string info_str) {
lua_encounters[name]->Depop();
lua_encounters.erase(name);
lua_encounters_loaded.erase(name);
std::vector<std::any> info_ptrs;
info_ptrs.push_back(&info_str);
parse->EventEncounter(EVENT_ENCOUNTER_UNLOAD, name, "", 0, &info_ptrs);
std::vector<std::any> args;
args.emplace_back(&info_str);
parse->EventEncounter(EVENT_ENCOUNTER_UNLOAD, name, "", 0, &args);
}
void register_event(std::string package_name, std::string name, int evt, luabind::adl::object func) {