pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-05-17 07:18:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Quest API] Cleanup string copies and push_backs. (#2807)

Browse Source 
# Notes
- Several places use `push_back` instead of `emplace_back`.
- Several places use `std::string` instead of `const std::string&`.
This commit is contained in:
Alex King
2023-01-29 15:14:49 -05:00
committed by GitHub
parent 0fef46a6c1
commit bcc2e022dc
21 changed files with 372 additions and 397 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/embparser.cpp
+8 -8
View File
@@ -361,7 +361,7 @@ int PerlembParser::EventCommon(
}
int PerlembParser::EventNPC(
QuestEventID evt, NPC *npc, Mob *mob, std::string data, uint32 extra_data,
QuestEventID evt, NPC *npc, Mob *mob, const std::string& data, uint32 extra_data,
std::vector<std::any> *extra_pointers
)
{
@@ -369,7 +369,7 @@ int PerlembParser::EventNPC(
}
int PerlembParser::EventGlobalNPC(
QuestEventID evt, NPC *npc, Mob *mob, std::string data, uint32 extra_data,
QuestEventID evt, NPC *npc, Mob *mob, const std::string& data, uint32 extra_data,
std::vector<std::any> *extra_pointers
)
{
@@ -377,7 +377,7 @@ int PerlembParser::EventGlobalNPC(
}
int PerlembParser::EventPlayer(
QuestEventID evt, Client *client, std::string data, uint32 extra_data,
QuestEventID evt, Client *client, const std::string& data, uint32 extra_data,
std::vector<std::any> *extra_pointers
)
{
@@ -385,7 +385,7 @@ int PerlembParser::EventPlayer(
}
int PerlembParser::EventGlobalPlayer(
QuestEventID evt, Client *client, std::string data, uint32 extra_data,
QuestEventID evt, Client *client, const std::string& data, uint32 extra_data,
std::vector<std::any> *extra_pointers
)
{
@@ -393,7 +393,7 @@ int PerlembParser::EventGlobalPlayer(
}
int PerlembParser::EventItem(
QuestEventID evt, Client *client, EQ::ItemInstance *item, Mob *mob, std::string data, uint32 extra_data,
QuestEventID evt, Client *client, EQ::ItemInstance *item, Mob *mob, const std::string& data, uint32 extra_data,
std::vector<std::any> *extra_pointers
)
{
@@ -402,7 +402,7 @@ int PerlembParser::EventItem(
}
int PerlembParser::EventSpell(
QuestEventID evt, Mob *mob, Client *client, uint32 spell_id, std::string data, uint32 extra_data,
QuestEventID evt, Mob *mob, Client *client, uint32 spell_id, const std::string& data, uint32 extra_data,
std::vector<std::any> *extra_pointers
)
{
@@ -2152,7 +2152,7 @@ int PerlembParser::EventBot(
QuestEventID evt,
Bot *bot,
Mob *mob,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
) {
@@ -2163,7 +2163,7 @@ int PerlembParser::EventGlobalBot(
QuestEventID evt,
Bot *bot,
Mob *mob,
std::string data,
const std::string& data,
uint32 extra_data,
std::vector<std::any> *extra_pointers
) {