[Cleanup] Reference type in GetRaidLeaderName (#4218)

Minor cleanup from #4054
This commit is contained in:
JJ 2024-03-28 19:15:16 -04:00 committed by GitHub
parent ab8ac81df6
commit b946b800fb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions

View File

@ -1333,7 +1333,7 @@ uint32 Database::GetRaidID(const std::string& name)
return e.raidid; return e.raidid;
} }
const std::string& Database::GetRaidLeaderName(uint32 raid_id) const std::string Database::GetRaidLeaderName(uint32 raid_id)
{ {
const auto& l = RaidMembersRepository::GetWhere( const auto& l = RaidMembersRepository::GetWhere(
*this, *this,
@ -1348,7 +1348,7 @@ const std::string& Database::GetRaidLeaderName(uint32 raid_id)
return "UNKNOWN"; return "UNKNOWN";
} }
auto e = l.front(); auto& e = l.front();
return e.name; return e.name;
} }

View File

@ -216,7 +216,7 @@ public:
void SetGroupLeaderName(uint32 group_id, const std::string& name); void SetGroupLeaderName(uint32 group_id, const std::string& name);
/* Raids */ /* Raids */
const std::string& GetRaidLeaderName(uint32 raid_id); const std::string GetRaidLeaderName(uint32 raid_id);
uint32 GetRaidID(const std::string& name); uint32 GetRaidID(const std::string& name);
void ClearRaid(uint32 raid_id = 0); void ClearRaid(uint32 raid_id = 0);
void ClearRaidDetails(uint32 raid_id = 0); void ClearRaidDetails(uint32 raid_id = 0);