From b946b800fb3a14a8ea1100058d7ac486a0696985 Mon Sep 17 00:00:00 2001
From: JJ <3617814+joligario@users.noreply.github.com>
Date: Thu, 28 Mar 2024 19:15:16 -0400
Subject: [PATCH] [Cleanup] Reference type in `GetRaidLeaderName` (#4218)

Minor cleanup from #4054
---
 common/database.cpp | 4 ++--
 common/database.h   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/database.cpp b/common/database.cpp
index 7f45e253d..821f84b90 100644
--- a/common/database.cpp
+++ b/common/database.cpp
@@ -1333,7 +1333,7 @@ uint32 Database::GetRaidID(const std::string& name)
 	return e.raidid;
 }
 
-const std::string& Database::GetRaidLeaderName(uint32 raid_id)
+const std::string Database::GetRaidLeaderName(uint32 raid_id)
 {
 	const auto& l = RaidMembersRepository::GetWhere(
 		*this,
@@ -1348,7 +1348,7 @@ const std::string& Database::GetRaidLeaderName(uint32 raid_id)
 		return "UNKNOWN";
 	}
 
-	auto e = l.front();
+	auto& e = l.front();
 
 	return e.name;
 }
diff --git a/common/database.h b/common/database.h
index 1f022ab19..44406e8e9 100644
--- a/common/database.h
+++ b/common/database.h
@@ -216,7 +216,7 @@ public:
 	void SetGroupLeaderName(uint32 group_id, const std::string& name);
 
 	/* Raids */
-	const std::string& GetRaidLeaderName(uint32 raid_id);
+	const std::string GetRaidLeaderName(uint32 raid_id);
 	uint32 GetRaidID(const std::string& name);
 	void ClearRaid(uint32 raid_id = 0);
 	void ClearRaidDetails(uint32 raid_id = 0);