Small fix for an NPC on a faction but with no entries in npc_faction_entries.

This commit is contained in:
Noudess 2018-12-06 14:25:58 -05:00
parent 2a9f38de2a
commit 9bf23a131b

View File

@ -2632,7 +2632,16 @@ FACTION_VALUE NPC::CheckNPCFactionAlly(int32 other_faction) {
return FACTION_INDIFFERENT; return FACTION_INDIFFERENT;
} }
} }
return FACTION_INDIFFERENT;
// I believe that the assumption is, barring no entry in npc_faction_entries
// that two npcs on like faction con ally to each other. This catches cases
// where an npc is on a faction but has no hits (hence no entry in
// npc_faction_entries).
if (GetPrimaryFaction() == other_faction)
return FACTION_ALLY;
else
return FACTION_INDIFFERENT;
} }
bool NPC::IsFactionListAlly(uint32 other_faction) { bool NPC::IsFactionListAlly(uint32 other_faction) {