Added IsBuffSpell(spell_id). This will return true if the spell would end up having a duration, which will mean it would end up in one of the many buff windows on the client. This just makes sure the spell has a buffduration or buffdurationformula, which means the calculation will return a duration

Replaced all instances of CalcBuffDuration being used to determine if a spell was a buff with IsBuffSpell
Removed Mob::HasBuffIcon since it does the same thing IsBuffSpell does in a more convoluted way and had a rather missing leading name
Fixed issues that arose from the 10/03/2013 changes
This commit is contained in:
Michael Cook
2013-10-08 17:24:07 -04:00
parent 24308aec6c
commit 9a19a00bdc
8 changed files with 19 additions and 15 deletions
+7
View File
@@ -987,6 +987,13 @@ bool IsSelfConversionSpell(uint16 spell_id) {
return false;
}
// returns true for both detrimental and beneficial buffs
bool IsBuffSpell(uint16 spell_id) {
if(IsValidSpell(spell_id) && (spells[spell_id].buffduration || spells[spell_id].buffdurationformula))
return true;
return false;
}
uint32 GetMorphTrigger(uint32 spell_id)
{
for(int i = 0; i < EFFECT_COUNT; ++i)