pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-11 21:01:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Bug Fix] Remove duplicate logic in GetActSpellHealing reducing HOT criticals (#2786)

Browse Source 
# Notes
- Removes duplicate critical chance roll in `Mob::GetActSpellHealing`.
- Not sure if this was Live-like or an oversight, but it seems to drastically reduce the possibility of a HOT getting a critical.
- A 1% chance becomes a 0.01% chance being we have to roll twice.
This commit is contained in:
Alex King 2023-01-24 13:39:46 -05:00 committed by GitHub
parent 037be84f38
commit 8c12f7b431
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zone/effects.cpp
View File

@ -437,8 +437,7 @@ int64 Mob::GetActSpellHealing(uint16 spell_id, int64 value, Mob* target, bool fr
}
}
if (critical_chance && zone->random.Roll(critical_chance))
value *= critical_modifier;
value *= critical_modifier;
}
if (IsNPC() && CastToNPC()->GetHealScale()) {