From 8c12f7b431a35ba23d88f5221ec3b3c5978478b9 Mon Sep 17 00:00:00 2001
From: Alex King <89047260+Kinglykrab@users.noreply.github.com>
Date: Tue, 24 Jan 2023 13:39:46 -0500
Subject: [PATCH] [Bug Fix] Remove duplicate logic in GetActSpellHealing
 reducing HOT criticals (#2786)

# Notes
- Removes duplicate critical chance roll in `Mob::GetActSpellHealing`.
- Not sure if this was Live-like or an oversight, but it seems to drastically reduce the possibility of a HOT getting a critical.
- A 1% chance becomes a 0.01% chance being we have to roll twice.
---
 zone/effects.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/zone/effects.cpp b/zone/effects.cpp
index 86a5c847f..8f5f9c96f 100644
--- a/zone/effects.cpp
+++ b/zone/effects.cpp
@@ -437,8 +437,7 @@ int64 Mob::GetActSpellHealing(uint16 spell_id, int64 value, Mob* target, bool fr
 			}
 		}
 
-		if (critical_chance && zone->random.Roll(critical_chance))
-			value *= critical_modifier;
+		value *= critical_modifier;
 	}
 
 	if (IsNPC() && CastToNPC()->GetHealScale()) {