Merge pull request #9 from Valorith/claude/review-inventory-full-jKPLd

Fix inventory overflow bug overwriting equipment slot 0
This commit is contained in:
Vayle 2026-01-23 17:20:32 -05:00 committed by GitHub
commit 87371a1304
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions

View File

@ -1847,7 +1847,7 @@ int16 EQ::InventoryProfile::FindFirstFreeSlotThatFitsItem(const EQ::ItemData *it
}
}
}
return 0;
return INVALID_INDEX;
}
//This function has the same flaw as noted above

View File

@ -4679,7 +4679,8 @@ bool Client::PutItemInInventoryWithStacking(EQ::ItemInstance *inst)
return true;
}
}
if (free_id != INVALID_INDEX) {
// Protect equipment slots (0-22) from being overwritten
if (free_id != INVALID_INDEX && !EQ::ValueWithin(free_id, EQ::invslot::EQUIPMENT_BEGIN, EQ::invslot::EQUIPMENT_END)) {
if (PutItemInInventory(free_id, *inst, true)) {
return true;
}