pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-12 17:51:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Bug Fix] Resolves issues with improper genders and textures on spells. (#1533)

Browse Source 
* [Bug Fix] Resolves issues with improper genders and textures on spells.
Spells will now properly understand their expected gender and texture.
Logic is based on what I saw in a stock PEQ database, can be adjusted if need be.
Any feedback is helpful.

* Made use of GetRaceGenderDefaultHeight() and added all races to their proper conditions.

* Formatting.
This commit is contained in:
Kinglykrab 2021-09-12 23:40:07 -04:00 committed by GitHub
parent 38a86edc70
commit 7b1b05a35c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 105 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
zone/mob.cpp
View File

@ -2123,26 +2123,70 @@ uint16 Mob::GetFactionRace() {
} }
uint8 Mob::GetDefaultGender(uint16 in_race, uint8 in_gender) { uint8 Mob::GetDefaultGender(uint16 in_race, uint8 in_gender) {
if (Mob::IsPlayerRace(in_race) || in_race == 15 || in_race == 50 || in_race == 57 || in_race == 70 || in_race == 98 || in_race == 118 || in_race == 562) { if (
if (in_gender >= 2) { Mob::IsPlayerRace(in_race) ||
// Male default for PC Races in_race == RACE_BROWNIE_15 ||
in_race == RACE_KERRAN_23 ||
in_race == RACE_LION_50 ||
in_race == RACE_DRACNID_57 ||
in_race == RACE_ZOMBIE_70 ||
in_race == RACE_QEYNOS_CITIZEN_71 ||
in_race == RACE_RIVERVALE_CITIZEN_81 ||
in_race == RACE_HALAS_CITIZEN_90 ||
in_race == RACE_GROBB_CITIZEN_92 ||
in_race == RACE_OGGOK_CITIZEN_93 ||
in_race == RACE_KALADIM_CITIZEN_94 ||
in_race == RACE_ELF_VAMPIRE_98 ||
in_race == RACE_FELGUARD_106 ||
in_race == RACE_FAYGUARD_112 ||
in_race == RACE_ERUDITE_GHOST_118 ||
in_race == RACE_IKSAR_CITIZEN_139 ||
in_race == RACE_TROLL_CREW_MEMBER_331 ||
in_race == RACE_PIRATE_DECKHAND_332 ||
in_race == RACE_GNOME_PIRATE_338 ||
in_race == RACE_DARK_ELF_PIRATE_339 ||
in_race == RACE_OGRE_PIRATE_340 ||
in_race == RACE_HUMAN_PIRATE_341 ||
in_race == RACE_ERUDITE_PIRATE_342 ||
in_race == RACE_UNDEAD_PIRATE_344 ||
in_race == RACE_KNIGHT_OF_HATE_351 ||
in_race == RACE_WARLOCK_OF_HATE_352 ||
in_race == RACE_UNDEAD_VAMPIRE_359 ||
in_race == RACE_VAMPIRE_360 ||
in_race == RACE_ZOMBIE_471 ||
in_race == RACE_VAMPIRE_497 ||
in_race == RACE_KERRAN_562 ||
in_race == RACE_BROWNIE_568 ||
in_race == RACE_HUMAN_566 ||
in_race == RACE_ELVEN_GHOST_587 ||
in_race == RACE_HUMAN_GHOST_588 ||
in_race == RACE_COLDAIN_645
) {
if (in_gender >= 2) { // Male default for PC Races
return 0; return 0;
} } else {
else
return in_gender; return in_gender;
} }
else if (in_race == 44 || in_race == 52 || in_race == 55 || in_race == 65 || in_race == 67 || in_race == 88 || in_race == 117 || in_race == 127 || } else if (
in_race == 77 || in_race == 78 || in_race == 81 || in_race == 90 || in_race == 92 || in_race == 93 || in_race == 94 || in_race == 106 || in_race == 112 || in_race == 471) { in_race == RACE_FREEPORT_GUARD_44 ||
// Male only races in_race == RACE_MIMIC_52 ||
in_race == RACE_HUMAN_BEGGAR_55 ||
in_race == RACE_VAMPIRE_65 ||
in_race == RACE_HIGHPASS_CITIZEN_67 ||
in_race == RACE_NERIAK_CITIZEN_77 ||
in_race == RACE_ERUDITE_CITIZEN_78 ||
in_race == RACE_CLOCKWORK_GNOME_88 ||
in_race == RACE_DWARF_GHOST_117 ||
in_race == RACE_SPECTRAL_IKSAR_147 ||
in_race == RACE_INVISIBLE_MAN_127 ||
in_race == RACE_VAMPYRE_208 ||
in_race == RACE_BROKEN_SKULL_PIRATE_333 ||
in_race == RACE_ERUDITE_678
) { // Male only races
return 0; return 0;
} else if (in_race == RACE_FAIRY_25 || in_race == RACE_PIXIE_56) { // Female only races
}
else if (in_race == 25 || in_race == 56) {
// Female only races
return 1; return 1;
} } else { // Neutral default for NPC Races
else {
// Neutral default for NPC Races
return 2; return 2;
} }
} }

74
zone/spell_effects.cpp
View File

@ -1445,37 +1445,53 @@ bool Mob::SpellEffect(Mob* caster, uint16 spell_id, float partial, int level_ove
} }
// Racial Illusions // Racial Illusions
else { else {
SendIllusionPacket auto gender_id = (
( spell.max[i] > 0 &&
spell.base[i], (
Mob::GetDefaultGender(spell.base[i], GetGender()), spell.max[i] != 3 ||
spell.base2[i], spell.base2[i] == 0
spell.max[i] ) ?
(spell.max[i] - 1) :
Mob::GetDefaultGender(spell.base[i], GetGender())
); );
if(spell.base[i] == OGRE){
SendAppearancePacket(AT_Size, 9); auto race_size = GetRaceGenderDefaultHeight(
} spell.base[i],
else if(spell.base[i] == TROLL){ gender_id
SendAppearancePacket(AT_Size, 8); );
}
else if(spell.base[i] == VAHSHIR || spell.base[i] == BARBARIAN){ if (spell.max[i] > 0) {
SendAppearancePacket(AT_Size, 7); if (spell.base2[i] == 0) {
} SendIllusionPacket(
else if(spell.base[i] == HALF_ELF || spell.base[i] == WOOD_ELF || spell.base[i] == DARK_ELF || spell.base[i] == FROGLOK){ spell.base[i],
SendAppearancePacket(AT_Size, 5); gender_id
} );
else if(spell.base[i] == DWARF){ } else {
SendAppearancePacket(AT_Size, 4); if (spell.max[i] != 3) {
} SendIllusionPacket(
else if(spell.base[i] == HALFLING || spell.base[i] == GNOME){ spell.base[i],
SendAppearancePacket(AT_Size, 3); gender_id,
} spell.base2[i],
else if(spell.base[i] == WOLF) { spell.max[i]
SendAppearancePacket(AT_Size, 2); );
} } else {
else{ SendIllusionPacket(
SendAppearancePacket(AT_Size, 6); spell.base[i],
gender_id,
spell.base2[i],
spell.base2[i]
);
}
}
} else {
SendIllusionPacket(
spell.base[i],
gender_id,
spell.base2[i],
spell.max[i]
);
} }
SendAppearancePacket(AT_Size, race_size);
} }
for (int x = EQ::textures::textureBegin; x <= EQ::textures::LastTintableTexture; x++) { for (int x = EQ::textures::textureBegin; x <= EQ::textures::LastTintableTexture; x++) {