pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-13 23:01:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Remove unnecessary condition and cleanup variable name in tasks.cpp (#3293)

Browse Source 
# Notes
- `task_state` is verified by `safe_delete`.
- `size` is the name of a member variable, we should just use `sizeof(uint32_t)` instead.
This commit is contained in:
Alex King 2023-04-14 19:38:28 -04:00 committed by GitHub
parent 21002c2e8a
commit 3f4334985b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
zone/tasks.cpp
View File

@ -15,9 +15,7 @@ extern QueryServ *QServ;
void Client::LoadClientTaskState() void Client::LoadClientTaskState()
{ {
if (RuleB(TaskSystem, EnableTaskSystem) && task_manager) { if (RuleB(TaskSystem, EnableTaskSystem) && task_manager) {
if (task_state) {
safe_delete(task_state); safe_delete(task_state);
}
task_state = new ClientTaskState(); task_state = new ClientTaskState();
if (!task_manager->LoadClientState(this, task_state)) { if (!task_manager->LoadClientState(this, task_state)) {
@ -147,8 +145,7 @@ void Client::StartTaskRequestCooldownTimer()
uint32_t milliseconds = RuleI(TaskSystem, RequestCooldownTimerSeconds) * 1000; uint32_t milliseconds = RuleI(TaskSystem, RequestCooldownTimerSeconds) * 1000;
task_request_timer.Start(milliseconds); task_request_timer.Start(milliseconds);
uint32_t size = sizeof(uint32_t); auto outapp = std::make_unique<EQApplicationPacket>(OP_TaskRequestTimer, sizeof(uint32_t));
auto outapp = std::make_unique<EQApplicationPacket>(OP_TaskRequestTimer, size);
outapp->WriteUInt32(milliseconds); outapp->WriteUInt32(milliseconds);
QueuePacket(outapp.get()); QueuePacket(outapp.get());
} }