From 3f4334985b5575fcd52acb0c2ee00acee1848467 Mon Sep 17 00:00:00 2001 From: Alex King <89047260+Kinglykrab@users.noreply.github.com> Date: Fri, 14 Apr 2023 19:38:28 -0400 Subject: [PATCH] [Cleanup] Remove unnecessary condition and cleanup variable name in tasks.cpp (#3293) # Notes - `task_state` is verified by `safe_delete`. - `size` is the name of a member variable, we should just use `sizeof(uint32_t)` instead. --- zone/tasks.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/zone/tasks.cpp b/zone/tasks.cpp index 114594482..47bccd0a3 100644 --- a/zone/tasks.cpp +++ b/zone/tasks.cpp @@ -15,9 +15,7 @@ extern QueryServ *QServ; void Client::LoadClientTaskState() { if (RuleB(TaskSystem, EnableTaskSystem) && task_manager) { - if (task_state) { - safe_delete(task_state); - } + safe_delete(task_state); task_state = new ClientTaskState(); if (!task_manager->LoadClientState(this, task_state)) { @@ -147,8 +145,7 @@ void Client::StartTaskRequestCooldownTimer() uint32_t milliseconds = RuleI(TaskSystem, RequestCooldownTimerSeconds) * 1000; task_request_timer.Start(milliseconds); - uint32_t size = sizeof(uint32_t); - auto outapp = std::make_unique(OP_TaskRequestTimer, size); + auto outapp = std::make_unique(OP_TaskRequestTimer, sizeof(uint32_t)); outapp->WriteUInt32(milliseconds); QueuePacket(outapp.get()); }