pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-05-17 03:08:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Bug Fix] Handle memory leaks from return value of Client::GetTraderItems() (#2266)

Browse Source 
* Move delete of ItemInstance to avoid edge case leaking in ZoneDatabase::LoadWorldContainer()

* Delete ItemInstance after use in Client::Handle_OP_AdventureMerchantPurchase()

* Delete ItemInstance after use in NPC::GetEquipmentMaterial()

* Delete ItemInstance after use in Bot::AddBotItem()

* Delete GetItems_Struct in edge case when !TradeItemsValid in Client::Handle_OP_Trader()

* Move delete GetItems_Struct to handle edge case when Customer is not valid in Client::Trader_EndTrader()
This commit is contained in:
Quintinon
2022-07-02 20:01:42 -07:00
committed by GitHub
parent 445c94bf4a
commit 30f35a920b
5 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/trading.cpp
+1 -1
View File
@@ -1151,8 +1151,8 @@ void Client::Trader_EndTrader() {
}
safe_delete(outapp);
safe_delete(gis);
}
safe_delete(gis);
}
database.DeleteTraderItem(CharacterID());