[Fix] Guard against crash condition (#4062)

This commit is contained in:
Mitch Freeman 2024-02-11 19:32:59 -04:00 committed by GitHub
parent 1567141c19
commit 20c01ef343
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -146,13 +146,20 @@ void Client::SendGuildRankNames()
{
if (IsInAGuild() && (ClientVersion() >= EQ::versions::ClientVersion::RoF)) {
auto guild = guild_mgr.GetGuildByGuildID(GuildID());
if (!guild) {
return;
}
for (int i = 1; i <= GUILD_MAX_RANK; i++) {
auto outapp = new EQApplicationPacket(OP_GuildUpdate, sizeof(GuildUpdateUCPStruct));
GuildUpdateUCPStruct *gucp = (GuildUpdateUCPStruct *) outapp->pBuffer;
GuildUpdateUCPStruct* gucp = (GuildUpdateUCPStruct*)outapp->pBuffer;
gucp->payload.rank_name.rank = i;
if (guild->rank_names[i].empty()) {
continue;
}
strn0cpy(
gucp->payload.rank_name.rank_name,
guild->rank_names[i].c_str(),