pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-26 11:01:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] quest::setallskill() had always true condition. (#3301)

Browse Source 
# Notes
- Remove unnecessary double check of `initiator`.
- Cleanup logic to use `EQ::skills::GetSkillTypeMap()`.
This commit is contained in:
Alex King 2023-04-29 20:52:30 -04:00 committed by GitHub
parent 6e2e035d66
commit 09a5551de1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
zone/questmgr.cpp
View File

@ -1354,13 +1354,12 @@ void QuestManager::setskill(int skill_id, int value) {
void QuestManager::setallskill(int value) {
QuestManagerCurrentQuestVars();
if (!initiator)
if (!initiator) {
return;
if (initiator) {
EQ::skills::SkillType sk;
for (sk = EQ::skills::Skill1HBlunt; sk <= EQ::skills::HIGHEST_SKILL; sk = (EQ::skills::SkillType)(sk + 1)) {
initiator->SetSkill(sk, value);
}
}
for (const auto& s : EQ::skills::GetSkillTypeMap()) {
initiator->SetSkill(s.first, value);
}
}