From 09a5551de136e21874e970f22b54e1d03d850040 Mon Sep 17 00:00:00 2001
From: Alex King <89047260+Kinglykrab@users.noreply.github.com>
Date: Sat, 29 Apr 2023 20:52:30 -0400
Subject: [PATCH] [Cleanup] quest::setallskill() had always true condition.
 (#3301)

# Notes
- Remove unnecessary double check of `initiator`.
- Cleanup logic to use `EQ::skills::GetSkillTypeMap()`.
---
 zone/questmgr.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/zone/questmgr.cpp b/zone/questmgr.cpp
index be71aa995..5ef32eaac 100644
--- a/zone/questmgr.cpp
+++ b/zone/questmgr.cpp
@@ -1354,13 +1354,12 @@ void QuestManager::setskill(int skill_id, int value) {
 
 void QuestManager::setallskill(int value) {
 	QuestManagerCurrentQuestVars();
-	if (!initiator)
+	if (!initiator) {
 		return;
-	if (initiator) {
-		EQ::skills::SkillType sk;
-		for (sk = EQ::skills::Skill1HBlunt; sk <= EQ::skills::HIGHEST_SKILL; sk = (EQ::skills::SkillType)(sk + 1)) {
-			initiator->SetSkill(sk, value);
-		}
+	}
+
+	for (const auto& s : EQ::skills::GetSkillTypeMap()) {
+		initiator->SetSkill(s.first, value);
 	}
 }