pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-04-22 03:12:27 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
eqemu-server/common
History
Roy Love 5e6fef4098 fix: correct off-by-one in GetSpellLevel for Berserker class 
Class::Berserker == 16 and Class::PLAYER_CLASS_COUNT == 16, so the
guard `class_id >= PLAYER_CLASS_COUNT` evaluated 16 >= 16 as true and
returned UINT8_MAX before reaching the array lookup.

The array access `classes[class_id - 1]` is correct — classes[15] is
the valid Berserker slot. The bug was only in the boundary check.

Replace the count-based guard with explicit named-constant bounds so
the valid range (Warrior=1 through Berserker=16) is self-documenting
and both ends are checked (class_id=0 would underflow the index).

Fixes #5056
2026-04-10 20:27:27 -05:00
..
cli
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
content
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
cron
Standardize Licensing
2026-04-01 17:09:57 -07:00
database
Standardize Licensing
2026-04-01 17:09:57 -07:00
discord
Standardize Licensing
2026-04-01 17:09:57 -07:00
event
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
events
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
http
normalize includes: common
2025-12-26 20:58:07 -08:00
json
[API] Implement Zone Sidecar (#3635)
2023-10-23 22:39:37 -05:00
memory
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
net
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
patches
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
pch
Standardize Licensing
2026-04-01 17:09:57 -07:00
platform
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
process
Standardize Licensing
2026-04-01 17:09:57 -07:00
repositories
Standardize Licensing
2026-04-01 17:09:57 -07:00
stacktrace
[Cleanup] Cleanup uses of insert/push_back when a temp object is used. (#3170)
2023-04-03 16:45:01 -04:00
StackWalker
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
termcolor
Standardize Licensing
2026-04-01 17:09:57 -07:00
util
Standardize Licensing
2026-04-01 17:09:57 -07:00
additive_lagged_fibonacci_engine.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
base_packet.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
base_packet.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
bazaar.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
bazaar.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
bodytypes.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
bodytypes.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
classes.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
classes.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
CMakeLists.txt
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
compression.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
compression.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
crash.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
crash.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
crc16.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
crc16.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
crc32.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
crc32.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
data_bucket.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
data_bucket.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
data_verification.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
database_instances.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
database_schema.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
database.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
database.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
dbcore.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
dbcore.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
deity.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
deity.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
dynamic_zone_base.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
dynamic_zone_base.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
dynamic_zone_lockout.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
dynamic_zone_lockout.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_constants.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_constants.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_limits.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_limits.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_opcodes.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_opcodes.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_oplist.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_versions.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
emu_versions.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_constants.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_limits.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_limits.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_packet_structs.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_packet.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
eq_packet.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
eq_stream_ident.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_stream_ident.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_stream_intf.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
eq_stream_locator.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_stream_proxy.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eq_stream_proxy.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqdb_res.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqdb_res.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqdb.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqdb.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_config_elements.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_config.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_config.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_exception.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_exception.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_logsys_log_aliases.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqemu_logsys.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
eqemu_logsys.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqtime.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
eqtime.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
event_sub.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
event_sub.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
evolving_items.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
evolving_items.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
extprofile.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
extprofile.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
faction.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
faction.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
features.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
file.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
file.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
fixed_memory_hash_set.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
fixed_memory_variable_hash_set.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
global_define.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
guild_base.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
guild_base.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
guilds.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
inventory_profile.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
inventory_profile.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
inventory_slot.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
inventory_slot.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
ip_util.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
ip_util.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
ipc_mutex.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
ipc_mutex.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
item_data.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
item_data.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
item_instance.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
item_instance.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
json_config.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
json_config.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
light_source.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
light_source.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
linked_list.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
loot.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
mail_oplist.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
md5.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
md5.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
memory_buffer.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
memory_buffer.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
memory_mapped_file.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
memory_mapped_file.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
misc_functions.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
misc_functions.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
misc.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
misc.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
mysql_request_result.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
mysql_request_result.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
mysql_request_row.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
mysql_request_row.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
mysql_stmt.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
mysql_stmt.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
op_codes.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
opcode_dispatch.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
opcode_map.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
opcodemgr.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
opcodemgr.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
packet_dump_file.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
packet_dump_file.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
packet_dump.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
packet_dump.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
packet_functions.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
packet_functions.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
packetfile.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
packetfile.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
path_manager.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
path_manager.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
perl_eqdb_res.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
perl_eqdb.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
platform.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
platform.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
proc_launcher.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
proc_launcher.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
process.cpp
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
process.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
profanity_manager.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
profanity_manager.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
profiler.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
ptimer.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
ptimer.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
queue.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
races.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
races.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
raid.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
random.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
rdtsc.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
rdtsc.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
rulesys.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
rulesys.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
ruletypes.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
say_link.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
say_link.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
seperator.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
serialize_buffer.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
serialize_buffer.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
server_event_scheduler.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
server_event_scheduler.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
server_reload_types.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
serverinfo.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
serverinfo.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
servertalk.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
shared_tasks.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
shared_tasks.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
shareddb.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
shareddb.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
skill_caps.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
skill_caps.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
skills.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
skills.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
spdat_bot.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
spdat.cpp
fix: correct off-by-one in GetSpellLevel for Berserker class
2026-04-10 20:27:27 -05:00
spdat.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
strings_legacy.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
strings_misc.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
strings.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
strings.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
struct_strategy.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
struct_strategy.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
tasks.h
Warning fixes, general cleanup (#5053)
2026-04-04 23:27:21 -07:00
textures.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
textures.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
timeoutmgr.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
timeoutmgr.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
timer.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
timer.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
types.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
unix.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
unix.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
useperl.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
version.h
Standardize Licensing
2026-04-01 17:09:57 -07:00
zone_store.cpp
Standardize Licensing
2026-04-01 17:09:57 -07:00
zone_store.h
Standardize Licensing
2026-04-01 17:09:57 -07:00