heroforge testing fixes

.devcontainer/.gitignore

@@ -1,6 +0,0 @@
-!Makefile
-base/*.sql
-base/*.zip
-base/db/
-base/maps/
-!base/expansion/Makefile

.devcontainer/Dockerfile.debian.arm64.dev

@@ -1,9 +0,0 @@
-# This is a "dev" image for running eqemu in development, also for dev containers
-ARG USERNAME=user-name-goes-here
-ARG USER_UID=1000
-ARG USER_GID=$USER_UID
-
-FROM --platform=linux/arm64 mcr.microsoft.com/devcontainers/base:debian
-RUN sudo apt update && sudo apt install -y --no-install-recommends build-essential libtool cmake curl debconf-utils git libluabind-dev libsodium-dev liblua5.2-0 liblua5.2-dev libmariadb-dev libssl-dev minizip make mariadb-client locales nano open-vm-tools unzip uuid-dev iputils-ping wget libcurl4-openssl-dev gdb libyaml-cpp-dev ccache ninja-build pv mariadb-server libperl-dev libjson-perl libio-stringy-perl liblua5.1-dev libluabind-dev libboost-dev mariadb-server valgrind telnet libgoogle-perftools-dev google-perftools
-
-USER $USERNAME

.devcontainer/Dockerfile.debian.dev

@@ -1,9 +0,0 @@
-# This is a "dev" image for running eqemu in development, also for dev containers
-ARG USERNAME=user-name-goes-here
-ARG USER_UID=1000
-ARG USER_GID=$USER_UID
-
-FROM mcr.microsoft.com/devcontainers/base:debian
-RUN sudo apt update && sudo apt install -y --no-install-recommends build-essential libtool cmake curl debconf-utils git libluabind-dev libsodium-dev liblua5.2-0 liblua5.2-dev libmariadb-dev libssl-dev minizip make mariadb-client locales nano open-vm-tools unzip uuid-dev iputils-ping wget libcurl4-openssl-dev gdb libyaml-cpp-dev ccache ninja-build pv mariadb-server libperl-dev libjson-perl libio-stringy-perl liblua5.1-dev libluabind-dev libboost-dev mariadb-server valgrind telnet libgoogle-perftools-dev google-perftools
-
-USER $USERNAME

.devcontainer/Makefile

@@ -1,284 +0,0 @@
-NAME := eqemu-server
-.ONESHELL:
-
-DOCKER_ARGS := --rm  --name ${NAME} -v $$PWD:/src -w /src ${NAME}
-DOCKER_ARM64_ARGS := --rm --platform linux/arm64 --name ${NAME}-arm64 -v $$PWD:/src -w /src ${NAME}-arm64
-
-.PHONY: build
-build:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile build --no-print-directory
-	exit
-endif
-	cd build$$BUILD_SUFFIX && cmake --build . --config Release --target all --
-
-.PHONY: cmake
-cmake:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile cmake --no-print-directory
-	exit
-endif
-	@echo "working directory: $$PWD"
-	mkdir -p build$$BUILD_SUFFIX
-	@cd build$$BUILD_SUFFIX && cmake -DEQEMU_BUILD_LOGIN=ON \
-			-DEQEMU_BUILD_TESTS=ON \
-			-DCMAKE_CXX_COMPILER_LAUNCHER=ccache -G Ninja ..
-
-clean:
-ifneq (,$(findstring .devcontainer,$$PWD))
-	@make -C ../ -f .devcontainer/Makefile clean --no-print-directory
-endif
-	rm -rf build
-
-docker-cmake:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile docker-cmake --no-print-directory
-	exit
-endif
-	@echo "working directory: $$PWD"
-	git submodule update --init --recursive
-	docker run ${DOCKER_ARGS} make cmake
-
-docker-build:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile docker-build --no-print-directory
-	exit
-endif
-	docker run ${DOCKER_ARGS} make build
-
-# Build image if it doesn't exist
-docker-image-build:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile docker-image-build --no-print-directory
-	exit
-endif
-ifeq ($(shell docker images -q ${NAME} 2> /dev/null),)
-	@echo "Docker image not found. Building..."
-	docker build -f Dockerfile.debian.dev -t ${NAME} .
-endif
-
-docker-arm-cmake: docker-arm-image-build
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile docker-arm-cmake --no-print-directory
-	exit
-endif
-	git submodule update --init --recursive
-	docker run ${DOCKER_ARM64_ARGS} make cmake BUILD_SUFFIX=arm64
-
-docker-arm-build: docker-arm-image-build
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile docker-arm-build --no-print-directory
-	exit
-endif
-	docker run ${DOCKER_ARM64_ARGS} make build BUILD_SUFFIX=arm64
-
-docker-arm-image-build:
-ifeq ($(shell docker images -q ${NAME}-arm64 2> /dev/null),)
-	@echo "Docker image not found. Building..."
-	docker build -f Dockerfile.debian.arm.dev -t ${NAME}-arm64 .
-endif
-
-docker-clean: clean
-
-.PHONY: prep
-prep:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile prep --no-print-directory
-	exit
-endif
-	@echo "Preparing build/bin for usage..."
-	mkdir -p build/bin/assets/patches
-	cp -R -u -p .devcontainer/base/eqemu_config.json build/bin/eqemu_config.json
-	cp -R -u -p .devcontainer/base/login.json build/bin/login.json
-	cp -R -u -p loginserver/login_util/* build/bin/assets/patches/
-	mkdir -p build/bin/assets
-	cp -R -u -p utils/patches build/bin/assets/
-	-unlink build/bin/lua_modules
-	cd build/bin && ln -s quests/lua_modules lua_modules
-	-unlink build/bin/mods
-	cd build/bin && ln -s quests/mods mods
-	-unlink build/bin/maps
-	cd build/bin && ln -s ../../base/maps maps
-	mkdir -p build/bin/logs
-	mkdir -p build/bin/shared
-	@echo "Eqemu is prepared. Edit build/bin/eqemu_config.json to configure."
-
-maps:
-	@echo "Downloading maps..."
-	@mkdir -p base/maps
-	@cd base/maps && wget -nc https://github.com/Akkadius/eqemu-maps/archive/refs/heads/master.zip
-	@cd base/maps && unzip -o master.zip
-	@cd base/maps && mv eqemu-maps-master/* .
-	@cd base/maps && rm -rf eqemu-maps-master
-	@echo "Maps downloaded."
-
-quests:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile quests --no-print-directory
-	exit
-endif
-	@cd build/bin && git clone https://github.com/ProjectEQ/projecteqquests.git quests
-
-# Runs tests
-.PHONY: test
-test:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile test --no-print-directory
-	exit
-endif
-	cd build/bin && ./tests
-
-# Runs login binary
-.PHONY: login
-login:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile login --no-print-directory
-	exit
-endif
-	cd build/bin && ./loginserver
-
-# Runs shared_memory binary
-.PHONY: shared
-shared:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile shared --no-print-directory
-	exit
-endif
-	cd build/bin && ./shared_memory
-
-# Runs zone binary
-.PHONY: zone
-zone:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile zone --no-print-directory
-	exit
-endif
-	@-rm build/bin/logs/zone/zone*.log
-	cd build/bin && ./zone
-
-# Runs world binary
-.PHONY: world
-world:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile world --no-print-directory
-	exit
-endif
-	@-rm build/bin/logs/world*.log
-	cd build/bin && ./world
-
-# Runs ucs binary
-.PHONY: ucs
-ucs:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile ucs --no-print-directory
-	exit
-endif
-	@-rm build/bin/logs/ucs*.log
-	cd build/bin && ./ucs
-
-# Runs queryserv binary
-.PHONY: queryserv
-queryserv:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile queryserv --no-print-directory
-	exit
-endif
-	@-rm build/bin/logs/query_server*.log
-	cd build/bin && ./queryserv
-
-valgrind-%:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile valgrind --no-print-directory
-	exit
-endif
-	cd build/bin && valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes --verbose --log-file=logs/$*.valgrind.log ./$*
-
-# Start mariaDB standalone
-.PHONY: mariadb
-mariadb:
-	@sudo service mariadb start
-
-.PHONY: inject-mariadb
-inject-mariadb:
-	-sudo service mariadb start
-	-mkdir -p base/db/
-	-sudo mariadb -e 'DROP DATABASE IF EXISTS peq;'
-	-sudo mariadb -e 'CREATE DATABASE peq;'
-	-sudo mariadb -e "CREATE USER 'peq'@'127.0.0.1' IDENTIFIED BY 'peqpass';"
-	-sudo mariadb -e "GRANT ALL PRIVILEGES ON *.* TO 'peq'@'127.0.0.1';"
-ifeq (,$(wildcard base/db/db.sql.zip))
-	@echo "base/db.sql.zip not found. Downloading latest from https://db.projecteq.net/"
-	wget -nc https://db.projecteq.net/latest -O base/db/db.sql.zip
-	-cd base/db && unzip db.sql.zip
-endif
-	@echo "Sourcing db may take a while, please wait..."
-	@cd base/db/peq-dump && sudo mariadb --database peq -e "source create_all_tables.sql"
-	@echo "MariaDB is now injected."
-
-.PHONY: gm-%
-gm-%:
-	sudo mariadb --database peq -e "UPDATE account SET status=255 WHERE name = '$*';"
-	@echo "Account $* is now a GM. /camp to have it go into effect."
-
-depends:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile depends --no-print-directory
-	exit
-endif
-	sudo apt install graphviz pip time
-	pip3 install graphviz
-	mkdir -p build/depends
-	@if [ ! -f "build/depends/dependency_graph.py" ]; then \
-		wget https://raw.githubusercontent.com/pvigier/dependency-graph/master/dependency_graph.py -O build/depends/dependency_graph.py; \
-	fi
-	@echo "Generating dependency graphs (This may take a while)..."
-	@echo "Login..."
-	time python3 build/depends/dependency_graph.py -f png login build/depends/login.dot
-	@echo "World..."
-	time python3 build/depends/dependency_graph.py -f png world build/depends/world.dot
-	@echo "Zone..."
-	time python3 build/depends/dependency_graph.py -f png zone build/depends/zone.dot
-	@echo "Common..."
-	time python3 build/depends/dependency_graph.py -f png common build/depends/common.dot
-
-backup:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile backup --no-print-directory
-	exit
-endif
-	@mkdir -p build/bin/backup
-	cd build/bin && ./world database:dump --compress --player-tables --state-tables --system-tables --query-serv-tables
-
-cpu-zone:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile cpu-zone --no-print-directory
-	exit
-endif
-	@cd build/bin && mkdir -p tmp
-	cd build/bin && CPUPROFILE=prof.out ./zone
-
-pprof-zone:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile pprof-zone --no-print-directory
-	exit
-endif
-	cd build/bin && google-pprof --pdf zone prof.out > prof.pdf
-pprof-web-zone:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile pprof-web-zone --no-print-directory
-	exit
-endif
-	cd build/bin && google-pprof --web zone prof.out
-pprof-gv-zone:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile pprof-gv-zone --no-print-directory
-	exit
-endif
-	cd build/bin && google-pprof --gv zone prof.out > prof.gv
-heap-zone:
-ifeq ($(findstring .devcontainer,$(CURDIR)),.devcontainer)
-	@make -C ../ -f .devcontainer/Makefile heap-zone --no-print-directory
-	exit
-endif
-	@cd build/bin && mkdir -p tmp
-	cd build/bin && HEAPPROFILE=prof.out ./zone

.devcontainer/base/eqemu_config.json

@@ -1,73 +0,0 @@
-{
-	"server": {
-		"zones": {
-			"defaultstatus": "0",
-			"ports": {
-				"low": "7000",
-				"high": "7400"
-			}
-		},
-		"qsdatabase": {
-			"host": "127.0.0.1",
-			"port": "3306",
-			"username": "peq",
-			"password": "peqpass",
-			"db": "peq"
-		},
-		"chatserver": {
-			"port": "7778",
-			"host": ""
-		},
-		"mailserver": {
-			"host": "",
-			"port": "7778"
-		},
-		"webinterface": {
-			"port": "9081"
-		},
-		"world": {
-			"longname": "New Devbox",
-			"address": "192.168.1.100",
-			"localaddress": "192.168.1.100",
-			"loginserver1": {
-				"account": "",
-				"password": "",
-				"legacy": 0,
-				"host": "login.projecteq.net",
-				"port": "5998"
-			},
-			"tcp": {
-				"ip": "127.0.0.1",
-				"port": "9001"
-			},
-			"telnet": {
-				"ip": "0.0.0.0",
-				"port": "9000",
-				"enabled": "true"
-			},
-			"key": "random-generate-here",
-			"http": {
-				"port": "9080",
-				"enabled": "true",
-				"mimefile": "mime.types"
-			},
-			"shortname": "dev"
-		},
-		"database": {
-			"db": "peq",
-			"host": "127.0.0.1",
-			"port": "3306",
-			"username": "peq",
-			"password": "peqpass"
-		},
-		"files": {
-			"opcodes": "assets/patches/opcodes.conf",
-			"mail_opcodes": "assets/patches/mail_opcodes.conf"
-		},
-		"directories": {
-			"patches": "assets/patches/",
-			"opcodes": "assets/patches/",
-			"plugins": "quests/plugins/"
-		}
-	}
-}

.devcontainer/base/login.json

@@ -1,37 +0,0 @@
-{
-	"database": {
-		"host": "127.0.0.1",
-		"port": "3306",
-		"db": "peq",
-		"user": "peq",
-		"password": "peqpass"
-	},
-	"account": {
-		"auto_create_accounts": true
-	},
-	"worldservers": {
-		"unregistered_allowed": true,
-		"reject_duplicate_servers": false
-	},
-	"web_api": {
-		"enabled": true,
-		"port": 6000
-	},
-	"security": {
-		"mode": 14,
-		"allow_password_login": true,
-		"allow_token_login": true
-	},
-	"logging": {
-		"trace": false,
-		"world_trace": false,
-		"dump_packets_in": false,
-		"dump_packets_out": false
-	},
-	"client_configuration": {
-		"titanium_port": 5998,
-		"titanium_opcodes": "assets/patches/login_opcodes.conf",
-		"sod_port": 5999,
-		"sod_opcodes": "assets/patches/login_opcodes_sod.conf"
-	}
-}

.devcontainer/devcontainer.json

@@ -1,49 +0,0 @@
-// For format details, see https://aka.ms/devcontainer.json. For config options, see the
-// README at: https://github.com/devcontainers/templates/tree/main/src/ubuntu
-{
-	"name": "eqemu",
-	"build": {
-		"dockerfile": "Dockerfile.debian.dev"
-	},
-	"appPort": [
-		"5998:5998/udp",
-		"7000:7000/udp",
-		"7001:7001/udp",
-		"7002:7002/udp",
-		"7003:7003/udp",
-		"7004:7004/udp",
-		"7005:7005/udp",
-		"9000:9000/udp",
-		"9001:9001/udp"
-	],
-	"forwardPorts": [
-		3306
-	],
-	"remoteEnv": {
-		"LOCALWSF": "${localWorkspaceFolder}",
-		"CONTAINERWSF": "${containerWorkspaceFolder}"
-	},
-	"containerUser": "vscode",
-	// add ptrace
-	"runArgs": [
-		"--cap-add=SYS_PTRACE",
-		"--security-opt",
-		"seccomp=unconfined"
-	],
-	"customizations": {
-		"vscode": {
-			"extensions": [
-				"ms-vscode.cpptools-extension-pack",
-				"vilicvane.sensitive-replace",
-				"maattdd.gitless",
-				"bibhasdn.unique-lines",
-				"GitHub.copilot",
-				"xackery.make-magic",
-				"Gruntfuggly.todo-tree",
-				"ms-vscode.cmake-tools"
-			]
-		}
-	},
-	"workspaceFolder": "/src",
-	"workspaceMount": "source=${localWorkspaceFolder},target=/src,type=bind,consistency=cached"
-}

.gitignore

@@ -61,6 +61,9 @@ bin/
 compile_flags.txt
 .cache/
 
+# vscode generated settings
+.vscode/
+
 # Build pipeline
 !utils/scripts/build/
 !utils/scripts/build/should-release/should-release

.vscode/c_cpp_properties.json

@@ -1,23 +0,0 @@
-{
-    "configurations": [
-        {
-            "name": "Linux",
-            "includePath": [
-                "${default}",
-                "${workspaceFolder}/submodules/fmt/include",
-                "${workspaceFolder}/submodules/cereal/include",
-                "${workspaceFolder}/submodules/glm",
-                "${workspaceFolder}/submodules/libuv/include"
-            ],
-            "defines": [
-                "LUA_EQEMU=1"
-            ],
-            "compilerPath": "/usr/bin/gcc",
-            "cStandard": "c17",
-            "cppStandard": "gnu++17",
-            "intelliSenseMode": "linux-gcc-x64",
-            "configurationProvider": "ms-vscode.cmake-tools"
-        }
-    ],
-    "version": 4
-}

.vscode/launch.json

@@ -1,173 +0,0 @@
-{
-	// Use IntelliSense to learn about possible attributes.
-	// Hover to view descriptions of existing attributes.
-	// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
-	"version": "0.2.0",
-	"configurations": [
-		{
-			"name": "(gdb) attach",
-			"type": "cppdbg",
-			"request": "attach",
-			"program": "${workspaceFolder}/build/bin/world",
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) shared_memory",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/shared_memory",
-			"cwd": "${workspaceFolder}/build/bin",
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) world",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/world",
-			"cwd": "${workspaceFolder}/build/bin",
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) zone",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/zone",
-			"cwd": "${workspaceFolder}/build/bin",
-			"args": [
-				"",
-			],
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) zone neriakb",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/zone",
-			"cwd": "${workspaceFolder}/build/bin",
-			"args": [
-				"neriakb",
-			],
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) login",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/loginserver",
-			"cwd": "${workspaceFolder}/build/bin",
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) ucs",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/ucs",
-			"cwd": "${workspaceFolder}/build/bin",
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		},
-		{
-			"name": "(gdb) queryserv",
-			"type": "cppdbg",
-			"request": "launch",
-			"program": "${workspaceFolder}/build/bin/queryserv",
-			"cwd": "${workspaceFolder}/build/bin",
-			"MIMode": "gdb",
-			"setupCommands": [
-				{
-					"description": "Enable pretty-printing for gdb",
-					"text": "-enable-pretty-printing",
-					"ignoreFailures": true
-				},
-				{
-					"description": "Set Disassembly Flavor to Intel",
-					"text": "-gdb-set disassembly-flavor intel",
-					"ignoreFailures": true
-				}
-			]
-		}
-	]
-}

.vscode/settings.json

@@ -1,136 +0,0 @@
-{
-	"editor.detectIndentation": false,
-	"editor.insertSpaces": false,
-	"editor.tabSize": 4,
-	"editor.autoIndent": "full",
-	"editor.trimAutoWhitespace": true,
-	"files.trimTrailingWhitespace": true,
-	//"editor.formatOnSave": true,
-	"search.exclude": {
-		"dependencies": false,
-	},
-	"C_Cpp.default.includePath": [
-		"/usr/include/x86_64-linux-gnu",
-		"/usr/include/lua5.2",
-		"/usr/include/mariadb",
-		"${workspaceFolder}/dependencies/curl_x64/include",
-		"${workspaceFolder}/dependencies/fmt/include",
-		"${workspaceFolder}/dependencies/glm",
-		"${workspaceFolder}/dependencies/libuv/include",
-		"${workspaceFolder}/dependencies/sol2",
-		"${workspaceFolder}/dependencies/zlibng"
-	],
-	"telemetry.enableTelemetry": false,
-	"cmake.buildDirectory": "${workspaceFolder}/build",
-	"cmake.configureArgs": [
-		"-DEQEMU_BUILD_LOGIN=ON",
-		"-DEQEMU_BUILD_TESTS=ON",
-		"-DCMAKE_CXX_COMPILER_LAUNCHER=ccache",
-		"-DEQEMU_ADD_PROFILER=ON",
-		"Ninja"
-	],
-	"cmake.skipConfigureIfCachePresent": true,
-	"cmake.configureOnOpen": false,
-	"files.associations": {
-		"*.ipp": "cpp",
-		"functional": "cpp",
-		"string": "cpp",
-		"iostream": "cpp",
-		"map": "cpp",
-		"fstream": "cpp",
-		"type_traits": "cpp",
-		"utility": "cpp",
-		"cstring": "cpp",
-		"*.tcc": "cpp",
-		"cctype": "cpp",
-		"clocale": "cpp",
-		"cmath": "cpp",
-		"csignal": "cpp",
-		"cstdarg": "cpp",
-		"cstddef": "cpp",
-		"cstdio": "cpp",
-		"cstdlib": "cpp",
-		"ctime": "cpp",
-		"cwchar": "cpp",
-		"cwctype": "cpp",
-		"any": "cpp",
-		"array": "cpp",
-		"atomic": "cpp",
-		"strstream": "cpp",
-		"bit": "cpp",
-		"bitset": "cpp",
-		"chrono": "cpp",
-		"codecvt": "cpp",
-		"compare": "cpp",
-		"complex": "cpp",
-		"concepts": "cpp",
-		"condition_variable": "cpp",
-		"coroutine": "cpp",
-		"cstdint": "cpp",
-		"deque": "cpp",
-		"forward_list": "cpp",
-		"list": "cpp",
-		"set": "cpp",
-		"unordered_map": "cpp",
-		"unordered_set": "cpp",
-		"vector": "cpp",
-		"exception": "cpp",
-		"algorithm": "cpp",
-		"iterator": "cpp",
-		"memory": "cpp",
-		"memory_resource": "cpp",
-		"numeric": "cpp",
-		"optional": "cpp",
-		"random": "cpp",
-		"ratio": "cpp",
-		"regex": "cpp",
-		"source_location": "cpp",
-		"string_view": "cpp",
-		"system_error": "cpp",
-		"tuple": "cpp",
-		"future": "cpp",
-		"initializer_list": "cpp",
-		"iomanip": "cpp",
-		"iosfwd": "cpp",
-		"istream": "cpp",
-		"limits": "cpp",
-		"mutex": "cpp",
-		"new": "cpp",
-		"numbers": "cpp",
-		"ostream": "cpp",
-		"semaphore": "cpp",
-		"sstream": "cpp",
-		"stdexcept": "cpp",
-		"stop_token": "cpp",
-		"streambuf": "cpp",
-		"thread": "cpp",
-		"cfenv": "cpp",
-		"cinttypes": "cpp",
-		"typeindex": "cpp",
-		"typeinfo": "cpp",
-		"valarray": "cpp",
-		"variant": "cpp",
-		"csetjmp": "cpp",
-		"charconv": "cpp",
-		"format": "cpp",
-		"ranges": "cpp",
-		"span": "cpp"
-	},
-	"cmake.statusbar.advanced": {
-		"kit": {
-			"visibility": "hidden",
-		},
-		"debug": {
-			"visibility": "hidden",
-		},
-		"buildTarget": {
-			"visibility": "hidden",
-		},
-		"launch": {
-			"visibility": "hidden",
-		},
-		"ctest": {
-			"visibility": "icon",
-		}
-	}
-}

CHANGELOG.md

@@ -1,391 +1,3 @@
-## [22.53.1] 6/16/2024
-
-### Fixes
-
-* Fix trader mode ([#4397](https://github.com/EQEmu/Server/pull/4397)) @joligario 2024-06-17
-
-## [22.53.0] 6/14/2024
-
-### Bug
-
-* Anon players should not show in /who all ([#4392](https://github.com/EQEmu/Server/pull/4392)) @fryguy503 2024-06-14
-* Escape should put player into SOS if owned. ([#4388](https://github.com/EQEmu/Server/pull/4388)) @fryguy503 2024-06-07
-* Prevent Resurrection Spells from being resisted ([#4393](https://github.com/EQEmu/Server/pull/4393)) @fryguy503 2024-06-14
-
-### Code
-
-* Cleanup Account Status Code ([#4376](https://github.com/EQEmu/Server/pull/4376)) @Kinglykrab 2024-06-02
-* Cleanup Body Type Code ([#4366](https://github.com/EQEmu/Server/pull/4366)) @Kinglykrab 2024-06-02
-* Cleanup Object Type Code ([#4375](https://github.com/EQEmu/Server/pull/4375)) @Kinglykrab 2024-06-14
-* Remove unused code in emu_constants.h ([#4384](https://github.com/EQEmu/Server/pull/4384)) @Kinglykrab 2024-06-14
-
-### Fixes
-
-* Fix #goto Target ([#4382](https://github.com/EQEmu/Server/pull/4382)) @Kinglykrab 2024-06-03
-* Fix Swarm Pet Damage Messages ([#4383](https://github.com/EQEmu/Server/pull/4383)) @Kinglykrab 2024-06-04
-* Fix for players having empty bazaar window dropdown list, even though trader is tagged as a trader. ([#4391](https://github.com/EQEmu/Server/pull/4391)) @neckkola 2024-06-14
-* Fix potential trader crash when serialized item not found ([#4386](https://github.com/EQEmu/Server/pull/4386)) @joligario 2024-06-14
-
-### Rules
-
-* Add Invisible Augment Rules ([#4385](https://github.com/EQEmu/Server/pull/4385)) @Kinglykrab 2024-06-14
-* Classic Harm Touch Formula ([#4394](https://github.com/EQEmu/Server/pull/4394)) @fryguy503 2024-06-14
-* Mend/Sneak allow success tuning ([#4390](https://github.com/EQEmu/Server/pull/4390)) @fryguy503 2024-06-14
-* Snare Override Movement Bonus ([#4381](https://github.com/EQEmu/Server/pull/4381)) @fryguy503 2024-06-02
-
-## [22.52.0] 6/1/2024
-
-### Code
-
-* Cleanup Bucket Comparison Code ([#4374](https://github.com/EQEmu/Server/pull/4374)) @Kinglykrab 2024-06-02
-* Cleanup Bug Category Code ([#4367](https://github.com/EQEmu/Server/pull/4367)) @Kinglykrab 2024-06-01
-* Cleanup Deity Code ([#4363](https://github.com/EQEmu/Server/pull/4363)) @Kinglykrab 2024-06-01
-* Cleanup Special Ability Code ([#4365](https://github.com/EQEmu/Server/pull/4365)) @Kinglykrab 2024-06-01
-* Remove unused code in common/eq_constants.h ([#4364](https://github.com/EQEmu/Server/pull/4364)) @Kinglykrab 2024-06-01
-
-### Combat
-
-* Adjustments to Crippling Blows/Slay Undead and Confirmed Critical Code ([#4354](https://github.com/EQEmu/Server/pull/4354)) @fryguy503 2024-05-27
-
-### Fixes
-
-* Add protection to ensure adventure points award are only attempted on players ([#4371](https://github.com/EQEmu/Server/pull/4371)) @joligario 2024-05-31
-* Adjust Kick/RoundKick Damage Lower levels ([#4355](https://github.com/EQEmu/Server/pull/4355)) @fryguy503 2024-05-28
-* Bazaar Search not working correctly for Iksar, Vashir, Drakkin and Froglok races ([#4379](https://github.com/EQEmu/Server/pull/4379)) @neckkola 2024-06-02
-* Fix Unescaped String in Client::GotoPlayer ([#4373](https://github.com/EQEmu/Server/pull/4373)) @Kinglykrab 2024-06-01
-
-### NPC Spells
-
-* Fixed an issue where the repository spell adj value was overriding the spell difficulty default value ([#4370](https://github.com/EQEmu/Server/pull/4370)) @regneq 2024-06-01
-
-### Quest API
-
-* Add Item Link Methods to Perl/Lua ([#4359](https://github.com/EQEmu/Server/pull/4359)) @Kinglykrab 2024-06-01
-
-### Quests
-
-* Fix Lua encounter double register ([#4369](https://github.com/EQEmu/Server/pull/4369)) @Akkadius 2024-05-31
-* Fix issue with Lua encounters loading in certain circumstances ([#4378](https://github.com/EQEmu/Server/pull/4378)) @Akkadius 2024-06-01
-
-### Rules
-
-* Add Skill Base Damage Rules ([#4360](https://github.com/EQEmu/Server/pull/4360)) @Kinglykrab 2024-06-01
-
-### Skills
-
-* Fix caps out of bounds issue ([#4377](https://github.com/EQEmu/Server/pull/4377)) @Akkadius 2024-06-01
-
-## [22.51.1] 5/27/2024
-
-### Fixes
-
-* Adjust return for perl release check  @Akkadius 2024-05-26
-* Corrected issue with bazaar purchase via parcels where an incorrect quantity would be calculated. ([#4352](https://github.com/EQEmu/Server/pull/4352)) @neckkola 2024-05-27
-
-### Performance
-
-* Improve SkillCaps::GetTrainLevel() Efficiency ([#4350](https://github.com/EQEmu/Server/pull/4350)) @Kinglykrab 2024-05-26
-
-### Rules
-
-* Legacy Compute Defense against modern agi based defense. ([#4349](https://github.com/EQEmu/Server/pull/4349)) @fryguy503 2024-05-27
-
-## [22.51.0] 5/26/2024
-
-### Commands
-
-* #npcspawn Changes ([#4311](https://github.com/EQEmu/Server/pull/4311)) @twincannon 2024-05-16
-* Cleanup #resetaa Command ([#4310](https://github.com/EQEmu/Server/pull/4310)) @Kinglykrab 2024-05-22
-
-### Crash
-
-* Add validation to RemoveXTarget ([#4324](https://github.com/EQEmu/Server/pull/4324)) @Akkadius 2024-05-25
-* Fix Zone deconstructor crashes ([#4325](https://github.com/EQEmu/Server/pull/4325)) @Akkadius 2024-05-25
-* Fix crash issue when dividing by zero in CalcHPRegen ([#4320](https://github.com/EQEmu/Server/pull/4320)) @Akkadius 2024-05-25
-* Fix crash when map name is null ([#4322](https://github.com/EQEmu/Server/pull/4322)) @Akkadius 2024-05-25
-* Fix player event crash in ITEM_DESTROY ([#4326](https://github.com/EQEmu/Server/pull/4326)) @Akkadius 2024-05-25
-* Fix player events reload when out of bounds ([#4321](https://github.com/EQEmu/Server/pull/4321)) @Akkadius 2024-05-25
-* Fix rarer crash in EntityList::MobProcess ([#4319](https://github.com/EQEmu/Server/pull/4319)) @Akkadius 2024-05-25
-
-### Feature
-
-* Add RoF2 Bazaar Support ([#4315](https://github.com/EQEmu/Server/pull/4315)) @neckkola 2024-05-26
-* Add SE_IncreaseArchery and rules to tune archery ([#4335](https://github.com/EQEmu/Server/pull/4335)) @fryguy503 2024-05-26
-* Add parcel container support ([#4305](https://github.com/EQEmu/Server/pull/4305)) @neckkola 2024-05-17
-
-### Fixes
-
-* Accuracy, Avoidance and Atk adjustments ([#4336](https://github.com/EQEmu/Server/pull/4336)) @fryguy503 2024-05-26
-* Fix Crash with null Argument in #modifynpcstat ([#4318](https://github.com/EQEmu/Server/pull/4318)) @Kinglykrab 2024-05-24
-* Fix RemoveAlternateCurrencyValue not updating Client ([#4317](https://github.com/EQEmu/Server/pull/4317)) @Kinglykrab 2024-05-23
-* Fix Using Bind Wound Above 70% Health ([#4340](https://github.com/EQEmu/Server/pull/4340)) @Kinglykrab 2024-05-26
-* Fix issue with #hotfix ([#4316](https://github.com/EQEmu/Server/pull/4316)) @Kinglykrab 2024-05-22
-* Fix issue with #suspend ([#4314](https://github.com/EQEmu/Server/pull/4314)) @Kinglykrab 2024-05-23
-* Fix issue with KeepOneRecordPerCompletedTask ([#4313](https://github.com/EQEmu/Server/pull/4313)) @Kinglykrab 2024-05-23
-* Fix mistaken removed RULE_CATEGORY_END() ([#4341](https://github.com/EQEmu/Server/pull/4341)) @fryguy503 2024-05-26
-* Missed a mob offense section for PR #4328 ([#4331](https://github.com/EQEmu/Server/pull/4331)) @fryguy503 2024-05-26
-* Raid Targets should not be Blindable as this will break all spell casting AI. ([#4334](https://github.com/EQEmu/Server/pull/4334)) @fryguy503 2024-05-26
-* When Mounts are allowed to zone, block them from zoning to disallowed zones. ([#4330](https://github.com/EQEmu/Server/pull/4330)) @fryguy503 2024-05-25
-* When refreshing buffs, attempt to use the same buffslot if the buff still exists. ([#4338](https://github.com/EQEmu/Server/pull/4338)) @fryguy503 2024-05-26
-
-### Lua Mod
-
-* Fix issue with SetAAEXP and SetEXP firing when uninitialized ([#4345](https://github.com/EQEmu/Server/pull/4345)) @Akkadius 2024-05-26
-
-### Merchants
-
-* Add New Classic Greed/Faction/Charisma Prices Rule ([#4301](https://github.com/EQEmu/Server/pull/4301)) @noudess 2024-05-17
-
-### Mobs
-
-* Remove entity type checks from ScanCloseMobs ([#4323](https://github.com/EQEmu/Server/pull/4323)) @Akkadius 2024-05-25
-
-### NPC Spells
-
-* Fix an issue where procs wouldn't fire if no spell entries in list ([#4344](https://github.com/EQEmu/Server/pull/4344)) @Akkadius 2024-05-26
-
-### Perl
-
-* Linux /opt/eqemu-perl checks when using release binaries ([#4346](https://github.com/EQEmu/Server/pull/4346)) @Akkadius 2024-05-26
-
-### Quest API
-
-* Add Zone Uptime Exports to Perl/Lua ([#4339](https://github.com/EQEmu/Server/pull/4339)) @Kinglykrab 2024-05-26
-
-### Rules
-
-* Added MeleeMitigation Level Difference Roll Adjusted for level diffs ([#4332](https://github.com/EQEmu/Server/pull/4332)) @fryguy503 2024-05-26
-* Allow maximum per kill AA amount ([#4329](https://github.com/EQEmu/Server/pull/4329)) @fryguy503 2024-05-25
-* Allow servers to adjust the filtering threshold for heals from damage (e.g. Mark of Kings). ([#4327](https://github.com/EQEmu/Server/pull/4327)) @fryguy503 2024-05-25
-* Backstab Haste Correction ([#4337](https://github.com/EQEmu/Server/pull/4337)) @fryguy503 2024-05-26
-* Mob Offensive and Weapon Skill static tables ([#4328](https://github.com/EQEmu/Server/pull/4328)) @fryguy503 2024-05-25
-* Remove hard coded initial aggro in favor or an adjustable Rule ([#4333](https://github.com/EQEmu/Server/pull/4333)) @fryguy503 2024-05-26
-
-### Scripts
-
-* Fix zone data load ordering issue ([#4343](https://github.com/EQEmu/Server/pull/4343)) @Akkadius 2024-05-26
-
-### Spells
-
-* Add content filtering to NPC spells ([#4309](https://github.com/EQEmu/Server/pull/4309)) @Akkadius 2024-05-17
-
-## [22.50.1] 5/12/2024
-
-### Fixes
-
-* Clear GuildOnlineStatus on world boot ([#4306](https://github.com/EQEmu/Server/pull/4306)) @neckkola 2024-05-12
-
-## [22.50.0] 5/9/2024
-
-### Code
-
-* Fix Message in #find task ([#4270](https://github.com/EQEmu/Server/pull/4270)) @Kinglykrab 2024-04-19
-
-### Combat
-
-* Add rule to set stun duration.  Add rule to add stun messages. ([#4284](https://github.com/EQEmu/Server/pull/4284)) @noudess 2024-04-25
-
-### Commands
-
-* Adjust #kill and #list Commands ([#4271](https://github.com/EQEmu/Server/pull/4271)) @Kinglykrab 2024-05-04
-
-### Compiling
-
-* Add profiler flag ([#4293](https://github.com/EQEmu/Server/pull/4293)) @xackery 2024-05-04
-
-### Corpses
-
-* Corpse searches for items did not search augs ([#4289](https://github.com/EQEmu/Server/pull/4289)) @noudess 2024-04-27
-
-### Database
-
-* Add Extra Haste to Bots/Character Tables ([#4286](https://github.com/EQEmu/Server/pull/4286)) @Kinglykrab 2024-05-04
-* Break out changes to `npc_types` from parcels ([#4295](https://github.com/EQEmu/Server/pull/4295)) @joligario 2024-05-03
-* Move pets query to content database ([#4296](https://github.com/EQEmu/Server/pull/4296)) @joligario 2024-05-04
-
-### Doors
-
-* Replace magic # in code with a field in doors table for when door closes. ([#4288](https://github.com/EQEmu/Server/pull/4288)) @noudess 2024-04-25
-
-### Experience
-
-* Add SetExp/SetAAExp lua mods ([#4292](https://github.com/EQEmu/Server/pull/4292)) @xackery 2024-05-04
-
-### Feature
-
-* Add Augmentation Support for Parcels ([#4285](https://github.com/EQEmu/Server/pull/4285)) @neckkola 2024-04-24
-* Add Character Auto Login ([#4216](https://github.com/EQEmu/Server/pull/4216)) @Kinglykrab 2024-04-15
-* Add Parcel Feature for RoF2 Clients ([#4198](https://github.com/EQEmu/Server/pull/4198)) @neckkola 2024-04-21
-* Add `is_parcel_merchant` to #npcedit ([#4290](https://github.com/EQEmu/Server/pull/4290)) @Kinglykrab 2024-05-04
-* Add devcontainer support ([#4294](https://github.com/EQEmu/Server/pull/4294)) @xackery 2024-05-09
-* Fix ignore_default on lua mod damage ([#4228](https://github.com/EQEmu/Server/pull/4228)) @xackery 2024-04-15
-
-### Fixes
-
-* "GM flag" vs "GM Flag"  @Akkadius 2024-05-04
-* All NPC classes could stun with kick/only warriors could be stunned ([#4273](https://github.com/EQEmu/Server/pull/4273)) @noudess 2024-04-24
-* Fix Account Flags Loading ([#4243](https://github.com/EQEmu/Server/pull/4243)) @Kinglykrab 2024-04-15
-* Fix Corpses "Disappearing" ([#4275](https://github.com/EQEmu/Server/pull/4275)) @joligario 2024-04-21
-* Fix Issue With Auto Login ([#4267](https://github.com/EQEmu/Server/pull/4267)) @Kinglykrab 2024-04-21
-* Fix crash from #4266  @Akkadius 2024-05-05
-* Fixes Issue 4257 - Double Taunt Message ([#4258](https://github.com/EQEmu/Server/pull/4258)) @fryguy503 2024-04-18
-* GLAA fix after database.cpp updates ([#4277](https://github.com/EQEmu/Server/pull/4277)) @neckkola 2024-04-21
-* GetSkill default return 0  @Akkadius 2024-05-05
-* Hero forge armor bug on login and show helm toggle. ([#4246](https://github.com/EQEmu/Server/pull/4246)) @noudess 2024-04-15
-* Perl__send_parcel GCC compile error  @Akkadius 2024-05-05
-* Remove food or water GM message  @Akkadius 2024-05-05
-* Revert GetSkill from #4234  @Akkadius 2024-05-05
-* Fix for world crash with over 1500 guilds ([#4299](https://github.com/EQEmu/Server/pull/4299)) @neckkola 2024-05-09
-
-### Hot Fix
-
-* Update database_update_manifest.cpp ([#4291](https://github.com/EQEmu/Server/pull/4291)) @noudess 2024-04-29
-
-### Loot
-
-* Add content filtering to lootdrop_entries ([#4229](https://github.com/EQEmu/Server/pull/4229)) @Akkadius 2024-04-15
-* Consolidate filtering logic ([#4280](https://github.com/EQEmu/Server/pull/4280)) @Akkadius 2024-04-21
-
-### Lua
-
-* Add IsImmuneToSpell Lua Mod ([#4278](https://github.com/EQEmu/Server/pull/4278)) @xackery 2024-04-28
-* Add UpdatePersonalFaction Lua Mod ([#4279](https://github.com/EQEmu/Server/pull/4279)) @xackery 2024-05-04
-
-### Messages
-
-* Add GM Status and Invulnerability Messages ([#4266](https://github.com/EQEmu/Server/pull/4266)) @Kinglykrab 2024-05-04
-* Fix bug where DoT messages stop coming out when mob dies. ([#4249](https://github.com/EQEmu/Server/pull/4249)) @noudess 2024-04-15
-* Fix multiple errors in spell damage at death. ([#4264](https://github.com/EQEmu/Server/pull/4264)) @noudess 2024-04-28
-
-### Performance
-
-* Change skill_cap from vector to map ([#4252](https://github.com/EQEmu/Server/pull/4252)) @xackery 2024-04-15
-
-### Pets
-
-* Fix errors in sync with client of sit/stand ([#4245](https://github.com/EQEmu/Server/pull/4245)) @noudess 2024-04-15
-
-### Quest API
-
-* Add DescribeSpecialAbilities() to Perl/Lua ([#4269](https://github.com/EQEmu/Server/pull/4269)) @Kinglykrab 2024-04-21
-* Add GetConsiderColor() to Perl/Lua ([#4253](https://github.com/EQEmu/Server/pull/4253)) @Kinglykrab 2024-04-15
-* Add Parcel Sending to Perl/Lua ([#4287](https://github.com/EQEmu/Server/pull/4287)) @Kinglykrab 2024-05-04
-* Add Zone Methods to Perl/Lua ([#4268](https://github.com/EQEmu/Server/pull/4268)) @Kinglykrab 2024-04-21
-
-### Quests
-
-* Hot Reload Changes ([#4302](https://github.com/EQEmu/Server/pull/4302)) @Akkadius 2024-05-09
-* Reload Quests on Bootup, Init earlier ([#4298](https://github.com/EQEmu/Server/pull/4298)) @Akkadius 2024-05-05
-
-### Spells
-
-* Implemented SPA 122 SE_ReduceSkill ([#4234](https://github.com/EQEmu/Server/pull/4234)) @KayenEQ 2024-05-04
-* Normal Group Spells (non-raid) landed twice on caster ([#4240](https://github.com/EQEmu/Server/pull/4240)) @noudess 2024-04-15
-* SPA69 TotalHP can be used in Worn Slot, Fixes/Updates to Max HP related variables. ([#4244](https://github.com/EQEmu/Server/pull/4244)) @KayenEQ 2024-04-15
-
-### Zone Instances
-
-* Handle routing to instances when using evac/succor ([#4297](https://github.com/EQEmu/Server/pull/4297)) @joligario 2024-05-04
-
-## [22.49.1] 4/15/2024
-
-### Zoning
-
-* Fix zone routing edge case ([#4255](https://github.com/EQEmu/Server/pull/4255)) @Akkadius 2024-04-15
-
-## [22.49.0] 4/15/2024
-
-### Code
-
-* Avoid unnecessary copies in database functions ([#4220](https://github.com/EQEmu/Server/pull/4220)) @joligario 2024-03-29
-* Reference type in `GetRaidLeaderName` ([#4218](https://github.com/EQEmu/Server/pull/4218)) @joligario 2024-03-28
-* Remove unnecessary reference types ([#4212](https://github.com/EQEmu/Server/pull/4212)) @joligario 2024-03-28
-
-### Crash
-
-* Check mob pointer before trying to remove it ([#4230](https://github.com/EQEmu/Server/pull/4230)) @Akkadius 2024-04-01
-
-### Feature
-
-* Add Character Auto Login ([#4216](https://github.com/EQEmu/Server/pull/4216)) @Kinglykrab 2024-04-15
-* Add LuaMod functions for CommonDamage and HealDamage ([#4227](https://github.com/EQEmu/Server/pull/4227)) @xackery 2024-03-31
-* Add RegisterBug LuaMod ([#4209](https://github.com/EQEmu/Server/pull/4209)) @xackery 2024-03-30
-* Additive Spell Focus from Worn slot with Limit Checks ([#4208](https://github.com/EQEmu/Server/pull/4208)) @KayenEQ 2024-03-30
-* Fix ignore_default on lua mod damage ([#4228](https://github.com/EQEmu/Server/pull/4228)) @xackery 2024-04-15
-
-### Fixes
-
-* Client not updating HP bar when an HP Buff with a Heal is applied. ([#4237](https://github.com/EQEmu/Server/pull/4237)) @KayenEQ 2024-04-02
-* Fix Account Flags Loading ([#4243](https://github.com/EQEmu/Server/pull/4243)) @Kinglykrab 2024-04-15
-* Fix Auto Login Issue ([#4213](https://github.com/EQEmu/Server/pull/4213)) @Kinglykrab 2024-03-28
-* Fix Bot Creation Issue ([#4235](https://github.com/EQEmu/Server/pull/4235)) @Kinglykrab 2024-04-02
-* Fix Bot/Character ID Overlap in Groups ([#4093](https://github.com/EQEmu/Server/pull/4093)) @Kinglykrab 2024-03-23
-* Fix Group Leadership ([#4214](https://github.com/EQEmu/Server/pull/4214)) @Kinglykrab 2024-03-28
-* Fix Issue With Bot Raid Aggro ([#4222](https://github.com/EQEmu/Server/pull/4222)) @Kinglykrab 2024-03-31
-* Fix Lua Crash with Spell Blocked Event ([#4236](https://github.com/EQEmu/Server/pull/4236)) @Kinglykrab 2024-04-01
-* Fix Luabind Double Class Register ([#4219](https://github.com/EQEmu/Server/pull/4219)) @Kinglykrab 2024-03-29
-* Fix crash in SendEnterWorld ([#4204](https://github.com/EQEmu/Server/pull/4204)) @Akkadius 2024-03-24
-* Fix event_consider any_cast error ([#4210](https://github.com/EQEmu/Server/pull/4210)) @xackery 2024-03-27
-* Fix fishing chances ([#4203](https://github.com/EQEmu/Server/pull/4203)) @joligario 2024-03-24
-* Fix manifest for skill caps schema type ([#4231](https://github.com/EQEmu/Server/pull/4231)) @Akkadius 2024-04-02
-* Hero forge armor bug on login and show helm toggle. ([#4246](https://github.com/EQEmu/Server/pull/4246)) @noudess 2024-04-15
-* Radiant/Ebon Crystals should only extract to 1000 ([#4195](https://github.com/EQEmu/Server/pull/4195)) @fryguy503 2024-03-23
-* SPA214 SE_MaxHPChange calculation errors corrected. ([#4238](https://github.com/EQEmu/Server/pull/4238)) @KayenEQ 2024-04-02
-* Shared Tasks - charid is now character_id ([#4233](https://github.com/EQEmu/Server/pull/4233)) @fryguy503 2024-04-01
-* Using %T in channel messages on fresh corpse yields mob, not corpse name. ([#4168](https://github.com/EQEmu/Server/pull/4168)) @noudess 2024-04-05
-
-### Hot Fix
-
-* Fix Group::AddToGroup ([#4201](https://github.com/EQEmu/Server/pull/4201)) @Kinglykrab 2024-03-23
-* Hot Fix for Group::AddToGroup Hot Fix ([#4202](https://github.com/EQEmu/Server/pull/4202)) @Kinglykrab 2024-03-23
-
-### Loot
-
-* Add content filtering to lootdrop_entries ([#4229](https://github.com/EQEmu/Server/pull/4229)) @Akkadius 2024-04-15
-
-### Lua
-
-* Add Zone and Language Constants ([#4211](https://github.com/EQEmu/Server/pull/4211)) @fryguy503 2024-03-28
-
-### Messages
-
-* Fix bug where DoT messages stop coming out when mob dies. ([#4249](https://github.com/EQEmu/Server/pull/4249)) @noudess 2024-04-15
-
-### Performance
-
-* Change skill_cap from vector to map ([#4252](https://github.com/EQEmu/Server/pull/4252)) @xackery 2024-04-15
-
-### Pets
-
-* Fix errors in sync with client of sit/stand ([#4245](https://github.com/EQEmu/Server/pull/4245)) @noudess 2024-04-15
-
-### Quest API
-
-* Add Archetype Methods to Perl/Lua ([#4181](https://github.com/EQEmu/Server/pull/4181)) @Kinglykrab 2024-03-23
-* Add Class/Deity/Race Methods to Perl/Lua ([#4215](https://github.com/EQEmu/Server/pull/4215)) @Kinglykrab 2024-03-28
-* Add GetConsiderColor() to Perl/Lua ([#4253](https://github.com/EQEmu/Server/pull/4253)) @Kinglykrab 2024-04-15
-* Add Spell Blocked Event to Perl/Lua ([#4217](https://github.com/EQEmu/Server/pull/4217)) @Kinglykrab 2024-04-01
-
-### Quests
-
-* Avoid Player and Bot quests in unloaded zone ([#4232](https://github.com/EQEmu/Server/pull/4232)) @hgtw 2024-04-01
-
-### Repositories
-
-* Convert database.cpp to Repositories ([#4054](https://github.com/EQEmu/Server/pull/4054)) @Kinglykrab 2024-03-24
-
-### Skill Caps
-
-* Further improvements ([#4205](https://github.com/EQEmu/Server/pull/4205)) @Akkadius 2024-03-24
-* Remove from shared memory and simplify ([#4069](https://github.com/EQEmu/Server/pull/4069)) @Kinglykrab 2024-03-23
-
-### Spells
-
-* Implemented SPA 463 SE_SHIELD_TARGET ([#4224](https://github.com/EQEmu/Server/pull/4224)) @KayenEQ 2024-03-30
-* Normal Group Spells (non-raid) landed twice on caster ([#4240](https://github.com/EQEmu/Server/pull/4240)) @noudess 2024-04-15
-* SPA148 Stacking Fix ([#4206](https://github.com/EQEmu/Server/pull/4206)) @KayenEQ 2024-03-27
-* SPA69 TotalHP can be used in Worn Slot, Fixes/Updates to Max HP related variables. ([#4244](https://github.com/EQEmu/Server/pull/4244)) @KayenEQ 2024-04-15
-
 ## [22.48.0] 3/23/2024
 
 ### Bots

CMakeLists.txt

@@ -31,13 +31,6 @@ IF (EQEMU_BUILD_STATIC)
 	ENDIF ()
 ENDIF (EQEMU_BUILD_STATIC)
 
-
-# Requires libgoogle-perftools-dev google-perftools packages for linux (debian)
-IF(EQEMU_ADD_PROFILER)
-	SET(CMAKE_EXE_LINKER_FLAGS "-Wl,--no-as-needed,-lprofiler,--as-needed")
-ENDIF(EQEMU_ADD_PROFILER)
-
-
 IF(MSVC)
 	ADD_DEFINITIONS(-D_CRT_SECURE_NO_WARNINGS)
 	ADD_DEFINITIONS(-DNOMINMAX)

client_files/export/main.cpp

@@ -31,14 +31,11 @@
 #include "../../common/path_manager.h"
 #include "../../common/repositories/skill_caps_repository.h"
 #include "../../common/file.h"
-#include "../../common/events/player_event_logs.h"
-#include "../../common/skill_caps.h"
 
 EQEmuLogSys LogSys;
 WorldContentService content_service;
 ZoneStore zone_store;
 PathManager path;
-PlayerEventLogs     player_event_logs;
 
 void ExportSpells(SharedDatabase *db);
 void ExportSkillCaps(SharedDatabase *db);
@@ -214,16 +211,17 @@ void ExportSkillCaps(SharedDatabase* db)
 		return;
 	}
 
+	const uint8 skill_cap_max_level = (
+		RuleI(Character, SkillCapMaxLevel) > 0 ?
+		RuleI(Character, SkillCapMaxLevel) :
+		RuleI(Character, MaxLevel)
+	);
+
 	for (uint8 class_id = Class::Warrior; class_id <= Class::Berserker; class_id++) {
 		for (uint8 skill_id = EQ::skills::Skill1HBlunt; skill_id <= EQ::skills::Skill2HPiercing; skill_id++) {
 			if (SkillUsable(db, skill_id, class_id)) {
 				uint32 previous_cap = 0;
-
+				for (uint8 level = 1; level <= skill_cap_max_level; level++) {
-				for (
-					uint8 level = 1;
-					level <= SkillCaps::GetSkillCapMaxLevel(class_id, static_cast<EQ::skills::SkillType>(skill_id));
-					level++
-					) {
 					uint32 cap = GetSkill(db, skill_id, class_id, level);
 					if (cap < previous_cap) {
 						cap = previous_cap;

client_files/import/main.cpp

@@ -29,13 +29,11 @@
 #include "../../common/path_manager.h"
 #include "../../common/repositories/base_data_repository.h"
 #include "../../common/file.h"
-#include "../../common/events/player_event_logs.h"
 
 EQEmuLogSys LogSys;
 WorldContentService content_service;
 ZoneStore zone_store;
 PathManager path;
-PlayerEventLogs     player_event_logs;
 
 void ImportSpells(SharedDatabase *db);
 void ImportSkillCaps(SharedDatabase *db);

common/CMakeLists.txt

@@ -2,8 +2,6 @@ CMAKE_MINIMUM_REQUIRED(VERSION 3.12)
 
 SET(common_sources
     base_packet.cpp
-    bazaar.cpp
-    bodytypes.cpp
     classes.cpp
     cli/eqemu_command_handler.cpp
     compression.cpp
@@ -179,8 +177,6 @@ SET(repositories
     repositories/base/base_character_leadership_abilities_repository.h
     repositories/base/base_character_material_repository.h
     repositories/base/base_character_memmed_spells_repository.h
-    repositories/base/base_character_parcels_repository.h
-    repositories/base/base_character_parcels_containers_repository.h
     repositories/base/base_character_peqzone_flags_repository.h
     repositories/base/base_character_pet_buffs_repository.h
     repositories/base/base_character_pet_info_repository.h
@@ -361,8 +357,6 @@ SET(repositories
     repositories/character_leadership_abilities_repository.h
     repositories/character_material_repository.h
     repositories/character_memmed_spells_repository.h
-    repositories/character_parcels_repository.h
-    repositories/character_parcels_containers_repository.h
     repositories/character_peqzone_flags_repository.h
     repositories/character_pet_buffs_repository.h
     repositories/character_pet_info_repository.h
@@ -503,7 +497,6 @@ SET(repositories
 
 SET(common_headers
     additive_lagged_fibonacci_engine.h
-    bazaar.h
     base_packet.h
     bodytypes.h
     classes.h

common/bazaar.cpp

@@ -1,359 +0,0 @@
-#include "bazaar.h"
-
-#include "../../common/item_instance.h"
-#include "repositories/trader_repository.h"
-#include <memory>
-
-std::vector<BazaarSearchResultsFromDB_Struct>
-Bazaar::GetSearchResults(
-	SharedDatabase &db,
-	BazaarSearchCriteria_Struct search,
-	uint32 char_zone_id
-)
-{
-	LogTrading(
-		"Searching for items with search criteria - item_name [{}] min_cost [{}] max_cost [{}] min_level [{}] "
-		"max_level [{}] max_results [{}] prestige [{}] augment [{}] trader_entity_id [{}] trader_id [{}] "
-		"search_scope [{}] char_zone_id [{}]",
-		search.item_name,
-		search.min_cost,
-		search.max_cost,
-		search.min_level,
-		search.max_level,
-		search.max_results,
-		search.prestige,
-		search.augment,
-		search.trader_entity_id,
-		search.trader_id,
-		search.search_scope,
-		char_zone_id
-	);
-
-	std::string search_criteria_trader("TRUE ");
-
-	if (search.search_scope == NonRoFBazaarSearchScope) {
-		search_criteria_trader.append(
-			fmt::format(
-				" AND trader.char_entity_id = {} AND trader.char_zone_id = {}",
-				search.trader_entity_id,
-				Zones::BAZAAR
-			)
-		);
-	}
-	else if (search.search_scope == Local_Scope) {
-		search_criteria_trader.append(fmt::format(" AND trader.char_zone_id = {}", char_zone_id));
-	}
-	else if (search.trader_id > 0) {
-		search_criteria_trader.append(fmt::format(" AND trader.char_id = {}", search.trader_id));
-	}
-	if (search.min_cost != 0) {
-		search_criteria_trader.append(fmt::format(" AND trader.item_cost >= {}", search.min_cost));
-	}
-	if (search.max_cost != 0) {
-		search_criteria_trader.append(fmt::format(" AND trader.item_cost <= {}", (uint64) search.max_cost * 1000));
-	}
-
-	// not yet implemented
-	//	if (search.prestige != 0) {
-	// 	   0xffffffff prestige only, 0xfffffffe non-prestige, 0 all
-	//		search_criteria.append(fmt::format(" AND items.type = {} ", search.prestige));
-	//	}
-
-	std::string query = fmt::format(
-		"SELECT COUNT(item_id), trader.char_id, trader.item_id, trader.item_sn, trader.item_charges, trader.item_cost, "
-		"trader.slot_id, SUM(trader.item_charges), trader.char_zone_id, trader.char_entity_id, character_data.name, "
-		"aug_slot_1, aug_slot_2, aug_slot_3, aug_slot_4, aug_slot_5, aug_slot_6 "
-		"FROM trader, character_data "
-		"WHERE {} AND trader.char_id = character_data.id "
-		"GROUP BY trader.item_sn, trader.item_charges, trader.char_id",
-		search_criteria_trader.c_str()
-	);
-
-	std::vector<BazaarSearchResultsFromDB_Struct> all_entries;
-
-	auto results = db.QueryDatabase(query);
-
-	if (!results.Success()) {
-		return all_entries;
-	}
-
-	struct ItemSearchType {
-		EQ::item::ItemType type;
-		bool               condition;
-	};
-
-	struct AddititiveSearchCriteria {
-		bool should_check;
-		bool condition;
-	};
-
-	for (auto row: results) {
-		BazaarSearchResultsFromDB_Struct r{};
-
-		r.item_id = Strings::ToInt(row[2]);
-		r.charges = Strings::ToInt(row[4]);
-
-		auto item = db.GetItem(r.item_id);
-		if (!item) {
-			continue;
-		}
-
-		uint32 aug_slot_1 = Strings::ToUnsignedInt(row[11]);
-		uint32 aug_slot_2 = Strings::ToUnsignedInt(row[12]);
-		uint32 aug_slot_3 = Strings::ToUnsignedInt(row[13]);
-		uint32 aug_slot_4 = Strings::ToUnsignedInt(row[14]);
-		uint32 aug_slot_5 = Strings::ToUnsignedInt(row[15]);
-		uint32 aug_slot_6 = Strings::ToUnsignedInt(row[16]);
-
-		std::unique_ptr<EQ::ItemInstance> inst(
-			db.CreateItem(
-				item,
-				r.charges,
-				aug_slot_1,
-				aug_slot_2,
-				aug_slot_3,
-				aug_slot_4,
-				aug_slot_5,
-				aug_slot_6
-			)
-		);
-
-		if (!inst->GetItem()) {
-			continue;
-		}
-
-		r.count             = Strings::ToInt(row[0]);
-		r.trader_id         = Strings::ToInt(row[1]);
-		r.serial_number     = Strings::ToInt(row[3]);
-		r.cost              = Strings::ToInt(row[5]);
-		r.slot_id           = Strings::ToInt(row[6]);
-		r.sum_charges       = Strings::ToInt(row[7]);
-		r.stackable         = item->Stackable;
-		r.icon_id           = item->Icon;
-		r.trader_zone_id    = Strings::ToInt(row[8]);
-		r.trader_entity_id  = Strings::ToInt(row[9]);
-		r.serial_number_RoF = fmt::format("{:016}\0", Strings::ToInt(row[3]));
-		r.item_name         = fmt::format("{:.63}\0", item->Name);
-		r.trader_name       = fmt::format("{:.63}\0", std::string(row[10]).c_str());
-
-		LogTradingDetail(
-			"Searching against item [{}] ({}) for trader [{}]",
-			item->Name,
-			item->ID,
-			r.trader_name
-		);
-
-		// item stat searches
-		std::map<uint32, uint32> item_stat_searches = {
-
-			{STAT_AC,                  inst->GetItemArmorClass(true)},
-			{STAT_AGI,                 static_cast<uint32>(inst->GetItemAgi(true))},
-			{STAT_CHA,                 static_cast<uint32>(inst->GetItemCha(true))},
-			{STAT_DEX,                 static_cast<uint32>(inst->GetItemDex(true))},
-			{STAT_INT,                 static_cast<uint32>(inst->GetItemInt(true))},
-			{STAT_STA,                 static_cast<uint32>(inst->GetItemSta(true))},
-			{STAT_STR,                 static_cast<uint32>(inst->GetItemStr(true))},
-			{STAT_WIS,                 static_cast<uint32>(inst->GetItemWis(true))},
-			{STAT_COLD,                static_cast<uint32>(inst->GetItemCR(true))},
-			{STAT_DISEASE,             static_cast<uint32>(inst->GetItemDR(true))},
-			{STAT_FIRE,                static_cast<uint32>(inst->GetItemFR(true))},
-			{STAT_MAGIC,               static_cast<uint32>(inst->GetItemMR(true))},
-			{STAT_POISON,              static_cast<uint32>(inst->GetItemPR(true))},
-			{STAT_HP,                  static_cast<uint32>(inst->GetItemHP(true))},
-			{STAT_MANA,                static_cast<uint32>(inst->GetItemMana(true))},
-			{STAT_ENDURANCE,           static_cast<uint32>(inst->GetItemEndur(true))},
-			{STAT_ATTACK,              static_cast<uint32>(inst->GetItemAttack(true))},
-			{STAT_HP_REGEN,            static_cast<uint32>(inst->GetItemRegen(true))},
-			{STAT_MANA_REGEN,          static_cast<uint32>(inst->GetItemManaRegen(true))},
-			{STAT_HASTE,               static_cast<uint32>(inst->GetItemHaste(true))},
-			{STAT_DAMAGE_SHIELD,       static_cast<uint32>(inst->GetItemDamageShield(true))},
-			{STAT_DS_MITIGATION,       static_cast<uint32>(inst->GetItemDSMitigation(true))},
-			{STAT_HEAL_AMOUNT,         static_cast<uint32>(inst->GetItemHealAmt(true))},
-			{STAT_SPELL_DAMAGE,        static_cast<uint32>(inst->GetItemSpellDamage(true))},
-			{STAT_CLAIRVOYANCE,        static_cast<uint32>(inst->GetItemClairvoyance(true))},
-			{STAT_HEROIC_AGILITY,      static_cast<uint32>(inst->GetItemHeroicAgi(true))},
-			{STAT_HEROIC_CHARISMA,     static_cast<uint32>(inst->GetItemHeroicCha(true))},
-			{STAT_HEROIC_DEXTERITY,    static_cast<uint32>(inst->GetItemHeroicDex(true))},
-			{STAT_HEROIC_INTELLIGENCE, static_cast<uint32>(inst->GetItemHeroicInt(true))},
-			{STAT_HEROIC_STAMINA,      static_cast<uint32>(inst->GetItemHeroicSta(true))},
-			{STAT_HEROIC_STRENGTH,     static_cast<uint32>(inst->GetItemHeroicStr(true))},
-			{STAT_HEROIC_WISDOM,       static_cast<uint32>(inst->GetItemHeroicWis(true))},
-			{STAT_BASH,                static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillBash, true))},
-			{STAT_BACKSTAB,            static_cast<uint32>(inst->GetItemBackstabDamage(true))},
-			{STAT_DRAGON_PUNCH,        static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillDragonPunch, true))},
-			{STAT_EAGLE_STRIKE,        static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillEagleStrike, true))},
-			{STAT_FLYING_KICK,         static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillFlyingKick, true))},
-			{STAT_KICK,                static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillKick, true))},
-			{STAT_ROUND_KICK,          static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillRoundKick, true))},
-			{STAT_TIGER_CLAW,          static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillTigerClaw, true))},
-			{STAT_FRENZY,              static_cast<uint32>(inst->GetItemSkillsStat(EQ::skills::SkillFrenzy, true))},
-		};
-
-		r.item_stat = item_stat_searches.contains(search.item_stat) ? item_stat_searches[search.item_stat] : 0;
-		if (item_stat_searches.contains(search.item_stat) && item_stat_searches[search.item_stat] <= 0) {
-			continue;
-		}
-
-		static std::map<uint8, uint32> item_slot_searches = {
-			{EQ::invslot::slotCharm,       1},
-			{EQ::invslot::slotEar1,        2},
-			{EQ::invslot::slotHead,        4},
-			{EQ::invslot::slotFace,        8},
-			{EQ::invslot::slotEar2,        16},
-			{EQ::invslot::slotNeck,        32},
-			{EQ::invslot::slotShoulders,   64},
-			{EQ::invslot::slotArms,        128},
-			{EQ::invslot::slotBack,        256},
-			{EQ::invslot::slotWrist1,      512},
-			{EQ::invslot::slotWrist2,      1024},
-			{EQ::invslot::slotRange,       2048},
-			{EQ::invslot::slotHands,       4096},
-			{EQ::invslot::slotPrimary,     8192},
-			{EQ::invslot::slotSecondary,   16384},
-			{EQ::invslot::slotFinger1,     32768},
-			{EQ::invslot::slotFinger2,     65536},
-			{EQ::invslot::slotChest,       131072},
-			{EQ::invslot::slotLegs,        262144},
-			{EQ::invslot::slotFeet,        524288},
-			{EQ::invslot::slotWaist,       1048576},
-			{EQ::invslot::slotPowerSource, 2097152},
-			{EQ::invslot::slotAmmo,        4194304},
-		};
-
-		auto GetEquipmentSlotBit = [&](uint32 slot) -> uint32 {
-			return item_slot_searches.contains(slot) ? item_slot_searches[slot] : 0;
-		};
-
-		auto FindItemAugSlot = [&]() -> bool {
-			for (auto const &s: inst->GetItem()->AugSlotType) {
-				return s == search.augment;
-			}
-			return false;
-		};
-
-		// item type searches
-		std::vector<ItemSearchType> item_search_types = {
-			{EQ::item::ItemType::ItemTypeAll,                  true},
-			{EQ::item::ItemType::ItemTypeBook,                 item->ItemClass == EQ::item::ItemType::ItemTypeBook},
-			{EQ::item::ItemType::ItemTypeContainer,            item->ItemClass == EQ::item::ItemType::ItemTypeContainer},
-			{EQ::item::ItemType::ItemTypeAllEffects,           item->Scroll.Effect > 0 && item->Scroll.Effect < 65000},
-			{EQ::item::ItemType::ItemTypeUnknown9,             item->Worn.Effect == 998},
-			{EQ::item::ItemType::ItemTypeUnknown10,            item->Worn.Effect >= 1298 && item->Worn.Effect <= 1307},
-			{EQ::item::ItemType::ItemTypeFocusEffect,          item->Focus.Effect > 0},
-			{EQ::item::ItemType::ItemTypeArmor,                item->ItemType == EQ::item::ItemType::ItemTypeArmor},
-			{EQ::item::ItemType::ItemType1HBlunt,              item->ItemType == EQ::item::ItemType::ItemType1HBlunt},
-			{EQ::item::ItemType::ItemType1HPiercing,           item->ItemType == EQ::item::ItemType::ItemType1HPiercing},
-			{EQ::item::ItemType::ItemType1HSlash,              item->ItemType == EQ::item::ItemType::ItemType1HSlash},
-			{EQ::item::ItemType::ItemType2HBlunt,              item->ItemType == EQ::item::ItemType::ItemType2HBlunt},
-			{EQ::item::ItemType::ItemType2HSlash,              item->ItemType == EQ::item::ItemType::ItemType2HSlash},
-			{EQ::item::ItemType::ItemTypeBow,                  item->ItemType == EQ::item::ItemType::ItemTypeBow},
-			{EQ::item::ItemType::ItemTypeShield,               item->ItemType == EQ::item::ItemType::ItemTypeShield},
-			{EQ::item::ItemType::ItemTypeMisc,                 item->ItemType == EQ::item::ItemType::ItemTypeMisc},
-			{EQ::item::ItemType::ItemTypeFood,                 item->ItemType == EQ::item::ItemType::ItemTypeFood},
-			{EQ::item::ItemType::ItemTypeDrink,                item->ItemType == EQ::item::ItemType::ItemTypeDrink},
-			{EQ::item::ItemType::ItemTypeLight,                item->ItemType == EQ::item::ItemType::ItemTypeLight},
-			{EQ::item::ItemType::ItemTypeCombinable,           item->ItemType == EQ::item::ItemType::ItemTypeCombinable},
-			{EQ::item::ItemType::ItemTypeBandage,              item->ItemType == EQ::item::ItemType::ItemTypeBandage},
-			{EQ::item::ItemType::ItemTypeSmallThrowing,        item->ItemType == EQ::item::ItemType::ItemTypeSmallThrowing ||
-			                                                   item->ItemType == EQ::item::ItemType::ItemTypeLargeThrowing},
-			{EQ::item::ItemType::ItemTypeSpell,                item->ItemType == EQ::item::ItemType::ItemTypeSpell},
-			{EQ::item::ItemType::ItemTypePotion,               item->ItemType == EQ::item::ItemType::ItemTypePotion},
-			{EQ::item::ItemType::ItemTypeBrassInstrument,      item->ItemType == EQ::item::ItemType::ItemTypeBrassInstrument},
-			{EQ::item::ItemType::ItemTypeWindInstrument,       item->ItemType == EQ::item::ItemType::ItemTypeWindInstrument},
-			{EQ::item::ItemType::ItemTypeStringedInstrument,   item->ItemType == EQ::item::ItemType::ItemTypeStringedInstrument},
-			{EQ::item::ItemType::ItemTypePercussionInstrument, item->ItemType == EQ::item::ItemType::ItemTypePercussionInstrument},
-			{EQ::item::ItemType::ItemTypeArrow,                item->ItemType == EQ::item::ItemType::ItemTypeArrow},
-			{EQ::item::ItemType::ItemTypeJewelry,              item->ItemType == EQ::item::ItemType::ItemTypeJewelry},
-			{EQ::item::ItemType::ItemTypeNote,                 item->ItemType == EQ::item::ItemType::ItemTypeNote},
-			{EQ::item::ItemType::ItemTypeKey,                  item->ItemType == EQ::item::ItemType::ItemTypeKey},
-			{EQ::item::ItemType::ItemType2HPiercing,           item->ItemType == EQ::item::ItemType::ItemType2HPiercing},
-			{EQ::item::ItemType::ItemTypeAlcohol,              item->ItemType == EQ::item::ItemType::ItemTypeAlcohol},
-			{EQ::item::ItemType::ItemTypeMartial,              item->ItemType == EQ::item::ItemType::ItemTypeMartial},
-			{EQ::item::ItemType::ItemTypeAugmentation,         item->ItemType == EQ::item::ItemType::ItemTypeAugmentation},
-			{EQ::item::ItemType::ItemTypeAlternateAbility,     item->ItemType == EQ::item::ItemType::ItemTypeAlternateAbility},
-			{EQ::item::ItemType::ItemTypeCount,                item->ItemType == EQ::item::ItemType::ItemTypeCount},
-			{EQ::item::ItemType::ItemTypeCollectible,          item->ItemType == EQ::item::ItemType::ItemTypeCollectible}
-			};
-
-		bool met_filter = false;
-		bool has_filter = false;
-
-		for (auto &i: item_search_types) {
-			if (i.type == search.type) {
-				has_filter = true;
-				if (i.condition) {
-					LogTradingDetail("Item [{}] met search criteria for type [{}]", item->Name, uint8(i.type));
-					met_filter = true;
-					break;
-				}
-			}
-		}
-		if (has_filter && !met_filter) {
-			continue;
-		}
-
-		// TODO: Add catch-all item type filter for specific item types
-
-		// item additive searches
-		std::vector<AddititiveSearchCriteria> item_additive_searches = {
-			{
-				.should_check = search.min_level != 1 && inst->GetItemRequiredLevel(true) > 0,
-				.condition = inst->GetItemRequiredLevel(true) >= search.min_level
-			},
-			{
-				.should_check = search.max_level != 1 && inst->GetItemRequiredLevel(true) > 0,
-				.condition = inst->GetItemRequiredLevel(true) <= search.max_level
-			},
-			{
-				.should_check = !std::string(search.item_name).empty(),
-				.condition = Strings::ContainsLower(item->Name, search.item_name)
-			},
-			{
-				.should_check = search._class != 0xFFFFFFFF,
-				.condition = static_cast<bool>(item->Classes & GetPlayerClassBit(search._class))
-			},
-			{
-				.should_check = search.race != 0xFFFFFFFF,
-				.condition = static_cast<bool>(item->Races & GetPlayerRaceBit(GetRaceIDFromPlayerRaceValue(search.race)))
-			},
-			{
-				.should_check = search.augment != 0,
-				.condition = FindItemAugSlot()
-			},
-			{
-				.should_check = search.slot != 0xFFFFFFFF,
-				.condition = static_cast<bool>(item->Slots & GetEquipmentSlotBit(search.slot))
-			},
-		};
-
-		bool should_add = true;
-
-		for (auto &i: item_additive_searches) {
-			LogTradingDetail(
-				"Checking item [{}] for search criteria - should_check [{}] condition [{}]",
-				item->Name,
-				i.should_check,
-				i.condition
-			);
-			if (i.should_check && !i.condition) {
-				should_add = false;
-				continue;
-			}
-		}
-
-		if (!should_add) {
-			continue;
-		}
-
-		LogTradingDetail("Found item [{}] meeting search criteria.", r.item_name);
-		all_entries.push_back(r);
-	}
-
-	if (all_entries.size() > search.max_results) {
-		all_entries.resize(search.max_results);
-	}
-
-	LogTrading("Returning [{}] items from search results", all_entries.size());
-
-	return all_entries;
-}

common/bazaar.h

@@ -1,14 +0,0 @@
-#ifndef EQEMU_BAZAAR_H
-#define EQEMU_BAZAAR_H
-
-#include <vector>
-#include "shareddb.h"
-
-class Bazaar {
-public:
-	static std::vector<BazaarSearchResultsFromDB_Struct>
-	GetSearchResults(SharedDatabase &db, BazaarSearchCriteria_Struct search, unsigned int char_zone_id);
-};
-
-
-#endif //EQEMU_BAZAAR_H

common/bodytypes.cpp

@@ -1,12 +0,0 @@
-#include "../common/global_define.h"
-#include "../common/bodytypes.h"
-
-std::string BodyType::GetName(uint8 body_type_id)
-{
-	return IsValid(body_type_id) ? body_type_names[body_type_id] : "UNKNOWN BODY TYPE";
-}
-
-bool BodyType::IsValid(uint8 body_type_id)
-{
-	return body_type_names.find(body_type_id) != body_type_names.end();
-}

common/bodytypes.h

@@ -18,96 +18,52 @@
 #ifndef BODYTYPES_H
 #define BODYTYPES_H
 
-#include "types.h"
+typedef enum {
-#include <map>
+	BT_Humanoid			= 1,
-#include <string>
+	BT_Lycanthrope		= 2,
+	BT_Undead			= 3,
+	BT_Giant			= 4,
+	BT_Construct		= 5,
+	BT_Extraplanar		= 6,
+	BT_Magical			= 7,	//this name might be a bit off,
+	BT_SummonedUndead	= 8,
+	BT_RaidGiant		= 9,    //Velious era Raid Giant
+	BT_RaidColdain      = 10,   //Velious era Raid Coldain
+	BT_NoTarget			= 11,	//no name, can't target this bodytype
+	BT_Vampire			= 12,
+	BT_Atenha_Ra		= 13,
+	BT_Greater_Akheva	= 14,
+	BT_Khati_Sha		= 15,
+	BT_Seru				= 16,	
+	BT_Grieg_Veneficus  = 17,
+	BT_Draz_Nurakk      = 18,
+	BT_Zek				= 19,	//"creatures from the Plane of War."
+	BT_Luggald			= 20,
+	BT_Animal			= 21,
+	BT_Insect			= 22,
+	BT_Monster			= 23,
+	BT_Summoned			= 24,	//Elemental?
+	BT_Plant			= 25,
+	BT_Dragon			= 26,
+	BT_Summoned2		= 27,
+	BT_Summoned3		= 28,
+	BT_Dragon2          = 29,   //database data indicates this is a dragon type (kunark and DoN?)
+	BT_VeliousDragon	= 30,	//might not be a tight set
+	BT_Familiar			= 31,
+	BT_Dragon3			= 32,
+	BT_Boxes			= 33,
+	BT_Muramite			= 34,	//tribal dudes
+	//					...
+	BT_NoTarget2		= 60,
+	//					...
+	BT_SwarmPet			= 63,	//Looks like weapon proc related temp pets and few misc pets, should not be used for checking swarm pets in general.
+	BT_MonsterSummon	= 64,
+	                   // 65,   trap or effect related?
+	BT_InvisMan			= 66,	//no name, seen on 'InvisMan', can be /targeted
+	BT_Special			= 67
+} bodyType;
+/* bodytypes above 64 make the mob not show up */
 
-// body types above 64 make the mob invisible
+constexpr int format_as(bodyType type) { return static_cast<int>(type); }
-namespace BodyType {
-	constexpr uint8 Humanoid       = 1;
-	constexpr uint8 Lycanthrope    = 2;
-	constexpr uint8 Undead         = 3;
-	constexpr uint8 Giant          = 4;
-	constexpr uint8 Construct      = 5;
-	constexpr uint8 Extraplanar    = 6;
-	constexpr uint8 Magical        = 7;     // this name might be a bit off,
-	constexpr uint8 SummonedUndead = 8;
-	constexpr uint8 RaidGiant      = 9;     // Velious era Raid Giant
-	constexpr uint8 RaidColdain    = 10;    // Velious era Raid Coldain
-	constexpr uint8 NoTarget       = 11;    // no name, can't target this bodytype
-	constexpr uint8 Vampire        = 12;
-	constexpr uint8 AtenHaRa       = 13;
-	constexpr uint8 GreaterAkheva  = 14;
-	constexpr uint8 KhatiSha       = 15;
-	constexpr uint8 Seru           = 16;
-	constexpr uint8 GriegVeneficus = 17;
-	constexpr uint8 DrazNurakk     = 18;
-	constexpr uint8 Zek            = 19;    //"creatures from the Plane of War."
-	constexpr uint8 Luggald        = 20;
-	constexpr uint8 Animal         = 21;
-	constexpr uint8 Insect         = 22;
-	constexpr uint8 Monster        = 23;
-	constexpr uint8 Summoned       = 24;    // Elemental?
-	constexpr uint8 Plant          = 25;
-	constexpr uint8 Dragon         = 26;
-	constexpr uint8 Summoned2      = 27;
-	constexpr uint8 Summoned3      = 28;
-	constexpr uint8 Dragon2        = 29;    // database data indicates this is a dragon type (Kunark and DoN?)
-	constexpr uint8 VeliousDragon  = 30;    // might not be a tight set
-	constexpr uint8 Familiar       = 31;
-	constexpr uint8 Dragon3        = 32;
-	constexpr uint8 Boxes          = 33;
-	constexpr uint8 Muramite       = 34;    // tribal dudes
-	constexpr uint8 NoTarget2      = 60;
-	constexpr uint8 SwarmPet       = 63;    // Looks like weapon proc related temp pets and few misc pets, should not be used for checking swarm pets in general.
-	constexpr uint8 MonsterSummon  = 64;
-	constexpr uint8 InvisibleMan   = 66;    // no name, seen on 'InvisMan', can be /targeted
-	constexpr uint8 Special        = 67;
-
-	std::string GetName(uint8 body_type_id);
-	bool IsValid(uint8 body_type_id);
-}
-
-static std::map<uint8, std::string> body_type_names = {
-	{ BodyType::Humanoid,       "Humanoid" },
-	{ BodyType::Lycanthrope,    "Lycanthrope" },
-	{ BodyType::Undead,         "Undead" },
-	{ BodyType::Giant,          "Giant" },
-	{ BodyType::Construct,      "Construct" },
-	{ BodyType::Extraplanar,    "Extraplanar" },
-	{ BodyType::Magical,        "Magical" },
-	{ BodyType::SummonedUndead, "Summoned Undead" },
-	{ BodyType::RaidGiant,      "Raid Giant" },
-	{ BodyType::RaidColdain,    "Raid Coldain" },
-	{ BodyType::NoTarget,       "Untargetable" },
-	{ BodyType::Vampire,        "Vampire" },
-	{ BodyType::AtenHaRa,       "Aten Ha Ra" },
-	{ BodyType::GreaterAkheva,  "Greater Akheva" },
-	{ BodyType::KhatiSha,       "Khati Sha" },
-	{ BodyType::Seru,           "Seru" },
-	{ BodyType::GriegVeneficus, "Grieg Veneficus" },
-	{ BodyType::DrazNurakk,     "Draz Nurakk" },
-	{ BodyType::Zek,            "Zek" },
-	{ BodyType::Luggald,        "Luggald" },
-	{ BodyType::Animal,         "Animal" },
-	{ BodyType::Insect,         "Insect" },
-	{ BodyType::Monster,        "Monster" },
-	{ BodyType::Summoned,       "Summoned" },
-	{ BodyType::Plant,          "Plant" },
-	{ BodyType::Dragon,         "Dragon" },
-	{ BodyType::Summoned2,      "Summoned 2" },
-	{ BodyType::Summoned3,      "Summoned 3" },
-	{ BodyType::Dragon2,        "Dragon 2" },
-	{ BodyType::VeliousDragon,  "Velious Dragon" },
-	{ BodyType::Familiar,       "Familiar" },
-	{ BodyType::Dragon3,        "Dragon 3" },
-	{ BodyType::Boxes,          "Boxes" },
-	{ BodyType::Muramite,       "Muramite" },
-	{ BodyType::NoTarget2,      "Untargetable 2" },
-	{ BodyType::SwarmPet,       "Swarm Pet" },
-	{ BodyType::MonsterSummon,  "Monster Summon" },
-	{ BodyType::InvisibleMan,   "Invisible Man" },
-	{ BodyType::Special,        "Special" },
-};
 
 #endif

common/content/world_content_service.cpp

@@ -357,13 +357,3 @@ WorldContentService::FindZoneResult WorldContentService::FindZone(uint32 zone_id
 	return WorldContentService::FindZoneResult{.zone_id = 0};
 }
 
-bool WorldContentService::IsInPublicStaticInstance(uint32 instance_id)
-{
-	for (auto &i: m_zone_instances) {
-		if (i.id == instance_id) {
-			return true;
-		}
-	}
-
-	return false;
-}

common/content/world_content_service.h

@@ -178,8 +178,6 @@ public:
 	};
 
 	FindZoneResult FindZone(uint32 zone_id, uint32 instance_id);
-	bool IsInPublicStaticInstance(uint32 instance_id);
-
 private:
 	int current_expansion{};
 	std::vector<ContentFlagsRepository::ContentFlags> content_flags;

common/database.cpp

@@ -35,7 +35,6 @@
 #include "../common/repositories/character_data_repository.h"
 #include "../common/repositories/character_languages_repository.h"
 #include "../common/repositories/character_leadership_abilities_repository.h"
-#include "../common/repositories/character_parcels_repository.h"
 #include "../common/repositories/character_skills_repository.h"
 #include "../common/repositories/data_buckets_repository.h"
 #include "../common/repositories/group_id_repository.h"
@@ -50,7 +49,6 @@
 #include "../common/repositories/raid_members_repository.h"
 #include "../common/repositories/reports_repository.h"
 #include "../common/repositories/variables_repository.h"
-#include "../common/events/player_event_logs.h"
 
 // Disgrace: for windows compile
 #ifdef _WINDOWS
@@ -77,7 +75,6 @@
 #include "zone_store.h"
 #include "repositories/merchantlist_temp_repository.h"
 #include "repositories/bot_data_repository.h"
-#include "repositories/trader_repository.h"
 
 extern Client client;
 
@@ -207,19 +204,9 @@ void Database::LoginIP(uint32 account_id, const std::string& login_ip)
 	QueryDatabase(query);
 }
 
-int16 Database::GetAccountStatus(uint32 account_id)
+int16 Database::CheckStatus(uint32 account_id)
 {
-	auto e = AccountRepository::FindOne(*this, account_id);
+	return AccountRepository::GetAccountStatus(*this, account_id);
-
-	if (e.suspendeduntil > 0 && e.suspendeduntil < std::time(nullptr)) {
-		e.status         = 0;
-		e.suspendeduntil = 0;
-		e.suspend_reason = "";
-
-		AccountRepository::UpdateOne(*this, e);
-	}
-
-	return e.status;
 }
 
 uint32 Database::CreateAccount(
@@ -752,7 +739,7 @@ bool Database::SetVariable(const std::string& name, const std::string& value)
 	auto l = VariablesRepository::GetWhere(
 		*this,
 		fmt::format(
-			"`varname` = '{}'",
+			"`name` = '{}'",
 			Strings::Escape(name)
 		)
 	);
@@ -1138,7 +1125,7 @@ std::string Database::GetGroupLeaderForLogin(const std::string& character_name)
 	return e.gid ? e.leadername : std::string();
 }
 
-void Database::SetGroupLeaderName(uint32 group_id, const std::string &name)
+void Database::SetGroupLeaderName(uint32 group_id, const std::string& name)
 {
 	auto e = GroupLeadersRepository::FindOne(*this, group_id);
 
@@ -1158,7 +1145,7 @@ void Database::SetGroupLeaderName(uint32 group_id, const std::string &name)
 	e.mentoree       = std::string();
 	e.mentor_percent = 0;
 
-    GroupLeadersRepository::ReplaceOne(*this, e);
+	GroupLeadersRepository::InsertOne(*this, e);
 }
 
 std::string Database::GetGroupLeaderName(uint32 group_id)
@@ -1191,7 +1178,7 @@ char* Database::GetGroupLeadershipInfo(
 	GroupLeadershipAA_Struct* GLAA
 )
 {
-	auto e = GroupLeadersRepository::FindOne(*this, group_id);
+	const auto& e = GroupLeadersRepository::FindOne(*this, group_id);
 
 	if (!e.gid) {
 		if (leaderbuf) {
@@ -1252,9 +1239,9 @@ char* Database::GetGroupLeadershipInfo(
 	if (mentor_percent) {
 		*mentor_percent = e.mentor_percent;
 	}
-	if(GLAA && e.leadershipaa.length() == sizeof(GroupLeadershipAA_Struct)) {
+
-		Decode(e.leadershipaa);
+	if (GLAA && e.leadershipaa.length() == sizeof(GroupLeadershipAA_Struct)) {
-		memcpy(GLAA, e.leadershipaa.data(), sizeof(GroupLeadershipAA_Struct));
+		memcpy(GLAA, e.leadershipaa.c_str(), sizeof(GroupLeadershipAA_Struct));
 	}
 
 	return leaderbuf;
@@ -2041,72 +2028,3 @@ void Database::SourceSqlFromUrl(const std::string& url)
 		LogError("URI parser error [{}]", iae.what());
 	}
 }
-
-void Database::Encode(std::string &in)
-{
-	for(int i = 0; i < in.length(); i++) {
-		in.at(i) += char('0');
-	}
-};
-
-void Database::Decode(std::string &in)
-{
-	for(int i = 0; i < in.length(); i++) {
-		in.at(i) -= char('0');
-	}
-};
-
-void Database::PurgeCharacterParcels()
-{
-	auto filter  = fmt::format("sent_date < (NOW() - INTERVAL {} DAY)", RuleI(Parcel, ParcelPruneDelay));
-	auto results = CharacterParcelsRepository::GetWhere(*this, filter);
-	auto prune   = CharacterParcelsRepository::DeleteWhere(*this, filter);
-
-	PlayerEvent::ParcelDelete                  pd{};
-	PlayerEventLogsRepository::PlayerEventLogs pel{};
-	pel.event_type_id   = PlayerEvent::PARCEL_DELETE;
-	pel.event_type_name = PlayerEvent::EventName[pel.event_type_id];
-	std::stringstream ss;
-	for (auto const   &r: results) {
-		pd.from_name  = r.from_name;
-		pd.item_id    = r.item_id;
-		pd.aug_slot_1 = r.aug_slot_1;
-		pd.aug_slot_2 = r.aug_slot_2;
-		pd.aug_slot_3 = r.aug_slot_3;
-		pd.aug_slot_4 = r.aug_slot_4;
-		pd.aug_slot_5 = r.aug_slot_5;
-		pd.aug_slot_6 = r.aug_slot_6;
-		pd.note       = r.note;
-		pd.quantity   = r.quantity;
-		pd.sent_date  = r.sent_date;
-		pd.char_id    = r.char_id;
-		{
-			cereal::JSONOutputArchiveSingleLine ar(ss);
-			pd.serialize(ar);
-		}
-
-		pel.event_data = ss.str();
-		pel.created_at = std::time(nullptr);
-
-		player_event_logs.AddToQueue(pel);
-
-		ss.str("");
-		ss.clear();
-	}
-
-	LogInfo(
-		"Purged <yellow>[{}] parcels that were over <yellow>[{}] days old.",
-		results.size(),
-		RuleI(Parcel, ParcelPruneDelay)
-	);
-}
-
-void Database::ClearGuildOnlineStatus()
-{
-	GuildMembersRepository::ClearOnlineStatus(*this);
-}
-
-void Database::ClearTraderDetails()
-{
-	TraderRepository::Truncate(*this);
-}

common/database.h

@@ -170,7 +170,7 @@ public:
 	bool SetAccountStatus(const std::string& account_name, int16 status);
 	bool SetLocalPassword(uint32 account_id, const std::string& password);
 	bool UpdateLiveChar(const std::string& name, uint32 account_id);
-	int16 GetAccountStatus(uint32 account_id);
+	int16 CheckStatus(uint32 account_id);
 	void SetAccountCRCField(uint32 account_id, const std::string& field_name, uint64 checksum);
 	uint32 CheckLogin(const std::string& name, const std::string& password, const std::string& loginserver, int16* status = 0);
 	uint32 CreateAccount(
@@ -243,8 +243,6 @@ public:
 	void SetRaidGroupLeaderInfo(uint32 group_id, uint32 raid_id);
 
 	void PurgeAllDeletedDataBuckets();
-	void ClearGuildOnlineStatus();
-	void ClearTraderDetails();
 
 
 	/* Database Variables */
@@ -269,9 +267,6 @@ public:
 
 	void SourceDatabaseTableFromUrl(const std::string& table_name, const std::string& url);
 	void SourceSqlFromUrl(const std::string& url);
-	void PurgeCharacterParcels();
-	void Encode(std::string &in);
-	void Decode(std::string &in);
 
 private:
 	Mutex           Mvarcache;

common/database/database_update_manifest.cpp

@@ -5469,198 +5469,6 @@ ADD PRIMARY KEY (`id`) USING BTREE,
 ADD INDEX `level_skill_cap`(`skill_id`, `class_id`, `level`, `cap`);
 )",
 		.content_schema_update = true,
-	},
-	ManifestEntry{
-		.version = 9269,
-		.description = "2024_03_27_account_auto_login_charname.sql",
-		.check = "SHOW COLUMNS FROM `account` LIKE 'auto_login_charname'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `account`
-ADD COLUMN `auto_login_charname` varchar(64) CHARACTER SET latin1 COLLATE latin1_swedish_ci NOT NULL DEFAULT '' AFTER `charname`;
-)"
-	},
-	ManifestEntry{
-		.version = 9270,
-		.description = "2024_04_31_content_flagging_lootdrop_entries.sql",
-		.check = "SHOW COLUMNS FROM `lootdrop_entries` LIKE 'content_flags'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `lootdrop_entries` ADD `min_expansion` tinyint(4) NOT NULL DEFAULT -1;
-ALTER TABLE `lootdrop_entries` ADD `max_expansion` tinyint(4) NOT NULL DEFAULT -1;
-ALTER TABLE `lootdrop_entries` ADD `content_flags` varchar(100) NULL;
-ALTER TABLE `lootdrop_entries` ADD `content_flags_disabled` varchar(100) NULL;
-)",
-		.content_schema_update = true
-	},
-	ManifestEntry{
-		.version = 9271,
-		.description = "2024_03_10_parcel_implementation.sql",
-		.check = "SHOW TABLES LIKE 'character_parcels'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(CREATE TABLE `character_parcels` (
-				`id` INT(10) UNSIGNED NOT NULL AUTO_INCREMENT,
-				`char_id` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-				`item_id` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-				`slot_id` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-				`quantity` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-				`from_name` VARCHAR(64) NULL DEFAULT NULL COLLATE 'latin1_swedish_ci',
-				`note` VARCHAR(1024) NULL DEFAULT NULL COLLATE 'latin1_swedish_ci',
-				`sent_date` DATETIME NULL DEFAULT NULL,
-				PRIMARY KEY (`id`) USING BTREE,
-				UNIQUE INDEX `data_constraint` (`slot_id`, `char_id`) USING BTREE
-				)
-				COLLATE='latin1_swedish_ci'
-				ENGINE=InnoDB
-				AUTO_INCREMENT=1;
-		)"
-	},
-	ManifestEntry{
-		.version     = 9272,
-		.description = "2024_04_23_add_parcel_support_for_augmented_items.sql",
-		.check       = "SHOW COLUMNS FROM `character_parcels` LIKE 'aug_slot_1'",
-		.condition   = "empty",
-		.match       = "",
-		.sql         = R"(
-ALTER TABLE `character_parcels`
-	ADD COLUMN `aug_slot_1` INT UNSIGNED NOT NULL DEFAULT '0' AFTER `item_id`,
-	ADD COLUMN `aug_slot_2` INT UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_1`,
-	ADD COLUMN `aug_slot_3` INT UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_2`,
-	ADD COLUMN `aug_slot_4` INT UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_3`,
-	ADD COLUMN `aug_slot_5` INT UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_4`,
-	ADD COLUMN `aug_slot_6` INT UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_5`;
-)"
-	},
-	ManifestEntry{
-		.version = 9273,
-		.description = "2024_04_24_door_close_timer.sql",
-		.check = "SHOW COLUMNS FROM `doors` LIKE 'close_timer_ms'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `doors`
-ADD COLUMN `close_timer_ms` smallint(8) UNSIGNED NOT NULL DEFAULT 5000 AFTER `is_ldon_door`;
-)",
-		.content_schema_update = true
-	},
-	ManifestEntry{
-		.version = 9274,
-		.description = "2024_05_02_parcel_npc_content.sql",
-		.check = "SHOW COLUMNS FROM `npc_types` LIKE 'is_parcel_merchant'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `npc_types`
-ADD COLUMN `is_parcel_merchant` TINYINT(1) UNSIGNED NOT NULL DEFAULT '0' AFTER `keeps_sold_items`;
-)",
-		.content_schema_update = true
-	},
-	ManifestEntry{
-		.version = 9275,
-		.description = "2024_04_28_character_extra_haste.sql",
-		.check = "SHOW COLUMNS FROM `character_data` LIKE 'extra_haste'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `character_data`
-ADD COLUMN `extra_haste` int(11) NOT NULL DEFAULT 0 AFTER `wis`;
-)"
-	},
-	ManifestEntry{
-		.version = 9276,
-		.description = "2024_05_12_fix_guild_bank_dup_issue.sql",
-		.check = "SHOW COLUMNS FROM `guild_bank` WHERE FIELD = 'qty' AND Type LIKE '%unsigned';",
-		.condition = "not_empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `guild_bank`
-	CHANGE COLUMN `qty` `qty` INT(10) NOT NULL DEFAULT '0' AFTER `itemid`;
-)"
-	},
-	ManifestEntry{
-		.version = 9277,
-		.description = "2024_05_09_parcel_enable_containers.sql",
-		.check = "SHOW TABLES LIKE 'character_parcels_containers'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-CREATE TABLE `character_parcels_containers` (
-	`id` INT(10) UNSIGNED NOT NULL AUTO_INCREMENT,
-	`parcels_id` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`slot_id` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`item_id` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`aug_slot_1` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`aug_slot_2` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`aug_slot_3` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`aug_slot_4` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`aug_slot_5` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`aug_slot_6` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	`quantity` INT(10) UNSIGNED NOT NULL DEFAULT '0',
-	PRIMARY KEY (`id`) USING BTREE,
-	INDEX `fk_character_parcels_id` (`parcels_id`) USING BTREE,
-	CONSTRAINT `fk_character_parcels_id` FOREIGN KEY (`parcels_id`) REFERENCES `character_parcels` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE
-)
-COLLATE='latin1_swedish_ci'
-ENGINE=InnoDB
-AUTO_INCREMENT=1
-;
-)"
-	},
-	ManifestEntry{
-		.version = 9278,
-		.description = "2024_05_06_npc_greed.sql",
-		.check = "SHOW COLUMNS FROM `npc_types` LIKE 'greed'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `npc_types`
-ADD COLUMN `greed` tinyint(8) UNSIGNED NOT NULL DEFAULT 0 AFTER `merchant_id`;
- )",
-		.content_schema_update = true
-	},
-	ManifestEntry{
-		.version = 9279,
-		.description = "2024_05_13_content_flagging_npc_spells_entries.sql",
-		.check = "SHOW COLUMNS FROM `npc_spells_entries` LIKE 'content_flags'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `npc_spells_entries` ADD `min_expansion` tinyint(4) NOT NULL DEFAULT -1;
-ALTER TABLE `npc_spells_entries` ADD `max_expansion` tinyint(4) NOT NULL DEFAULT -1;
-ALTER TABLE `npc_spells_entries` ADD `content_flags` varchar(100) NULL;
-ALTER TABLE `npc_spells_entries` ADD `content_flags_disabled` varchar(100) NULL;
-)",
-		.content_schema_update = true
-	},
-	ManifestEntry{
-		.version     = 9280,
-		.description = "2024_05_11_update_trader_support.sql",
-		.check       = "SHOW COLUMNS FROM `trader` LIKE 'aug_slot_1'",
-		.condition   = "empty",
-		.match       = "",
-		.sql         = R"(
-ALTER TABLE `trader`
-	ADD COLUMN `id` BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT FIRST,
-	CHANGE COLUMN `char_id` `char_id` INT(11) UNSIGNED NOT NULL DEFAULT '0' AFTER `id`,
-	CHANGE COLUMN `item_id` `item_id` INT(11) UNSIGNED NOT NULL DEFAULT '0' AFTER `char_id`,
-	ADD COLUMN `aug_slot_1` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `item_id`,
-	ADD COLUMN `aug_slot_2` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_1`,
-	ADD COLUMN `aug_slot_3` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_2`,
-	ADD COLUMN `aug_slot_4` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_3`,
-	ADD COLUMN `aug_slot_5` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_4`,
-	ADD COLUMN `aug_slot_6` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_5`,
-	CHANGE COLUMN `serialnumber` `item_sn` INT(10) UNSIGNED NOT NULL DEFAULT '0' AFTER `aug_slot_6`,
-	CHANGE COLUMN `charges` `item_charges` INT(11) NOT NULL DEFAULT '0' AFTER `item_sn`,
-	ADD COLUMN `char_entity_id` INT(11) UNSIGNED NOT NULL DEFAULT 0 AFTER `slot_id`,
-	ADD COLUMN `char_zone_id` INT(11) UNSIGNED NOT NULL DEFAULT 0 AFTER `char_entity_id`,
-	ADD COLUMN `active_transaction` TINYINT(3) UNSIGNED NOT NULL DEFAULT 0 AFTER `char_zone_id`,
-	DROP PRIMARY KEY,
-	ADD PRIMARY KEY (`id`),
-	ADD INDEX `charid_slotid` (`char_id`, `slot_id`);
-)"
 	}
 // -- template; copy/paste this when you need to create a new entry
 //	ManifestEntry{

common/database/database_update_manifest_bots.cpp

@@ -139,17 +139,6 @@ ADD COLUMN `augment_three` int(11) UNSIGNED NOT NULL DEFAULT 0 AFTER `augment_tw
 ADD COLUMN `augment_four` int(11) UNSIGNED NOT NULL DEFAULT 0 AFTER `augment_three`,
 ADD COLUMN `augment_five` int(11) UNSIGNED NOT NULL DEFAULT 0 AFTER `augment_four`,
 ADD COLUMN `augment_six` int(11) UNSIGNED NOT NULL DEFAULT 0 AFTER `augment_five`;
-)"
-	},
-	ManifestEntry{
-		.version = 9044,
-		.description = "2024_04_23_bot_extra_haste.sql",
-		.check = "SHOW COLUMNS FROM `bot_data` LIKE 'extra_haste'",
-		.condition = "empty",
-		.match = "",
-		.sql = R"(
-ALTER TABLE `bot_data`
-ADD COLUMN `extra_haste` mediumint(8) NOT NULL DEFAULT 0 AFTER `wis`;
 )"
 	}
 // -- template; copy/paste this when you need to create a new entry

common/database_schema.h

@@ -59,8 +59,6 @@ namespace DatabaseSchema {
 			{"character_leadership_abilities", "id"},
 			{"character_material",             "id"},
 			{"character_memmed_spells",        "id"},
-			{"character_parcels",              "char_id"},
-			{"character_parcels_containers",   "id"},
 			{"character_pet_buffs",            "char_id"},
 			{"character_pet_info",             "char_id"},
 			{"character_pet_inventory",        "char_id"},
@@ -130,8 +128,6 @@ namespace DatabaseSchema {
 			"character_leadership_abilities",
 			"character_material",
 			"character_memmed_spells",
-			"character_parcels",
-			"character_parcels_containers",
 			"character_pet_buffs",
 			"character_pet_info",
 			"character_pet_inventory",

common/deity.cpp

@@ -19,17 +19,81 @@
 
 #include "deity.h"
 
-uint32 Deity::GetBitmask(uint32 deity_id)
+EQ::deity::DeityTypeBit EQ::deity::GetDeityBitmask(DeityType deity_type)
 {
-	return IsValid(deity_id) ? deity_bitmasks[deity_id] : Deity::Bitmask::All;
+	switch (deity_type) {
+		case DeityBertoxxulous:
+			return bit_DeityBertoxxulous;
+		case DeityBrellSirilis:
+			return bit_DeityBrellSirilis;
+		case DeityCazicThule:
+			return bit_DeityCazicThule;
+		case DeityErollisiMarr:
+			return bit_DeityErollisiMarr;
+		case DeityBristlebane:
+			return bit_DeityBristlebane;
+		case DeityInnoruuk:
+			return bit_DeityInnoruuk;
+		case DeityKarana:
+			return bit_DeityKarana;
+		case DeityMithanielMarr:
+			return bit_DeityMithanielMarr;
+		case DeityPrexus:
+			return bit_DeityPrexus;
+		case DeityQuellious:
+			return bit_DeityQuellious;
+		case DeityRallosZek:
+			return bit_DeityRallosZek;
+		case DeityRodcetNife:
+			return bit_DeityRodcetNife;
+		case DeitySolusekRo:
+			return bit_DeitySolusekRo;
+		case DeityTheTribunal:
+			return bit_DeityTheTribunal;
+		case DeityTunare:
+			return bit_DeityTunare;
+		case DeityVeeshan:
+			return bit_DeityVeeshan;
+		case DeityAgnostic_LB:
+		case DeityAgnostic:
+			return bit_DeityAgnostic;
+		default:
+			return bit_DeityAll;
+	}
 }
 
-std::string Deity::GetName(uint32 deity_id)
+const std::map<EQ::deity::DeityType, std::string>& EQ::deity::GetDeityMap()
 {
-	return IsValid(deity_id) ? deity_names[deity_id] : "UNKNOWN DEITY";
+	static const std::map<EQ::deity::DeityType, std::string> deity_map = {
+		{ DeityAgnostic, "Agnostic" },
+		{ DeityAgnostic_LB, "Agnostic" },
+		{ DeityBertoxxulous, "Bertoxxulous" },
+		{ DeityBrellSirilis, "Brell Serilis" },
+		{ DeityBristlebane, "Bristlebane" },
+		{ DeityCazicThule, "Cazic-Thule" },
+		{ DeityErollisiMarr, "Erollisi Marr" },
+		{ DeityInnoruuk, "Innoruuk" },
+		{ DeityKarana, "Karana" },
+		{ DeityMithanielMarr, "Mithaniel Marr" },
+		{ DeityPrexus, "Prexus" },
+		{ DeityQuellious, "Quellious" },
+		{ DeityRallosZek, "Rallos Zek" },
+		{ DeityRodcetNife, "Rodcet Nife" },
+		{ DeitySolusekRo, "Solusek Ro" },
+		{ DeityTheTribunal, "The Tribunal" },
+		{ DeityTunare, "Tunare" },
+		{ DeityVeeshan, "Veeshan" }
+	};
+
+	return deity_map;
 }
 
-bool Deity::IsValid(uint32 deity_id)
+std::string EQ::deity::GetDeityName(DeityType deity_type)
 {
-	return deity_names.find(deity_id) != deity_names.end();
+
+	if (EQ::deity::GetDeityMap().find(deity_type) != EQ::deity::GetDeityMap().end()) {
+		return EQ::deity::GetDeityMap().find(deity_type)->second;
+	}
+
+	return std::string();
 }

common/deity.h

@@ -23,95 +23,62 @@
 #include "types.h"
 #include <map>
 #include <string>
-#include <limits>
 
-namespace Deity {
-	constexpr uint32 Unknown       = 0;
-	constexpr uint32 Agnostic1     = 140;
-	constexpr uint32 Bertoxxulous  = 201;
-	constexpr uint32 BrellSirilis  = 202;
-	constexpr uint32 CazicThule    = 203;
-	constexpr uint32 ErollisiMarr  = 204;
-	constexpr uint32 Bristlebane   = 205;
-	constexpr uint32 Innoruuk      = 206;
-	constexpr uint32 Karana        = 207;
-	constexpr uint32 MithanielMarr = 208;
-	constexpr uint32 Prexus        = 209;
-	constexpr uint32 Quellious     = 210;
-	constexpr uint32 RallosZek     = 211;
-	constexpr uint32 RodcetNife    = 212;
-	constexpr uint32 SolusekRo     = 213;
-	constexpr uint32 TheTribunal   = 214;
-	constexpr uint32 Tunare        = 215;
-	constexpr uint32 Veeshan       = 216;
-	constexpr uint32 Agnostic2     = 396;
 
-	namespace Bitmask {
+namespace EQ
-		constexpr uint32 Agnostic      = 1;
+{
-		constexpr uint32 Bertoxxulous  = 2;
+	namespace deity {
-		constexpr uint32 BrellSirilis  = 4;
+		enum DeityType {
-		constexpr uint32 CazicThule    = 8;
+			DeityUnknown = 0,
-		constexpr uint32 ErollisiMarr  = 16;
+			DeityAgnostic_LB = 140,
-		constexpr uint32 Bristlebane   = 32;
+			DeityBertoxxulous = 201,
-		constexpr uint32 Innoruuk      = 64;
+			DeityBrellSirilis,
-		constexpr uint32 Karana        = 128;
+			DeityCazicThule,
-		constexpr uint32 MithanielMarr = 256;
+			DeityErollisiMarr,
-		constexpr uint32 Prexus        = 512;
+			DeityBristlebane,
-		constexpr uint32 Quellious     = 1024;
+			DeityInnoruuk,
-		constexpr uint32 RallosZek     = 2048;
+			DeityKarana,
-		constexpr uint32 RodcetNife    = 4096;
+			DeityMithanielMarr,
-		constexpr uint32 SolusekRo     = 8192;
+			DeityPrexus,
-		constexpr uint32 TheTribunal   = 16384;
+			DeityQuellious,
-		constexpr uint32 Tunare        = 32768;
+			DeityRallosZek,
-		constexpr uint32 Veeshan       = 65536;
+			DeityRodcetNife,
-		constexpr uint32 All           = std::numeric_limits<uint32>::max();
+			DeitySolusekRo,
-	}
+			DeityTheTribunal,
+			DeityTunare,
+			DeityVeeshan,
+			DeityAgnostic = 396
+		};
 
-	uint32 GetBitmask(uint32 deity_id);
+		enum DeityTypeBit : uint32 {
-	std::string GetName(uint32 deity_id);
+			bit_DeityAgnostic      = 0x00000001,
-	bool IsValid(uint32 deity_id);
+			bit_DeityBertoxxulous  = 0x00000002,
-}
+			bit_DeityBrellSirilis  = 0x00000004,
+			bit_DeityCazicThule    = 0x00000008,
+			bit_DeityErollisiMarr  = 0x00000010,
+			bit_DeityBristlebane   = 0x00000020,
+			bit_DeityInnoruuk      = 0x00000040,
+			bit_DeityKarana        = 0x00000080,
+			bit_DeityMithanielMarr = 0x00000100,
+			bit_DeityPrexus        = 0x00000200,
+			bit_DeityQuellious     = 0x00000400,
+			bit_DeityRallosZek     = 0x00000800,
+			bit_DeityRodcetNife    = 0x00001000,
+			bit_DeitySolusekRo     = 0x00002000,
+			bit_DeityTheTribunal   = 0x00004000,
+			bit_DeityTunare        = 0x00008000,
+			bit_DeityVeeshan       = 0x00010000,
+			bit_DeityAll           = UINT32_MAX
+		};
 
-static std::map<uint32, std::string> deity_names = {
+		constexpr int format_as(DeityType type) { return static_cast<int>(type); }
-	{ Deity::Agnostic1,     "Agnostic" },
-	{ Deity::Agnostic2,     "Agnostic" },
-	{ Deity::Bertoxxulous,  "Bertoxxulous" },
-	{ Deity::BrellSirilis,  "Brell Serilis" },
-	{ Deity::Bristlebane,   "Bristlebane" },
-	{ Deity::CazicThule,    "Cazic-Thule" },
-	{ Deity::ErollisiMarr,  "Erollisi Marr" },
-	{ Deity::Innoruuk,      "Innoruuk" },
-	{ Deity::Karana,        "Karana" },
-	{ Deity::MithanielMarr, "Mithaniel Marr" },
-	{ Deity::Prexus,        "Prexus" },
-	{ Deity::Quellious,     "Quellious" },
-	{ Deity::RallosZek,     "Rallos Zek" },
-	{ Deity::RodcetNife,    "Rodcet Nife" },
-	{ Deity::SolusekRo,     "Solusek Ro" },
-	{ Deity::TheTribunal,   "The Tribunal" },
-	{ Deity::Tunare,        "Tunare" },
-	{ Deity::Veeshan,       "Veeshan" }
-};
 
-static std::map<uint32, uint32> deity_bitmasks = {
+		extern DeityTypeBit GetDeityBitmask(DeityType deity_type);
-	{ Deity::Agnostic1,     Deity::Bitmask::Agnostic },
+		extern std::string GetDeityName(DeityType deity_type);
-	{ Deity::Agnostic2,     Deity::Bitmask::Agnostic },
+		extern const std::map<DeityType, std::string>& GetDeityMap();
-	{ Deity::Bertoxxulous,  Deity::Bitmask::Bertoxxulous },
+
-	{ Deity::BrellSirilis,  Deity::Bitmask::BrellSirilis },
+	} /*deity*/
-	{ Deity::CazicThule,    Deity::Bitmask::CazicThule },
+
-	{ Deity::ErollisiMarr,  Deity::Bitmask::ErollisiMarr },
+} /*EQEmu*/
-	{ Deity::Bristlebane,   Deity::Bitmask::Bristlebane },
-	{ Deity::Innoruuk,      Deity::Bitmask::Innoruuk },
-	{ Deity::Karana,        Deity::Bitmask::Karana },
-	{ Deity::MithanielMarr, Deity::Bitmask::MithanielMarr },
-	{ Deity::Prexus,        Deity::Bitmask::Prexus },
-	{ Deity::Quellious,     Deity::Bitmask::Quellious },
-	{ Deity::RallosZek,     Deity::Bitmask::RallosZek },
-	{ Deity::RodcetNife,    Deity::Bitmask::RodcetNife },
-	{ Deity::SolusekRo,     Deity::Bitmask::SolusekRo },
-	{ Deity::TheTribunal,   Deity::Bitmask::TheTribunal },
-	{ Deity::Tunare,        Deity::Bitmask::Tunare },
-	{ Deity::Veeshan,       Deity::Bitmask::Veeshan }
-};
 
 #endif /* COMMON_DEITY_H */

common/emu_constants.cpp

@@ -59,25 +59,68 @@ int16 EQ::invtype::GetInvTypeSize(int16 inv_type) {
 	return local_array[inv_type];
 }
 
-uint32 Bug::GetID(const std::string& category_name)
+const char* EQ::bug::CategoryIDToCategoryName(CategoryID category_id) {
-{
+	switch (category_id) {
-	for (const auto& e : bug_category_names) {
+	case catVideo:
-		if (e.second == category_name) {
+		return "Video";
-			return e.first;
+	case catAudio:
+		return "Audio";
+	case catPathing:
+		return "Pathing";
+	case catQuest:
+		return "Quest";
+	case catTradeskills:
+		return "Tradeskills";
+	case catSpellStacking:
+		return "Spell stacking";
+	case catDoorsPortals:
+		return "Doors/Portals";
+	case catItems:
+		return "Items";
+	case catNPC:
+		return "NPC";
+	case catDialogs:
+		return "Dialogs";
+	case catLoNTCG:
+		return "LoN - TCG";
+	case catMercenaries:
+		return "Mercenaries";
+	case catOther:
+	default:
+		return "Other";
 	}
-	}
-
-	return Bug::Category::Other;
 }
 
-std::string Bug::GetName(uint32 category_id)
+EQ::bug::CategoryID EQ::bug::CategoryNameToCategoryID(const char* category_name) {
-{
+	if (!category_name)
-	return IsValid(category_id) ? bug_category_names[category_id] : "UNKNOWN BUG CATEGORY";
+		return catOther;
-}
 
-bool Bug::IsValid(uint32 category_id)
+	if (!strcmp(category_name, "Video"))
-{
+		return catVideo;
-	return bug_category_names.find(category_id) != bug_category_names.end();
+	if (!strcmp(category_name, "Audio"))
+		return catAudio;
+	if (!strcmp(category_name, "Pathing"))
+		return catPathing;
+	if (!strcmp(category_name, "Quest"))
+		return catQuest;
+	if (!strcmp(category_name, "Tradeskills"))
+		return catTradeskills;
+	if (!strcmp(category_name, "Spell stacking"))
+		return catSpellStacking;
+	if (!strcmp(category_name, "Doors/Portals"))
+		return catDoorsPortals;
+	if (!strcmp(category_name, "Items"))
+		return catItems;
+	if (!strcmp(category_name, "NPC"))
+		return catNPC;
+	if (!strcmp(category_name, "Dialogs"))
+		return catDialogs;
+	if (!strcmp(category_name, "LoN - TCG"))
+		return catLoNTCG;
+	if (!strcmp(category_name, "Mercenaries"))
+		return catMercenaries;
+
+	return catOther;
 }
 
 const char *EQ::constants::GetStanceName(StanceType stance_type) {
@@ -206,6 +249,102 @@ std::string EQ::constants::GetFlyModeName(int8 flymode_id)
 	return EQ::constants::GetFlyModeMap().find(flymode_id)->second;
 }
 
+const std::map<bodyType, std::string>& EQ::constants::GetBodyTypeMap()
+{
+	static const std::map<bodyType, std::string> bodytype_map = {
+		{ BT_Humanoid, "Humanoid" },
+		{ BT_Lycanthrope, "Lycanthrope" },
+		{ BT_Undead, "Undead" },
+		{ BT_Giant, "Giant" },
+		{ BT_Construct, "Construct" },
+		{ BT_Extraplanar, "Extraplanar" },
+		{ BT_Magical, "Magical" },
+		{ BT_SummonedUndead, "Summoned Undead" },
+		{ BT_RaidGiant, "Raid Giant" },
+		{ BT_RaidColdain, "Raid Coldain" },
+		{ BT_NoTarget, "Untargetable" },
+		{ BT_Vampire, "Vampire" },
+		{ BT_Atenha_Ra, "Aten Ha Ra" },
+		{ BT_Greater_Akheva, "Greater Akheva" },
+		{ BT_Khati_Sha, "Khati Sha" },
+		{ BT_Seru, "Seru" },
+		{ BT_Grieg_Veneficus, "Grieg Veneficus" },
+		{ BT_Draz_Nurakk, "Draz Nurakk" },
+		{ BT_Zek, "Zek" },
+		{ BT_Luggald, "Luggald" },
+		{ BT_Animal, "Animal" },
+		{ BT_Insect, "Insect" },
+		{ BT_Monster, "Monster" },
+		{ BT_Summoned, "Summoned" },
+		{ BT_Plant, "Plant" },
+		{ BT_Dragon, "Dragon" },
+		{ BT_Summoned2, "Summoned 2" },
+		{ BT_Summoned3, "Summoned 3" },
+		{ BT_Dragon2, "Dragon 2" },
+		{ BT_VeliousDragon, "Velious Dragon" },
+		{ BT_Familiar, "Familiar" },
+		{ BT_Dragon3, "Dragon 3" },
+		{ BT_Boxes, "Boxes" },
+		{ BT_Muramite, "Muramite" },
+		{ BT_NoTarget2, "Untargetable 2" },
+		{ BT_SwarmPet, "Swarm Pet" },
+		{ BT_MonsterSummon, "Monster Summon" },
+		{ BT_InvisMan, "Invisible Man" },
+		{ BT_Special, "Special" },
+	};
+
+	return bodytype_map;
+}
+
+std::string EQ::constants::GetBodyTypeName(bodyType bodytype_id)
+{
+	if (EQ::constants::GetBodyTypeMap().find(bodytype_id) != EQ::constants::GetBodyTypeMap().end()) {
+		return EQ::constants::GetBodyTypeMap().find(bodytype_id)->second;
+	}
+
+	return std::string();
+}
+
+const std::map<uint8, std::string>& EQ::constants::GetAccountStatusMap()
+{
+	static const std::map<uint8, std::string> account_status_map = {
+		{ AccountStatus::Player, "Player" },
+		{ AccountStatus::Steward, "Steward" },
+		{ AccountStatus::ApprenticeGuide, "Apprentice Guide" },
+		{ AccountStatus::Guide, "Guide" },
+		{ AccountStatus::QuestTroupe, "Quest Troupe" },
+		{ AccountStatus::SeniorGuide, "Senior Guide" },
+		{ AccountStatus::GMTester, "GM Tester" },
+		{ AccountStatus::EQSupport, "EQ Support" },
+		{ AccountStatus::GMStaff, "GM Staff" },
+		{ AccountStatus::GMAdmin, "GM Admin" },
+		{ AccountStatus::GMLeadAdmin, "GM Lead Admin" },
+		{ AccountStatus::QuestMaster, "Quest Master" },
+		{ AccountStatus::GMAreas, "GM Areas" },
+		{ AccountStatus::GMCoder, "GM Coder" },
+		{ AccountStatus::GMMgmt, "GM Mgmt" },
+		{ AccountStatus::GMImpossible, "GM Impossible" },
+		{ AccountStatus::Max, "GM Max" }
+	};
+
+	return account_status_map;
+}
+
+std::string EQ::constants::GetAccountStatusName(uint8 account_status)
+{
+	for (
+		auto status_level = EQ::constants::GetAccountStatusMap().rbegin();
+		status_level != EQ::constants::GetAccountStatusMap().rend();
+		++status_level
+	) {
+		if (account_status >= status_level->first) {
+			return status_level->second;
+		}
+	}
+
+	return std::string();
+}
+
 const std::map<uint8, std::string>& EQ::constants::GetConsiderLevelMap()
 {
 	static const std::map<uint8, std::string> consider_level_map = {
@@ -296,6 +435,84 @@ std::string EQ::constants::GetSpawnAnimationName(uint8 animation_id)
 	return EQ::constants::GetSpawnAnimationMap().find(animation_id)->second;
 }
 
+const std::map<int, std::string>& EQ::constants::GetObjectTypeMap()
+{
+	static const std::map<int, std::string> object_type_map = {
+		{ ObjectTypes::SmallBag, "Small Bag" },
+		{ ObjectTypes::LargeBag, "Large Bag" },
+		{ ObjectTypes::Quiver, "Quiver" },
+		{ ObjectTypes::BeltPouch, "Belt Pouch" },
+		{ ObjectTypes::WristPouch, "Wrist Pouch" },
+		{ ObjectTypes::Backpack, "Backpack" },
+		{ ObjectTypes::SmallChest, "Small Chest" },
+		{ ObjectTypes::LargeChest, "Large Chest" },
+		{ ObjectTypes::Bandolier, "Bandolier" },
+		{ ObjectTypes::Medicine, "Medicine" },
+		{ ObjectTypes::Tinkering, "Tinkering" },
+		{ ObjectTypes::Lexicon, "Lexicon" },
+		{ ObjectTypes::PoisonMaking, "Mortar and Pestle" },
+		{ ObjectTypes::Quest, "Quest" },
+		{ ObjectTypes::MixingBowl, "Mixing Bowl" },
+		{ ObjectTypes::Baking, "Baking" },
+		{ ObjectTypes::Tailoring, "Tailoring" },
+		{ ObjectTypes::Blacksmithing, "Blacksmithing" },
+		{ ObjectTypes::Fletching, "Fletching" },
+		{ ObjectTypes::Brewing, "Brewing" },
+		{ ObjectTypes::JewelryMaking, "Jewelry Making" },
+		{ ObjectTypes::Pottery, "Pottery" },
+		{ ObjectTypes::Kiln, "Kiln" },
+		{ ObjectTypes::KeyMaker, "Key Maker" },
+		{ ObjectTypes::ResearchWIZ, "Lexicon" },
+		{ ObjectTypes::ResearchMAG, "Lexicon" },
+		{ ObjectTypes::ResearchNEC, "Lexicon" },
+		{ ObjectTypes::ResearchENC, "Lexicon" },
+		{ ObjectTypes::Unknown, "Unknown" },
+		{ ObjectTypes::ResearchPractice, "Lexicon" },
+		{ ObjectTypes::Alchemy, "Alchemy" },
+		{ ObjectTypes::HighElfForge, "High Elf Forge" },
+		{ ObjectTypes::DarkElfForge, "Dark Elf Forge" },
+		{ ObjectTypes::OgreForge, "Ogre Forge" },
+		{ ObjectTypes::DwarfForge, "Dwarf Forge" },
+		{ ObjectTypes::GnomeForge, "Gnome Forge" },
+		{ ObjectTypes::BarbarianForge, "Barbarian Forge" },
+		{ ObjectTypes::IksarForge, "Iksar Forge" },
+		{ ObjectTypes::HumanForgeOne, "Human Forge" },
+		{ ObjectTypes::HumanForgeTwo, "Human Forge" },
+		{ ObjectTypes::HalflingTailoringOne, "Halfling Tailoring" },
+		{ ObjectTypes::HalflingTailoringTwo, "Halfling Tailoring" },
+		{ ObjectTypes::EruditeTailoring, "Erudite Tailoring" },
+		{ ObjectTypes::WoodElfTailoring, "Wood Elf Tailoring" },
+		{ ObjectTypes::WoodElfFletching, "Wood Elf Fletching" },
+		{ ObjectTypes::IksarPottery, "Iksar Pottery" },
+		{ ObjectTypes::Fishing, "Fishing" },
+		{ ObjectTypes::TrollForge, "Troll Forge" },
+		{ ObjectTypes::WoodElfForge, "Wood Elf Forge" },
+		{ ObjectTypes::HalflingForge, "Halfling Forge" },
+		{ ObjectTypes::EruditeForge, "Erudite Forge" },
+		{ ObjectTypes::Merchant, "Merchant" },
+		{ ObjectTypes::FroglokForge, "Froglok Forge" },
+		{ ObjectTypes::Augmenter, "Augmenter" },
+		{ ObjectTypes::Churn, "Churn" },
+		{ ObjectTypes::TransformationMold, "Transformation Mold" },
+		{ ObjectTypes::DetransformationMold, "Detransformation Mold" },
+		{ ObjectTypes::Unattuner, "Unattuner" },
+		{ ObjectTypes::TradeskillBag, "Tradeskill Bag" },
+		{ ObjectTypes::CollectibleBag, "Collectible Bag" },
+		{ ObjectTypes::NoDeposit, "No Deposit" }
+	};
+
+	return object_type_map;
+}
+
+std::string EQ::constants::GetObjectTypeName(int object_type)
+{
+	if (!EQ::ValueWithin(object_type, ObjectTypes::SmallBag, ObjectTypes::NoDeposit)) {
+		return std::string();
+	}
+
+	return EQ::constants::GetObjectTypeMap().find(object_type)->second;
+}
+
 const std::map<uint8, std::string> &EQ::constants::GetWeatherTypeMap()
 {
 	static const std::map<uint8, std::string> weather_type_map = {
@@ -423,59 +640,77 @@ std::string EQ::constants::GetAppearanceTypeName(uint32 appearance_type)
 	return std::string();
 }
 
-std::string SpecialAbility::GetName(int ability_id)
+const std::map<uint32, std::string>& EQ::constants::GetSpecialAbilityMap()
 {
-	return IsValid(ability_id) ? special_ability_names[ability_id] : "UNKNOWN SPECIAL ABILITY";
+	static const std::map<uint32, std::string> special_ability_map = {
-}
+		{ SPECATK_SUMMON,            "Summon" },
-
+		{ SPECATK_ENRAGE,            "Enrage" },
-bool SpecialAbility::IsValid(int ability_id)
+		{ SPECATK_RAMPAGE,           "Rampage" },
-{
+		{ SPECATK_AREA_RAMPAGE,      "Area Rampage" },
-	return special_ability_names.find(ability_id) != special_ability_names.end();
+		{ SPECATK_FLURRY,            "Flurry" },
-}
+		{ SPECATK_TRIPLE,            "Triple Attack" },
-
+		{ SPECATK_QUAD,              "Quadruple Attack" },
-const std::map<uint32, std::string>& EQ::constants::GetConsiderColorMap()
+		{ SPECATK_INNATE_DW,         "Dual Wield" },
-{
+		{ SPECATK_BANE,              "Bane Attack" },
-	static const std::map<uint32, std::string> consider_color_map = {
+		{ SPECATK_MAGICAL,           "Magical Attack" },
-		{ ConsiderColor::Green,         "Green" },
+		{ SPECATK_RANGED_ATK,        "Ranged Attack" },
-		{ ConsiderColor::DarkBlue,      "Dark Blue" },
+		{ UNSLOWABLE,                "Immune to Slow" },
-		{ ConsiderColor::Gray,          "Gray" },
+		{ UNMEZABLE,                 "Immune to Mesmerize" },
-		{ ConsiderColor::White,         "White" },
+		{ UNCHARMABLE,               "Immune to Charm" },
-		{ ConsiderColor::Red,           "Red" },
+		{ UNSTUNABLE,                "Immune to Stun" },
-		{ ConsiderColor::Yellow,        "Yellow" },
+		{ UNSNAREABLE,               "Immune to Snare" },
-		{ ConsiderColor::LightBlue,     "Light Blue" },
+		{ UNFEARABLE,                "Immune to Fear" },
-		{ ConsiderColor::WhiteTitanium, "White" },
+		{ UNDISPELLABLE,             "Immune to Dispell" },
+		{ IMMUNE_MELEE,              "Immune to Melee" },
+		{ IMMUNE_MAGIC,              "Immune to Magic" },
+		{ IMMUNE_FLEEING,            "Immune to Fleeing" },
+		{ IMMUNE_MELEE_EXCEPT_BANE,  "Immune to Melee except Bane" },
+		{ IMMUNE_MELEE_NONMAGICAL,   "Immune to Non-Magical Melee" },
+		{ IMMUNE_AGGRO,              "Immune to Aggro" },
+		{ IMMUNE_AGGRO_ON,           "Immune to Being Aggro" },
+		{ IMMUNE_CASTING_FROM_RANGE, "Immune to Ranged Spells" },
+		{ IMMUNE_FEIGN_DEATH,        "Immune to Feign Death" },
+		{ IMMUNE_TAUNT,              "Immune to Taunt" },
+		{ NPC_TUNNELVISION,          "Tunnel Vision" },
+		{ NPC_NO_BUFFHEAL_FRIENDS,   "Does Not Heal of Buff Allies" },
+		{ IMMUNE_PACIFY,             "Immune to Pacify" },
+		{ LEASH,                     "Leashed" },
+		{ TETHER,                    "Tethered" },
+		{ DESTRUCTIBLE_OBJECT,       "Destructible Object" },
+		{ NO_HARM_FROM_CLIENT,       "Immune to Harm from Client" },
+		{ ALWAYS_FLEE,               "Always Flees" },
+		{ FLEE_PERCENT,              "Flee Percentage" },
+		{ ALLOW_BENEFICIAL,          "Allows Beneficial Spells" },
+		{ DISABLE_MELEE,             "Melee is Disabled" },
+		{ NPC_CHASE_DISTANCE,        "Chase Distance" },
+		{ ALLOW_TO_TANK,             "Allowed to Tank" },
+		{ IGNORE_ROOT_AGGRO_RULES,   "Ignores Root Aggro" },
+		{ CASTING_RESIST_DIFF,       "Casting Resist Difficulty" },
+		{ COUNTER_AVOID_DAMAGE,      "Counter Damage Avoidance" },
+		{ PROX_AGGRO,                "Proximity Aggro" },
+		{ IMMUNE_RANGED_ATTACKS,     "Immune to Ranged Attacks" },
+		{ IMMUNE_DAMAGE_CLIENT,      "Immune to Client Damage" },
+		{ IMMUNE_DAMAGE_NPC,         "Immune to NPC Damage" },
+		{ IMMUNE_AGGRO_CLIENT,       "Immune to Client Aggro" },
+		{ IMMUNE_AGGRO_NPC,          "Immune to NPC Aggro" },
+		{ MODIFY_AVOID_DAMAGE,       "Modify Damage Avoidance" },
+		{ IMMUNE_FADING_MEMORIES,    "Immune to Memory Fades" },
+		{ IMMUNE_OPEN,               "Immune to Open" },
+		{ IMMUNE_ASSASSINATE,        "Immune to Assassinate" },
+		{ IMMUNE_HEADSHOT,           "Immune to Headshot" },
+		{ IMMUNE_AGGRO_BOT,          "Immune to Bot Aggro" },
+		{ IMMUNE_DAMAGE_BOT,         "Immune to Bot Damage" },
 	};
 
-	return consider_color_map;
+	return special_ability_map;
 }
 
-std::string EQ::constants::GetConsiderColorName(uint32 consider_color)
+std::string EQ::constants::GetSpecialAbilityName(uint32 ability_id)
 {
-	const auto& c = EQ::constants::GetConsiderColorMap().find(consider_color);
+	const auto& a = EQ::constants::GetSpecialAbilityMap().find(ability_id);
-	return c != EQ::constants::GetConsiderColorMap().end() ? c->second : std::string();
+	if (a != EQ::constants::GetSpecialAbilityMap().end()) {
-}
+		return a->second;
-
-std::string AccountStatus::GetName(uint8 account_status)
-{
-	for (
-		auto e = account_status_names.rbegin();
-		e != account_status_names.rend();
-		++e
-	) {
-		if (account_status >= e->first) {
-			return e->second;
-		}
 	}
 
-	return "UNKNOWN ACCOUNT STATUS";
+	return std::string();
-}
-
-std::string ComparisonType::GetName(uint8 type)
-{
-	return IsValid(type) ? comparison_types[type] : "UNKNOWN COMPARISON TYPE";
-}
-
-bool ComparisonType::IsValid(uint8 type)
-{
-	return comparison_types.find(type) != comparison_types.end();
 }

common/emu_constants.h

@@ -26,76 +26,6 @@
 
 #include <string.h>
 
-namespace AccountStatus {
-	constexpr uint8 Player          = 0;
-	constexpr uint8 Steward         = 10;
-	constexpr uint8 ApprenticeGuide = 20;
-	constexpr uint8 Guide           = 50;
-	constexpr uint8 QuestTroupe     = 80;
-	constexpr uint8 SeniorGuide     = 81;
-	constexpr uint8 GMTester        = 85;
-	constexpr uint8 EQSupport       = 90;
-	constexpr uint8 GMStaff         = 95;
-	constexpr uint8 GMAdmin         = 100;
-	constexpr uint8 GMLeadAdmin     = 150;
-	constexpr uint8 QuestMaster     = 160;
-	constexpr uint8 GMAreas         = 170;
-	constexpr uint8 GMCoder         = 180;
-	constexpr uint8 GMMgmt          = 200;
-	constexpr uint8 GMImpossible    = 250;
-	constexpr uint8 Max             = 255;
-
-	std::string GetName(uint8 account_status);
-}
-
-static std::map<uint8, std::string> account_status_names = {
-	{ AccountStatus::Player,          "Player" },
-	{ AccountStatus::Steward,         "Steward" },
-	{ AccountStatus::ApprenticeGuide, "Apprentice Guide" },
-	{ AccountStatus::Guide,           "Guide" },
-	{ AccountStatus::QuestTroupe,     "Quest Troupe" },
-	{ AccountStatus::SeniorGuide,     "Senior Guide" },
-	{ AccountStatus::GMTester,        "GM Tester" },
-	{ AccountStatus::EQSupport,       "EQ Support" },
-	{ AccountStatus::GMStaff,         "GM Staff" },
-	{ AccountStatus::GMAdmin,         "GM Admin" },
-	{ AccountStatus::GMLeadAdmin,     "GM Lead Admin" },
-	{ AccountStatus::QuestMaster,     "Quest Master" },
-	{ AccountStatus::GMAreas,         "GM Areas" },
-	{ AccountStatus::GMCoder,         "GM Coder" },
-	{ AccountStatus::GMMgmt,          "GM Mgmt" },
-	{ AccountStatus::GMImpossible,    "GM Impossible" },
-	{ AccountStatus::Max,             "GM Max" }
-};
-
-namespace ComparisonType {
-	constexpr uint8 Equal          = 0;
-	constexpr uint8 NotEqual       = 1;
-	constexpr uint8 GreaterOrEqual = 2;
-	constexpr uint8 LesserOrEqual  = 3;
-	constexpr uint8 Greater        = 4;
-	constexpr uint8 Lesser         = 5;
-	constexpr uint8 Any            = 6;
-	constexpr uint8 NotAny         = 7;
-	constexpr uint8 Between        = 8;
-	constexpr uint8 NotBetween     = 9;
-
-	std::string GetName(uint8 type);
-	bool IsValid(uint8 type);
-}
-
-static std::map<uint8, std::string> comparison_types = {
-	{ ComparisonType::Equal,          "Equal" },
-	{ ComparisonType::NotEqual,       "Not Equal" },
-	{ ComparisonType::GreaterOrEqual, "Greater or Equal" },
-	{ ComparisonType::LesserOrEqual,  "Lesser or Equal" },
-	{ ComparisonType::Greater,        "Greater" },
-	{ ComparisonType::Lesser,         "Lesser" },
-	{ ComparisonType::Any,            "Any" },
-	{ ComparisonType::NotAny,         "Not Any" },
-	{ ComparisonType::Between,        "Between" },
-	{ ComparisonType::NotBetween,     "Not Between" },
-};
 
 // local definitions are the result of using hybrid-client or server-only values and methods
 namespace EQ
@@ -337,6 +267,70 @@ namespace EQ
 			Looting
 		};
 
+		enum ObjectTypes : int {
+			SmallBag,
+			LargeBag,
+			Quiver,
+			BeltPouch,
+			WristPouch,
+			Backpack,
+			SmallChest,
+			LargeChest,
+			Bandolier,
+			Medicine,
+			Tinkering,
+			Lexicon,
+			PoisonMaking,
+			Quest,
+			MixingBowl,
+			Baking,
+			Tailoring,
+			Blacksmithing,
+			Fletching,
+			Brewing,
+			JewelryMaking,
+			Pottery,
+			Kiln,
+			KeyMaker,
+			ResearchWIZ,
+			ResearchMAG,
+			ResearchNEC,
+			ResearchENC,
+			Unknown,
+			ResearchPractice,
+			Alchemy,
+			HighElfForge,
+			DarkElfForge,
+			OgreForge,
+			DwarfForge,
+			GnomeForge,
+			BarbarianForge,
+			IksarForge,
+			HumanForgeOne,
+			HumanForgeTwo,
+			HalflingTailoringOne,
+			HalflingTailoringTwo,
+			EruditeTailoring,
+			WoodElfTailoring,
+			WoodElfFletching,
+			IksarPottery,
+			Fishing,
+			TrollForge,
+			WoodElfForge,
+			HalflingForge,
+			EruditeForge,
+			Merchant,
+			FroglokForge,
+			Augmenter,
+			Churn,
+			TransformationMold,
+			DetransformationMold,
+			Unattuner,
+			TradeskillBag,
+			CollectibleBag,
+			NoDeposit
+		};
+
 		enum WeatherTypes : uint8 {
 			None,
 			Raining,
@@ -374,6 +368,12 @@ namespace EQ
 		extern const std::map<int8, std::string>& GetFlyModeMap();
 		std::string GetFlyModeName(int8 flymode_id);
 
+		extern const std::map<bodyType, std::string>& GetBodyTypeMap();
+		std::string GetBodyTypeName(bodyType bodytype_id);
+
+		extern const std::map<uint8, std::string>& GetAccountStatusMap();
+		std::string GetAccountStatusName(uint8 account_status);
+
 		extern const std::map<uint8, std::string>& GetConsiderLevelMap();
 		std::string GetConsiderLevelName(uint8 consider_level);
 
@@ -386,6 +386,9 @@ namespace EQ
 		extern const std::map<uint8, std::string>& GetSpawnAnimationMap();
 		std::string GetSpawnAnimationName(uint8 animation_id);
 
+		extern const std::map<int, std::string>& GetObjectTypeMap();
+		std::string GetObjectTypeName(int object_type);
+
 		extern const std::map<uint8, std::string>& GetWeatherTypeMap();
 		std::string GetWeatherTypeName(uint8 weather_type);
 
@@ -398,8 +401,8 @@ namespace EQ
 		extern const std::map<uint32, std::string>& GetAppearanceTypeMap();
 		std::string GetAppearanceTypeName(uint32 animation_type);
 
-		extern const std::map<uint32, std::string>& GetConsiderColorMap();
+		extern const std::map<uint32, std::string>& GetSpecialAbilityMap();
-		std::string GetConsiderColorName(uint32 consider_color);
+		std::string GetSpecialAbilityName(uint32 ability_id);
 
 		const int STANCE_TYPE_FIRST = stancePassive;
 		const int STANCE_TYPE_LAST = stanceBurnAE;
@@ -458,6 +461,37 @@ namespace EQ
 
 	} // namespace spells
 
+	namespace bug {
+		enum CategoryID : uint32 {
+			catOther = 0,
+			catVideo,
+			catAudio,
+			catPathing,
+			catQuest,
+			catTradeskills,
+			catSpellStacking,
+			catDoorsPortals,
+			catItems,
+			catNPC,
+			catDialogs,
+			catLoNTCG,
+			catMercenaries
+		};
+
+		enum OptionalInfoFlag : uint32 {
+			infoNoOptionalInfo = 0x0,
+			infoCanDuplicate = 0x1,
+			infoCrashBug = 0x2,
+			infoTargetInfo = 0x4,
+			infoCharacterFlags = 0x8,
+			infoUnknownValue = 0xFFFFFFF0
+		};
+
+		const char* CategoryIDToCategoryName(CategoryID category_id);
+		CategoryID CategoryNameToCategoryID(const char* category_name);
+
+	} // namespace bug
+
 	enum WaypointStatus : int {
 		RoamBoxPauseInProgress = -3,
 		QuestControlNoGrid = -2,
@@ -480,6 +514,26 @@ enum ServerLockType : int {
 	Unlock
 };
 
+enum AccountStatus : uint8 {
+	Player = 0,
+	Steward = 10,
+	ApprenticeGuide = 20,
+	Guide = 50,
+	QuestTroupe = 80,
+	SeniorGuide = 81,
+	GMTester = 85,
+	EQSupport = 90,
+	GMStaff = 95,
+	GMAdmin = 100,
+	GMLeadAdmin = 150,
+	QuestMaster = 160,
+	GMAreas = 170,
+	GMCoder = 180,
+	GMMgmt = 200,
+	GMImpossible = 250,
+	Max = 255
+};
+
 enum Invisibility : uint8 {
 	Visible,
 	Invisible,
@@ -505,17 +559,6 @@ enum ConsiderLevel : uint8 {
 	Scowls
 };
 
-namespace ConsiderColor {
-	constexpr uint32 Green         = 2;
-	constexpr uint32 DarkBlue      = 4;
-	constexpr uint32 Gray          = 6;
-	constexpr uint32 White         = 10;
-	constexpr uint32 Red           = 13;
-	constexpr uint32 Yellow        = 15;
-	constexpr uint32 LightBlue     = 18;
-	constexpr uint32 WhiteTitanium = 20;
-};
-
 enum TargetDescriptionType : uint8 {
 	LCSelf,
 	UCSelf,
@@ -531,6 +574,19 @@ enum ReloadWorld : uint8 {
 	ForceRepop
 };
 
+enum BucketComparison : uint8 {
+	BucketEqualTo = 0,
+	BucketNotEqualTo,
+	BucketGreaterThanOrEqualTo,
+	BucketLesserThanOrEqualTo,
+	BucketGreaterThan,
+	BucketLesserThan,
+	BucketIsAny,
+	BucketIsNotAny,
+	BucketIsBetween,
+	BucketIsNotBetween
+};
+
 enum class EntityFilterType {
 	All,
 	Bots,
@@ -544,132 +600,68 @@ enum class ApplySpellType {
 	Raid
 };
 
-namespace SpecialAbility {
+enum {
-	constexpr int Summon                     = 1;
+	SPECATK_SUMMON            = 1,
-	constexpr int Enrage                     = 2;
+	SPECATK_ENRAGE            = 2,
-	constexpr int Rampage                    = 3;
+	SPECATK_RAMPAGE           = 3,
-	constexpr int AreaRampage                = 4;
+	SPECATK_AREA_RAMPAGE      = 4,
-	constexpr int Flurry                     = 5;
+	SPECATK_FLURRY            = 5,
-	constexpr int TripleAttack               = 6;
+	SPECATK_TRIPLE            = 6,
-	constexpr int QuadrupleAttack            = 7;
+	SPECATK_QUAD              = 7,
-	constexpr int DualWield                  = 8;
+	SPECATK_INNATE_DW         = 8,
-	constexpr int BaneAttack                 = 9;
+	SPECATK_BANE              = 9,
-	constexpr int MagicalAttack              = 10;
+	SPECATK_MAGICAL           = 10,
-	constexpr int RangedAttack               = 11;
+	SPECATK_RANGED_ATK        = 11,
-	constexpr int SlowImmunity               = 12;
+	UNSLOWABLE                = 12,
-	constexpr int MesmerizeImmunity          = 13;
+	UNMEZABLE                 = 13,
-	constexpr int CharmImmunity              = 14;
+	UNCHARMABLE               = 14,
-	constexpr int StunImmunity               = 15;
+	UNSTUNABLE                = 15,
-	constexpr int SnareImmunity              = 16;
+	UNSNAREABLE               = 16,
-	constexpr int FearImmunity               = 17;
+	UNFEARABLE                = 17,
-	constexpr int DispellImmunity            = 18;
+	UNDISPELLABLE             = 18,
-	constexpr int MeleeImmunity              = 19;
+	IMMUNE_MELEE              = 19,
-	constexpr int MagicImmunity              = 20;
+	IMMUNE_MAGIC              = 20,
-	constexpr int FleeingImmunity            = 21;
+	IMMUNE_FLEEING            = 21,
-	constexpr int MeleeImmunityExceptBane    = 22;
+	IMMUNE_MELEE_EXCEPT_BANE  = 22,
-	constexpr int MeleeImmunityExceptMagical = 23;
+	IMMUNE_MELEE_NONMAGICAL   = 23,
-	constexpr int AggroImmunity              = 24;
+	IMMUNE_AGGRO              = 24,
-	constexpr int BeingAggroImmunity         = 25;
+	IMMUNE_AGGRO_ON           = 25,
-	constexpr int CastingFromRangeImmunity   = 26;
+	IMMUNE_CASTING_FROM_RANGE = 26,
-	constexpr int FeignDeathImmunity         = 27;
+	IMMUNE_FEIGN_DEATH        = 27,
-	constexpr int TauntImmunity              = 28;
+	IMMUNE_TAUNT              = 28,
-	constexpr int TunnelVision               = 29;
+	NPC_TUNNELVISION          = 29,
-	constexpr int NoBuffHealFriends          = 30;
+	NPC_NO_BUFFHEAL_FRIENDS   = 30,
-	constexpr int PacifyImmunity             = 31;
+	IMMUNE_PACIFY             = 31,
-	constexpr int Leash                      = 32;
+	LEASH                     = 32,
-	constexpr int Tether                     = 33;
+	TETHER                    = 33,
-	constexpr int DestructibleObject         = 34;
+	DESTRUCTIBLE_OBJECT       = 34,
-	constexpr int HarmFromClientImmunity     = 35;
+	NO_HARM_FROM_CLIENT       = 35,
-	constexpr int AlwaysFlee                 = 36;
+	ALWAYS_FLEE               = 36,
-	constexpr int FleePercent                = 37;
+	FLEE_PERCENT              = 37,
-	constexpr int AllowBeneficial            = 38;
+	ALLOW_BENEFICIAL          = 38,
-	constexpr int DisableMelee               = 39;
+	DISABLE_MELEE             = 39,
-	constexpr int NPCChaseDistance           = 40;
+	NPC_CHASE_DISTANCE        = 40,
-	constexpr int AllowedToTank              = 41;
+	ALLOW_TO_TANK             = 41,
-	constexpr int IgnoreRootAggroRules       = 42;
+	IGNORE_ROOT_AGGRO_RULES   = 42,
-	constexpr int CastingResistDifficulty    = 43;
+	CASTING_RESIST_DIFF       = 43,
-	constexpr int CounterAvoidDamage         = 44;
+	COUNTER_AVOID_DAMAGE      = 44, // Modify by percent NPC's opponents chance to riposte, block, parry or dodge individually, or for all skills
-	constexpr int ProximityAggro             = 45;
+	PROX_AGGRO                = 45,
-	constexpr int RangedAttackImmunity       = 46;
+	IMMUNE_RANGED_ATTACKS     = 46,
-	constexpr int ClientDamageImmunity       = 47;
+	IMMUNE_DAMAGE_CLIENT      = 47,
-	constexpr int NPCDamageImmunity          = 48;
+	IMMUNE_DAMAGE_NPC         = 48,
-	constexpr int ClientAggroImmunity        = 49;
+	IMMUNE_AGGRO_CLIENT       = 49,
-	constexpr int NPCAggroImmunity           = 50;
+	IMMUNE_AGGRO_NPC          = 50,
-	constexpr int ModifyAvoidDamage          = 51;
+	MODIFY_AVOID_DAMAGE       = 51, // Modify by percent the NPCs chance to riposte, block, parry or dodge individually, or for all skills
-	constexpr int MemoryFadeImmunity         = 52;
+	IMMUNE_FADING_MEMORIES    = 52,
-	constexpr int OpenImmunity               = 53;
+	IMMUNE_OPEN               = 53,
-	constexpr int AssassinateImmunity        = 54;
+	IMMUNE_ASSASSINATE        = 54,
-	constexpr int HeadshotImmunity           = 55;
+	IMMUNE_HEADSHOT           = 55,
-	constexpr int BotAggroImmunity           = 56;
+	IMMUNE_AGGRO_BOT          = 56,
-	constexpr int BotDamageImmunity          = 57;
+	IMMUNE_DAMAGE_BOT         = 57,
-	constexpr int Max                        = 58;
+	MAX_SPECIAL_ATTACK        = 58
-
-	constexpr int MaxParameters = 9;
-
-	std::string GetName(int ability_id);
-	bool IsValid(int ability_id);
-}
-
-static std::map<int, std::string> special_ability_names = {
-	{ SpecialAbility::Summon,                     "Summon" },
-	{ SpecialAbility::Enrage,                     "Enrage" },
-	{ SpecialAbility::Rampage,                    "Rampage" },
-	{ SpecialAbility::AreaRampage,                "Area Rampage" },
-	{ SpecialAbility::Flurry,                     "Flurry" },
-	{ SpecialAbility::TripleAttack,               "Triple Attack" },
-	{ SpecialAbility::QuadrupleAttack,            "Quadruple Attack" },
-	{ SpecialAbility::DualWield,                  "Dual Wield" },
-	{ SpecialAbility::BaneAttack,                 "Bane Attack" },
-	{ SpecialAbility::MagicalAttack,              "Magical Attack" },
-	{ SpecialAbility::RangedAttack,               "Ranged Attack" },
-	{ SpecialAbility::SlowImmunity,               "Immune to Slow" },
-	{ SpecialAbility::MesmerizeImmunity,          "Immune to Mesmerize" },
-	{ SpecialAbility::CharmImmunity,              "Immune to Charm" },
-	{ SpecialAbility::StunImmunity,               "Immune to Stun" },
-	{ SpecialAbility::SnareImmunity,              "Immune to Snare" },
-	{ SpecialAbility::FearImmunity,               "Immune to Fear" },
-	{ SpecialAbility::DispellImmunity,            "Immune to Dispell" },
-	{ SpecialAbility::MeleeImmunity,              "Immune to Melee" },
-	{ SpecialAbility::MagicImmunity,              "Immune to Magic" },
-	{ SpecialAbility::FleeingImmunity,            "Immune to Fleeing" },
-	{ SpecialAbility::MeleeImmunityExceptBane,    "Immune to Melee except Bane" },
-	{ SpecialAbility::MeleeImmunityExceptMagical, "Immune to Non-Magical Melee" },
-	{ SpecialAbility::AggroImmunity,              "Immune to Aggro" },
-	{ SpecialAbility::BeingAggroImmunity,         "Immune to Being Aggro" },
-	{ SpecialAbility::CastingFromRangeImmunity,   "Immune to Ranged Spells" },
-	{ SpecialAbility::FeignDeathImmunity,         "Immune to Feign Death" },
-	{ SpecialAbility::TauntImmunity,              "Immune to Taunt" },
-	{ SpecialAbility::TunnelVision,               "Tunnel Vision" },
-	{ SpecialAbility::NoBuffHealFriends,          "Does Not Heal or Buff Allies" },
-	{ SpecialAbility::PacifyImmunity,             "Immune to Pacify" },
-	{ SpecialAbility::Leash,                      "Leashed" },
-	{ SpecialAbility::Tether,                     "Tethered" },
-	{ SpecialAbility::DestructibleObject,         "Destructible Object" },
-	{ SpecialAbility::HarmFromClientImmunity,     "Immune to Harm from Client" },
-	{ SpecialAbility::AlwaysFlee,                 "Always Flees" },
-	{ SpecialAbility::FleePercent,                "Flee Percentage" },
-	{ SpecialAbility::AllowBeneficial,            "Allows Beneficial Spells" },
-	{ SpecialAbility::DisableMelee,               "Melee is Disabled" },
-	{ SpecialAbility::NPCChaseDistance,           "Chase Distance" },
-	{ SpecialAbility::AllowedToTank,              "Allowed to Tank" },
-	{ SpecialAbility::IgnoreRootAggroRules,       "Ignores Root Aggro" },
-	{ SpecialAbility::CastingResistDifficulty,    "Casting Resist Difficulty" },
-	{ SpecialAbility::CounterAvoidDamage,         "Counter Damage Avoidance" },
-	{ SpecialAbility::ProximityAggro,             "Proximity Aggro" },
-	{ SpecialAbility::RangedAttackImmunity,       "Immune to Ranged Attacks" },
-	{ SpecialAbility::ClientDamageImmunity,       "Immune to Client Damage" },
-	{ SpecialAbility::NPCDamageImmunity,          "Immune to NPC Damage" },
-	{ SpecialAbility::ClientAggroImmunity,        "Immune to Client Aggro" },
-	{ SpecialAbility::NPCAggroImmunity,           "Immune to NPC Aggro" },
-	{ SpecialAbility::ModifyAvoidDamage,          "Modify Damage Avoidance" },
-	{ SpecialAbility::MemoryFadeImmunity,         "Immune to Memory Fades" },
-	{ SpecialAbility::OpenImmunity,               "Immune to Open" },
-	{ SpecialAbility::AssassinateImmunity,        "Immune to Assassinate" },
-	{ SpecialAbility::HeadshotImmunity,           "Immune to Headshot" },
-	{ SpecialAbility::BotAggroImmunity,           "Immune to Bot Aggro" },
-	{ SpecialAbility::BotDamageImmunity,          "Immune to Bot Damage" },
 };
 
+
 namespace HeroicBonusBucket
 {
 	const std::string WisMaxMana 			= "HWIS-MaxMana";
@@ -694,51 +686,4 @@ namespace HeroicBonusBucket
 	const std::string DexEnduranceRegen		= "HDEX-EnduranceRegen";
 }
 
-namespace Bug {
-	namespace Category {
-		constexpr uint32 Other         = 0;
-		constexpr uint32 Video         = 1;
-		constexpr uint32 Audio         = 2;
-		constexpr uint32 Pathing       = 3;
-		constexpr uint32 Quest         = 4;
-		constexpr uint32 Tradeskills   = 5;
-		constexpr uint32 SpellStacking = 6;
-		constexpr uint32 DoorsPortals  = 7;
-		constexpr uint32 Items         = 8;
-		constexpr uint32 NPC           = 9;
-		constexpr uint32 Dialogs       = 10;
-		constexpr uint32 LoNTCG        = 11;
-		constexpr uint32 Mercenaries   = 12;
-	}
-
-	namespace InformationFlag {
-		constexpr uint32 None           = 0;
-		constexpr uint32 Repeatable     = 1;
-		constexpr uint32 Crash          = 2;
-		constexpr uint32 TargetInfo     = 4;
-		constexpr uint32 CharacterFlags = 8;
-		constexpr uint32 Unknown        = 4294967280;
-	}
-
-	uint32 GetID(const std::string& category_name);
-	std::string GetName(uint32 category_id);
-	bool IsValid(uint32 category_id);
-}
-
-static std::map<uint32, std::string> bug_category_names = {
-	{ Bug::Category::Other,         "Other" },
-	{ Bug::Category::Video,         "Video" },
-	{ Bug::Category::Audio,         "Audio" },
-	{ Bug::Category::Pathing,       "Pathing" },
-	{ Bug::Category::Quest,         "Quest" },
-	{ Bug::Category::Tradeskills,   "Tradeskills" },
-	{ Bug::Category::SpellStacking, "Spell Stacking" },
-	{ Bug::Category::DoorsPortals,  "Doors and Portals" },
-	{ Bug::Category::Items,         "Items" },
-	{ Bug::Category::NPC,           "NPC" },
-	{ Bug::Category::Dialogs,       "Dialogs" },
-	{ Bug::Category::LoNTCG,        "LoN - TCG" },
-	{ Bug::Category::Mercenaries,   "Mercenaries" }
-};
-
 #endif /*COMMON_EMU_CONSTANTS_H*/

common/emu_oplist.h

@@ -510,11 +510,6 @@ N(OP_ShopEndConfirm),
 N(OP_ShopItem),
 N(OP_ShopPlayerBuy),
 N(OP_ShopPlayerSell),
-N(OP_ShopSendParcel),
-N(OP_ShopDeleteParcel),
-N(OP_ShopRespondParcel),
-N(OP_ShopRetrieveParcel), 
-N(OP_ShopParcelIcon),
 N(OP_ShopRequest),
 N(OP_SimpleMessage),
 N(OP_SkillUpdate),
@@ -557,7 +552,6 @@ N(OP_TradeBusy),
 N(OP_TradeCoins),
 N(OP_TradeMoneyUpdate),
 N(OP_Trader),
-N(OP_TraderBulkSend),
 N(OP_TraderBuy),
 N(OP_TraderDelItem),
 N(OP_TradeRequest),

common/eq_constants.h

@@ -793,26 +793,46 @@ typedef enum {
 #define STAT_MANA_REGEN		18
 #define STAT_HASTE		19
 #define STAT_DAMAGE_SHIELD	20
-#define STAT_DS_MITIGATION       22
+
-#define	STAT_HEAL_AMOUNT         23
+/*
-#define	STAT_SPELL_DAMAGE        24
+**	Recast timer types. Used as an off set to charProfileStruct timers.
-#define	STAT_CLAIRVOYANCE        25
+**
-#define	STAT_HEROIC_AGILITY      26
+**	(Another orphaned enumeration...)
-#define	STAT_HEROIC_CHARISMA     27
+*/
-#define	STAT_HEROIC_DEXTERITY    28
+enum RecastTimerTypes
-#define	STAT_HEROIC_INTELLIGENCE 29
+{
-#define	STAT_HEROIC_STAMINA      30
+	RecTimer_0 = 0,
-#define	STAT_HEROIC_STRENGTH     31
+	RecTimer_1,
-#define	STAT_HEROIC_WISDOM       32
+	RecTimer_WeaponHealClick,		// 2
-#define	STAT_BASH                33
+	RecTimer_MuramiteBaneNukeClick,	// 3
-#define	STAT_BACKSTAB            34
+	RecTimer_4,
-#define	STAT_DRAGON_PUNCH        35
+	RecTimer_DispellClick,			// 5 (also click heal orbs?)
-#define	STAT_EAGLE_STRIKE        36
+	RecTimer_Epic,					// 6
-#define	STAT_FLYING_KICK         37
+	RecTimer_OoWBPClick,			// 7
-#define STAT_KICK                38
+	RecTimer_VishQuestClassItem,	// 8
-#define	STAT_ROUND_KICK          39
+	RecTimer_HealPotion,			// 9
-#define STAT_TIGER_CLAW          40
+	RecTimer_10,
-#define STAT_FRENZY              41
+	RecTimer_11,
+	RecTimer_12,
+	RecTimer_13,
+	RecTimer_14,
+	RecTimer_15,
+	RecTimer_16,
+	RecTimer_17,
+	RecTimer_18,
+	RecTimer_ModRod,				// 19
+	_RecTimerCount
+};
+
+enum GroupUpdateAction
+{
+	GUA_Joined = 0,
+	GUA_Left = 1,
+	GUA_LastLeft = 6,
+	GUA_FullGroupInfo = 7,
+	GUA_MakeLeader = 8,
+	GUA_Started = 9
+};
 
 static const uint8 DamageTypeSomething	= 0x1C;	//0x1c is something...
 static const uint8 DamageTypeFalling	= 0xFC;
@@ -1111,22 +1131,4 @@ namespace LeadershipAbilitySlot {
 	constexpr uint16 HealthOfTargetsTarget = 14;
 }
 
-enum ExpSource
-{
-	Quest,
-	GM,
-	Kill,
-	Death,
-	Resurrection,
-	LDoNChest,
-	Task,
-	Sacrifice
-};
-
-#define PARCEL_SEND_ITEMS    0
-#define PARCEL_SEND_MONEY    1
-#define PARCEL_MONEY_ITEM_ID 99990 // item id of money
-#define PARCEL_LIMIT         5
-#define PARCEL_BEGIN_SLOT    1
-
 #endif /*COMMON_EQ_CONSTANTS_H*/

common/eq_packet_structs.h

@@ -27,9 +27,7 @@
 #include "../common/version.h"
 #include "emu_constants.h"
 #include "textures.h"
-#include "../cereal/include/cereal/archives/binary.hpp"
+
-#include "../cereal/include/cereal/types/string.hpp"
-#include "../cereal/include/cereal/types/vector.hpp"
 
 static const uint32 BUFF_COUNT = 42;
 static const uint32 PET_BUFF_COUNT = 30;
@@ -322,7 +320,6 @@ union
 	bool targetable_with_hotkey;
 	bool show_name;
 	bool guild_show;
-	bool trader;
 };
 
 struct PlayerState_Struct {
@@ -1119,7 +1116,7 @@ struct PlayerProfile_Struct
 /*19558*/	uint8				guildAutoconsent;	// 0=off, 1=on
 /*19559*/	uint8				unknown19595[5];	// ***Placeholder (6/29/2005)
 /*19564*/	uint32				RestTimer;
-/*19568*/	uint32				char_id;			// Found as part of bazaar revamp (5/15/2024)
+/*19568*/
 
 	// All player profile packets are translated and this overhead is ignored in out-bound packets
 	PlayerProfile_Struct() : m_player_profile_version(EQ::versions::MobVersion::Unknown) { }
@@ -1536,7 +1533,8 @@ struct ExpUpdate_Struct
 ** Packet Types: See ItemPacketType enum
 **
 */
-enum ItemPacketType {
+enum ItemPacketType
+{
 	ItemPacketViewLink			= 0x00,
 	ItemPacketMerchant			= 0x64,
 	ItemPacketTradeView			= 0x65,
@@ -1548,22 +1546,9 @@ enum ItemPacketType {
 	ItemPacketTributeItem		= 0x6C,
 	ItemPacketGuildTribute		= 0x6D,
 	ItemPacketCharmUpdate		= 0x6E, // noted as incorrect
-    ItemPacketRecovery       = 0x71,
-    ItemPacketParcel         = 0x73,
 	ItemPacketInvalid			= 0xFF
 };
 
-enum MerchantWindowTabDisplay {
-    None                 = 0x00,
-    SellBuy              = 0x01,
-    Recover              = 0x02,
-    SellBuyRecover       = 0x03,
-    Parcel               = 0x04,
-    SellBuyParcel        = 0x05,
-    RecoverParcel        = 0x06,
-    SellBuyRecoverParcel = 0x07
-};
-
 //enum ItemPacketType
 //{
 //	ItemPacketMerchant			= /*100*/ 0x64, // Titanium+
@@ -1693,38 +1678,6 @@ struct GuildsList_Struct {
 	GuildsListEntry_Struct Guilds[MAX_NUMBER_GUILDS];
 };
 
-struct GuildsListMessagingEntry_Struct {
-	/*000*/	uint32		guild_id;
-	/*004*/	std::string guild_name;
-
-	template<class Archive>
-	void serialize(Archive& archive)
-	{
-		archive(
-			CEREAL_NVP(guild_id),
-			CEREAL_NVP(guild_name)
-		);
-	}
-};
-
-struct GuildsListMessaging_Struct {
-	/*000*/    char                                         header[64];
-	/*064*/    uint32                                       no_of_guilds;
-	/*068*/    uint32                                       string_length;
-	/*072*/    std::vector<GuildsListMessagingEntry_Struct> guild_detail;
-
-	template<class Archive>
-	void serialize(Archive& archive)
-	{
-		archive(
-			CEREAL_NVP(header),
-			CEREAL_NVP(no_of_guilds),
-			CEREAL_NVP(string_length),
-			CEREAL_NVP(guild_detail)
-		);
-	}
-};
-
 struct GuildUpdate_Struct {
 	uint32	guildID;
 	GuildsListEntry_Struct entry;
@@ -2104,75 +2057,12 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct
+struct Merchant_Click_Struct {
-{
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-    /*000*/ uint32 npc_id;      // Merchant NPC's entity id
+/*004*/ uint32	playerid;
-    /*004*/ uint32 player_id;
+/*008*/ uint32	command;		//1=open, 0=cancel/close
-    /*008*/ uint32 command;     // 1=open, 0=cancel/close
+/*012*/ float	rate;			//cost multiplier, dosent work anymore
-    /*012*/ float  rate;        // cost multiplier, dosent work anymore
-    /*016*/ int32  tab_display; // bitmask b000 none, b001 Purchase/Sell, b010 Recover, b100 Parcels
-    /*020*/ int32  unknown020;  // Seen 2592000 from Server or -1 from Client
-    /*024*/
 };
-
-enum MerchantActions {
-    Close = 0,
-    Open  = 1
-};
-
-struct Parcel_Struct
-{
-    /*000*/ uint32 npc_id;
-    /*004*/ uint32 item_slot;
-    /*008*/ uint32 quantity;
-    /*012*/ uint32 money_flag;
-    /*016*/ char   send_to[64];
-    /*080*/ char   note[128];
-    /*208*/ uint32 unknown_208;
-    /*212*/ uint32 unknown_212;
-    /*216*/ uint32 unknown_216;
-};
-
-struct ParcelRetrieve_Struct
-{
-    uint32 merchant_entity_id;
-    uint32 player_entity_id;
-    uint32 parcel_slot_id;
-    uint32 parcel_item_id;
-};
-
-struct ParcelMessaging_Struct {
-	ItemPacketType packet_type;
-	std::string    serialized_item;
-	uint32         sent_time;
-	std::string    player_name;
-	std::string    note;
-	uint32         slot_id;
-
-	template<class Archive>
-	void serialize(Archive &archive)
-	{
-		archive(
-			CEREAL_NVP(packet_type),
-			CEREAL_NVP(serialized_item),
-			CEREAL_NVP(sent_time),
-			CEREAL_NVP(player_name),
-			CEREAL_NVP(note),
-			CEREAL_NVP(slot_id)
-		);
-	}
-};
-
-struct ParcelIcon_Struct {
-	uint32 status; //0 off 1 on 2 overlimit
-};
-
-enum ParcelIconActions {
-	IconOff   = 0,
-	IconOn    = 1,
-	Overlimit = 2
-};
-
 /*
 Unknowns:
 0 is e7 from 01 to // MAYBE SLOT IN PURCHASE
@@ -3032,41 +2922,31 @@ struct BazaarWindowStart_Struct {
 
 
 struct BazaarWelcome_Struct {
-	uint32 action;
+	BazaarWindowStart_Struct Beginning;
-	uint32 traders;
+	uint32	Traders;
-	uint32 items;
+	uint32	Items;
-	uint32 unknown_012;
+	uint32	Unknown012;
-	uint32 unknown_016;
+	uint32	Unknown016;
 };
 
-struct BazaarSearchCriteria_Struct {
+struct BazaarSearch_Struct {
-	/*000*/ uint32 action{0};
+	BazaarWindowStart_Struct Beginning;
-	/*004*/ uint32 search_scope{0}; // 1 all traders 0 local traders
+	uint32	TraderID;
-	/*008*/ uint32 unknown_008{0};
+	uint32	Class_;
-	/*012*/ uint32 unknown_012{0};
+	uint32	Race;
-	/*016*/ uint32 trader_id{0};
+	uint32	ItemStat;
-	/*020*/ uint32 _class{0};
+	uint32	Slot;
-	/*024*/ uint32 race{0};
+	uint32	Type;
-	/*028*/ uint32 item_stat{0};
+	char	Name[64];
-	/*032*/ uint32 slot{0};
+	uint32	MinPrice;
-	/*036*/ uint32 type{0};
+	uint32	MaxPrice;
-	/*040*/ char   item_name[64]{""};
+	uint32	Minlevel;
-	/*104*/ uint32 min_cost{0};
+	uint32	MaxLlevel;
-	/*108*/ uint32 max_cost{0};
-	/*112*/ uint32 min_level{1};
-	/*116*/ uint32 max_level{0};
-	/*120*/ uint32 max_results{0};
-	/*124*/ uint32 prestige{0};
-	/*128*/ uint32 augment{0};
-	/*132*/ uint32 trader_entity_id{0};
 };
-
+struct BazaarInspect_Struct{
-struct BazaarInspect_Struct {
+	uint32 ItemID;
-	uint32 action;
+	uint32 Unknown004;
-	char   player_name[64];
+	char Name[64];
-	uint32 serial_number;
-	uint32 item_id;
-	uint32 trader_id;
 };
 
 struct NewBazaarInspect_Struct {
@@ -3086,14 +2966,6 @@ struct BazaarReturnDone_Struct{
 	uint32 Unknown012;
 	uint32 Unknown016;
 };
-
-struct BazaarDeliveryCost_Struct {
-	uint32 action;
-	uint16 voucher_delivery_cost;
-	float  parcel_deliver_cost; //percentage of item cost
-	uint32 unknown_010;
-};
-
 struct BazaarSearchResults_Struct {
 /*000*/	BazaarWindowStart_Struct Beginning;
 /*004*/	uint32	NumItems;
@@ -3106,10 +2978,8 @@ struct BazaarSearchResults_Struct {
 	// New fields for SoD+, stripped off when encoding for older clients.
 	char	SellerName[64];
 	uint32	ItemID;
-	uint32	ItemID2;
 };
 
-
 // Barter/Buyer
 //
 //
@@ -3409,31 +3279,32 @@ struct WhoAllReturnStruct {
 };
 
 struct Trader_Struct {
-/*000*/	uint32	action;
+/*000*/	uint32	Code;
-/*004*/	uint32	unknown_004;
+/*004*/	uint32	Unknown004;
-/*008*/	uint64	items[EQ::invtype::BAZAAR_SIZE];
+/*008*/	uint64	Items[80];
-/*648*/	uint32	item_cost[EQ::invtype::BAZAAR_SIZE];
+/*648*/	uint32	ItemCost[80];
 };
 
 struct ClickTrader_Struct {
-/*000*/	uint32	action;
+/*000*/	uint32	Code;
-/*004*/	uint32	unknown_004;
+/*004*/	uint32	Unknown004;
-/*008*/	int64	serial_number[EQ::invtype::BAZAAR_SIZE] {};
+/*008*/	int64	SerialNumber[80];
-/*648*/	uint32	item_cost[EQ::invtype::BAZAAR_SIZE] {};
+/*648*/	uint32	ItemCost[80];
 };
 
 struct GetItems_Struct{
-	uint32	items[EQ::invtype::BAZAAR_SIZE];
+	uint32	Items[80];
-	int32	serial_number[EQ::invtype::BAZAAR_SIZE];
+	int32	SerialNumber[80];
-	int32	charges[EQ::invtype::BAZAAR_SIZE];
+	int32	Charges[80];
 };
 
-struct BecomeTrader_Struct {
+struct BecomeTrader_Struct
-	uint32 action;
+{
-	uint32 zone_id;
+/*000*/	uint32 ID;
-	uint32 trader_id;
+/*004*/	uint32 Code;
-	uint32 entity_id;
+/*008*/	char Name[64];
-	char   trader_name[64];
+/*072*/	uint32 Unknown072;	// Observed 0x33,0x91 etc on zone-in, 0x00 when sent for a new trader after zone-in
+/*076*/
 };
 
 struct TraderStatus_Struct{
@@ -3443,30 +3314,20 @@ struct TraderStatus_Struct{
 };
 
 struct Trader_ShowItems_Struct{
-/*000*/	uint32 action;
+/*000*/	uint32 Code;
-/*004*/	uint32 entity_id;
+/*004*/	uint32 TraderID;
 /*008*/	uint32 Unknown08[3];
 /*020*/
 };
 
-struct TraderBuy_Struct {
+struct TraderBuy_Struct{
-/*000*/ uint32	action;
+/*000*/	uint32 Action;
-/*004*/	uint32	method;
+/*004*/	uint32 TraderID;
-/*008*/ uint32	sub_action;
+/*008*/	uint32 ItemID;
-/*012*/	uint32	unknown_012;
+/*012*/	uint32 AlreadySold;
-/*016*/ uint32	trader_id;
+/*016*/	uint32 Price;
-/*020*/ char	buyer_name[64];
+/*020*/	uint32 Quantity;
-/*084*/ char	seller_name[64];
+/*024*/	char ItemName[64];
-/*148*/ char	unknown_148[32];
-/*180*/ char	item_name[64];
-/*244*/ char	serial_number[17];
-/*261*/ char	unknown_261[3];
-/*264*/ uint32	item_id;
-/*268*/ uint32	price;
-/*272*/ uint32	already_sold;
-/*276*/ uint32	unknown_276;
-/*280*/ uint32	quantity;
-/*284*/
 };
 
 struct TraderItemUpdate_Struct{
@@ -3494,15 +3355,15 @@ struct MoneyUpdate_Struct{
 };
 
 struct TraderDelItem_Struct{
-	uint32 unknown_000;
+	uint32 Unknown000;
-	uint32 trader_id;
+	uint32 TraderID;
-	uint32 item_id;
+	uint32 ItemID;
-	uint32 unknown_012;
+	uint32 Unknown012;
 };
 
 struct TraderClick_Struct{
-/*000*/	uint32 Code;
+/*000*/	uint32 TraderID;
-/*004*/	uint32 TraderID;
+/*004*/	uint32 Code;
 /*008*/	uint32 Unknown008;
 /*012*/	uint32 Approval;
 /*016*/
@@ -6020,102 +5881,6 @@ struct UnderWorld {
 	/* 16 */
 };
 
-enum BazaarTraderBarterActions {
-	TraderOff                    = 0,
-	TraderOn                     = 1,
-	PriceUpdate                  = 3,
-	EndTransaction               = 4,
-	BazaarSearch                 = 7,
-	WelcomeMessage               = 9,
-	BuyTraderItem                = 10,
-	ListTraderItems              = 11,
-	CustomerBrowsing             = 13,
-	BazaarInspect                = 18,
-	ItemMove                     = 19,
-	TraderAck2                   = 22,
-	AddTraderToBazaarWindow      = 24,
-	RemoveTraderFromBazaarWindow = 25,
-	ClickTrader                  = 28,
-	DeliveryCostUpdate           = 29
-};
-
-enum BazaarPurchaseActions {
-	ByVendor            = 0,
-	ByParcel            = 1,
-	ByDirectToInventory = 2
-};
-
-enum BazaarPurchaseSubActions {
-	Success               = 0,
-	Failed                = 1,
-	DataOutDated          = 3,
-	TooManyParcels        = 5,
-	TransactionInProgress = 6,
-	InsufficientFunds     = 7
-};
-
-enum BazaarSearchScopes {
-	Local_Scope             = 0,
-	AllTraders_Scope        = 1,
-	NonRoFBazaarSearchScope = 99
-};
-
-struct BazaarSearchResultsFromDB_Struct {
-	uint32      count;
-	uint32      trader_id;
-	uint32      item_id;
-	uint32      serial_number;
-	uint32      charges;
-	uint32      cost;
-	uint32      slot_id;
-	uint32      icon_id;
-	uint32      sum_charges;
-	uint32      trader_zone_id;
-	uint32      trader_entity_id;
-	uint32      item_stat;
-	bool        stackable;
-	std::string item_name;
-	std::string serial_number_RoF;
-	std::string trader_name;
-
-	template<class Archive>
-	void serialize(Archive &archive)
-	{
-		archive(
-			CEREAL_NVP(count),
-			CEREAL_NVP(trader_id),
-			CEREAL_NVP(item_id),
-			CEREAL_NVP(serial_number),
-			CEREAL_NVP(charges),
-			CEREAL_NVP(cost),
-			CEREAL_NVP(slot_id),
-			CEREAL_NVP(icon_id),
-			CEREAL_NVP(sum_charges),
-			CEREAL_NVP(trader_zone_id),
-			CEREAL_NVP(trader_entity_id),
-			CEREAL_NVP(item_stat),
-			CEREAL_NVP(stackable),
-			CEREAL_NVP(item_name),
-			CEREAL_NVP(serial_number_RoF),
-			CEREAL_NVP(trader_name)
-		);
-	}
-};
-
-struct BazaarSearchMessaging_Struct {
-	uint32 action;
-	char   payload[];
-
-	template<class Archive>
-	void serialize(Archive &archive)
-	{
-		archive(
-			CEREAL_NVP(action),
-			CEREAL_NVP(payload)
-		);
-	}
-};
-
 // Restore structure packing to default
 #pragma pack()
 

common/events/player_event_logs.cpp

@@ -642,10 +642,6 @@ void PlayerEventLogs::ProcessRetentionTruncation()
 void PlayerEventLogs::ReloadSettings()
 {
 	for (auto &e: PlayerEventLogSettingsRepository::All(*m_database)) {
-		if (e.id >= PlayerEvent::MAX || e.id < 0) {
-			continue;
-		}
-
 		m_settings[e.id] = e;
 	}
 }
@@ -703,9 +699,6 @@ void PlayerEventLogs::SetSettingsDefaults()
 	m_settings[PlayerEvent::ITEM_CREATION].event_enabled      = 1;
 	m_settings[PlayerEvent::GUILD_TRIBUTE_DONATE_ITEM].event_enabled      = 1;
 	m_settings[PlayerEvent::GUILD_TRIBUTE_DONATE_PLAT].event_enabled      = 1;
-	m_settings[PlayerEvent::PARCEL_SEND].event_enabled               = 1;
-	m_settings[PlayerEvent::PARCEL_RETRIEVE].event_enabled           = 1;
-	m_settings[PlayerEvent::PARCEL_DELETE].event_enabled             = 1;
 
 	for (int i = PlayerEvent::GM_COMMAND; i != PlayerEvent::MAX; i++) {
 		m_settings[i].retention_days = RETENTION_DAYS_DEFAULT;

common/events/player_events.h

@@ -58,9 +58,6 @@ namespace PlayerEvent {
 		ITEM_CREATION,
 		GUILD_TRIBUTE_DONATE_ITEM,
 		GUILD_TRIBUTE_DONATE_PLAT,
-		PARCEL_SEND,
-		PARCEL_RETRIEVE,
-		PARCEL_DELETE, 
 		MAX // dont remove
 	};
 
@@ -69,7 +66,7 @@ namespace PlayerEvent {
 	// If event is unimplemented just tag (Unimplemented) in the name
 	// Events don't get saved to the database if unimplemented or deprecated
 	// Events tagged as deprecated will get automatically removed
-	static const char *EventName[EventType::MAX] = {
+	static const char *EventName[PlayerEvent::MAX] = {
 		"None",
 		"GM Command",
 		"Zoning",
@@ -119,10 +116,7 @@ namespace PlayerEvent {
 		"Killed Raid NPC",
 		"Item Creation",
 		"Guild Tribute Donate Item",
-		"Guild Tribute Donate Platinum",
+		"Guild Tribute Donate Platinum"
-		"Parcel Item Sent",
-		"Parcel Item Retrieved",
-		"Parcel Prune Routine"
 	};
 
 	// Generic struct used by all events
@@ -982,105 +976,6 @@ namespace PlayerEvent {
 			);
 		}
 	};
-
-	struct ParcelRetrieve {
-		uint32      item_id;
-		uint32      quantity;
-		std::string from_player_name;
-		uint32      sent_date;
-		uint32      aug_slot_1;
-		uint32      aug_slot_2;
-		uint32      aug_slot_3;
-		uint32      aug_slot_4;
-		uint32      aug_slot_5;
-		uint32      aug_slot_6;
-
-		// cereal
-		template<class Archive>
-		void serialize(Archive &ar)
-		{
-			ar(
-				CEREAL_NVP(item_id),
-				CEREAL_NVP(quantity),
-				CEREAL_NVP(from_player_name),
-				CEREAL_NVP(sent_date),
-				CEREAL_NVP(aug_slot_1),
-				CEREAL_NVP(aug_slot_2),
-				CEREAL_NVP(aug_slot_3),
-				CEREAL_NVP(aug_slot_4),
-				CEREAL_NVP(aug_slot_5),
-				CEREAL_NVP(aug_slot_6)
-			);
-		}
-	};
-
-	struct ParcelSend {
-		uint32      item_id;
-		uint32      quantity;
-		std::string from_player_name;
-		std::string to_player_name;
-		uint32      sent_date;
-		uint32      aug_slot_1;
-		uint32      aug_slot_2;
-		uint32      aug_slot_3;
-		uint32      aug_slot_4;
-		uint32      aug_slot_5;
-		uint32      aug_slot_6;
-
-		// cereal
-		template<class Archive>
-		void serialize(Archive &ar)
-		{
-			ar(
-				CEREAL_NVP(item_id),
-				CEREAL_NVP(quantity),
-				CEREAL_NVP(from_player_name),
-				CEREAL_NVP(to_player_name),
-				CEREAL_NVP(sent_date),
-				CEREAL_NVP(aug_slot_1),
-				CEREAL_NVP(aug_slot_2),
-				CEREAL_NVP(aug_slot_3),
-				CEREAL_NVP(aug_slot_4),
-				CEREAL_NVP(aug_slot_5),
-				CEREAL_NVP(aug_slot_6)
-			);
-		}
-	};
-
-	struct ParcelDelete {
-		uint32      item_id;
-		uint32      quantity;
-		uint32      char_id;
-		std::string from_name;
-		std::string note;
-		uint32      sent_date;
-		uint32      aug_slot_1;
-		uint32      aug_slot_2;
-		uint32      aug_slot_3;
-		uint32      aug_slot_4;
-		uint32      aug_slot_5;
-		uint32      aug_slot_6;
-
-		// cereal
-		template<class Archive>
-		void serialize(Archive &ar)
-		{
-			ar(
-				CEREAL_NVP(item_id),
-				CEREAL_NVP(quantity),
-				CEREAL_NVP(char_id),
-				CEREAL_NVP(from_name),
-				CEREAL_NVP(note),
-				CEREAL_NVP(sent_date),
-				CEREAL_NVP(aug_slot_1),
-				CEREAL_NVP(aug_slot_2),
-				CEREAL_NVP(aug_slot_3),
-				CEREAL_NVP(aug_slot_4),
-				CEREAL_NVP(aug_slot_5),
-				CEREAL_NVP(aug_slot_6)
-				);
-		}
-	};
 }
 
 #endif //EQEMU_PLAYER_EVENTS_H

common/guild_base.cpp

@@ -92,20 +92,10 @@ BaseGuildManager::~BaseGuildManager()
 bool BaseGuildManager::LoadGuilds()
 {
 	ClearGuilds();
-	auto guilds             = GuildsRepository::GetWhere(
+	auto guilds             = GuildsRepository::All(*m_db);
-		*m_db,
+	auto guilds_ranks       = GuildRanksRepository::All(*m_db);
-		fmt::format("`id` < '{}'", RoF2::constants::MAX_GUILD_ID)
+	auto guilds_permissions = GuildPermissionsRepository::All(*m_db);
-	);
+	auto guilds_tributes    = GuildTributesRepository::All(*m_db);
-	auto guilds_ranks       = GuildRanksRepository::LoadAll(*m_db);
-	auto guilds_permissions = GuildPermissionsRepository::LoadAll(*m_db);
-	auto guilds_tributes    = GuildTributesRepository::GetWhere(
-		*m_db,
-		fmt::format(
-			"`guild_id` < '{}'",
-			RoF2::constants::MAX_GUILD_ID
-		)
-	);
-
 
 	if (guilds.empty()) {
 		LogGuilds("No Guilds found in database.");
@@ -118,28 +108,23 @@ bool BaseGuildManager::LoadGuilds()
 
 		_CreateGuild(g.id, g.name, g.leader, g.minstatus, g.motd, g.motd_setter, g.channel, g.url, g.favor);
 
-		for (int i = 1; i <= GUILD_MAX_RANK; i++) {
+		for (auto const &r: guilds_ranks) {
-			auto key = fmt::format("{}-{}", g.id, i);
+			if (r.guild_id == g.id) {
-
+				m_guilds[g.id]->rank_names[r.rank_] = r.title;
-			if (guilds_ranks.contains(key)) {
-				m_guilds[g.id]->rank_names[i] = guilds_ranks.find(key)->second;
 			}
 		}
 
 		auto count = 0;
 
-		for (int i = 1; i <= GUILD_MAX_FUNCTIONS; i++) {
+		for (auto const &p: guilds_permissions) {
-			auto key = fmt::format("{}-{}", g.id, i);
+			if (p.guild_id == g.id) {
-			if (guilds_permissions.contains(key)) {
-				auto p = guilds_permissions.find(key)->second;
 				m_guilds[g.id]->functions[p.perm_id].id         = p.id;
 				m_guilds[g.id]->functions[p.perm_id].guild_id   = p.guild_id;
 				m_guilds[g.id]->functions[p.perm_id].perm_id    = p.perm_id;
 				m_guilds[g.id]->functions[p.perm_id].perm_value = p.permission;
-			}
-
 				count++;
 			}
+		}
 
 		if (count < GUILD_MAX_FUNCTIONS) {
 			store_to_db = true;
@@ -944,24 +929,33 @@ bool BaseGuildManager::GetCharInfo(uint32 char_id, CharGuildInfo &into)
 
 }
 
-GuildsListMessaging_Struct BaseGuildManager::MakeGuildList()
+//returns ownership of the buffer.
+uint8 *BaseGuildManager::MakeGuildList(const char *head_name, uint32 &length) const
 {
-	GuildsListMessaging_Struct guild_list_messaging{};
+	//dynamic structs will make this a lot less painful.
-	uint32                     string_length = 0;
 
-	for (auto const &g: m_guilds) {
+	length = sizeof(GuildsList_Struct);
-		GuildsListMessagingEntry_Struct guild_entry{};
+	auto buffer = new uint8[length];
 
-		guild_entry.guild_id   = g.first;
+	//a bit little better than memsetting the whole thing...
-		guild_entry.guild_name = g.second->name;
+	uint32 r, pos;
-		string_length         += g.second->name.length() + 1;
+	for (r = 0, pos = 0; r <= MAX_NUMBER_GUILDS; r++, pos += 64) {
-		guild_list_messaging.guild_detail.push_back(guild_entry);
+		//strcpy((char *) buffer+pos, "BAD GUILD");
+		// These 'BAD GUILD' entries were showing in the drop-downs for selecting guilds in the LFP window,
+		// so just fill unused entries with an empty string instead.
+		buffer[pos] = '\0';
 	}
 
-	guild_list_messaging.no_of_guilds  = m_guilds.size();
+	strn0cpy((char *) buffer, head_name, 64);
-	guild_list_messaging.string_length = string_length;
 
-	return guild_list_messaging;
+	std::map<uint32, GuildInfo *>::const_iterator cur, end;
+	cur = m_guilds.begin();
+	end = m_guilds.end();
+	for (; cur != end; ++cur) {
+		pos = 64 + (64 * cur->first);
+		strn0cpy((char *) buffer + pos, cur->second->name.c_str(), 64);
+	}
+	return (buffer);
 }
 
 const char *BaseGuildManager::GetRankName(uint32 guild_id, uint8 rank) const

common/guild_base.h

@@ -134,7 +134,7 @@ class BaseGuildManager
         bool	CheckGMStatus(uint32 guild_id, uint8 status) const;
         bool	CheckPermission(uint32 guild_id, uint8 rank, GuildAction act) const;
         bool	UpdateDbBankerFlag(uint32 charid, bool is_banker);
-        GuildsListMessaging_Struct MakeGuildList();
+        uint8*  MakeGuildList(const char* head_name, uint32& length) const;	//make a guild list packet, returns ownership of the buffer.
         uint8	GetDisplayedRank(uint32 guild_id, uint8 rank, uint32 char_id) const;
         uint32	GetGuildIDByName(const char *GuildName);
 		uint32  GetGuildIDByCharacterID(uint32 character_id);

common/inventory_profile.cpp

@@ -276,7 +276,7 @@ bool EQ::InventoryProfile::SwapItem(
 	SwapItemFailState &fail_state,
 	uint16 race_id,
 	uint8 class_id,
-	uint32 deity_id,
+	uint16 deity_id,
 	uint8 level
 ) {
 	fail_state = swapInvalid;
@@ -354,7 +354,7 @@ bool EQ::InventoryProfile::SwapItem(
 				fail_state = swapRaceClass;
 				return false;
 			}
-			if (deity_id && source_item->Deity && !(Deity::GetBitmask(deity_id) & source_item->Deity)) {
+			if (deity_id && source_item->Deity && !(deity::GetDeityBitmask((deity::DeityType)deity_id) & source_item->Deity)) {
 				fail_state = swapDeity;
 				return false;
 			}
@@ -380,7 +380,7 @@ bool EQ::InventoryProfile::SwapItem(
 				fail_state = swapRaceClass;
 				return false;
 			}
-			if (deity_id && destination_item->Deity && !(Deity::GetBitmask(deity_id) & destination_item->Deity)) {
+			if (deity_id && destination_item->Deity && !(deity::GetDeityBitmask((deity::DeityType)deity_id) & destination_item->Deity)) {
 				fail_state = swapDeity;
 				return false;
 			}

common/inventory_profile.h

@@ -132,7 +132,7 @@ namespace EQ
 
 		// Swap items in inventory
 		enum SwapItemFailState : int8 { swapInvalid = -1, swapPass = 0, swapNotAllowed, swapNullData, swapRaceClass, swapDeity, swapLevel };
-		bool SwapItem(int16 source_slot, int16 destination_slot, SwapItemFailState& fail_state, uint16 race_id = Race::Doug, uint8 class_id = Class::None, uint32 deity_id = Deity::Unknown, uint8 level = 0);
+		bool SwapItem(int16 source_slot, int16 destination_slot, SwapItemFailState& fail_state, uint16 race_id = Race::Doug, uint8 class_id = Class::None, uint16 deity_id = deity::DeityType::DeityUnknown, uint8 level = 0);
 
 		// Remove item from inventory
 		bool DeleteItem(int16 slot_id, int16 quantity = 0);

common/item_data.h

@@ -58,75 +58,72 @@ namespace EQ
 		};
 
 		enum ItemType : uint8 {
-			/*9138*/ ItemType1HSlash = 0,
+/*9138*/	ItemType1HSlash = 0,
-			/*9141*/ ItemType2HSlash,
+/*9141*/	ItemType2HSlash,
-			/*9140*/ ItemType1HPiercing,
+/*9140*/	ItemType1HPiercing,
-			/*9139*/ ItemType1HBlunt,
+/*9139*/	ItemType1HBlunt,
-			/*9142*/ ItemType2HBlunt,
+/*9142*/	ItemType2HBlunt,
-			/*5504*/ ItemTypeBow,                 // 5
+/*5504*/	ItemTypeBow, // 5
-			/*----*/ ItemTypeUnknown1,
+/*----*/	ItemTypeUnknown1,
-			/*----*/ ItemTypeLargeThrowing,
+/*----*/	ItemTypeLargeThrowing,
-			/*5505*/ ItemTypeShield,
+/*5505*/	ItemTypeShield,
-			/*5506*/ ItemTypeScroll,
+/*5506*/	ItemTypeScroll,
-			/*5507*/ ItemTypeArmor,               // 10
+/*5507*/	ItemTypeArmor, // 10
-			/*5508*/ ItemTypeMisc,                // a lot of random crap has this item use.
+/*5508*/	ItemTypeMisc,			// a lot of random crap has this item use.
-			/*7564*/ ItemTypeLockPick,
+/*7564*/	ItemTypeLockPick,
-			/*----*/ ItemTypeUnknown2,
+/*----*/	ItemTypeUnknown2,
-			/*5509*/ ItemTypeFood,
+/*5509*/	ItemTypeFood,
-			/*5510*/ ItemTypeDrink,               // 15
+/*5510*/	ItemTypeDrink, // 15
-			/*5511*/ ItemTypeLight,
+/*5511*/	ItemTypeLight,
-			/*5512*/ ItemTypeCombinable,          // not all stackable items are this use...
+/*5512*/	ItemTypeCombinable,		// not all stackable items are this use...
-			/*5513*/ ItemTypeBandage,
+/*5513*/	ItemTypeBandage,
-			/*----*/ ItemTypeSmallThrowing,
+/*----*/	ItemTypeSmallThrowing,
-			/*----*/ ItemTypeSpell,               // 20	// spells and tomes
+/*----*/	ItemTypeSpell, // 20	// spells and tomes
-			/*5514*/ ItemTypePotion,
+/*5514*/	ItemTypePotion,
-			/*----*/ ItemTypeUnknown3,
+/*----*/	ItemTypeUnknown3,
-			/*0406*/ ItemTypeWindInstrument,
+/*0406*/	ItemTypeWindInstrument,
-			/*0407*/ ItemTypeStringedInstrument,
+/*0407*/	ItemTypeStringedInstrument,
-			/*0408*/ ItemTypeBrassInstrument,     // 25
+/*0408*/	ItemTypeBrassInstrument, // 25
-			/*0405*/ ItemTypePercussionInstrument,
+/*0405*/	ItemTypePercussionInstrument,
-			/*5515*/ ItemTypeArrow,
+/*5515*/	ItemTypeArrow,
-			/*----*/ ItemTypeUnknown4,
+/*----*/	ItemTypeUnknown4,
-			/*5521*/ ItemTypeJewelry,
+/*5521*/	ItemTypeJewelry,
-			/*----*/ ItemTypeSkull,               // 30
+/*----*/	ItemTypeSkull, // 30
-			/*5516*/ ItemTypeBook,                // skill-up tomes/books? (would probably need a pp flag if true...)
+/*5516*/	ItemTypeBook,			// skill-up tomes/books? (would probably need a pp flag if true...)
-			/*5517*/ ItemTypeNote,
+/*5517*/	ItemTypeNote,
-			/*5518*/ ItemTypeKey,
+/*5518*/	ItemTypeKey,
-			/*----*/ ItemTypeCoin,
+/*----*/	ItemTypeCoin,
-			/*5520*/ ItemType2HPiercing,          // 35
+/*5520*/	ItemType2HPiercing, // 35
-			/*----*/ ItemTypeFishingPole,
+/*----*/	ItemTypeFishingPole,
-			/*----*/ ItemTypeFishingBait,
+/*----*/	ItemTypeFishingBait,
-			/*5519*/ ItemTypeAlcohol,
+/*5519*/	ItemTypeAlcohol,
-			/*----*/ ItemTypeKey2,                // keys and satchels?? (questable keys?)
+/*----*/	ItemTypeKey2,			// keys and satchels?? (questable keys?)
-			/*----*/ ItemTypeCompass,             // 40
+/*----*/	ItemTypeCompass, // 40
-			/*----*/ ItemTypeUnknown5,
+/*----*/	ItemTypeUnknown5,
-			/*----*/ ItemTypePoison,              // might be wrong, but includes poisons
+/*----*/	ItemTypePoison,			// might be wrong, but includes poisons
-			/*----*/ ItemTypeUnknown6,
+/*----*/	ItemTypeUnknown6,
-			/*----*/ ItemTypeUnknown7,
+/*----*/	ItemTypeUnknown7,
-			/*5522*/ ItemTypeMartial,             // 45
+/*5522*/	ItemTypeMartial, // 45
-			/*----*/ ItemTypeAllEffects,
+/*----*/	ItemTypeUnknown8,
-			/*----*/ ItemTypeUnknown9,
+/*----*/	ItemTypeUnknown9,
-			/*----*/ ItemTypeUnknown10,
+/*----*/	ItemTypeUnknown10,
-			/*----*/ ItemTypeFocusEffect,
+/*----*/	ItemTypeUnknown11,
-			/*----*/ ItemTypeSinging,             // 50
+/*----*/	ItemTypeSinging, // 50
-			/*5750*/ ItemTypeAllInstrumentTypes,
+/*5750*/	ItemTypeAllInstrumentTypes,
-			/*5776*/ ItemTypeCharm,
+/*5776*/	ItemTypeCharm,
-			/*----*/ ItemTypeDye,
+/*----*/	ItemTypeDye,
-			/*----*/ ItemTypeAugmentation,
+/*----*/	ItemTypeAugmentation,
-			/*----*/ ItemTypeAugmentationSolvent, // 55
+/*----*/	ItemTypeAugmentationSolvent, // 55
-			/*----*/ ItemTypeAugmentationDistiller,
+/*----*/	ItemTypeAugmentationDistiller,
-			/*----*/ ItemTypeAlternateAbility,
+/*----*/	ItemTypeUnknown12,
-			/*----*/ ItemTypeFellowshipKit,
+/*----*/	ItemTypeFellowshipKit,
-			/*----*/ ItemTypeUnknown13,
+/*----*/	ItemTypeUnknown13,
-			/*----*/ ItemTypeRecipe,              // 60
+/*----*/	ItemTypeRecipe, // 60
-			/*----*/ ItemTypeAdvancedRecipe,
+/*----*/	ItemTypeAdvancedRecipe,
-			/*----*/ ItemTypeJournal,             // only one(1) database entry
+/*----*/	ItemTypeJournal,		// only one(1) database entry
-			/*----*/ ItemTypeAltCurrency,         // alt-currency (as opposed to coinage)
+/*----*/	ItemTypeAltCurrency,	// alt-currency (as opposed to coinage)
-			/*5881*/ ItemTypePerfectedAugmentationDistiller,
+/*5881*/	ItemTypePerfectedAugmentationDistiller,
-			/*----*/ ItemTypeCount,
+/*----*/	ItemTypeCount
-			/*----*/ ItemTypeCollectible,
-			/*----*/ ItemTypeContainer,
-			/*----*/ ItemTypeAll     = 0xFF
 
 /*
 			Unknowns:

common/item_instance.cpp

@@ -303,34 +303,47 @@ int8 EQ::ItemInstance::AvailableAugmentSlot(int32 augment_type) const
 		return INVALID_INDEX;
 	}
 
-	for (int16 slot_id = invaug::SOCKET_BEGIN; slot_id <= invaug::SOCKET_END; ++slot_id) {
+	auto i = invaug::SOCKET_BEGIN;
-		if (IsAugmentSlotAvailable(augment_type, slot_id)) {
+	for (; i <= invaug::SOCKET_END; ++i) {
-			return slot_id;
+		if (GetItem(i)) {
+			continue;
+		}
+
+		if (
+			augment_type == -1 ||
+			(
+				m_item->AugSlotType[i] &&
+				((1 << (m_item->AugSlotType[i] - 1)) & augment_type)
+			)
+		) {
+			break;
 		}
 	}
 
-	return INVALID_INDEX;
+	return (i <= invaug::SOCKET_END) ? i : INVALID_INDEX;
 }
 
 bool EQ::ItemInstance::IsAugmentSlotAvailable(int32 augment_type, uint8 slot) const
 {
-	if (!m_item || !m_item->IsClassCommon() || GetItem(slot)) {
+	if (!m_item || !m_item->IsClassCommon()) {
 		return false;
 	}
 
-	return (
+	if (
 		(
+			!GetItem(slot) &&
+			m_item->AugSlotVisible[slot]
+		) &&
 		augment_type == -1 ||
 		(
 			m_item->AugSlotType[slot] &&
 			((1 << (m_item->AugSlotType[slot] - 1)) & augment_type)
 		)
-		) &&
+	) {
-		(
+		return true;
-			RuleB(Items, AugmentItemAllowInvisibleAugments) ||
+	}
-			m_item->AugSlotVisible[slot]
+
-		)
+	return false;
-	);
 }
 
 // Retrieve item inside container
@@ -1279,7 +1292,7 @@ int EQ::ItemInstance::GetItemBaneDamageRace(bool augments) const
 	return race;
 }
 
-int EQ::ItemInstance::GetItemBaneDamageBody(uint8 against, bool augments) const
+int EQ::ItemInstance::GetItemBaneDamageBody(bodyType against, bool augments) const
 {
 	int64 damage = 0;
 	const auto item = GetItem();
@@ -1799,142 +1812,6 @@ std::vector<uint32> EQ::ItemInstance::GetAugmentIDs() const
 	return augments;
 }
 
-int EQ::ItemInstance::GetItemRegen(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->Regen;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemRegen();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemManaRegen(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->ManaRegen;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemManaRegen();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemDamageShield(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->DamageShield;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemDamageShield();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemDSMitigation(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->DSMitigation;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemDSMitigation();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemHealAmt(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->HealAmt;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemHealAmt();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemSpellDamage(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->SpellDmg;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemSpellDamage();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemClairvoyance(bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->Clairvoyance;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemClairvoyance();
-				}
-			}
-		}
-	}
-	return stat;
-}
-
-int EQ::ItemInstance::GetItemSkillsStat(EQ::skills::SkillType skill, bool augments) const
-{
-	int        stat = 0;
-	const auto item = GetItem();
-	if (item) {
-		stat = item->ExtraDmgSkill == skill ? item->ExtraDmgAmt : 0;
-		if (augments) {
-			for (int i = invaug::SOCKET_BEGIN; i <= invaug::SOCKET_END; ++i) {
-				if (GetAugment(i)) {
-					stat += GetAugment(i)->GetItemSkillsStat(skill);
-				}
-			}
-		}
-	}
-	return stat;
-}
-
 //
 // class EvolveInfo
 //

common/item_instance.h

@@ -265,12 +265,11 @@ namespace EQ
 		// these two are just quick checks
 		int GetItemBaneDamageBody(bool augments = false) const;
 		int GetItemBaneDamageRace(bool augments = false) const;
-		int GetItemBaneDamageBody(uint8 against, bool augments = false) const;
+		int GetItemBaneDamageBody(bodyType against, bool augments = false) const;
 		int GetItemBaneDamageRace(uint16 against, bool augments = false) const;
 		int GetItemMagical(bool augments = false) const;
 		int GetItemHP(bool augments = false) const;
 		int GetItemMana(bool augments = false) const;
-		int GetItemManaRegen(bool augments = false) const;
 		int GetItemEndur(bool augments = false) const;
 		int GetItemAttack(bool augments = false) const;
 		int GetItemStr(bool augments = false) const;
@@ -300,13 +299,6 @@ namespace EQ
 		int GetItemHeroicDR(bool augments = false) const;
 		int GetItemHeroicCorrup(bool augments = false) const;
 		int GetItemHaste(bool augments = false) const;
-		int GetItemRegen(bool augments = false) const;
-		int GetItemDamageShield(bool augments = false) const;
-		int GetItemDSMitigation(bool augments = false) const;
-		int GetItemHealAmt(bool augments = false) const;
-		int GetItemSpellDamage(bool augments = false) const;
-		int GetItemClairvoyance(bool augments = false) const;
-		int GetItemSkillsStat(EQ::skills::SkillType skill, bool augments = false) const;
 		uint32 GetItemGuildFavor() const;
 		std::vector<uint32> GetAugmentIDs() const;
 

common/patches/rof.cpp

@@ -3089,6 +3089,21 @@ namespace RoF
 		FINISH_ENCODE();
 	}
 
+	ENCODE(OP_ShopRequest)
+	{
+		ENCODE_LENGTH_EXACT(Merchant_Click_Struct);
+		SETUP_DIRECT_ENCODE(Merchant_Click_Struct, structs::Merchant_Click_Struct);
+
+		OUT(npcid);
+		OUT(playerid);
+		OUT(command);
+		OUT(rate);
+		eq->unknown01 = 3;	// Not sure what these values do yet, but list won't display without them
+		eq->unknown02 = 2592000;
+
+		FINISH_ENCODE();
+	}
+
 	ENCODE(OP_SkillUpdate)
 	{
 		ENCODE_LENGTH_EXACT(SkillUpdate_Struct);
@@ -3494,13 +3509,14 @@ namespace RoF
 			ENCODE_LENGTH_EXACT(ClickTrader_Struct);
 			SETUP_DIRECT_ENCODE(ClickTrader_Struct, structs::ClickTrader_Struct);
 
-			eq->Code = emu->action;
+			eq->Code = emu->Code;
-			for (uint32 i = 0; i < RoF::invtype::BAZAAR_SIZE; i++)
+			// Live actually has 200 items now, but 80 is the most our internal struct supports
+			for (uint32 i = 0; i < 200; i++)
 			{
 				strncpy(eq->items[i].SerialNumber, "0000000000000000", sizeof(eq->items[i].SerialNumber));
 				eq->items[i].Unknown18 = 0;
 				if (i < 80) {
-					eq->ItemCost[i] = emu->item_cost[i];
+					eq->ItemCost[i] = emu->ItemCost[i];
 				}
 				else {
 					eq->ItemCost[i] = 0;
@@ -3514,9 +3530,9 @@ namespace RoF
 			ENCODE_LENGTH_EXACT(Trader_ShowItems_Struct);
 			SETUP_DIRECT_ENCODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
 
-			eq->Code = emu->action;
+			eq->Code = emu->Code;
 			strncpy(eq->SerialNumber, "0000000000000000", sizeof(eq->SerialNumber));
-			eq->TraderID = emu->entity_id;
+			eq->TraderID = emu->TraderID;
 			eq->Stacksize = 0;
 			eq->Price = 0;
 
@@ -3542,13 +3558,13 @@ namespace RoF
 		ENCODE_LENGTH_EXACT(TraderBuy_Struct);
 		SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 
-		OUT(action);
+		OUT(Action);
-		OUT(price);
+		OUT(Price);
-		OUT(trader_id);
+		OUT(TraderID);
-		memcpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
+		memcpy(eq->ItemName, emu->ItemName, sizeof(eq->ItemName));
-		OUT(item_id);
+		OUT(ItemID);
-		OUT(quantity);
+		OUT(Quantity);
-		OUT(already_sold);
+		OUT(AlreadySold);
 
 		FINISH_ENCODE();
 	}
@@ -5031,6 +5047,19 @@ namespace RoF
 		FINISH_DIRECT_DECODE();
 	}
 
+	DECODE(OP_ShopRequest)
+	{
+		DECODE_LENGTH_EXACT(structs::Merchant_Click_Struct);
+		SETUP_DIRECT_DECODE(Merchant_Click_Struct, structs::Merchant_Click_Struct);
+
+		IN(npcid);
+		IN(playerid);
+		IN(command);
+		IN(rate);
+
+		FINISH_DIRECT_DECODE();
+	}
+
 	DECODE(OP_Trader)
 	{
 		uint32 psize = __packet->size;
@@ -5040,11 +5069,12 @@ namespace RoF
 			SETUP_DIRECT_DECODE(ClickTrader_Struct, structs::ClickTrader_Struct);
 			MEMSET_IN(ClickTrader_Struct);
 
-			emu->action = eq->Code;
+			emu->Code = eq->Code;
-			for (uint32 i = 0; i < RoF::invtype::BAZAAR_SIZE; i++)
+			// Live actually has 200 items now, but 80 is the most our internal struct supports
+			for (uint32 i = 0; i < 80; i++)
 			{
-				emu->serial_number[i] = 0;    // eq->SerialNumber[i];
+				emu->SerialNumber[i] = 0;	// eq->SerialNumber[i];
-				emu->item_cost[i]     = eq->ItemCost[i];
+				emu->ItemCost[i] = eq->ItemCost[i];
 			}
 
 			FINISH_DIRECT_DECODE();
@@ -5055,8 +5085,8 @@ namespace RoF
 			SETUP_DIRECT_DECODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
 			MEMSET_IN(Trader_ShowItems_Struct);
 
-			emu->action = eq->Code;
+			emu->Code = eq->Code;
-			emu->entity_id = eq->TraderID;
+			emu->TraderID = eq->TraderID;
 
 			FINISH_DIRECT_DECODE();
 		}
@@ -5078,12 +5108,12 @@ namespace RoF
 		SETUP_DIRECT_DECODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 		MEMSET_IN(TraderBuy_Struct);
 
-		IN(action);
+		IN(Action);
-		IN(price);
+		IN(Price);
-		IN(trader_id);
+		IN(TraderID);
-		memcpy(emu->item_name, eq->item_name, sizeof(emu->item_name));
+		memcpy(emu->ItemName, eq->ItemName, sizeof(emu->ItemName));
-		IN(item_id);
+		IN(ItemID);
-		IN(quantity);
+		IN(Quantity);
 
 		FINISH_DIRECT_DECODE();
 	}

common/patches/rof2_limits.h

@@ -271,7 +271,6 @@ namespace RoF2
 		const size_t CHARACTER_CREATION_LIMIT = 12;
 
 		const size_t SAY_LINK_BODY_SIZE = 56;
-		const uint32 MAX_GUILD_ID       = 50000;
 
 	} /*constants*/
 

common/patches/rof2_ops.h

@@ -43,7 +43,6 @@ E(OP_ApplyPoison)
 E(OP_AugmentInfo)
 E(OP_Barter)
 E(OP_BazaarSearch)
-E(OP_BecomeTrader)
 E(OP_BeginCast)
 E(OP_BlockedBuffs)
 E(OP_Buff)
@@ -117,6 +116,7 @@ E(OP_SendZonepoints)
 E(OP_SetGuildRank)
 E(OP_ShopPlayerBuy)
 E(OP_ShopPlayerSell)
+E(OP_ShopRequest)
 E(OP_SkillUpdate)
 E(OP_SomeItemPacketMaybe)
 E(OP_SpawnAppearance)
@@ -200,7 +200,7 @@ D(OP_Save)
 D(OP_SetServerFilter)
 D(OP_ShopPlayerBuy)
 D(OP_ShopPlayerSell)
-D(OP_ShopSendParcel)
+D(OP_ShopRequest)
 D(OP_Trader)
 D(OP_TraderBuy)
 D(OP_TradeSkillCombine)

common/patches/rof2_structs.h

@@ -2247,17 +2247,15 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct
+struct Merchant_Click_Struct {
-{
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-    /*000*/ uint32 npc_id;      // Merchant NPC's entity id
+/*004*/ uint32	playerid;
-    /*004*/ uint32 player_id;
+/*008*/ uint32	command;		// 1=open, 0=cancel/close
-    /*008*/ uint32 command;     // 1=open, 0=cancel/close
+/*012*/ float	rate;			// cost multiplier, dosent work anymore
-    /*012*/ float  rate;        // cost multiplier, dosent work anymore
+/*016*/ int32	unknown01;		// Seen 3 from Server or -1 from Client
-    /*016*/ int32  tab_display; // bitmask b000 none, b001 Purchase/Sell, b010 Recover, b100 Parcels
+/*020*/ int32	unknown02;		// Seen 2592000 from Server or -1 from Client
-    /*020*/ int32  unknown02;   // Seen 2592000 from Server or -1 from Client
+/*024*/
-    /*024*/
 };
-
 /*
 Unknowns:
 0 is e7 from 01 to // MAYBE SLOT IN PURCHASE
@@ -3106,21 +3104,6 @@ struct EnvDamage2_Struct {
 };
 
 //Bazaar Stuff
-enum RoF2BazaarTraderBuyerActions {
-	Zero            = 0,
-	BeginTraderMode = 1,
-	EndTraderMode   = 2,
-	PriceUpdate     = 3,
-	EndTransaction  = 4,
-	BazaarSearch    = 7,
-	WelcomeMessage  = 9,
-	BuyTraderItem   = 10,
-	ListTraderItems = 11,
-	BazaarInspect   = 18,
-	ClickTrader     = 28,
-	ItemMove        = 19,
-	ReconcileItems  = 20
-};
 
 enum {
 	BazaarTrader_StartTraderMode = 1,
@@ -3151,51 +3134,34 @@ struct BazaarWindowStart_Struct {
 	uint16  Unknown002;
 };
 
-struct BazaarDeliveryCost_Struct {
-	uint32 action;
-	uint32 voucher_delivery_cost;
-	float  parcel_deliver_cost; //percentage of item cost
-	uint32 unknown_010;
-};
 
 struct BazaarWelcome_Struct {
-	uint32 action;
+	uint32 Code;
-	uint32 unknown_004;
+	uint32 EntityID;
-	uint32 num_of_traders;
+	uint32 Traders;
-	uint32 num_of_items;
+	uint32 Items;
+	uint32 Traders2;
+	uint32 Items2;
 };
 
 struct BazaarSearch_Struct {
-/*000*/ uint32 action;
+	BazaarWindowStart_Struct Beginning;
-/*004*/ uint8  search_scope;//1 all traders 0 local traders
+	uint32	TraderID;
-/*005*/ uint8  unknown_005{0};
+	uint32	Class_;
-/*006*/ uint16 unknown_006{0};
+	uint32	Race;
-/*008*/ uint32 unknown_008{0};
+	uint32	ItemStat;
-/*012*/ uint32 unknown_012{0};
+	uint32	Slot;
-/*016*/ uint32 trader_id;
+	uint32	Type;
-/*020*/ uint32 _class;
+	char	Name[64];
-/*024*/ uint32 race;
+	uint32	MinPrice;
-/*028*/ uint32 item_stat;
+	uint32	MaxPrice;
-/*032*/ uint32 slot;
+	uint32	Minlevel;
-/*036*/ uint32 type;
+	uint32	MaxLlevel;
-/*040*/ char   item_name[64];
-/*104*/ uint32 min_cost;
-/*108*/ uint32 max_cost;
-/*112*/ uint32 min_level;
-/*116*/ uint32 max_level;
-/*120*/ uint32 max_results;
-/*124*/ uint32 prestige;
-/*128*/ uint32 augment;
 };
-
+struct BazaarInspect_Struct{
-struct BazaarInspect_Struct {
+	uint32 ItemID;
-	uint32 action;
+	uint32 Unknown004;
-	uint32 unknown_004;
+	char Name[64];
-	uint32 trader_id;
-	char   serial_number[17];
-	char   unknown_029[3];
-	uint32 item_id;
-	uint32 unknown_036;
 };
 
 struct NewBazaarInspect_Struct {
@@ -3216,23 +3182,18 @@ struct BazaarReturnDone_Struct{
 	uint32 Unknown016;
 };
 
-struct BazaarSearchDetails_Struct { //24+name+17
+struct BazaarSearchResults_Struct {
-/*014*/	uint32	trader_id;
+/*000*/	BazaarWindowStart_Struct Beginning;
-/*018*/	char	serial_num[17];
+/*004*/	uint32	SellerID;
-/*022*/	uint32	cost;
+/*008*/	char	SellerName[64];
-/*026*/	uint32	quanity;
+/*072*/	uint32	NumItems;
-/*030*/	uint32	id;
+/*076*/	uint32	ItemID;
-/*034*/	uint32	icon;
+/*080*/	uint32	SerialNumber;
-/*038*/	char	name[1];
+/*084*/	uint32	Unknown084;
-/*039*/	uint32	stat;
+/*088*/	char	ItemName[64];
-};
+/*152*/	uint32	Cost;
-
+/*156*/	uint32	ItemStat;
-struct BazaarSearchResults_Struct { //14
+/*160*/
-/*000*/    uint32                     unknown000;
-/*004*/    uint16                     zone_id;
-/*006*/    uint32                     entity_id;
-/*010*/    uint32                     num_items;
-/*014*/    BazaarSearchDetails_Struct items[];
 };
 
 struct ServerSideFilters_Struct {
@@ -3435,26 +3396,21 @@ struct	WhoAllPlayerPart4 {
 };
 
 struct TraderItemSerial_Struct {
-	char	serial_number[17];
+	char	SerialNumber[17];
-	uint8	unknown_018;
+	uint8	Unknown18;
-
-	void operator=(uint32 a) {
-		auto _tmp = fmt::format("{:016}", a);
-		strn0cpy(this->serial_number, _tmp.c_str(), sizeof(this->serial_number));
-	}
 };
 
-struct BeginTrader_Struct {
+struct Trader_Struct {
-/*0000*/    uint32                  action;
+/*0000*/	uint32	Code;
 /*0004*/	TraderItemSerial_Struct	items[200];
-/*3604*/    uint32                  item_cost[200];
+/*3604*/	uint32	ItemCost[200];
 /*4404*/
 };
 
 struct ClickTrader_Struct {
-/*0000*/    uint32                  action;
+/*0000*/	uint32	Code;
 /*0004*/	TraderItemSerial_Struct	items[200];
-/*3604*/    uint32                  item_cost[200];
+/*3604*/	uint32	ItemCost[200];
 /*4404*/
 };
 
@@ -3463,55 +3419,67 @@ struct GetItems_Struct {
 };
 
 struct BecomeTrader_Struct {
-	uint32 entity_id;
+	uint32 id;
-	uint32 action;
+	uint32 code;
-};
-
-struct BazaarWindowRemoveTrader_Struct {
-	uint32 action;
-	uint32 trader_id;
-};
-
-struct TraderPriceUpdate_Struct {
-	uint32 action;
-	char   serial_number[17];
-	char   unknown_021[3];
-	uint32 unknown_024;
-	uint32 new_price;
 };
 
 struct Trader_ShowItems_Struct {
-/*000*/	uint32 action;
+	/*000*/	uint32 Code;
-/*004*/	uint32 entity_id;
+	/*004*/	uint16 TraderID;
-/*008*/	uint32 unknown_008;
+	/*008*/	uint32 Unknown08;
-/*012*/
+	/*012*/
+};
+
+struct Trader_ShowItems_Struct_WIP {
+/*000*/	uint32 Code;
+/*004*/	char   SerialNumber[17];
+/*021*/	uint8  Unknown21;
+/*022*/	uint16 TraderID;
+/*026*/	uint32 Stacksize;
+/*030*/	uint32 Price;
+/*032*/
 };
 
 struct TraderStatus_Struct {
-/*000*/	uint32 action;
+/*000*/	uint32 Code;
-/*004*/	uint32 sub_action;
+/*004*/	uint32 Uknown04;
-/*008*/	uint32 uknown_008;
+/*008*/	uint32 Uknown08;
 /*012*/
 };
 
 struct TraderBuy_Struct {
-/*000*/ uint32	action;
+	/*000*/ uint32	Action;
-/*004*/	uint32	method;
+	/*004*/	uint32	Unknown004;
-/*008*/ uint32	sub_action;
+	/*008*/ uint32	Unknown008;
-/*012*/	uint32	unknown_012;
+	/*012*/	uint32	Unknown012;
-/*016*/ uint32	trader_id;
+	/*016*/ uint32	TraderID;
-/*020*/ char	buyer_name[64];
+	/*020*/ char	BuyerName[64];
-/*084*/ char	seller_name[64];
+	/*084*/ char	SellerName[64];
-/*148*/ char	unknown_148[32];
+	/*148*/ char	Unknown148[32];
-/*180*/ char	item_name[64];
+	/*180*/ char	ItemName[64];
-/*244*/ char	serial_number[17];
+	/*244*/ char	SerialNumber[16];
-/*261*/ char	unknown_261[3];
+	/*260*/ uint32	Unknown076;
-/*264*/ uint32	item_id;
+	/*264*/ uint32	ItemID;
-/*268*/ uint32	price;
+	/*268*/ uint32	Price;
-/*272*/ uint32	already_sold;
+	/*272*/ uint32	AlreadySold;
-/*276*/ uint32	unknown_276;
+	/*276*/ uint32	Unknown276;
-/*280*/ uint32	quantity;
+	/*280*/ uint32	Quantity;
-/*284*/
+	/*284*/
+};
+
+struct TraderBuy_Struct_OLD {
+/*000*/ uint32   Action;
+/*004*/	uint32	Unknown004;
+/*008*/ uint32   Price;
+/*012*/	uint32	Unknown008;	// Probably high order bits of a 64 bit price.
+/*016*/ uint32   TraderID;
+/*020*/ char    ItemName[64];
+/*084*/ uint32   Unknown076;
+/*088*/ uint32   ItemID;
+/*092*/ uint32   AlreadySold;
+/*096*/ uint32   Quantity;
+/*100*/ uint32   Unknown092;
+/*104*/
 };
 
 struct TraderItemUpdate_Struct{
@@ -3532,15 +3500,15 @@ struct MoneyUpdate_Struct{
 struct TraderDelItem_Struct{
 	/*000*/ uint32 Unknown000;
 	/*004*/ uint32 TraderID;
-	/*008*/ char   SerialNumber[17];
+	/*008*/ char   SerialNumber[16];
 	/*024*/ uint32 Unknown012;
 	/*028*/
 };
 
 struct TraderClick_Struct{
-	/*000*/	uint32 action;
+	/*000*/	uint32 Code;
-	/*004*/	uint32 trader_id;
+	/*004*/	uint32 TraderID;
-	/*008*/	uint32 unknown_008;
+	/*008*/	uint32 Approval;
 	/*012*/
 };
 
@@ -4604,24 +4572,24 @@ struct RoF2SlotStruct
 
 struct ItemSerializationHeader
 {
-    /*000*/ char   unknown000[17]; // New for HoT. Looks like a string.
+/*000*/	char unknown000[17];	// New for HoT. Looks like a string.
-    /*017*/ uint32 stacksize;
+/*017*/	uint32 stacksize;
-    /*021*/ uint32 unknown004;
+/*021*/	uint32 unknown004;
-    /*025*/ uint8  slot_type;      // 0 = normal, 1 = bank, 2 = shared bank, 9 = merchant, 20 = ?
+/*025*/	uint8  slot_type;	// 0 = normal, 1 = bank, 2 = shared bank, 9 = merchant, 20 = ?
-    /*026*/ uint16 main_slot;
+/*026*/	uint16 main_slot;
-    /*028*/ uint16 sub_slot;
+/*028*/ uint16 sub_slot;
-    /*030*/ uint16 aug_slot;       // 0xffff
+/*030*/ uint16 aug_slot;	// 0xffff
-    /*032*/ uint32 price;
+/*032*/	uint32 price;
-    /*036*/ uint32 merchant_slot;  // 1 if not a merchant item
+/*036*/	uint32 merchant_slot; //1 if not a merchant item
-    /*040*/ uint32 scaled_value;   // 0
+/*040*/	uint32 scaled_value; //0
-    /*044*/ uint32 instance_id;    // unique instance id if not merchant item, else is merchant slot
+/*044*/	uint32 instance_id; //unique instance id if not merchant item, else is merchant slot
-    /*048*/ uint32 parcel_item_id; 
+/*048*/	uint32 unknown028; //0
-    /*052*/ uint32 last_cast_time; // Unix Time from PP of last cast for this recast type if recast delay > 0
+/*052*/	uint32 last_cast_time;	// Unix Time from PP of last cast for this recast type if recast delay > 0
-    /*056*/ uint32 charges;        // Total Charges an item has (-1 for unlimited)
+/*056*/	uint32 charges; //Total Charges an item has (-1 for unlimited)
-    /*060*/ uint32 inst_nodrop;    // 1 if the item is no drop (attuned items)
+/*060*/	uint32 inst_nodrop;	// 1 if the item is no drop (attuned items)
-    /*064*/ uint32 unknown044;     // 0
+/*064*/	uint32 unknown044;	// 0
-    /*068*/ uint32 unknown048;     // 0
+/*068*/	uint32 unknown048;	// 0
-    /*072*/ uint32 unknown052;     // 0
+/*072*/	uint32 unknown052;	// 0
 		uint8 isEvolving;
 };
 
@@ -5293,18 +5261,6 @@ struct Checksum_Struct {
     uint8_t  data[2048];
 };
 
-struct Parcel_Struct
-{
-    /*000*/ uint32                       npc_id;
-    /*004*/ TypelessInventorySlot_Struct inventory_slot;
-    /*012*/ uint32                       quantity;
-    /*016*/ uint32                       money_flag;
-    /*020*/ char                         send_to[64];
-    /*084*/ char                         note[128];
-    /*212*/ uint32                       unknown_212;
-    /*216*/ uint32                       unknown_216;
-    /*220*/ uint32                       unknown_220;
-};
 	}; /*structs*/
 
 }; /*RoF2*/

common/patches/rof_ops.h

@@ -101,6 +101,7 @@ E(OP_SendZonepoints)
 E(OP_SetGuildRank)
 E(OP_ShopPlayerBuy)
 E(OP_ShopPlayerSell)
+E(OP_ShopRequest)
 E(OP_SkillUpdate)
 E(OP_SomeItemPacketMaybe)
 E(OP_SpawnAppearance)
@@ -182,6 +183,7 @@ D(OP_Save)
 D(OP_SetServerFilter)
 D(OP_ShopPlayerBuy)
 D(OP_ShopPlayerSell)
+D(OP_ShopRequest)
 D(OP_Trader)
 D(OP_TraderBuy)
 D(OP_TradeSkillCombine)

common/patches/rof_structs.h

@@ -2200,17 +2200,15 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct
+struct Merchant_Click_Struct {
-{
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-    /*000*/ uint32 npc_id;      // Merchant NPC's entity id
+/*004*/ uint32	playerid;
-    /*004*/ uint32 player_id;
+/*008*/ uint32	command;		// 1=open, 0=cancel/close
-    /*008*/ uint32 command;     // 1=open, 0=cancel/close
+/*012*/ float	rate;			// cost multiplier, dosent work anymore
-    /*012*/ float  rate;        // cost multiplier, dosent work anymore
+/*016*/ int32	unknown01;		// Seen 3 from Server or -1 from Client
-    /*016*/ int32  tab_display; // bitmask b000 none, b001 Purchase/Sell, b010 Recover, b100 Parcels
+/*020*/ int32	unknown02;		// Seen 2592000 from Server or -1 from Client
-    /*020*/ int32  unknown020;  // Seen 2592000 from Server or -1 from Client
+/*024*/
-    /*024*/
 };
-
 /*
 Unknowns:
 0 is e7 from 01 to // MAYBE SLOT IN PURCHASE
@@ -3376,17 +3374,17 @@ struct TraderStatus_Struct {
 };
 
 struct TraderBuy_Struct {
-/*000*/ uint32  action;
+/*000*/ uint32   Action;
-/*004*/	uint32	unknown_004;
+/*004*/	uint32	Unknown004;
-/*008*/ uint32  price;
+/*008*/ uint32   Price;
-/*012*/	uint32	unknown_008;	// Probably high order bits of a 64 bit price.
+/*012*/	uint32	Unknown008;	// Probably high order bits of a 64 bit price.
-/*016*/ uint32  trader_id;
+/*016*/ uint32   TraderID;
-/*020*/ char    item_name[64];
+/*020*/ char    ItemName[64];
-/*084*/ uint32  unknown_076;
+/*084*/ uint32   Unknown076;
-/*088*/ uint32  item_id;
+/*088*/ uint32   ItemID;
-/*092*/ uint32  already_sold;
+/*092*/ uint32   AlreadySold;
-/*096*/ uint32  quantity;
+/*096*/ uint32   Quantity;
-/*100*/ uint32  unknown_092;
+/*100*/ uint32   Unknown092;
 /*104*/
 };
 

common/patches/sod.cpp

@@ -2026,19 +2026,6 @@ namespace SoD
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_ShopRequest)
-	{
-		ENCODE_LENGTH_EXACT(MerchantClick_Struct);
-		SETUP_DIRECT_ENCODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		OUT(npc_id);
-		OUT(player_id);
-		OUT(command);
-		OUT(rate);
-
-		FINISH_ENCODE();
-	}
-
 	ENCODE(OP_SomeItemPacketMaybe)
 	{
 		// This Opcode is not named very well. It is used for the animation of arrows leaving the player's bow
@@ -2286,13 +2273,13 @@ namespace SoD
 		ENCODE_LENGTH_EXACT(TraderBuy_Struct);
 		SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 
-		OUT(action);
+		OUT(Action);
-		OUT(price);
+		OUT(Price);
-		OUT(trader_id);
+		OUT(TraderID);
-		memcpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
+		memcpy(eq->ItemName, emu->ItemName, sizeof(eq->ItemName));
-		OUT(item_id);
+		OUT(ItemID);
-		OUT(quantity);
+		OUT(Quantity);
-		OUT(already_sold);
+		OUT(AlreadySold);
 
 		FINISH_ENCODE();
 	}
@@ -3496,33 +3483,18 @@ namespace SoD
 		FINISH_DIRECT_DECODE();
 	}
 
-	DECODE(OP_ShopRequest)
-	{
-		DECODE_LENGTH_EXACT(structs::MerchantClick_Struct);
-		SETUP_DIRECT_DECODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		IN(npc_id);
-		IN(player_id);
-		IN(command);
-		IN(rate);
-		emu->tab_display = 0;
-		emu->unknown020 = 0;
-
-		FINISH_DIRECT_DECODE();
-	}
-
 	DECODE(OP_TraderBuy)
 	{
 		DECODE_LENGTH_EXACT(structs::TraderBuy_Struct);
 		SETUP_DIRECT_DECODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 		MEMSET_IN(TraderBuy_Struct);
 
-		IN(action);
+		IN(Action);
-		IN(price);
+		IN(Price);
-		IN(trader_id);
+		IN(TraderID);
-		memcpy(emu->item_name, eq->item_name, sizeof(emu->item_name));
+		memcpy(emu->ItemName, eq->ItemName, sizeof(emu->ItemName));
-		IN(item_id);
+		IN(ItemID);
-		IN(quantity);
+		IN(Quantity);
 
 		FINISH_DIRECT_DECODE();
 	}

common/patches/sod_ops.h

@@ -78,7 +78,6 @@ E(OP_SendCharInfo)
 E(OP_SendZonepoints)
 E(OP_ShopPlayerBuy)
 E(OP_ShopPlayerSell)
-E(OP_ShopRequest)
 E(OP_SomeItemPacketMaybe)
 E(OP_SpawnDoor)
 E(OP_SpecialMesg)
@@ -142,7 +141,6 @@ D(OP_Save)
 D(OP_SetServerFilter)
 D(OP_ShopPlayerBuy)
 D(OP_ShopPlayerSell)
-D(OP_ShopRequest)
 D(OP_TraderBuy)
 D(OP_TradeSkillCombine)
 D(OP_TributeItem)

common/patches/sod_structs.h

@@ -1845,16 +1845,12 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct
+struct Merchant_Click_Struct {
-{
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-    /*000*/ uint32 npc_id;       // Merchant NPC's entity id
+/*004*/ uint32	playerid;
-    /*004*/ uint32 player_id;
+/*008*/ uint32	command;		//1=open, 0=cancel/close
-    /*008*/ uint32 command;     // 1=open, 0=cancel/close
+/*012*/ float	rate;			//cost multiplier, dosent work anymore
-    /*012*/ float  rate;        // cost multiplier, dosent work anymore
-    /*016*/ int32  tab_display; // bitmask b000 none, b001 Purchase/Sell, b010 Recover, b100 Parcels
-    /*020*/ int32  unknown020;  // Seen 2592000 from Server or -1 from Client
 };
-
 /*
 Unknowns:
 0 is e7 from 01 to // MAYBE SLOT IN PURCHASE
@@ -2879,21 +2875,20 @@ struct Trader_ShowItems_Struct{
 };
 
 struct TraderBuy_Struct {
-/*000*/ uint32  action;
+/*000*/ uint32   Action;
-/*004*/	uint32	unknown_004;
+/*004*/	uint32	Unknown004;
-/*008*/ uint32  price;
+/*008*/ uint32   Price;
-/*012*/	uint32	unknown_008;	// Probably high order bits of a 64 bit price.
+/*012*/	uint32	Unknown008;	// Probably high order bits of a 64 bit price.
-/*016*/ uint32  trader_id;
+/*016*/ uint32   TraderID;
-/*020*/ char    item_name[64];
+/*020*/ char    ItemName[64];
-/*084*/ uint32  unknown_076;
+/*084*/ uint32   Unknown076;
-/*088*/ uint32  item_id;
+/*088*/ uint32   ItemID;
-/*092*/ uint32  already_sold;
+/*092*/ uint32   AlreadySold;
-/*096*/ uint32  quantity;
+/*096*/ uint32   Quantity;
-/*100*/ uint32  unknown_092;
+/*100*/ uint32   Unknown092;
 /*104*/
 };
 
-
 struct TraderItemUpdate_Struct{
 	uint32 unknown0;
 	uint32 traderid;

common/patches/sof.cpp

@@ -270,8 +270,8 @@ namespace SoF
 		ENCODE_LENGTH_EXACT(BecomeTrader_Struct);
 		SETUP_DIRECT_ENCODE(BecomeTrader_Struct, structs::BecomeTrader_Struct);
 
-		OUT(trader_id);
+		OUT(ID);
-		OUT(action);
+		OUT(Code);
 
 		FINISH_ENCODE();
 	}
@@ -1683,19 +1683,6 @@ namespace SoF
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_ShopRequest)
-	{
-		ENCODE_LENGTH_EXACT(MerchantClick_Struct);
-		SETUP_DIRECT_ENCODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		OUT(npc_id);
-		OUT(player_id);
-		OUT(command);
-		OUT(rate);
-
-		FINISH_ENCODE();
-	}
-
 	ENCODE(OP_SomeItemPacketMaybe)
 	{
 		// This Opcode is not named very well. It is used for the animation of arrows leaving the player's bow
@@ -1902,13 +1889,13 @@ namespace SoF
 		ENCODE_LENGTH_EXACT(TraderBuy_Struct);
 		SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 
-		OUT(action);
+		OUT(Action);
-		OUT(price);
+		OUT(Price);
-		OUT(trader_id);
+		OUT(TraderID);
-		memcpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
+		memcpy(eq->ItemName, emu->ItemName, sizeof(eq->ItemName));
-		OUT(item_id);
+		OUT(ItemID);
-		OUT(quantity);
+		OUT(Quantity);
-		OUT(already_sold);
+		OUT(AlreadySold);
 
 		FINISH_ENCODE();
 	}
@@ -2349,7 +2336,7 @@ namespace SoF
 		DECODE_LENGTH_EXACT(structs::BugReport_Struct);
 		SETUP_DIRECT_DECODE(BugReport_Struct, structs::BugReport_Struct);
 
-		emu->category_id = Bug::GetID(eq->category_name);
+		emu->category_id = EQ::bug::CategoryNameToCategoryID(eq->category_name);
 		memcpy(emu->category_name, eq, sizeof(structs::BugReport_Struct));
 
 		FINISH_DIRECT_DECODE();
@@ -2887,33 +2874,18 @@ namespace SoF
 		FINISH_DIRECT_DECODE();
 	}
 
-	DECODE(OP_ShopRequest)
-	{
-		DECODE_LENGTH_EXACT(structs::MerchantClick_Struct);
-		SETUP_DIRECT_DECODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		IN(npc_id);
-		IN(player_id);
-		IN(command);
-		IN(rate);
-		emu->tab_display = 0;
-		emu->unknown020 = 0;
-
-		FINISH_DIRECT_DECODE();
-	}
-
 	DECODE(OP_TraderBuy)
 	{
 		DECODE_LENGTH_EXACT(structs::TraderBuy_Struct);
 		SETUP_DIRECT_DECODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 		MEMSET_IN(TraderBuy_Struct);
 
-		IN(action);
+		IN(Action);
-		IN(price);
+		IN(Price);
-		IN(trader_id);
+		IN(TraderID);
-		memcpy(emu->item_name, eq->item_name, sizeof(emu->item_name));
+		memcpy(emu->ItemName, eq->ItemName, sizeof(emu->ItemName));
-		IN(item_id);
+		IN(ItemID);
-		IN(quantity);
+		IN(Quantity);
 
 		FINISH_DIRECT_DECODE();
 	}

common/patches/sof_ops.h

@@ -72,7 +72,6 @@ E(OP_SendAATable)
 E(OP_SendCharInfo)
 E(OP_SendZonepoints)
 E(OP_ShopPlayerSell)
-E(OP_ShopRequest)
 E(OP_SomeItemPacketMaybe)
 E(OP_SpawnDoor)
 E(OP_SpecialMesg)
@@ -129,7 +128,6 @@ D(OP_ReadBook)
 D(OP_Save)
 D(OP_SetServerFilter)
 D(OP_ShopPlayerSell)
-D(OP_ShopRequest)
 D(OP_TraderBuy)
 D(OP_TradeSkillCombine)
 D(OP_TributeItem)

common/patches/sof_structs.h

@@ -1859,16 +1859,12 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct
+struct Merchant_Click_Struct {
-{
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-    /*000*/ uint32 npc_id;      // Merchant NPC's entity id
+/*004*/ uint32	playerid;
-    /*004*/ uint32 player_id;
+/*008*/ uint32	command;		//1=open, 0=cancel/close
-    /*008*/ uint32 command;     // 1=open, 0=cancel/close
+/*012*/ float	rate;			//cost multiplier, dosent work anymore
-    /*012*/ float  rate;        // cost multiplier, dosent work anymore
-    /*016*/ int32  tab_display; // bitmask b000 none, b001 Purchase/Sell, b010 Recover, b100 Parcels
-    /*020*/ int32  unknown020;  // Seen 2592000 from Server or -1 from Client
 };
-
 /*
 Unknowns:
 0 is e7 from 01 to // MAYBE SLOT IN PURCHASE
@@ -2771,8 +2767,8 @@ struct GetItems_Struct{
 };
 
 struct BecomeTrader_Struct{
-	uint32 trader_id;
+	uint32 ID;
-	uint32 action;
+	uint32 Code;
 };
 
 struct Trader_ShowItems_Struct{
@@ -2782,15 +2778,15 @@ struct Trader_ShowItems_Struct{
 };
 
 struct TraderBuy_Struct {
-/*000*/ uint32  action;
+/*000*/ uint32   Action;
-/*004*/ uint32  price;
+/*004*/ uint32   Price;
-/*008*/ uint32  trader_id;
+/*008*/ uint32   TraderID;
-/*012*/ char    item_name[64];
+/*012*/ char    ItemName[64];
-/*076*/ uint32  unknown_076;
+/*076*/ uint32   Unknown076;
-/*080*/ uint32  item_id;
+/*080*/ uint32   ItemID;
-/*084*/ uint32  already_sold;
+/*084*/ uint32   AlreadySold;
-/*088*/ uint32  quantity;
+/*088*/ uint32   Quantity;
-/*092*/ uint32  unknown_092;
+/*092*/ uint32   Unknown092;
 };
 
 struct TraderItemUpdate_Struct{

common/patches/ss_define.h

@@ -60,7 +60,7 @@
 	eq_struct *eq = (eq_struct *) __packet->pBuffer; \
 
 #define ALLOC_LEN_ENCODE(len) \
-	__packet->pBuffer = new unsigned char[len] {}; \
+	__packet->pBuffer = new unsigned char[len]; \
 	__packet->size = len; \
 	memset(__packet->pBuffer, 0, len); \
 
@@ -124,7 +124,7 @@
 #define SETUP_DIRECT_DECODE(emu_struct, eq_struct) \
 	unsigned char *__eq_buffer = __packet->pBuffer; \
 	__packet->size = sizeof(emu_struct); \
-	__packet->pBuffer = new unsigned char[__packet->size] {}; \
+	__packet->pBuffer = new unsigned char[__packet->size]; \
 	emu_struct *emu = (emu_struct *) __packet->pBuffer; \
 	eq_struct *eq = (eq_struct *) __eq_buffer;
 
@@ -133,7 +133,7 @@
 	eq_struct* in = (eq_struct*)__packet->pBuffer; \
 	auto size = strlen(in->var_field); \
 	__packet->size = sizeof(emu_struct) + size + 1; \
-	__packet->pBuffer = new unsigned char[__packet->size] {}; \
+	__packet->pBuffer = new unsigned char[__packet->size]; \
 	emu_struct *emu = (emu_struct *) __packet->pBuffer; \
 	eq_struct *eq = (eq_struct *) __eq_buffer;
 

common/patches/titanium.cpp

@@ -32,7 +32,6 @@
 #include "../strings.h"
 #include "../item_instance.h"
 #include "titanium_structs.h"
-#include "../rulesys.h"
 #include "../path_manager.h"
 #include "../raid.h"
 #include "../guilds.h"
@@ -198,135 +197,64 @@ namespace Titanium
 
 	ENCODE(OP_BazaarSearch)
 	{
+		if (((*p)->size == sizeof(BazaarReturnDone_Struct)) || ((*p)->size == sizeof(BazaarWelcome_Struct))) {
+
+			EQApplicationPacket *in = *p;
+			*p = nullptr;
+			dest->FastQueuePacket(&in, ack_req);
+			return;
+		}
+
+		//consume the packet
 		EQApplicationPacket *in = *p;
 		*p = nullptr;
 
-		uint32 action = *(uint32 *)in->pBuffer;
+		//store away the emu struct
+		unsigned char *__emu_buffer = in->pBuffer;
+		BazaarSearchResults_Struct *emu = (BazaarSearchResults_Struct *)__emu_buffer;
 
-		switch (action) {
+		//determine and verify length
-			case BazaarSearch: {
+		int entrycount = in->size / sizeof(BazaarSearchResults_Struct);
-				LogTrading(
+		if (entrycount == 0 || (in->size % sizeof(BazaarSearchResults_Struct)) != 0) {
-					"Encode OP_BazaarSearch(Ti) BazaarSearch action <green>[{}]",
+			Log(Logs::General, Logs::Netcode, "[STRUCTS] Wrong size on outbound %s: Got %d, expected multiple of %d",
-					action
+				opcodes->EmuToName(in->GetOpcode()), in->size, sizeof(BazaarSearchResults_Struct));
-				);
+			delete in;
-				std::vector<BazaarSearchResultsFromDB_Struct> results {};
+			return;
-				auto bsms = (BazaarSearchMessaging_Struct *)in->pBuffer;
-				EQ::Util::MemoryStreamReader ss(
-					reinterpret_cast<char *>(bsms->payload),
-					in->size - sizeof(BazaarSearchMessaging_Struct)
-				);
-				cereal::BinaryInputArchive ar(ss);
-				ar(results);
-
-				auto  size    = results.size() * sizeof(structs::BazaarSearchResults_Struct);
-				auto  buffer  = new uchar[size];
-				uchar *bufptr = buffer;
-				memset(buffer, 0, size);
-
-				for (auto row = results.begin(); row != results.end(); ++row) {
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, structs::TiBazaarTraderBuyerActions::BazaarSearch);
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, row->trader_entity_id);
-					bufptr += 4;
-					VARSTRUCT_ENCODE_TYPE(int32, bufptr, row->item_id);
-					VARSTRUCT_ENCODE_TYPE(int32, bufptr, row->serial_number);
-					bufptr += 4;
-					if (row->stackable) {
-						strn0cpy(
-							reinterpret_cast<char *>(bufptr),
-							fmt::format("{}({})", row->item_name.c_str(), row->charges).c_str(),
-							64
-						);
-					}
-					else {
-						strn0cpy(
-							reinterpret_cast<char *>(bufptr),
-							fmt::format("{}({})", row->item_name.c_str(), row->count).c_str(),
-							64
-						);
-					}
-					bufptr += 64;
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, row->cost);
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, row->item_stat);
 		}
 
-				auto outapp = new EQApplicationPacket(OP_BazaarSearch, size);
+		//make the EQ struct.
-				memcpy(outapp->pBuffer, buffer, size);
+		in->size = sizeof(structs::BazaarSearchResults_Struct)*entrycount;
-				dest->FastQueuePacket(&outapp);
+		in->pBuffer = new unsigned char[in->size];
+		structs::BazaarSearchResults_Struct *eq = (structs::BazaarSearchResults_Struct *) in->pBuffer;
 
-				safe_delete(outapp);
+		//zero out the packet. We could avoid this memset by setting all fields (including unknowns) in the loop.
-				safe_delete_array(buffer);
+		memset(in->pBuffer, 0, in->size);
-				safe_delete(in);
+
-				break;
+		for (int i = 0; i < entrycount; i++, eq++, emu++) {
+			eq->Beginning.Action = emu->Beginning.Action;
+			eq->Beginning.Unknown001 = emu->Beginning.Unknown001;
+			eq->Beginning.Unknown002 = emu->Beginning.Unknown002;
+			eq->NumItems = emu->NumItems;
+			eq->SerialNumber = emu->SerialNumber;
+			eq->SellerID = emu->SellerID;
+			eq->Cost = emu->Cost;
+			eq->ItemStat = emu->ItemStat;
+			strcpy(eq->ItemName, emu->ItemName);
 		}
-			case BazaarInspect:
+
-			case WelcomeMessage: {
+		delete[] __emu_buffer;
-				LogTrading(
-					"Encode OP_BazaarSearch(Ti) BazaarInspect/WelcomeMessage action <green>[{}]",
-					action
-				);
 		dest->FastQueuePacket(&in, ack_req);
-				break;
-			}
-			default: {
-				LogTrading(
-					"Encode OP_BazaarSearch(Ti) unhandled action <red>[{}]",
-					action
-				);
-				dest->FastQueuePacket(&in, ack_req);
-			}
-		}
 	}
 
 	ENCODE(OP_BecomeTrader)
 	{
-		uint32 action = *(uint32 *)(*p)->pBuffer;
+		ENCODE_LENGTH_EXACT(BecomeTrader_Struct);
+		SETUP_DIRECT_ENCODE(BecomeTrader_Struct, structs::BecomeTrader_Struct);
+
+		OUT(ID);
+		OUT(Code);
 
-		switch (action)
-		{
-			case TraderOff:
-			{
-				ENCODE_LENGTH_EXACT(BecomeTrader_Struct);
-				SETUP_DIRECT_ENCODE(BecomeTrader_Struct, structs::BecomeTrader_Struct);
-				LogTrading(
-					"Encode OP_BecomeTrader(Ti) TraderOff action <green>[{}] entity_id <green>[{}] trader_name "
-					"<green>[{}]",
-					emu->action,
-					emu->entity_id,
-					emu->trader_name
-				);
-				eq->action    = structs::TiBazaarTraderBuyerActions::Zero;
-				eq->entity_id = emu->entity_id;
 		FINISH_ENCODE();
-				break;
-			}
-			case TraderOn:
-			{
-				ENCODE_LENGTH_EXACT(BecomeTrader_Struct);
-				SETUP_DIRECT_ENCODE(BecomeTrader_Struct, structs::BecomeTrader_Struct);
-				LogTrading(
-					"Encode OP_BecomeTrader(Ti) TraderOn action <green>[{}] entity_id <green>[{}] trader_name "
-					"<green>[{}]",
-					emu->action,
-					emu->entity_id,
-					emu->trader_name
-				);
-				eq->action    = structs::TiBazaarTraderBuyerActions::BeginTraderMode;
-				eq->entity_id = emu->entity_id;
-				strn0cpy(eq->trader_name, emu->trader_name, sizeof(eq->trader_name));
-				FINISH_ENCODE();
-				break;
-			}
-			default:
-			{
-				LogTrading(
-					"Encode OP_BecomeTrader(Ti) unhandled action <red>[{}] Sending packet as is.",
-					action
-				);
-				EQApplicationPacket *in = *p;
-				*p = nullptr;
-				dest->FastQueuePacket(&in, ack_req);
-			}
-		}
 	}
 
 	ENCODE(OP_Buff)
@@ -820,28 +748,6 @@ namespace Titanium
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_GuildsList)
-	{
-		EQApplicationPacket* in = *p;
-		*p = nullptr;
-
-		GuildsListMessaging_Struct   glms{};
-		EQ::Util::MemoryStreamReader ss(reinterpret_cast<char *>(in->pBuffer), in->size);
-		cereal::BinaryInputArchive   ar(ss);
-		ar(glms);
-
-		auto outapp = new EQApplicationPacket(OP_GuildsList, sizeof(structs::GuildsList_Struct));
-		auto out    = (structs::GuildsList_Struct *) outapp->pBuffer;
-
-		for (auto const& g : glms.guild_detail) {
-			if (g.guild_id < Titanium::constants::MAX_GUILD_ID) {
-				strn0cpy(out->Guilds[g.guild_id].name, g.guild_name.c_str(), sizeof(out->Guilds[g.guild_id].name));
-			}
-		}
-
-		dest->FastQueuePacket(&outapp);
-	}
-
 	ENCODE(OP_GuildMemberAdd)
 	{
 		ENCODE_LENGTH_EXACT(GuildMemberAdd_Struct)
@@ -1952,19 +1858,6 @@ namespace Titanium
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_ShopRequest)
-	{
-		ENCODE_LENGTH_EXACT(MerchantClick_Struct);
-		SETUP_DIRECT_ENCODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		OUT(npc_id);
-		OUT(player_id);
-		OUT(command);
-		OUT(rate);
-
-		FINISH_ENCODE();
-	}
-
 	ENCODE(OP_SpecialMesg)
 	{
 		EQApplicationPacket *in = *p;
@@ -2082,170 +1975,32 @@ namespace Titanium
 
 	ENCODE(OP_Trader)
 	{
-		auto action = *(uint32 *) (*p)->pBuffer;
+		if ((*p)->size != sizeof(TraderBuy_Struct)) {
-
-		switch (action) {
-			case TraderOn: {
-				ENCODE_LENGTH_EXACT(Trader_ShowItems_Struct);
-				SETUP_DIRECT_ENCODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
-				LogTrading(
-					"Encode OP_Trader BeginTraderMode action <green>[{}]",
-					action
-				);
-
-				eq->action = structs::TiBazaarTraderBuyerActions::BeginTraderMode;
-				OUT(entity_id);
-
-				FINISH_ENCODE();
-				break;
-			}
-			case TraderOff: {
-				ENCODE_LENGTH_EXACT(Trader_ShowItems_Struct);
-				SETUP_DIRECT_ENCODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
-				LogTrading(
-					"Encode OP_Trader EndTraderMode action <green>[{}]",
-					action
-				);
-
-				eq->action = structs::TiBazaarTraderBuyerActions::EndTraderMode;
-				OUT(entity_id);
-
-				FINISH_ENCODE();
-				break;
-			}
-			case ListTraderItems: {
-				ENCODE_LENGTH_EXACT(Trader_Struct);
-				SETUP_DIRECT_ENCODE(Trader_Struct, structs::Trader_Struct);
-				LogTrading(
-					"Encode OP_Trader ListTraderItems action <green>[{}]",
-					action
-				);
-
-				eq->action = structs::TiBazaarTraderBuyerActions::ListTraderItems;
-				std::copy_n(emu->items, UF::invtype::BAZAAR_SIZE, eq->item_id);
-				std::copy_n(emu->item_cost, UF::invtype::BAZAAR_SIZE, eq->item_cost);
-
-				FINISH_ENCODE();
-				break;
-			}
-			case BuyTraderItem: {
-				ENCODE_LENGTH_EXACT(TraderBuy_Struct);
-				SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-				LogTrading(
-					"Encode OP_Trader item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-					eq->item_id,
-					eq->price,
-					eq->quantity,
-					eq->trader_id
-				);
-
-				eq->action = structs::TiBazaarTraderBuyerActions::BuyTraderItem;
-				OUT(price);
-				OUT(trader_id);
-				OUT(item_id);
-				OUT(already_sold);
-				OUT(quantity);
-				strn0cpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
-
-				FINISH_ENCODE();
-				break;
-			}
-			case ItemMove: {
-				LogTrading(
-					"Encode OP_Trader ItemMove action <green>[{}]",
-					action
-				);
 			EQApplicationPacket *in = *p;
 			*p = nullptr;
 			dest->FastQueuePacket(&in, ack_req);
-				break;
+			return;
 		}
-			default: {
-				EQApplicationPacket *in = *p;
-				*p = nullptr;
 
-				dest->FastQueuePacket(&in, ack_req);
+		ENCODE_FORWARD(OP_TraderBuy);
-				LogError("Unknown Encode OP_Trader action <red>{} received.  Unhandled.", action);
-			}
-		}
 	}
 
 	ENCODE(OP_TraderBuy)
 	{
 		ENCODE_LENGTH_EXACT(TraderBuy_Struct);
 		SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-		LogTrading(
-			"Encode OP_TraderBuy item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-			emu->item_id,
-			emu->price,
-			emu->quantity,
-			emu->trader_id
-		);
 
-		OUT(action);
+		OUT(Action);
-		OUT(price);
+		OUT(Price);
-		OUT(trader_id);
+		OUT(TraderID);
-		OUT(item_id);
+		memcpy(eq->ItemName, emu->ItemName, sizeof(eq->ItemName));
-		OUT(already_sold);
+		OUT(ItemID);
-		OUT(quantity);
+		OUT(Quantity);
-		OUT_str(item_name);
+		OUT(AlreadySold);
 
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_TraderShop)
-	{
-		auto action = *(uint32 *)(*p)->pBuffer;
-
-		switch (action) {
-			case ClickTrader: {
-				ENCODE_LENGTH_EXACT(TraderClick_Struct);
-				SETUP_DIRECT_ENCODE(TraderClick_Struct, structs::TraderClick_Struct);
-				LogTrading(
-					"ClickTrader action <green>[{}] trader_id <green>[{}]",
-					action,
-					emu->TraderID
-				);
-
-				eq->action    = 0;
-				eq->trader_id = emu->TraderID;
-				eq->approval  = emu->Approval;
-
-				FINISH_ENCODE();
-				break;
-			}
-			case BuyTraderItem: {
-				ENCODE_LENGTH_EXACT(TraderBuy_Struct);
-				SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-				LogTrading(
-					"Encode OP_TraderShop item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-					eq->item_id,
-					eq->price,
-					eq->quantity,
-					eq->trader_id
-				);
-
-				eq->action = structs::TiBazaarTraderBuyerActions::BuyTraderItem;
-				OUT(price);
-				OUT(trader_id);
-				OUT(item_id);
-				OUT(already_sold);
-				OUT(quantity);
-				strn0cpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
-
-				FINISH_ENCODE();
-				break;
-			}
-			default: {
-				EQApplicationPacket *in = *p;
-				*p = nullptr;
-
-				dest->FastQueuePacket(&in, ack_req);
-				LogError("Unknown Encode OP_TraderShop action <red>[{}] received.  Unhandled.", action);
-			}
-		}
-	}
-
 	ENCODE(OP_TributeItem)
 	{
 		ENCODE_LENGTH_EXACT(TributeItem_Struct);
@@ -2496,53 +2251,6 @@ namespace Titanium
 		FINISH_DIRECT_DECODE();
 	}
 
-	DECODE(OP_BazaarSearch)
-	{
-		uint32 action = *(uint32 *) __packet->pBuffer;
-
-		switch (action) {
-			case structs::TiBazaarTraderBuyerActions::BazaarSearch: {
-				DECODE_LENGTH_EXACT(structs::BazaarSearch_Struct);
-				SETUP_DIRECT_DECODE(BazaarSearchCriteria_Struct, structs::BazaarSearch_Struct);
-
-				emu->action           = eq->Beginning.Action;
-				emu->item_stat        = eq->ItemStat;
-				emu->max_cost         = eq->MaxPrice;
-				emu->min_cost         = eq->MinPrice;
-				emu->max_level        = eq->MaxLlevel;
-				emu->min_level        = eq->Minlevel;
-				emu->race             = eq->Race;
-				emu->slot             = eq->Slot;
-				emu->type             = eq->Type == UINT32_MAX ? UINT8_MAX : eq->Type;
-				emu->trader_entity_id = eq->TraderID;
-				emu->trader_id        = 0;
-				emu->_class           = eq->Class_;
-				emu->search_scope     = eq->TraderID > 0 ? NonRoFBazaarSearchScope : Local_Scope;
-				emu->max_results      = RuleI(Bazaar, MaxSearchResults);
-				strn0cpy(emu->item_name, eq->Name, sizeof(emu->item_name));
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::TiBazaarTraderBuyerActions::BazaarInspect: {
-				SETUP_DIRECT_DECODE(BazaarInspect_Struct, structs::BazaarInspect_Struct);
-
-				IN(action);
-				memcpy(emu->player_name, eq->player_name, sizeof(emu->player_name));
-				IN(serial_number);
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::TiBazaarTraderBuyerActions::WelcomeMessage: {
-				break;
-			}
-			default: {
-				LogTrading("(Ti) Unhandled action <red>[{}]", action);
-			}
-		}
-	}
-
 	DECODE(OP_Buff)
 	{
 		DECODE_LENGTH_EXACT(structs::SpellBuffPacket_Struct);
@@ -2567,7 +2275,7 @@ namespace Titanium
 		DECODE_LENGTH_EXACT(structs::BugReport_Struct);
 		SETUP_DIRECT_DECODE(BugReport_Struct, structs::BugReport_Struct);
 
-		emu->category_id = Bug::GetID(eq->category_name);
+		emu->category_id = EQ::bug::CategoryNameToCategoryID(eq->category_name);
 		memcpy(emu->category_name, eq, sizeof(structs::BugReport_Struct));
 
 		FINISH_DIRECT_DECODE();
@@ -3167,105 +2875,18 @@ namespace Titanium
 		FINISH_DIRECT_DECODE();
 	}
 
-	DECODE(OP_ShopRequest)
-	{
-		DECODE_LENGTH_EXACT(structs::MerchantClick_Struct);
-		SETUP_DIRECT_DECODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		IN(npc_id);
-		IN(player_id);
-		IN(command);
-		IN(rate);
-		emu->tab_display = 0;
-		emu->unknown020 = 0;
-
-		FINISH_DIRECT_DECODE();
-	}
-
-	DECODE(OP_Trader)
-	{
-		auto action = (uint32) __packet->pBuffer[0];
-
-		switch (action) {
-			case structs::TiBazaarTraderBuyerActions::BeginTraderMode: {
-				DECODE_LENGTH_EXACT(structs::BeginTrader_Struct);
-				SETUP_DIRECT_DECODE(ClickTrader_Struct, structs::BeginTrader_Struct);
-				LogTrading(
-					"Decode OP_Trader BeginTraderMode action <red>[{}]",
-					action
-				);
-
-				emu->action      = TraderOn;
-				emu->unknown_004 = 0;
-				std::copy_n(eq->serial_number, Titanium::invtype::BAZAAR_SIZE, emu->serial_number);
-				std::copy_n(eq->cost, Titanium::invtype::BAZAAR_SIZE, emu->item_cost);
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::TiBazaarTraderBuyerActions::EndTraderMode: {
-				DECODE_LENGTH_EXACT(structs::Trader_ShowItems_Struct);
-				SETUP_DIRECT_DECODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
-				LogTrading(
-					"Decode OP_Trader(Ti) EndTraderMode action <red>[{}]",
-					action
-				);
-
-				emu->action = TraderOff;
-				IN(entity_id);
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::TiBazaarTraderBuyerActions::PriceUpdate:
-			case structs::TiBazaarTraderBuyerActions::ItemMove:
-			case structs::TiBazaarTraderBuyerActions::EndTransaction:
-			case structs::TiBazaarTraderBuyerActions::ListTraderItems: {
-				LogTrading(
-					"Decode OP_Trader(Ti) Price/ItemMove/EndTransaction/ListTraderItems action <red>[{}]",
-					action
-				);
-				break;
-			}
-			case structs::TiBazaarTraderBuyerActions::ReconcileItems: {
-				break;
-			}
-			default: {
-				LogError("Unhandled(Ti) action <red>[{}] received.", action);
-			}
-		}
-	}
-
 	DECODE(OP_TraderBuy)
 	{
 		DECODE_LENGTH_EXACT(structs::TraderBuy_Struct);
 		SETUP_DIRECT_DECODE(TraderBuy_Struct, structs::TraderBuy_Struct);
 		MEMSET_IN(TraderBuy_Struct);
 
-		IN(action);
+		IN(Action);
-		IN(price);
+		IN(Price);
-		IN(trader_id);
+		IN(TraderID);
-		memcpy(emu->item_name, eq->item_name, sizeof(emu->item_name));
+		memcpy(emu->ItemName, eq->ItemName, sizeof(emu->ItemName));
-		IN(item_id);
+		IN(ItemID);
-		IN(quantity);
+		IN(Quantity);
-
-		FINISH_DIRECT_DECODE();
-	}
-
-	DECODE(OP_TraderShop)
-	{
-		DECODE_LENGTH_EXACT(structs::TraderClick_Struct);
-		SETUP_DIRECT_DECODE(TraderClick_Struct, structs::TraderClick_Struct);
-		LogTrading(
-			"(Ti) action <green>[{}] trader_id <green>[{}] approval <green>[{}]",
-			eq->action,
-			eq->trader_id,
-			eq->approval
-		);
-
-		emu->Code     = ClickTrader;
-		emu->TraderID = eq->trader_id;
-		emu->Approval = eq->approval;
 
 		FINISH_DIRECT_DECODE();
 	}

common/patches/titanium_limits.h

@@ -287,7 +287,6 @@ namespace Titanium
 		const size_t CHARACTER_CREATION_LIMIT = 8; // Hard-coded in client - DO NOT ALTER
 
 		const size_t SAY_LINK_BODY_SIZE = 45;
-		const uint32 MAX_GUILD_ID       = 1500;
 
 	} /*constants*/
 

common/patches/titanium_ops.h

@@ -45,7 +45,6 @@ E(OP_Emote)
 E(OP_FormattedMessage)
 E(OP_GroundSpawn)
 E(OP_SetGuildRank)
-E(OP_GuildsList)
 E(OP_GuildMemberLevelUpdate)
 E(OP_GuildMemberList)
 E(OP_GuildMemberAdd)
@@ -75,14 +74,12 @@ E(OP_SendCharInfo)
 E(OP_SendAATable)
 E(OP_SetFace)
 E(OP_ShopPlayerSell)
-E(OP_ShopRequest)
 E(OP_SpawnAppearance)
 E(OP_SpecialMesg)
 E(OP_TaskDescription)
 E(OP_Track)
 E(OP_Trader)
 E(OP_TraderBuy)
-E(OP_TraderShop)
 E(OP_TributeItem)
 E(OP_VetRewardsAvaliable)
 E(OP_WearChange)
@@ -93,7 +90,6 @@ E(OP_ZoneSpawns)
 D(OP_AdventureMerchantSell)
 D(OP_ApplyPoison)
 D(OP_AugmentItem)
-D(OP_BazaarSearch)
 D(OP_Buff)
 D(OP_Bug)
 D(OP_CastSpell)
@@ -124,10 +120,7 @@ D(OP_RaidInvite)
 D(OP_ReadBook)
 D(OP_SetServerFilter)
 D(OP_ShopPlayerSell)
-D(OP_ShopRequest)
-D(OP_Trader)
 D(OP_TraderBuy)
-D(OP_TraderShop)
 D(OP_TradeSkillCombine)
 D(OP_TributeItem)
 D(OP_WearChange)

common/patches/titanium_structs.h

@@ -1669,9 +1669,9 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct {
+struct Merchant_Click_Struct {
-/*000*/ uint32	npc_id;			// Merchant NPC's entity id
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-/*004*/ uint32	player_id;
+/*004*/ uint32	playerid;
 /*008*/ uint32	command;		//1=open, 0=cancel/close
 /*012*/ float	rate;			//cost multiplier, dosent work anymore
 };
@@ -2273,29 +2273,24 @@ struct BazaarWelcome_Struct {
 };
 
 struct BazaarSearch_Struct {
-	BazaarWindowStart_Struct Beginning;
+	BazaarWindowStart_Struct beginning;
-	uint32	TraderID;
+	uint32	traderid;
-	uint32	Class_;
+	uint32  class_;
-	uint32	Race;
+	uint32  race;
-	uint32	ItemStat;
+	uint32  stat;
-	uint32	Slot;
+	uint32  slot;
-	uint32	Type;
+	uint32  type;
-	char	Name[64];
+	char   name[64];
-	uint32	MinPrice;
+	uint32	minprice;
-	uint32	MaxPrice;
+	uint32	maxprice;
-	uint32	Minlevel;
+	uint32	minlevel;
-	uint32	MaxLlevel;
+	uint32	maxlevel;
 };
-
+struct BazaarInspect_Struct{
-struct BazaarInspect_Struct {
-	uint32 action;
-	char   player_name[64];
-	uint32 unknown_068;
-	uint32 serial_number;
-	uint32 unknown_076;
 	uint32 item_id;
+	uint32 unknown;
+	char name[64];
 };
-
 struct BazaarReturnDone_Struct{
 	uint32 type;
 	uint32 traderid;
@@ -2303,17 +2298,16 @@ struct BazaarReturnDone_Struct{
 	uint32 unknown12;
 	uint32 unknown16;
 };
-
 struct BazaarSearchResults_Struct {
 	BazaarWindowStart_Struct Beginning;
-	uint32                   entity_id;
+	uint32	SellerID;
-	uint32                   unknown_008;
+	uint32   NumItems; // Don't know. Don't know the significance of this field.
-	uint32                   item_id;
+	uint32   SerialNumber;
-	uint32                   serial_number;
+	uint32   Unknown016;
-	uint32                   unknown_020;
+	uint32   Unknown020; // Something to do with stats as well
-	char                     item_name[64];
+	char	ItemName[64];
-	uint32                   item_cost;
+	uint32	Cost;
-	uint32                   item_stat;
+	uint32	ItemStat;
 };
 
 struct ServerSideFilters_Struct {
@@ -2460,18 +2454,11 @@ struct WhoAllReturnStruct {
 	struct WhoAllPlayer player[0];
 };
 
-struct BeginTrader_Struct {
-	uint32 action;
-	uint32 unknown04;
-	uint64 serial_number[80];
-	uint32 cost[80];
-};
-
 struct Trader_Struct {
-	uint32 action;
+	uint32	code;
-	uint32 unknown004;
+	uint32	itemid[160];
-	uint64 item_id[80];
+	uint32	unknown;
-	uint32 item_cost[80];
+	uint32	itemcost[80];
 };
 
 struct ClickTrader_Struct {
@@ -2484,28 +2471,27 @@ struct GetItems_Struct{
 	uint32	items[80];
 };
 
-struct BecomeTrader_Struct {
+struct BecomeTrader_Struct{
-	uint32 entity_id;
+	uint32 ID;
-	uint32 action;
+	uint32 Code;
-	char   trader_name[64];
 };
 
 struct Trader_ShowItems_Struct{
-	uint32 action;
+	uint32 code;
-	uint32 entity_id;
+	uint32 traderid;
 	uint32 unknown08[3];
 };
 
 struct TraderBuy_Struct {
-/*000*/ uint32  action;
+/*000*/ uint32   Action;
-/*004*/ uint32  price;
+/*004*/ uint32   Price;
-/*008*/ uint32  trader_id;
+/*008*/ uint32   TraderID;
-/*012*/ char    item_name[64];
+/*012*/ char    ItemName[64];
-/*076*/ uint32  unknown_076;
+/*076*/ uint32   Unknown076;
-/*080*/ uint32  item_id;
+/*080*/ uint32   ItemID;
-/*084*/ uint32  already_sold;
+/*084*/ uint32   AlreadySold;
-/*088*/ uint32  quantity;
+/*088*/ uint32   Quantity;
-/*092*/ uint32  unknown_092;
+/*092*/ uint32   Unknown092;
 };
 
 
@@ -2531,9 +2517,8 @@ struct TraderDelItem_Struct{
 };
 
 struct TraderClick_Struct{
-	uint32 trader_id;
+	uint32 traderid;
-	uint32 action;
+	uint32 unknown4[2];
-	uint32 unknown_004;
 	uint32 approval;
 };
 
@@ -3759,21 +3744,6 @@ struct GuildMemberRank_Struct {
 	/*076*/ uint32 alt_banker; //Banker/Alt bit 00 - none 10 - Alt 11 - Alt and Banker 01 - Banker.  Banker not functional for RoF2+
 };
 
-enum TiBazaarTraderBuyerActions {
-	Zero            = 0,
-	BeginTraderMode = 1,
-	EndTraderMode   = 2,
-	PriceUpdate     = 3,
-	EndTransaction  = 4,
-	BazaarSearch    = 7,
-	WelcomeMessage  = 9,
-	BuyTraderItem   = 10,
-	ListTraderItems = 11,
-	BazaarInspect   = 18,
-	ItemMove        = 19,
-	ReconcileItems  = 20
-};
-
 	}; /*structs*/
 
 }; /*Titanium*/

common/patches/uf.cpp

@@ -37,8 +37,6 @@
 #include "../races.h"
 #include "../raid.h"
 #include "../guilds.h"
-//#include "../repositories/trader_repository.h"
-#include "../cereal/include/cereal/types/vector.hpp"
 
 #include <iostream>
 #include <sstream>
@@ -309,135 +307,51 @@ namespace UF
 		EQApplicationPacket *in = *p;
 		*p = nullptr;
 
-		uint32 action = *(uint32 *)in->pBuffer;
+		char *Buffer = (char *)in->pBuffer;
 
-		switch (action) {
+		uint8 SubAction = VARSTRUCT_DECODE_TYPE(uint8, Buffer);
-			case BazaarSearch: {
-				LogTrading(
-					"Encode OP_BazaarSearch(UF) BazaarSearch action <green>[{}]",
-					action
-				);
-				std::vector<BazaarSearchResultsFromDB_Struct> results {};
-				auto bsms = (BazaarSearchMessaging_Struct *)in->pBuffer;
-				EQ::Util::MemoryStreamReader ss(
-					reinterpret_cast<char *>(bsms->payload),
-					in->size - sizeof(BazaarSearchMessaging_Struct)
-				);
-				cereal::BinaryInputArchive ar(ss);
-				ar(results);
 
-				auto  size    = results.size() * sizeof(BazaarSearchResults_Struct);
+		if (SubAction != BazaarSearchResults)
-				auto  buffer  = new uchar[size];
+		{
-				uchar *bufptr = buffer;
-				memset(buffer, 0, size);
-
-				for (auto row = results.begin(); row != results.end(); ++row) {
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, structs::UFBazaarTraderBuyerActions::BazaarSearch);
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, row->trader_entity_id);
-					strn0cpy(reinterpret_cast<char *>(bufptr), row->trader_name.c_str(), 64);
-					bufptr += 64;
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, 1);
-					VARSTRUCT_ENCODE_TYPE(int32, bufptr, row->item_id);
-					VARSTRUCT_ENCODE_TYPE(int32, bufptr, row->serial_number);
-					bufptr += 4;
-					if (row->stackable) {
-						strn0cpy(
-							reinterpret_cast<char *>(bufptr),
-							fmt::format("{}({})", row->item_name.c_str(), row->charges).c_str(),
-							64
-						);
-					}
-					else {
-						strn0cpy(
-							reinterpret_cast<char *>(bufptr),
-							fmt::format("{}({})", row->item_name.c_str(), row->count).c_str(),
-							64
-						);
-					}
-					bufptr += 64;
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, row->cost);
-					VARSTRUCT_ENCODE_TYPE(uint32, bufptr, row->item_stat);
-				}
-
-				auto outapp = new EQApplicationPacket(OP_BazaarSearch, size);
-				memcpy(outapp->pBuffer, buffer, size);
-				dest->FastQueuePacket(&outapp);
-
-				safe_delete(outapp);
-				safe_delete_array(buffer);
-				safe_delete(in);
-				break;
-			}
-			case BazaarInspect:
-			case WelcomeMessage: {
-				LogTrading(
-					"Encode OP_BazaarSearch(UF) BazaarInspect/WelcomeMessage action <green>[{}]",
-					action
-				);
 			dest->FastQueuePacket(&in, ack_req);
-				break;
+			return;
-			}
-			default: {
-				LogTrading(
-					"Encode OP_BazaarSearch(UF) unhandled action <red>[{}]",
-					action
-				);
-				dest->FastQueuePacket(&in, ack_req);
-			}
-		}
 		}
 
-	ENCODE(OP_BecomeTrader)
+		unsigned char *__emu_buffer = in->pBuffer;
-	{
-		uint32 action = *(uint32 *)(*p)->pBuffer;
 
-		switch (action)
+		BazaarSearchResults_Struct *emu = (BazaarSearchResults_Struct *)__emu_buffer;
+
+		int EntryCount = in->size / sizeof(BazaarSearchResults_Struct);
+
+		if (EntryCount == 0 || (in->size % sizeof(BazaarSearchResults_Struct)) != 0)
 		{
-			case TraderOff:
+			LogNetcode("[STRUCTS] Wrong size on outbound [{}]: Got [{}], expected multiple of [{}]", opcodes->EmuToName(in->GetOpcode()), in->size, sizeof(BazaarSearchResults_Struct));
-			{
+			delete in;
-				ENCODE_LENGTH_EXACT(BecomeTrader_Struct);
+			return;
-				SETUP_DIRECT_ENCODE(BecomeTrader_Struct, structs::BecomeTrader_Struct);
-				LogTrading(
-                    "Encode OP_BecomeTrader(UF) TraderOff action <green>[{}] entity_id <green>[{}] trader_name "
-                    "<green>[{}]",
-                    emu->action,
-                    emu->entity_id,
-                    emu->trader_name
-                );
-				eq->action    = structs::UFBazaarTraderBuyerActions::Zero;
-				eq->entity_id = emu->entity_id;
-				FINISH_ENCODE();
-				break;
 		}
-			case TraderOn:
+
+		in->size = EntryCount * sizeof(structs::BazaarSearchResults_Struct);
+		in->pBuffer = new unsigned char[in->size];
+		memset(in->pBuffer, 0, in->size);
+
+		structs::BazaarSearchResults_Struct *eq = (structs::BazaarSearchResults_Struct *)in->pBuffer;
+
+		for (int i = 0; i < EntryCount; ++i, ++emu, ++eq)
 		{
-				ENCODE_LENGTH_EXACT(BecomeTrader_Struct);
+			OUT(Beginning.Action);
-				SETUP_DIRECT_ENCODE(BecomeTrader_Struct, structs::BecomeTrader_Struct);
+			OUT(SellerID);
-				LogTrading(
+			memcpy(eq->SellerName, emu->SellerName, sizeof(eq->SellerName));
-                    "Encode OP_BecomeTrader(UF) TraderOn action <green>[{}] entity_id <green>[{}] trader_name "
+			OUT(NumItems);
-                    "<green>[{}]",
+			OUT(ItemID);
-                    emu->action,
+			OUT(SerialNumber);
-                    emu->entity_id,
+			memcpy(eq->ItemName, emu->ItemName, sizeof(eq->ItemName));
-                    emu->trader_name
+			OUT(Cost);
-                );
+			OUT(ItemStat);
-				eq->action    = structs::UFBazaarTraderBuyerActions::BeginTraderMode;
-				eq->entity_id = emu->entity_id;
-				strn0cpy(eq->trader_name, emu->trader_name, sizeof(eq->trader_name));
-				FINISH_ENCODE();
-				break;
 		}
-			default:
+
-			{
+		delete[] __emu_buffer;
-				LogTrading(
-					"Encode OP_BecomeTrader(UF) unhandled action <red>[{}] Sending packet as is.",
-					action
-				);
-				EQApplicationPacket *in = *p;
-				*p = nullptr;
 		dest->FastQueuePacket(&in, ack_req);
 	}
-		}
-	}
 
 	ENCODE(OP_Buff)
 	{
@@ -1268,37 +1182,53 @@ namespace UF
 
 	ENCODE(OP_GuildsList)
 	{
-		EQApplicationPacket* in = *p;
+		EQApplicationPacket *in = *p;
 		*p = nullptr;
 
-		GuildsListMessaging_Struct   glms{};
+		uint32 NumberOfGuilds = in->size / 64;
-		EQ::Util::MemoryStreamReader ss(reinterpret_cast<char *>(in->pBuffer), in->size);
+		uint32 PacketSize = 68;	// 64 x 0x00 + a uint32 that I am guessing is the highest guild ID in use.
-		cereal::BinaryInputArchive   ar(ss);
-		ar(glms);
 
-		auto packet_size = 64 + 4 + glms.guild_detail.size() * 4 + glms.string_length;
+		unsigned char *__emu_buffer = in->pBuffer;
-		auto buffer      = new uchar[packet_size];
+		char *InBuffer = (char *)__emu_buffer;
-		auto buf_pos     = buffer;
+		uint32 actual_no_guilds = 0;
 
-		memset(buf_pos, 0, 64);
+		for (unsigned int i = 0; i < NumberOfGuilds; ++i)
-		buf_pos += 64;
+		{
-
+			if (InBuffer[0])
-		VARSTRUCT_ENCODE_TYPE(uint32, buf_pos, glms.no_of_guilds);
+			{
-
+				PacketSize += (5 + strlen(InBuffer));
-		for (auto const& g : glms.guild_detail) {
+                actual_no_guilds++;
-			if (g.guild_id < UF::constants::MAX_GUILD_ID) {
-				VARSTRUCT_ENCODE_TYPE(uint32, buf_pos, g.guild_id);
-				strn0cpy((char *) buf_pos, g.guild_name.c_str(), g.guild_name.length() + 1);
-				buf_pos += g.guild_name.length() + 1;
 			}
+			InBuffer += 64;
 		}
 
-		auto outapp = new EQApplicationPacket(OP_GuildsList);
+		PacketSize++;	// Appears to be an extra 0x00 at the very end.
+		in->size = PacketSize;
+		in->pBuffer = new unsigned char[in->size];
+		InBuffer = (char *)__emu_buffer;
+		char *OutBuffer = (char *)in->pBuffer;
 
-		outapp->size    = packet_size;
+		// Init the first 64 bytes to zero, as per live.
-		outapp->pBuffer = buffer;
+		//
+		memset(OutBuffer, 0, 64);
+		OutBuffer += 64;
 
-		dest->FastQueuePacket(&outapp);
+		VARSTRUCT_ENCODE_TYPE(uint32, OutBuffer, actual_no_guilds);
+
+		for (unsigned int i = 0; i < NumberOfGuilds; ++i)
+		{
+			if (InBuffer[0])
+			{
+				VARSTRUCT_ENCODE_TYPE(uint32, OutBuffer, i - 1);
+				VARSTRUCT_ENCODE_STRING(OutBuffer, InBuffer);
+			}
+			InBuffer += 64;
+		}
+
+		VARSTRUCT_ENCODE_TYPE(uint8, OutBuffer, 0x00);
+
+		delete[] __emu_buffer;
+		dest->FastQueuePacket(&in, ack_req);
 	}
 
 	ENCODE(OP_GuildMemberAdd)
@@ -2524,19 +2454,6 @@ namespace UF
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_ShopRequest)
-	{
-		ENCODE_LENGTH_EXACT(MerchantClick_Struct);
-		SETUP_DIRECT_ENCODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		OUT(npc_id);
-		OUT(player_id);
-		OUT(command);
-		OUT(rate);
-
-		FINISH_ENCODE();
-	}
-
 	ENCODE(OP_SomeItemPacketMaybe)
 	{
 		// This Opcode is not named very well. It is used for the animation of arrows leaving the player's bow
@@ -2829,170 +2746,32 @@ namespace UF
 
 	ENCODE(OP_Trader)
 	{
-		auto action = *(uint32 *) (*p)->pBuffer;
+		if ((*p)->size != sizeof(TraderBuy_Struct)) {
-
-		switch (action) {
-			case TraderOn: {
-				ENCODE_LENGTH_EXACT(Trader_ShowItems_Struct);
-				SETUP_DIRECT_ENCODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
-				LogTrading(
-					"Encode OP_Trader BeginTraderMode action <green>[{}]",
-					action
-				);
-
-				eq->action = structs::UFBazaarTraderBuyerActions::BeginTraderMode;
-				OUT(entity_id);
-
-				FINISH_ENCODE();
-				break;
-			}
-			case TraderOff: {
-				ENCODE_LENGTH_EXACT(Trader_ShowItems_Struct);
-				SETUP_DIRECT_ENCODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
-				LogTrading(
-					"Encode OP_Trader EndTraderMode action <green>[{}]",
-					action
-				);
-
-				eq->action = structs::UFBazaarTraderBuyerActions::EndTraderMode;
-				OUT(entity_id);
-
-				FINISH_ENCODE();
-				break;
-			}
-			case ListTraderItems: {
-				ENCODE_LENGTH_EXACT(Trader_Struct);
-				SETUP_DIRECT_ENCODE(Trader_Struct, structs::Trader_Struct);
-				LogTrading(
-					"Encode OP_Trader ListTraderItems action <green>[{}]",
-					action
-				);
-
-				eq->action = structs::UFBazaarTraderBuyerActions::ListTraderItems;
-				std::copy_n(emu->items, UF::invtype::BAZAAR_SIZE, eq->item_id);
-				std::copy_n(emu->item_cost, UF::invtype::BAZAAR_SIZE, eq->item_cost);
-
-				FINISH_ENCODE();
-				break;
-			}
-			case BuyTraderItem: {
-				ENCODE_LENGTH_EXACT(TraderBuy_Struct);
-				SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-				LogTrading(
-					"Encode OP_Trader item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-					eq->item_id,
-					eq->price,
-					eq->quantity,
-					eq->trader_id
-				);
-
-				eq->action = structs::UFBazaarTraderBuyerActions::BuyTraderItem;
-				OUT(price);
-				OUT(trader_id);
-				OUT(item_id);
-				OUT(already_sold);
-				OUT(quantity);
-				strn0cpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
-
-				FINISH_ENCODE();
-				break;
-			}
-			case ItemMove: {
-				LogTrading(
-					"Encode OP_Trader ItemMove action <green>[{}]",
-					action
-				);
 			EQApplicationPacket *in = *p;
 			*p = nullptr;
 			dest->FastQueuePacket(&in, ack_req);
-				break;
+			return;
 		}
-			default: {
-				EQApplicationPacket *in = *p;
-				*p                      = nullptr;
 
-				dest->FastQueuePacket(&in, ack_req);
+		ENCODE_FORWARD(OP_TraderBuy);
-				LogError("Unknown Encode OP_Trader action <red>{} received.  Unhandled.", action);
-			}
-		}
 	}
 
 	ENCODE(OP_TraderBuy)
 	{
 		ENCODE_LENGTH_EXACT(TraderBuy_Struct);
 		SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-		LogTrading(
-			"Encode OP_TraderBuy item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-			emu->item_id,
-			emu->price,
-			emu->quantity,
-			emu->trader_id
-		);
 
-		OUT(action);
+		OUT(Action);
-		OUT(price);
+		OUT(Price);
-		OUT(trader_id);
+		OUT(TraderID);
-		OUT(item_id);
+		memcpy(eq->ItemName, emu->ItemName, sizeof(eq->ItemName));
-		OUT(already_sold);
+		OUT(ItemID);
-		OUT(quantity);
+		OUT(Quantity);
-		OUT_str(item_name);
+		OUT(AlreadySold);
 
 		FINISH_ENCODE();
 	}
 
-	ENCODE(OP_TraderShop)
-	{
-		auto action = *(uint32 *)(*p)->pBuffer;
-
-		switch (action) {
-			case ClickTrader: {
-				ENCODE_LENGTH_EXACT(TraderClick_Struct);
-				SETUP_DIRECT_ENCODE(TraderClick_Struct, structs::TraderClick_Struct);
-				LogTrading(
-					"ClickTrader action <green>[{}] trader_id <green>[{}]",
-					action,
-					emu->TraderID
-				);
-
-				eq->action    = 0;
-				eq->trader_id = emu->TraderID;
-				eq->approval  = emu->Approval;
-
-				FINISH_ENCODE();
-				break;
-			}
-			case BuyTraderItem: {
-				ENCODE_LENGTH_EXACT(TraderBuy_Struct);
-				SETUP_DIRECT_ENCODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-				LogTrading(
-					"Encode OP_TraderShop item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-					eq->item_id,
-					eq->price,
-					eq->quantity,
-					eq->trader_id
-				);
-
-				eq->action = structs::UFBazaarTraderBuyerActions::BuyTraderItem;
-				OUT(price);
-				OUT(trader_id);
-				OUT(item_id);
-				OUT(already_sold);
-				OUT(quantity);
-				strn0cpy(eq->item_name, emu->item_name, sizeof(eq->item_name));
-
-				FINISH_ENCODE();
-				break;
-			}
-			default: {
-				EQApplicationPacket *in = *p;
-				*p = nullptr;
-
-				dest->FastQueuePacket(&in, ack_req);
-				LogError("Unknown Encode OP_TraderShop action <red>[{}] received.  Unhandled.", action);
-			}
-		}
-	}
-
 	ENCODE(OP_TributeItem)
 	{
 		ENCODE_LENGTH_EXACT(TributeItem_Struct);
@@ -3264,7 +3043,7 @@ namespace UF
 			Bitfields->targetable = 1;
 			Bitfields->targetable_with_hotkey = emu->targetable_with_hotkey ? 1 : 0;
 			Bitfields->statue = 0;
-			Bitfields->trader = emu->trader ? 1 : 0;
+			Bitfields->trader = 0;
 			Bitfields->buyer = 0;
 
 			Bitfields->showname = ShowName;
@@ -3587,49 +3366,20 @@ namespace UF
 
 	DECODE(OP_BazaarSearch)
 	{
-		uint32 action = *(uint32 *) __packet->pBuffer;
+		char *Buffer = (char *)__packet->pBuffer;
 
-		switch (action) {
+		uint8 SubAction = VARSTRUCT_DECODE_TYPE(uint8, Buffer);
-			case structs::UFBazaarTraderBuyerActions::BazaarSearch: {
-				DECODE_LENGTH_EXACT(structs::BazaarSearch_Struct);
-				SETUP_DIRECT_DECODE(BazaarSearchCriteria_Struct, structs::BazaarSearch_Struct);
 
-				emu->action           = eq->Beginning.Action;
+		if ((SubAction != BazaarInspectItem) || (__packet->size != sizeof(structs::NewBazaarInspect_Struct)))
-				emu->item_stat        = eq->ItemStat;
+			return;
-				emu->max_cost         = eq->MaxPrice;
+
-				emu->min_cost         = eq->MinPrice;
+		SETUP_DIRECT_DECODE(NewBazaarInspect_Struct, structs::NewBazaarInspect_Struct);
-				emu->max_level        = eq->MaxLlevel;
+		MEMSET_IN(structs::NewBazaarInspect_Struct);
-				emu->min_level        = eq->Minlevel;
+		IN(Beginning.Action);
-                emu->race             = eq->Race;
+		memcpy(emu->Name, eq->Name, sizeof(emu->Name));
-                emu->slot             = eq->Slot;
+		IN(SerialNumber);
-                emu->type             = eq->Type == UINT32_MAX ? UINT8_MAX : eq->Type;
-                emu->trader_entity_id = eq->TraderID;
-                emu->trader_id        = 0;
-                emu->_class           = eq->Class_;
-                emu->search_scope     = eq->TraderID > 0 ? NonRoFBazaarSearchScope : Local_Scope;
-                emu->max_results      = RuleI(Bazaar, MaxSearchResults);
-                strn0cpy(emu->item_name, eq->Name, sizeof(emu->item_name));
 
 		FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::UFBazaarTraderBuyerActions::BazaarInspect: {
-				SETUP_DIRECT_DECODE(BazaarInspect_Struct, structs::BazaarInspect_Struct);
-
-				IN(action);
-				memcpy(emu->player_name, eq->player_name, sizeof(emu->player_name));
-				IN(serial_number);
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::UFBazaarTraderBuyerActions::WelcomeMessage: {
-				break;
-			}
-			default: {
-				LogTrading("(UF) Unhandled action <red>[{}]", action);
-			}
-		}
 	}
 
 	DECODE(OP_BookButton)
@@ -4297,112 +4047,18 @@ namespace UF
 		FINISH_DIRECT_DECODE();
 	}
 
-	DECODE(OP_ShopRequest)
-	{
-		DECODE_LENGTH_EXACT(structs::MerchantClick_Struct);
-		SETUP_DIRECT_DECODE(MerchantClick_Struct, structs::MerchantClick_Struct);
-
-		IN(npc_id);
-		IN(player_id);
-		IN(command);
-		IN(rate);
-		emu->tab_display = 0;
-		emu->unknown020 = 0;
-
-		FINISH_DIRECT_DECODE();
-	}
-
-	DECODE(OP_Trader)
-	{
-		auto action = (uint32) __packet->pBuffer[0];
-
-		switch (action) {
-			case structs::UFBazaarTraderBuyerActions::BeginTraderMode: {
-				DECODE_LENGTH_EXACT(structs::BeginTrader_Struct);
-				SETUP_DIRECT_DECODE(ClickTrader_Struct, structs::BeginTrader_Struct);
-				LogTrading(
-					"Decode OP_Trader BeginTraderMode action <red>[{}]",
-					action
-				);
-
-				emu->action      = TraderOn;
-				emu->unknown_004 = 0;
-				std::copy_n(eq->serial_number, UF::invtype::BAZAAR_SIZE, emu->serial_number);
-				std::copy_n(eq->cost, UF::invtype::BAZAAR_SIZE, emu->item_cost);
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::UFBazaarTraderBuyerActions::EndTraderMode: {
-				DECODE_LENGTH_EXACT(structs::Trader_ShowItems_Struct);
-				SETUP_DIRECT_DECODE(Trader_ShowItems_Struct, structs::Trader_ShowItems_Struct);
-				LogTrading(
-					"Decode OP_Trader(UF) EndTraderMode action <red>[{}]",
-					action
-				);
-
-				emu->action = TraderOff;
-				IN(entity_id);
-
-				FINISH_DIRECT_DECODE();
-				break;
-			}
-			case structs::UFBazaarTraderBuyerActions::PriceUpdate:
-			case structs::UFBazaarTraderBuyerActions::ItemMove:
-			case structs::UFBazaarTraderBuyerActions::EndTransaction:
-			case structs::UFBazaarTraderBuyerActions::ListTraderItems: {
-				LogTrading(
-					"Decode OP_Trader(UF) Price/ItemMove/EndTransaction/ListTraderItems action <red>[{}]",
-					action
-				);
-				break;
-			}
-			case structs::UFBazaarTraderBuyerActions::ReconcileItems: {
-				break;
-			}
-			default: {
-				LogError("Unhandled(UF) action <red>[{}] received.", action);
-			}
-		}
-	}
-
 	DECODE(OP_TraderBuy)
 	{
 		DECODE_LENGTH_EXACT(structs::TraderBuy_Struct);
 		SETUP_DIRECT_DECODE(TraderBuy_Struct, structs::TraderBuy_Struct);
-		LogTrading(
+		MEMSET_IN(TraderBuy_Struct);
-			"Decode OP_TraderBuy(UF) item_id <green>[{}] price <green>[{}] quantity <green>[{}] trader_id <green>[{}]",
-			eq->item_id,
-			eq->price,
-			eq->quantity,
-			eq->trader_id
-		);
 
-		emu->action = BuyTraderItem;
+		IN(Action);
-		IN(price);
+		IN(Price);
-		IN(trader_id);
+		IN(TraderID);
-		IN(item_id);
+		memcpy(emu->ItemName, eq->ItemName, sizeof(emu->ItemName));
-		IN(quantity);
+		IN(ItemID);
-		IN(already_sold);
+		IN(Quantity);
-		strn0cpy(emu->item_name, eq->item_name, sizeof(eq->item_name));
-
-		FINISH_DIRECT_DECODE();
-	}
-
-	DECODE(OP_TraderShop)
-	{
-		DECODE_LENGTH_EXACT(structs::TraderClick_Struct);
-		SETUP_DIRECT_DECODE(TraderClick_Struct, structs::TraderClick_Struct);
-		LogTrading(
-			"(UF) action <green>[{}] trader_id <green>[{}] approval <green>[{}]",
-			eq->action,
-			eq->trader_id,
-			eq->approval
-		);
-
-		emu->Code     = ClickTrader;
-		emu->TraderID = eq->trader_id;
-		emu->Approval = eq->approval;
 
 		FINISH_DIRECT_DECODE();
 	}

common/patches/uf_limits.h

@@ -289,7 +289,6 @@ namespace UF
 		const size_t CHARACTER_CREATION_LIMIT = 12;
 
 		const size_t SAY_LINK_BODY_SIZE = 50;
-		const uint32 MAX_GUILD_ID       = 50000;
 
 	} /*constants*/
 

common/patches/uf_ops.h

@@ -27,7 +27,6 @@ E(OP_ApplyPoison)
 E(OP_AugmentInfo)
 E(OP_Barter)
 E(OP_BazaarSearch)
-E(OP_BecomeTrader)
 E(OP_Buff)
 E(OP_BuffCreate)
 E(OP_CancelTrade)
@@ -90,7 +89,6 @@ E(OP_SendZonepoints)
 E(OP_SetGuildRank)
 E(OP_ShopPlayerBuy)
 E(OP_ShopPlayerSell)
-E(OP_ShopRequest)
 E(OP_SomeItemPacketMaybe)
 E(OP_SpawnAppearance)
 E(OP_SpawnDoor)
@@ -101,7 +99,6 @@ E(OP_TaskDescription)
 E(OP_Track)
 E(OP_Trader)
 E(OP_TraderBuy)
-E(OP_TraderShop)
 E(OP_TributeItem)
 E(OP_VetRewardsAvaliable)
 E(OP_WearChange)
@@ -161,10 +158,7 @@ D(OP_Save)
 D(OP_SetServerFilter)
 D(OP_ShopPlayerBuy)
 D(OP_ShopPlayerSell)
-D(OP_ShopRequest)
-D(OP_Trader)
 D(OP_TraderBuy)
-D(OP_TraderShop)
 D(OP_TradeSkillCombine)
 D(OP_TributeItem)
 D(OP_WearChange)

common/patches/uf_structs.h

@@ -1916,9 +1916,9 @@ struct TimeOfDay_Struct {
 };
 
 // Darvik: shopkeeper structs
-struct MerchantClick_Struct {
+struct Merchant_Click_Struct {
-/*000*/ uint32	npc_id;			// Merchant NPC's entity id
+/*000*/ uint32	npcid;			// Merchant NPC's entity id
-/*004*/ uint32	player_id;
+/*004*/ uint32	playerid;
 /*008*/ uint32	command;		//1=open, 0=cancel/close
 /*012*/ float	rate;			//cost multiplier, dosent work anymore
 };
@@ -2687,14 +2687,10 @@ struct BazaarSearch_Struct {
 	uint32	Minlevel;
 	uint32	MaxLlevel;
 };
-
+struct BazaarInspect_Struct{
-struct BazaarInspect_Struct {
+	uint32 ItemID;
-	uint32 action;
+	uint32 Unknown004;
-	char   player_name[64];
+	char Name[64];
-	uint32 unknown_068;
-	uint32 serial_number;
-	uint32 unknown_076;
-	uint32 item_id;
 };
 
 struct NewBazaarInspect_Struct {
@@ -2933,17 +2929,10 @@ struct	WhoAllPlayerPart4 {
 };
 
 struct Trader_Struct {
-	uint32 action;
+	uint32	code;
-	uint32 unknown004;
+	uint32	itemid[160];
-	uint64 item_id[80];
+	uint32	unknown;
-	uint32 item_cost[80];
+	uint32	itemcost[80];
-};
-
-struct BeginTrader_Struct {
-	uint32 action;
-	uint32 unknown04;
-	uint64 serial_number[80];
-	uint32 cost[80];
 };
 
 struct ClickTrader_Struct {
@@ -2956,30 +2945,30 @@ struct GetItems_Struct{
 	uint32	items[80];
 };
 
-struct BecomeTrader_Struct {
+struct BecomeTrader_Struct{
-	uint32 entity_id;
+	uint32 id;
-	uint32 action;
+	uint32 code;
-	char   trader_name[64];
 };
 
 struct Trader_ShowItems_Struct{
-	uint32 action;
+	uint32 code;
-	uint32 entity_id;
+	uint32 traderid;
 	uint32 unknown08[3];
 };
 
 struct TraderBuy_Struct {
-	uint32 action;
+/*000*/ uint32   Action;
-	uint32 unknown_004;
+/*004*/	uint32	Unknown004;
-	uint32 price;
+/*008*/ uint32   Price;
-	uint32 unknown_008;    // Probably high order bits of a 64 bit price.
+/*012*/	uint32	Unknown008;	// Probably high order bits of a 64 bit price.
-	uint32 trader_id;
+/*016*/ uint32   TraderID;
-	char   item_name[64];
+/*020*/ char    ItemName[64];
-	uint32 unknown_076;
+/*084*/ uint32   Unknown076;
-	uint32 item_id;
+/*088*/ uint32   ItemID;
-	uint32 already_sold;
+/*092*/ uint32   AlreadySold;
-	uint32 quantity;
+/*096*/ uint32   Quantity;
-	uint32 unknown_092;
+/*100*/ uint32   Unknown092;
+/*104*/
 };
 
 struct TraderItemUpdate_Struct{
@@ -3013,9 +3002,8 @@ struct TraderDelItem_Struct{
 };
 
 struct TraderClick_Struct{
-	uint32 trader_id;
+	uint32 traderid;
-	uint32 action;
+	uint32 unknown4[2];
-	uint32 unknown_004;
 	uint32 approval;
 };
 
@@ -4686,30 +4674,6 @@ struct SayLinkBodyFrame_Struct {
 /*050*/
 };
 
-struct TraderPriceUpdate_Struct {
-/*000*/    uint32 action;
-/*004*/    uint32 sub_action;
-/*008*/    int32  serial_number;
-/*012*/    uint32 unknown_012;
-/*016*/    uint32 new_price;
-/*020*/    uint32 unknown_016;
-};
-
-enum UFBazaarTraderBuyerActions {
-	Zero            = 0,
-	BeginTraderMode = 1,
-	EndTraderMode   = 2,
-	PriceUpdate     = 3,
-	EndTransaction  = 4,
-	BazaarSearch    = 7,
-	WelcomeMessage  = 9,
-	BuyTraderItem   = 10,
-	ListTraderItems = 11,
-	BazaarInspect   = 18,
-	ItemMove        = 19,
-	ReconcileItems  = 20
-};
-
 	}; /*structs*/
 
 }; /*UF*/

common/repositories/account_repository.h

@@ -89,24 +89,6 @@ public:
 
 		return results.Success();
 	}
-
-	static std::string GetAutoLoginCharacterNameByAccountID(Database& db, const uint32 account_id)
-	{
-		return AccountRepository::FindOne(db, account_id).auto_login_charname;
-	}
-
-	static bool SetAutoLoginCharacterNameByAccountID(Database& db, const uint32 account_id, const std::string& character_name)
-	{
-		auto e = AccountRepository::FindOne(db, account_id);
-
-		if (!e.id) {
-			return false;
-		}
-
-		e.auto_login_charname = character_name;
-
-		return AccountRepository::UpdateOne(db, e);
-	}
 };
 
 #endif //EQEMU_ACCOUNT_REPOSITORY_H

common/repositories/base/base_account_repository.h

@@ -22,7 +22,6 @@ public:
 		int32_t     id;
 		std::string name;
 		std::string charname;
-		std::string auto_login_charname;
 		uint32_t    sharedplat;
 		std::string password;
 		int32_t     status;
@@ -57,7 +56,6 @@ public:
 			"id",
 			"name",
 			"charname",
-			"auto_login_charname",
 			"sharedplat",
 			"password",
 			"status",
@@ -88,7 +86,6 @@ public:
 			"id",
 			"name",
 			"charname",
-			"auto_login_charname",
 			"sharedplat",
 			"password",
 			"status",
@@ -153,7 +150,6 @@ public:
 		e.id             = 0;
 		e.name           = "";
 		e.charname       = "";
-		e.auto_login_charname = "";
 		e.sharedplat     = 0;
 		e.password       = "";
 		e.status         = 0;
@@ -214,28 +210,27 @@ public:
 			e.id             = row[0] ? static_cast<int32_t>(atoi(row[0])) : 0;
 			e.name           = row[1] ? row[1] : "";
 			e.charname       = row[2] ? row[2] : "";
-			e.auto_login_charname = row[3] ? row[3] : "";
+			e.sharedplat     = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.sharedplat          = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
+			e.password       = row[4] ? row[4] : "";
-			e.password            = row[5] ? row[5] : "";
+			e.status         = row[5] ? static_cast<int32_t>(atoi(row[5])) : 0;
-			e.status              = row[6] ? static_cast<int32_t>(atoi(row[6])) : 0;
+			e.ls_id          = row[6] ? row[6] : "eqemu";
-			e.ls_id               = row[7] ? row[7] : "eqemu";
+			e.lsaccount_id   = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.lsaccount_id        = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
+			e.gmspeed        = row[8] ? static_cast<uint8_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.gmspeed             = row[9] ? static_cast<uint8_t>(strtoul(row[9], nullptr, 10)) : 0;
+			e.invulnerable   = row[9] ? static_cast<int8_t>(atoi(row[9])) : 0;
-			e.invulnerable        = row[10] ? static_cast<int8_t>(atoi(row[10])) : 0;
+			e.flymode        = row[10] ? static_cast<int8_t>(atoi(row[10])) : 0;
-			e.flymode             = row[11] ? static_cast<int8_t>(atoi(row[11])) : 0;
+			e.ignore_tells   = row[11] ? static_cast<int8_t>(atoi(row[11])) : 0;
-			e.ignore_tells        = row[12] ? static_cast<int8_t>(atoi(row[12])) : 0;
+			e.revoked        = row[12] ? static_cast<uint8_t>(strtoul(row[12], nullptr, 10)) : 0;
-			e.revoked             = row[13] ? static_cast<uint8_t>(strtoul(row[13], nullptr, 10)) : 0;
+			e.karma          = row[13] ? static_cast<uint32_t>(strtoul(row[13], nullptr, 10)) : 0;
-			e.karma               = row[14] ? static_cast<uint32_t>(strtoul(row[14], nullptr, 10)) : 0;
+			e.minilogin_ip   = row[14] ? row[14] : "";
-			e.minilogin_ip        = row[15] ? row[15] : "";
+			e.hideme         = row[15] ? static_cast<int8_t>(atoi(row[15])) : 0;
-			e.hideme              = row[16] ? static_cast<int8_t>(atoi(row[16])) : 0;
+			e.rulesflag      = row[16] ? static_cast<uint8_t>(strtoul(row[16], nullptr, 10)) : 0;
-			e.rulesflag           = row[17] ? static_cast<uint8_t>(strtoul(row[17], nullptr, 10)) : 0;
+			e.suspendeduntil = strtoll(row[17] ? row[17] : "-1", nullptr, 10);
-			e.suspendeduntil      = strtoll(row[18] ? row[18] : "-1", nullptr, 10);
+			e.time_creation  = row[18] ? static_cast<uint32_t>(strtoul(row[18], nullptr, 10)) : 0;
-			e.time_creation       = row[19] ? static_cast<uint32_t>(strtoul(row[19], nullptr, 10)) : 0;
+			e.ban_reason     = row[19] ? row[19] : "";
-			e.ban_reason          = row[20] ? row[20] : "";
+			e.suspend_reason = row[20] ? row[20] : "";
-			e.suspend_reason      = row[21] ? row[21] : "";
+			e.crc_eqgame     = row[21] ? row[21] : "";
-			e.crc_eqgame          = row[22] ? row[22] : "";
+			e.crc_skillcaps  = row[22] ? row[22] : "";
-			e.crc_skillcaps       = row[23] ? row[23] : "";
+			e.crc_basedata   = row[23] ? row[23] : "";
-			e.crc_basedata        = row[24] ? row[24] : "";
 
 			return e;
 		}
@@ -271,28 +266,27 @@ public:
 
 		v.push_back(columns[1] + " = '" + Strings::Escape(e.name) + "'");
 		v.push_back(columns[2] + " = '" + Strings::Escape(e.charname) + "'");
-		v.push_back(columns[3] + " = '" + Strings::Escape(e.auto_login_charname) + "'");
+		v.push_back(columns[3] + " = " + std::to_string(e.sharedplat));
-		v.push_back(columns[4] + " = " + std::to_string(e.sharedplat));
+		v.push_back(columns[4] + " = '" + Strings::Escape(e.password) + "'");
-		v.push_back(columns[5] + " = '" + Strings::Escape(e.password) + "'");
+		v.push_back(columns[5] + " = " + std::to_string(e.status));
-		v.push_back(columns[6] + " = " + std::to_string(e.status));
+		v.push_back(columns[6] + " = '" + Strings::Escape(e.ls_id) + "'");
-		v.push_back(columns[7] + " = '" + Strings::Escape(e.ls_id) + "'");
+		v.push_back(columns[7] + " = " + std::to_string(e.lsaccount_id));
-		v.push_back(columns[8] + " = " + std::to_string(e.lsaccount_id));
+		v.push_back(columns[8] + " = " + std::to_string(e.gmspeed));
-		v.push_back(columns[9] + " = " + std::to_string(e.gmspeed));
+		v.push_back(columns[9] + " = " + std::to_string(e.invulnerable));
-		v.push_back(columns[10] + " = " + std::to_string(e.invulnerable));
+		v.push_back(columns[10] + " = " + std::to_string(e.flymode));
-		v.push_back(columns[11] + " = " + std::to_string(e.flymode));
+		v.push_back(columns[11] + " = " + std::to_string(e.ignore_tells));
-		v.push_back(columns[12] + " = " + std::to_string(e.ignore_tells));
+		v.push_back(columns[12] + " = " + std::to_string(e.revoked));
-		v.push_back(columns[13] + " = " + std::to_string(e.revoked));
+		v.push_back(columns[13] + " = " + std::to_string(e.karma));
-		v.push_back(columns[14] + " = " + std::to_string(e.karma));
+		v.push_back(columns[14] + " = '" + Strings::Escape(e.minilogin_ip) + "'");
-		v.push_back(columns[15] + " = '" + Strings::Escape(e.minilogin_ip) + "'");
+		v.push_back(columns[15] + " = " + std::to_string(e.hideme));
-		v.push_back(columns[16] + " = " + std::to_string(e.hideme));
+		v.push_back(columns[16] + " = " + std::to_string(e.rulesflag));
-		v.push_back(columns[17] + " = " + std::to_string(e.rulesflag));
+		v.push_back(columns[17] + " = FROM_UNIXTIME(" + (e.suspendeduntil > 0 ? std::to_string(e.suspendeduntil) : "null") + ")");
-		v.push_back(columns[18] + " = FROM_UNIXTIME(" + (e.suspendeduntil > 0 ? std::to_string(e.suspendeduntil) : "null") + ")");
+		v.push_back(columns[18] + " = " + std::to_string(e.time_creation));
-		v.push_back(columns[19] + " = " + std::to_string(e.time_creation));
+		v.push_back(columns[19] + " = '" + Strings::Escape(e.ban_reason) + "'");
-		v.push_back(columns[20] + " = '" + Strings::Escape(e.ban_reason) + "'");
+		v.push_back(columns[20] + " = '" + Strings::Escape(e.suspend_reason) + "'");
-		v.push_back(columns[21] + " = '" + Strings::Escape(e.suspend_reason) + "'");
+		v.push_back(columns[21] + " = '" + Strings::Escape(e.crc_eqgame) + "'");
-		v.push_back(columns[22] + " = '" + Strings::Escape(e.crc_eqgame) + "'");
+		v.push_back(columns[22] + " = '" + Strings::Escape(e.crc_skillcaps) + "'");
-		v.push_back(columns[23] + " = '" + Strings::Escape(e.crc_skillcaps) + "'");
+		v.push_back(columns[23] + " = '" + Strings::Escape(e.crc_basedata) + "'");
-		v.push_back(columns[24] + " = '" + Strings::Escape(e.crc_basedata) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -317,7 +311,6 @@ public:
 		v.push_back(std::to_string(e.id));
 		v.push_back("'" + Strings::Escape(e.name) + "'");
 		v.push_back("'" + Strings::Escape(e.charname) + "'");
-		v.push_back("'" + Strings::Escape(e.auto_login_charname) + "'");
 		v.push_back(std::to_string(e.sharedplat));
 		v.push_back("'" + Strings::Escape(e.password) + "'");
 		v.push_back(std::to_string(e.status));
@@ -371,7 +364,6 @@ public:
 			v.push_back(std::to_string(e.id));
 			v.push_back("'" + Strings::Escape(e.name) + "'");
 			v.push_back("'" + Strings::Escape(e.charname) + "'");
-			v.push_back("'" + Strings::Escape(e.auto_login_charname) + "'");
 			v.push_back(std::to_string(e.sharedplat));
 			v.push_back("'" + Strings::Escape(e.password) + "'");
 			v.push_back(std::to_string(e.status));
@@ -429,28 +421,27 @@ public:
 			e.id             = row[0] ? static_cast<int32_t>(atoi(row[0])) : 0;
 			e.name           = row[1] ? row[1] : "";
 			e.charname       = row[2] ? row[2] : "";
-			e.auto_login_charname = row[3] ? row[3] : "";
+			e.sharedplat     = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.sharedplat          = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
+			e.password       = row[4] ? row[4] : "";
-			e.password            = row[5] ? row[5] : "";
+			e.status         = row[5] ? static_cast<int32_t>(atoi(row[5])) : 0;
-			e.status              = row[6] ? static_cast<int32_t>(atoi(row[6])) : 0;
+			e.ls_id          = row[6] ? row[6] : "eqemu";
-			e.ls_id               = row[7] ? row[7] : "eqemu";
+			e.lsaccount_id   = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.lsaccount_id        = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
+			e.gmspeed        = row[8] ? static_cast<uint8_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.gmspeed             = row[9] ? static_cast<uint8_t>(strtoul(row[9], nullptr, 10)) : 0;
+			e.invulnerable   = row[9] ? static_cast<int8_t>(atoi(row[9])) : 0;
-			e.invulnerable        = row[10] ? static_cast<int8_t>(atoi(row[10])) : 0;
+			e.flymode        = row[10] ? static_cast<int8_t>(atoi(row[10])) : 0;
-			e.flymode             = row[11] ? static_cast<int8_t>(atoi(row[11])) : 0;
+			e.ignore_tells   = row[11] ? static_cast<int8_t>(atoi(row[11])) : 0;
-			e.ignore_tells        = row[12] ? static_cast<int8_t>(atoi(row[12])) : 0;
+			e.revoked        = row[12] ? static_cast<uint8_t>(strtoul(row[12], nullptr, 10)) : 0;
-			e.revoked             = row[13] ? static_cast<uint8_t>(strtoul(row[13], nullptr, 10)) : 0;
+			e.karma          = row[13] ? static_cast<uint32_t>(strtoul(row[13], nullptr, 10)) : 0;
-			e.karma               = row[14] ? static_cast<uint32_t>(strtoul(row[14], nullptr, 10)) : 0;
+			e.minilogin_ip   = row[14] ? row[14] : "";
-			e.minilogin_ip        = row[15] ? row[15] : "";
+			e.hideme         = row[15] ? static_cast<int8_t>(atoi(row[15])) : 0;
-			e.hideme              = row[16] ? static_cast<int8_t>(atoi(row[16])) : 0;
+			e.rulesflag      = row[16] ? static_cast<uint8_t>(strtoul(row[16], nullptr, 10)) : 0;
-			e.rulesflag           = row[17] ? static_cast<uint8_t>(strtoul(row[17], nullptr, 10)) : 0;
+			e.suspendeduntil = strtoll(row[17] ? row[17] : "-1", nullptr, 10);
-			e.suspendeduntil      = strtoll(row[18] ? row[18] : "-1", nullptr, 10);
+			e.time_creation  = row[18] ? static_cast<uint32_t>(strtoul(row[18], nullptr, 10)) : 0;
-			e.time_creation       = row[19] ? static_cast<uint32_t>(strtoul(row[19], nullptr, 10)) : 0;
+			e.ban_reason     = row[19] ? row[19] : "";
-			e.ban_reason          = row[20] ? row[20] : "";
+			e.suspend_reason = row[20] ? row[20] : "";
-			e.suspend_reason      = row[21] ? row[21] : "";
+			e.crc_eqgame     = row[21] ? row[21] : "";
-			e.crc_eqgame          = row[22] ? row[22] : "";
+			e.crc_skillcaps  = row[22] ? row[22] : "";
-			e.crc_skillcaps       = row[23] ? row[23] : "";
+			e.crc_basedata   = row[23] ? row[23] : "";
-			e.crc_basedata        = row[24] ? row[24] : "";
 
 			all_entries.push_back(e);
 		}
@@ -478,28 +469,27 @@ public:
 			e.id             = row[0] ? static_cast<int32_t>(atoi(row[0])) : 0;
 			e.name           = row[1] ? row[1] : "";
 			e.charname       = row[2] ? row[2] : "";
-			e.auto_login_charname = row[3] ? row[3] : "";
+			e.sharedplat     = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.sharedplat          = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
+			e.password       = row[4] ? row[4] : "";
-			e.password            = row[5] ? row[5] : "";
+			e.status         = row[5] ? static_cast<int32_t>(atoi(row[5])) : 0;
-			e.status              = row[6] ? static_cast<int32_t>(atoi(row[6])) : 0;
+			e.ls_id          = row[6] ? row[6] : "eqemu";
-			e.ls_id               = row[7] ? row[7] : "eqemu";
+			e.lsaccount_id   = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.lsaccount_id        = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
+			e.gmspeed        = row[8] ? static_cast<uint8_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.gmspeed             = row[9] ? static_cast<uint8_t>(strtoul(row[9], nullptr, 10)) : 0;
+			e.invulnerable   = row[9] ? static_cast<int8_t>(atoi(row[9])) : 0;
-			e.invulnerable        = row[10] ? static_cast<int8_t>(atoi(row[10])) : 0;
+			e.flymode        = row[10] ? static_cast<int8_t>(atoi(row[10])) : 0;
-			e.flymode             = row[11] ? static_cast<int8_t>(atoi(row[11])) : 0;
+			e.ignore_tells   = row[11] ? static_cast<int8_t>(atoi(row[11])) : 0;
-			e.ignore_tells        = row[12] ? static_cast<int8_t>(atoi(row[12])) : 0;
+			e.revoked        = row[12] ? static_cast<uint8_t>(strtoul(row[12], nullptr, 10)) : 0;
-			e.revoked             = row[13] ? static_cast<uint8_t>(strtoul(row[13], nullptr, 10)) : 0;
+			e.karma          = row[13] ? static_cast<uint32_t>(strtoul(row[13], nullptr, 10)) : 0;
-			e.karma               = row[14] ? static_cast<uint32_t>(strtoul(row[14], nullptr, 10)) : 0;
+			e.minilogin_ip   = row[14] ? row[14] : "";
-			e.minilogin_ip        = row[15] ? row[15] : "";
+			e.hideme         = row[15] ? static_cast<int8_t>(atoi(row[15])) : 0;
-			e.hideme              = row[16] ? static_cast<int8_t>(atoi(row[16])) : 0;
+			e.rulesflag      = row[16] ? static_cast<uint8_t>(strtoul(row[16], nullptr, 10)) : 0;
-			e.rulesflag           = row[17] ? static_cast<uint8_t>(strtoul(row[17], nullptr, 10)) : 0;
+			e.suspendeduntil = strtoll(row[17] ? row[17] : "-1", nullptr, 10);
-			e.suspendeduntil      = strtoll(row[18] ? row[18] : "-1", nullptr, 10);
+			e.time_creation  = row[18] ? static_cast<uint32_t>(strtoul(row[18], nullptr, 10)) : 0;
-			e.time_creation       = row[19] ? static_cast<uint32_t>(strtoul(row[19], nullptr, 10)) : 0;
+			e.ban_reason     = row[19] ? row[19] : "";
-			e.ban_reason          = row[20] ? row[20] : "";
+			e.suspend_reason = row[20] ? row[20] : "";
-			e.suspend_reason      = row[21] ? row[21] : "";
+			e.crc_eqgame     = row[21] ? row[21] : "";
-			e.crc_eqgame          = row[22] ? row[22] : "";
+			e.crc_skillcaps  = row[22] ? row[22] : "";
-			e.crc_skillcaps       = row[23] ? row[23] : "";
+			e.crc_basedata   = row[23] ? row[23] : "";
-			e.crc_basedata        = row[24] ? row[24] : "";
 
 			all_entries.push_back(e);
 		}
@@ -577,7 +567,6 @@ public:
 		v.push_back(std::to_string(e.id));
 		v.push_back("'" + Strings::Escape(e.name) + "'");
 		v.push_back("'" + Strings::Escape(e.charname) + "'");
-		v.push_back("'" + Strings::Escape(e.auto_login_charname) + "'");
 		v.push_back(std::to_string(e.sharedplat));
 		v.push_back("'" + Strings::Escape(e.password) + "'");
 		v.push_back(std::to_string(e.status));
@@ -624,7 +613,6 @@ public:
 			v.push_back(std::to_string(e.id));
 			v.push_back("'" + Strings::Escape(e.name) + "'");
 			v.push_back("'" + Strings::Escape(e.charname) + "'");
-			v.push_back("'" + Strings::Escape(e.auto_login_charname) + "'");
 			v.push_back(std::to_string(e.sharedplat));
 			v.push_back("'" + Strings::Escape(e.password) + "'");
 			v.push_back(std::to_string(e.status));

common/repositories/base/base_bot_data_repository.h

@@ -57,7 +57,6 @@ public:
 		int32_t     int_;
 		int32_t     agi;
 		int32_t     wis;
-		int32_t     extra_haste;
 		int16_t     fire;
 		int16_t     cold;
 		int16_t     magic;
@@ -119,7 +118,6 @@ public:
 			"`int`",
 			"agi",
 			"wis",
-			"extra_haste",
 			"fire",
 			"cold",
 			"magic",
@@ -177,7 +175,6 @@ public:
 			"`int`",
 			"agi",
 			"wis",
-			"extra_haste",
 			"fire",
 			"cold",
 			"magic",
@@ -269,7 +266,6 @@ public:
 		e.int_                   = 75;
 		e.agi                    = 75;
 		e.wis                    = 75;
-		e.extra_haste            = 0;
 		e.fire                   = 0;
 		e.cold                   = 0;
 		e.magic                  = 0;
@@ -357,20 +353,19 @@ public:
 			e.int_                   = row[35] ? static_cast<int32_t>(atoi(row[35])) : 75;
 			e.agi                    = row[36] ? static_cast<int32_t>(atoi(row[36])) : 75;
 			e.wis                    = row[37] ? static_cast<int32_t>(atoi(row[37])) : 75;
-			e.extra_haste            = row[38] ? static_cast<int32_t>(atoi(row[38])) : 0;
+			e.fire                   = row[38] ? static_cast<int16_t>(atoi(row[38])) : 0;
-			e.fire                   = row[39] ? static_cast<int16_t>(atoi(row[39])) : 0;
+			e.cold                   = row[39] ? static_cast<int16_t>(atoi(row[39])) : 0;
-			e.cold                   = row[40] ? static_cast<int16_t>(atoi(row[40])) : 0;
+			e.magic                  = row[40] ? static_cast<int16_t>(atoi(row[40])) : 0;
-			e.magic                  = row[41] ? static_cast<int16_t>(atoi(row[41])) : 0;
+			e.poison                 = row[41] ? static_cast<int16_t>(atoi(row[41])) : 0;
-			e.poison                 = row[42] ? static_cast<int16_t>(atoi(row[42])) : 0;
+			e.disease                = row[42] ? static_cast<int16_t>(atoi(row[42])) : 0;
-			e.disease                = row[43] ? static_cast<int16_t>(atoi(row[43])) : 0;
+			e.corruption             = row[43] ? static_cast<int16_t>(atoi(row[43])) : 0;
-			e.corruption             = row[44] ? static_cast<int16_t>(atoi(row[44])) : 0;
+			e.show_helm              = row[44] ? static_cast<uint32_t>(strtoul(row[44], nullptr, 10)) : 0;
-			e.show_helm              = row[45] ? static_cast<uint32_t>(strtoul(row[45], nullptr, 10)) : 0;
+			e.follow_distance        = row[45] ? static_cast<uint32_t>(strtoul(row[45], nullptr, 10)) : 200;
-			e.follow_distance        = row[46] ? static_cast<uint32_t>(strtoul(row[46], nullptr, 10)) : 200;
+			e.stop_melee_level       = row[46] ? static_cast<uint8_t>(strtoul(row[46], nullptr, 10)) : 255;
-			e.stop_melee_level       = row[47] ? static_cast<uint8_t>(strtoul(row[47], nullptr, 10)) : 255;
+			e.expansion_bitmask      = row[47] ? static_cast<int32_t>(atoi(row[47])) : -1;
-			e.expansion_bitmask      = row[48] ? static_cast<int32_t>(atoi(row[48])) : -1;
+			e.enforce_spell_settings = row[48] ? static_cast<uint8_t>(strtoul(row[48], nullptr, 10)) : 0;
-			e.enforce_spell_settings = row[49] ? static_cast<uint8_t>(strtoul(row[49], nullptr, 10)) : 0;
+			e.archery_setting        = row[49] ? static_cast<uint8_t>(strtoul(row[49], nullptr, 10)) : 0;
-			e.archery_setting        = row[50] ? static_cast<uint8_t>(strtoul(row[50], nullptr, 10)) : 0;
+			e.caster_range           = row[50] ? static_cast<uint32_t>(strtoul(row[50], nullptr, 10)) : 300;
-			e.caster_range           = row[51] ? static_cast<uint32_t>(strtoul(row[51], nullptr, 10)) : 300;
 
 			return e;
 		}
@@ -441,20 +436,19 @@ public:
 		v.push_back(columns[35] + " = " + std::to_string(e.int_));
 		v.push_back(columns[36] + " = " + std::to_string(e.agi));
 		v.push_back(columns[37] + " = " + std::to_string(e.wis));
-		v.push_back(columns[38] + " = " + std::to_string(e.extra_haste));
+		v.push_back(columns[38] + " = " + std::to_string(e.fire));
-		v.push_back(columns[39] + " = " + std::to_string(e.fire));
+		v.push_back(columns[39] + " = " + std::to_string(e.cold));
-		v.push_back(columns[40] + " = " + std::to_string(e.cold));
+		v.push_back(columns[40] + " = " + std::to_string(e.magic));
-		v.push_back(columns[41] + " = " + std::to_string(e.magic));
+		v.push_back(columns[41] + " = " + std::to_string(e.poison));
-		v.push_back(columns[42] + " = " + std::to_string(e.poison));
+		v.push_back(columns[42] + " = " + std::to_string(e.disease));
-		v.push_back(columns[43] + " = " + std::to_string(e.disease));
+		v.push_back(columns[43] + " = " + std::to_string(e.corruption));
-		v.push_back(columns[44] + " = " + std::to_string(e.corruption));
+		v.push_back(columns[44] + " = " + std::to_string(e.show_helm));
-		v.push_back(columns[45] + " = " + std::to_string(e.show_helm));
+		v.push_back(columns[45] + " = " + std::to_string(e.follow_distance));
-		v.push_back(columns[46] + " = " + std::to_string(e.follow_distance));
+		v.push_back(columns[46] + " = " + std::to_string(e.stop_melee_level));
-		v.push_back(columns[47] + " = " + std::to_string(e.stop_melee_level));
+		v.push_back(columns[47] + " = " + std::to_string(e.expansion_bitmask));
-		v.push_back(columns[48] + " = " + std::to_string(e.expansion_bitmask));
+		v.push_back(columns[48] + " = " + std::to_string(e.enforce_spell_settings));
-		v.push_back(columns[49] + " = " + std::to_string(e.enforce_spell_settings));
+		v.push_back(columns[49] + " = " + std::to_string(e.archery_setting));
-		v.push_back(columns[50] + " = " + std::to_string(e.archery_setting));
+		v.push_back(columns[50] + " = " + std::to_string(e.caster_range));
-		v.push_back(columns[51] + " = " + std::to_string(e.caster_range));
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -514,7 +508,6 @@ public:
 		v.push_back(std::to_string(e.int_));
 		v.push_back(std::to_string(e.agi));
 		v.push_back(std::to_string(e.wis));
-		v.push_back(std::to_string(e.extra_haste));
 		v.push_back(std::to_string(e.fire));
 		v.push_back(std::to_string(e.cold));
 		v.push_back(std::to_string(e.magic));
@@ -595,7 +588,6 @@ public:
 			v.push_back(std::to_string(e.int_));
 			v.push_back(std::to_string(e.agi));
 			v.push_back(std::to_string(e.wis));
-			v.push_back(std::to_string(e.extra_haste));
 			v.push_back(std::to_string(e.fire));
 			v.push_back(std::to_string(e.cold));
 			v.push_back(std::to_string(e.magic));
@@ -680,20 +672,19 @@ public:
 			e.int_                   = row[35] ? static_cast<int32_t>(atoi(row[35])) : 75;
 			e.agi                    = row[36] ? static_cast<int32_t>(atoi(row[36])) : 75;
 			e.wis                    = row[37] ? static_cast<int32_t>(atoi(row[37])) : 75;
-			e.extra_haste            = row[38] ? static_cast<int32_t>(atoi(row[38])) : 0;
+			e.fire                   = row[38] ? static_cast<int16_t>(atoi(row[38])) : 0;
-			e.fire                   = row[39] ? static_cast<int16_t>(atoi(row[39])) : 0;
+			e.cold                   = row[39] ? static_cast<int16_t>(atoi(row[39])) : 0;
-			e.cold                   = row[40] ? static_cast<int16_t>(atoi(row[40])) : 0;
+			e.magic                  = row[40] ? static_cast<int16_t>(atoi(row[40])) : 0;
-			e.magic                  = row[41] ? static_cast<int16_t>(atoi(row[41])) : 0;
+			e.poison                 = row[41] ? static_cast<int16_t>(atoi(row[41])) : 0;
-			e.poison                 = row[42] ? static_cast<int16_t>(atoi(row[42])) : 0;
+			e.disease                = row[42] ? static_cast<int16_t>(atoi(row[42])) : 0;
-			e.disease                = row[43] ? static_cast<int16_t>(atoi(row[43])) : 0;
+			e.corruption             = row[43] ? static_cast<int16_t>(atoi(row[43])) : 0;
-			e.corruption             = row[44] ? static_cast<int16_t>(atoi(row[44])) : 0;
+			e.show_helm              = row[44] ? static_cast<uint32_t>(strtoul(row[44], nullptr, 10)) : 0;
-			e.show_helm              = row[45] ? static_cast<uint32_t>(strtoul(row[45], nullptr, 10)) : 0;
+			e.follow_distance        = row[45] ? static_cast<uint32_t>(strtoul(row[45], nullptr, 10)) : 200;
-			e.follow_distance        = row[46] ? static_cast<uint32_t>(strtoul(row[46], nullptr, 10)) : 200;
+			e.stop_melee_level       = row[46] ? static_cast<uint8_t>(strtoul(row[46], nullptr, 10)) : 255;
-			e.stop_melee_level       = row[47] ? static_cast<uint8_t>(strtoul(row[47], nullptr, 10)) : 255;
+			e.expansion_bitmask      = row[47] ? static_cast<int32_t>(atoi(row[47])) : -1;
-			e.expansion_bitmask      = row[48] ? static_cast<int32_t>(atoi(row[48])) : -1;
+			e.enforce_spell_settings = row[48] ? static_cast<uint8_t>(strtoul(row[48], nullptr, 10)) : 0;
-			e.enforce_spell_settings = row[49] ? static_cast<uint8_t>(strtoul(row[49], nullptr, 10)) : 0;
+			e.archery_setting        = row[49] ? static_cast<uint8_t>(strtoul(row[49], nullptr, 10)) : 0;
-			e.archery_setting        = row[50] ? static_cast<uint8_t>(strtoul(row[50], nullptr, 10)) : 0;
+			e.caster_range           = row[50] ? static_cast<uint32_t>(strtoul(row[50], nullptr, 10)) : 300;
-			e.caster_range           = row[51] ? static_cast<uint32_t>(strtoul(row[51], nullptr, 10)) : 300;
 
 			all_entries.push_back(e);
 		}
@@ -756,20 +747,19 @@ public:
 			e.int_                   = row[35] ? static_cast<int32_t>(atoi(row[35])) : 75;
 			e.agi                    = row[36] ? static_cast<int32_t>(atoi(row[36])) : 75;
 			e.wis                    = row[37] ? static_cast<int32_t>(atoi(row[37])) : 75;
-			e.extra_haste            = row[38] ? static_cast<int32_t>(atoi(row[38])) : 0;
+			e.fire                   = row[38] ? static_cast<int16_t>(atoi(row[38])) : 0;
-			e.fire                   = row[39] ? static_cast<int16_t>(atoi(row[39])) : 0;
+			e.cold                   = row[39] ? static_cast<int16_t>(atoi(row[39])) : 0;
-			e.cold                   = row[40] ? static_cast<int16_t>(atoi(row[40])) : 0;
+			e.magic                  = row[40] ? static_cast<int16_t>(atoi(row[40])) : 0;
-			e.magic                  = row[41] ? static_cast<int16_t>(atoi(row[41])) : 0;
+			e.poison                 = row[41] ? static_cast<int16_t>(atoi(row[41])) : 0;
-			e.poison                 = row[42] ? static_cast<int16_t>(atoi(row[42])) : 0;
+			e.disease                = row[42] ? static_cast<int16_t>(atoi(row[42])) : 0;
-			e.disease                = row[43] ? static_cast<int16_t>(atoi(row[43])) : 0;
+			e.corruption             = row[43] ? static_cast<int16_t>(atoi(row[43])) : 0;
-			e.corruption             = row[44] ? static_cast<int16_t>(atoi(row[44])) : 0;
+			e.show_helm              = row[44] ? static_cast<uint32_t>(strtoul(row[44], nullptr, 10)) : 0;
-			e.show_helm              = row[45] ? static_cast<uint32_t>(strtoul(row[45], nullptr, 10)) : 0;
+			e.follow_distance        = row[45] ? static_cast<uint32_t>(strtoul(row[45], nullptr, 10)) : 200;
-			e.follow_distance        = row[46] ? static_cast<uint32_t>(strtoul(row[46], nullptr, 10)) : 200;
+			e.stop_melee_level       = row[46] ? static_cast<uint8_t>(strtoul(row[46], nullptr, 10)) : 255;
-			e.stop_melee_level       = row[47] ? static_cast<uint8_t>(strtoul(row[47], nullptr, 10)) : 255;
+			e.expansion_bitmask      = row[47] ? static_cast<int32_t>(atoi(row[47])) : -1;
-			e.expansion_bitmask      = row[48] ? static_cast<int32_t>(atoi(row[48])) : -1;
+			e.enforce_spell_settings = row[48] ? static_cast<uint8_t>(strtoul(row[48], nullptr, 10)) : 0;
-			e.enforce_spell_settings = row[49] ? static_cast<uint8_t>(strtoul(row[49], nullptr, 10)) : 0;
+			e.archery_setting        = row[49] ? static_cast<uint8_t>(strtoul(row[49], nullptr, 10)) : 0;
-			e.archery_setting        = row[50] ? static_cast<uint8_t>(strtoul(row[50], nullptr, 10)) : 0;
+			e.caster_range           = row[50] ? static_cast<uint32_t>(strtoul(row[50], nullptr, 10)) : 300;
-			e.caster_range           = row[51] ? static_cast<uint32_t>(strtoul(row[51], nullptr, 10)) : 300;
 
 			all_entries.push_back(e);
 		}
@@ -882,7 +872,6 @@ public:
 		v.push_back(std::to_string(e.int_));
 		v.push_back(std::to_string(e.agi));
 		v.push_back(std::to_string(e.wis));
-		v.push_back(std::to_string(e.extra_haste));
 		v.push_back(std::to_string(e.fire));
 		v.push_back(std::to_string(e.cold));
 		v.push_back(std::to_string(e.magic));
@@ -956,7 +945,6 @@ public:
 			v.push_back(std::to_string(e.int_));
 			v.push_back(std::to_string(e.agi));
 			v.push_back(std::to_string(e.wis));
-			v.push_back(std::to_string(e.extra_haste));
 			v.push_back(std::to_string(e.fire));
 			v.push_back(std::to_string(e.cold));
 			v.push_back(std::to_string(e.magic));

common/repositories/base/base_character_data_repository.h

@@ -77,7 +77,6 @@ public:
 		uint32_t    int_;
 		uint32_t    agi;
 		uint32_t    wis;
-		int32_t     extra_haste;
 		uint32_t    zone_change_count;
 		uint32_t    toxicity;
 		uint32_t    hunger_level;
@@ -191,7 +190,6 @@ public:
 			"`int`",
 			"agi",
 			"wis",
-			"extra_haste",
 			"zone_change_count",
 			"toxicity",
 			"hunger_level",
@@ -301,7 +299,6 @@ public:
 			"`int`",
 			"agi",
 			"wis",
-			"extra_haste",
 			"zone_change_count",
 			"toxicity",
 			"hunger_level",
@@ -445,7 +442,6 @@ public:
 		e.int_                    = 0;
 		e.agi                     = 0;
 		e.wis                     = 0;
-		e.extra_haste             = 0;
 		e.zone_change_count       = 0;
 		e.toxicity                = 0;
 		e.hunger_level            = 0;
@@ -585,52 +581,51 @@ public:
 			e.int_                    = row[55] ? static_cast<uint32_t>(strtoul(row[55], nullptr, 10)) : 0;
 			e.agi                     = row[56] ? static_cast<uint32_t>(strtoul(row[56], nullptr, 10)) : 0;
 			e.wis                     = row[57] ? static_cast<uint32_t>(strtoul(row[57], nullptr, 10)) : 0;
-			e.extra_haste             = row[58] ? static_cast<int32_t>(atoi(row[58])) : 0;
+			e.zone_change_count       = row[58] ? static_cast<uint32_t>(strtoul(row[58], nullptr, 10)) : 0;
-			e.zone_change_count       = row[59] ? static_cast<uint32_t>(strtoul(row[59], nullptr, 10)) : 0;
+			e.toxicity                = row[59] ? static_cast<uint32_t>(strtoul(row[59], nullptr, 10)) : 0;
-			e.toxicity                = row[60] ? static_cast<uint32_t>(strtoul(row[60], nullptr, 10)) : 0;
+			e.hunger_level            = row[60] ? static_cast<uint32_t>(strtoul(row[60], nullptr, 10)) : 0;
-			e.hunger_level            = row[61] ? static_cast<uint32_t>(strtoul(row[61], nullptr, 10)) : 0;
+			e.thirst_level            = row[61] ? static_cast<uint32_t>(strtoul(row[61], nullptr, 10)) : 0;
-			e.thirst_level            = row[62] ? static_cast<uint32_t>(strtoul(row[62], nullptr, 10)) : 0;
+			e.ability_up              = row[62] ? static_cast<uint32_t>(strtoul(row[62], nullptr, 10)) : 0;
-			e.ability_up              = row[63] ? static_cast<uint32_t>(strtoul(row[63], nullptr, 10)) : 0;
+			e.ldon_points_guk         = row[63] ? static_cast<uint32_t>(strtoul(row[63], nullptr, 10)) : 0;
-			e.ldon_points_guk         = row[64] ? static_cast<uint32_t>(strtoul(row[64], nullptr, 10)) : 0;
+			e.ldon_points_mir         = row[64] ? static_cast<uint32_t>(strtoul(row[64], nullptr, 10)) : 0;
-			e.ldon_points_mir         = row[65] ? static_cast<uint32_t>(strtoul(row[65], nullptr, 10)) : 0;
+			e.ldon_points_mmc         = row[65] ? static_cast<uint32_t>(strtoul(row[65], nullptr, 10)) : 0;
-			e.ldon_points_mmc         = row[66] ? static_cast<uint32_t>(strtoul(row[66], nullptr, 10)) : 0;
+			e.ldon_points_ruj         = row[66] ? static_cast<uint32_t>(strtoul(row[66], nullptr, 10)) : 0;
-			e.ldon_points_ruj         = row[67] ? static_cast<uint32_t>(strtoul(row[67], nullptr, 10)) : 0;
+			e.ldon_points_tak         = row[67] ? static_cast<uint32_t>(strtoul(row[67], nullptr, 10)) : 0;
-			e.ldon_points_tak         = row[68] ? static_cast<uint32_t>(strtoul(row[68], nullptr, 10)) : 0;
+			e.ldon_points_available   = row[68] ? static_cast<uint32_t>(strtoul(row[68], nullptr, 10)) : 0;
-			e.ldon_points_available   = row[69] ? static_cast<uint32_t>(strtoul(row[69], nullptr, 10)) : 0;
+			e.tribute_time_remaining  = row[69] ? static_cast<uint32_t>(strtoul(row[69], nullptr, 10)) : 0;
-			e.tribute_time_remaining  = row[70] ? static_cast<uint32_t>(strtoul(row[70], nullptr, 10)) : 0;
+			e.career_tribute_points   = row[70] ? static_cast<uint32_t>(strtoul(row[70], nullptr, 10)) : 0;
-			e.career_tribute_points   = row[71] ? static_cast<uint32_t>(strtoul(row[71], nullptr, 10)) : 0;
+			e.tribute_points          = row[71] ? static_cast<uint32_t>(strtoul(row[71], nullptr, 10)) : 0;
-			e.tribute_points          = row[72] ? static_cast<uint32_t>(strtoul(row[72], nullptr, 10)) : 0;
+			e.tribute_active          = row[72] ? static_cast<uint32_t>(strtoul(row[72], nullptr, 10)) : 0;
-			e.tribute_active          = row[73] ? static_cast<uint32_t>(strtoul(row[73], nullptr, 10)) : 0;
+			e.pvp_status              = row[73] ? static_cast<uint8_t>(strtoul(row[73], nullptr, 10)) : 0;
-			e.pvp_status              = row[74] ? static_cast<uint8_t>(strtoul(row[74], nullptr, 10)) : 0;
+			e.pvp_kills               = row[74] ? static_cast<uint32_t>(strtoul(row[74], nullptr, 10)) : 0;
-			e.pvp_kills               = row[75] ? static_cast<uint32_t>(strtoul(row[75], nullptr, 10)) : 0;
+			e.pvp_deaths              = row[75] ? static_cast<uint32_t>(strtoul(row[75], nullptr, 10)) : 0;
-			e.pvp_deaths              = row[76] ? static_cast<uint32_t>(strtoul(row[76], nullptr, 10)) : 0;
+			e.pvp_current_points      = row[76] ? static_cast<uint32_t>(strtoul(row[76], nullptr, 10)) : 0;
-			e.pvp_current_points      = row[77] ? static_cast<uint32_t>(strtoul(row[77], nullptr, 10)) : 0;
+			e.pvp_career_points       = row[77] ? static_cast<uint32_t>(strtoul(row[77], nullptr, 10)) : 0;
-			e.pvp_career_points       = row[78] ? static_cast<uint32_t>(strtoul(row[78], nullptr, 10)) : 0;
+			e.pvp_best_kill_streak    = row[78] ? static_cast<uint32_t>(strtoul(row[78], nullptr, 10)) : 0;
-			e.pvp_best_kill_streak    = row[79] ? static_cast<uint32_t>(strtoul(row[79], nullptr, 10)) : 0;
+			e.pvp_worst_death_streak  = row[79] ? static_cast<uint32_t>(strtoul(row[79], nullptr, 10)) : 0;
-			e.pvp_worst_death_streak  = row[80] ? static_cast<uint32_t>(strtoul(row[80], nullptr, 10)) : 0;
+			e.pvp_current_kill_streak = row[80] ? static_cast<uint32_t>(strtoul(row[80], nullptr, 10)) : 0;
-			e.pvp_current_kill_streak = row[81] ? static_cast<uint32_t>(strtoul(row[81], nullptr, 10)) : 0;
+			e.pvp2                    = row[81] ? static_cast<uint32_t>(strtoul(row[81], nullptr, 10)) : 0;
-			e.pvp2                    = row[82] ? static_cast<uint32_t>(strtoul(row[82], nullptr, 10)) : 0;
+			e.pvp_type                = row[82] ? static_cast<uint32_t>(strtoul(row[82], nullptr, 10)) : 0;
-			e.pvp_type                = row[83] ? static_cast<uint32_t>(strtoul(row[83], nullptr, 10)) : 0;
+			e.show_helm               = row[83] ? static_cast<uint32_t>(strtoul(row[83], nullptr, 10)) : 0;
-			e.show_helm               = row[84] ? static_cast<uint32_t>(strtoul(row[84], nullptr, 10)) : 0;
+			e.group_auto_consent      = row[84] ? static_cast<uint8_t>(strtoul(row[84], nullptr, 10)) : 0;
-			e.group_auto_consent      = row[85] ? static_cast<uint8_t>(strtoul(row[85], nullptr, 10)) : 0;
+			e.raid_auto_consent       = row[85] ? static_cast<uint8_t>(strtoul(row[85], nullptr, 10)) : 0;
-			e.raid_auto_consent       = row[86] ? static_cast<uint8_t>(strtoul(row[86], nullptr, 10)) : 0;
+			e.guild_auto_consent      = row[86] ? static_cast<uint8_t>(strtoul(row[86], nullptr, 10)) : 0;
-			e.guild_auto_consent      = row[87] ? static_cast<uint8_t>(strtoul(row[87], nullptr, 10)) : 0;
+			e.leadership_exp_on       = row[87] ? static_cast<uint8_t>(strtoul(row[87], nullptr, 10)) : 0;
-			e.leadership_exp_on       = row[88] ? static_cast<uint8_t>(strtoul(row[88], nullptr, 10)) : 0;
+			e.RestTimer               = row[88] ? static_cast<uint32_t>(strtoul(row[88], nullptr, 10)) : 0;
-			e.RestTimer               = row[89] ? static_cast<uint32_t>(strtoul(row[89], nullptr, 10)) : 0;
+			e.air_remaining           = row[89] ? static_cast<uint32_t>(strtoul(row[89], nullptr, 10)) : 0;
-			e.air_remaining           = row[90] ? static_cast<uint32_t>(strtoul(row[90], nullptr, 10)) : 0;
+			e.autosplit_enabled       = row[90] ? static_cast<uint32_t>(strtoul(row[90], nullptr, 10)) : 0;
-			e.autosplit_enabled       = row[91] ? static_cast<uint32_t>(strtoul(row[91], nullptr, 10)) : 0;
+			e.lfp                     = row[91] ? static_cast<uint8_t>(strtoul(row[91], nullptr, 10)) : 0;
-			e.lfp                     = row[92] ? static_cast<uint8_t>(strtoul(row[92], nullptr, 10)) : 0;
+			e.lfg                     = row[92] ? static_cast<uint8_t>(strtoul(row[92], nullptr, 10)) : 0;
-			e.lfg                     = row[93] ? static_cast<uint8_t>(strtoul(row[93], nullptr, 10)) : 0;
+			e.mailkey                 = row[93] ? row[93] : "";
-			e.mailkey                 = row[94] ? row[94] : "";
+			e.xtargets                = row[94] ? static_cast<uint8_t>(strtoul(row[94], nullptr, 10)) : 5;
-			e.xtargets                = row[95] ? static_cast<uint8_t>(strtoul(row[95], nullptr, 10)) : 5;
+			e.firstlogon              = row[95] ? static_cast<int8_t>(atoi(row[95])) : 0;
-			e.firstlogon              = row[96] ? static_cast<int8_t>(atoi(row[96])) : 0;
+			e.e_aa_effects            = row[96] ? static_cast<uint32_t>(strtoul(row[96], nullptr, 10)) : 0;
-			e.e_aa_effects            = row[97] ? static_cast<uint32_t>(strtoul(row[97], nullptr, 10)) : 0;
+			e.e_percent_to_aa         = row[97] ? static_cast<uint32_t>(strtoul(row[97], nullptr, 10)) : 0;
-			e.e_percent_to_aa         = row[98] ? static_cast<uint32_t>(strtoul(row[98], nullptr, 10)) : 0;
+			e.e_expended_aa_spent     = row[98] ? static_cast<uint32_t>(strtoul(row[98], nullptr, 10)) : 0;
-			e.e_expended_aa_spent     = row[99] ? static_cast<uint32_t>(strtoul(row[99], nullptr, 10)) : 0;
+			e.aa_points_spent_old     = row[99] ? static_cast<uint32_t>(strtoul(row[99], nullptr, 10)) : 0;
-			e.aa_points_spent_old     = row[100] ? static_cast<uint32_t>(strtoul(row[100], nullptr, 10)) : 0;
+			e.aa_points_old           = row[100] ? static_cast<uint32_t>(strtoul(row[100], nullptr, 10)) : 0;
-			e.aa_points_old           = row[101] ? static_cast<uint32_t>(strtoul(row[101], nullptr, 10)) : 0;
+			e.e_last_invsnapshot      = row[101] ? static_cast<uint32_t>(strtoul(row[101], nullptr, 10)) : 0;
-			e.e_last_invsnapshot      = row[102] ? static_cast<uint32_t>(strtoul(row[102], nullptr, 10)) : 0;
+			e.deleted_at              = strtoll(row[102] ? row[102] : "-1", nullptr, 10);
-			e.deleted_at              = strtoll(row[103] ? row[103] : "-1", nullptr, 10);
 
 			return e;
 		}
@@ -721,52 +716,51 @@ public:
 		v.push_back(columns[55] + " = " + std::to_string(e.int_));
 		v.push_back(columns[56] + " = " + std::to_string(e.agi));
 		v.push_back(columns[57] + " = " + std::to_string(e.wis));
-		v.push_back(columns[58] + " = " + std::to_string(e.extra_haste));
+		v.push_back(columns[58] + " = " + std::to_string(e.zone_change_count));
-		v.push_back(columns[59] + " = " + std::to_string(e.zone_change_count));
+		v.push_back(columns[59] + " = " + std::to_string(e.toxicity));
-		v.push_back(columns[60] + " = " + std::to_string(e.toxicity));
+		v.push_back(columns[60] + " = " + std::to_string(e.hunger_level));
-		v.push_back(columns[61] + " = " + std::to_string(e.hunger_level));
+		v.push_back(columns[61] + " = " + std::to_string(e.thirst_level));
-		v.push_back(columns[62] + " = " + std::to_string(e.thirst_level));
+		v.push_back(columns[62] + " = " + std::to_string(e.ability_up));
-		v.push_back(columns[63] + " = " + std::to_string(e.ability_up));
+		v.push_back(columns[63] + " = " + std::to_string(e.ldon_points_guk));
-		v.push_back(columns[64] + " = " + std::to_string(e.ldon_points_guk));
+		v.push_back(columns[64] + " = " + std::to_string(e.ldon_points_mir));
-		v.push_back(columns[65] + " = " + std::to_string(e.ldon_points_mir));
+		v.push_back(columns[65] + " = " + std::to_string(e.ldon_points_mmc));
-		v.push_back(columns[66] + " = " + std::to_string(e.ldon_points_mmc));
+		v.push_back(columns[66] + " = " + std::to_string(e.ldon_points_ruj));
-		v.push_back(columns[67] + " = " + std::to_string(e.ldon_points_ruj));
+		v.push_back(columns[67] + " = " + std::to_string(e.ldon_points_tak));
-		v.push_back(columns[68] + " = " + std::to_string(e.ldon_points_tak));
+		v.push_back(columns[68] + " = " + std::to_string(e.ldon_points_available));
-		v.push_back(columns[69] + " = " + std::to_string(e.ldon_points_available));
+		v.push_back(columns[69] + " = " + std::to_string(e.tribute_time_remaining));
-		v.push_back(columns[70] + " = " + std::to_string(e.tribute_time_remaining));
+		v.push_back(columns[70] + " = " + std::to_string(e.career_tribute_points));
-		v.push_back(columns[71] + " = " + std::to_string(e.career_tribute_points));
+		v.push_back(columns[71] + " = " + std::to_string(e.tribute_points));
-		v.push_back(columns[72] + " = " + std::to_string(e.tribute_points));
+		v.push_back(columns[72] + " = " + std::to_string(e.tribute_active));
-		v.push_back(columns[73] + " = " + std::to_string(e.tribute_active));
+		v.push_back(columns[73] + " = " + std::to_string(e.pvp_status));
-		v.push_back(columns[74] + " = " + std::to_string(e.pvp_status));
+		v.push_back(columns[74] + " = " + std::to_string(e.pvp_kills));
-		v.push_back(columns[75] + " = " + std::to_string(e.pvp_kills));
+		v.push_back(columns[75] + " = " + std::to_string(e.pvp_deaths));
-		v.push_back(columns[76] + " = " + std::to_string(e.pvp_deaths));
+		v.push_back(columns[76] + " = " + std::to_string(e.pvp_current_points));
-		v.push_back(columns[77] + " = " + std::to_string(e.pvp_current_points));
+		v.push_back(columns[77] + " = " + std::to_string(e.pvp_career_points));
-		v.push_back(columns[78] + " = " + std::to_string(e.pvp_career_points));
+		v.push_back(columns[78] + " = " + std::to_string(e.pvp_best_kill_streak));
-		v.push_back(columns[79] + " = " + std::to_string(e.pvp_best_kill_streak));
+		v.push_back(columns[79] + " = " + std::to_string(e.pvp_worst_death_streak));
-		v.push_back(columns[80] + " = " + std::to_string(e.pvp_worst_death_streak));
+		v.push_back(columns[80] + " = " + std::to_string(e.pvp_current_kill_streak));
-		v.push_back(columns[81] + " = " + std::to_string(e.pvp_current_kill_streak));
+		v.push_back(columns[81] + " = " + std::to_string(e.pvp2));
-		v.push_back(columns[82] + " = " + std::to_string(e.pvp2));
+		v.push_back(columns[82] + " = " + std::to_string(e.pvp_type));
-		v.push_back(columns[83] + " = " + std::to_string(e.pvp_type));
+		v.push_back(columns[83] + " = " + std::to_string(e.show_helm));
-		v.push_back(columns[84] + " = " + std::to_string(e.show_helm));
+		v.push_back(columns[84] + " = " + std::to_string(e.group_auto_consent));
-		v.push_back(columns[85] + " = " + std::to_string(e.group_auto_consent));
+		v.push_back(columns[85] + " = " + std::to_string(e.raid_auto_consent));
-		v.push_back(columns[86] + " = " + std::to_string(e.raid_auto_consent));
+		v.push_back(columns[86] + " = " + std::to_string(e.guild_auto_consent));
-		v.push_back(columns[87] + " = " + std::to_string(e.guild_auto_consent));
+		v.push_back(columns[87] + " = " + std::to_string(e.leadership_exp_on));
-		v.push_back(columns[88] + " = " + std::to_string(e.leadership_exp_on));
+		v.push_back(columns[88] + " = " + std::to_string(e.RestTimer));
-		v.push_back(columns[89] + " = " + std::to_string(e.RestTimer));
+		v.push_back(columns[89] + " = " + std::to_string(e.air_remaining));
-		v.push_back(columns[90] + " = " + std::to_string(e.air_remaining));
+		v.push_back(columns[90] + " = " + std::to_string(e.autosplit_enabled));
-		v.push_back(columns[91] + " = " + std::to_string(e.autosplit_enabled));
+		v.push_back(columns[91] + " = " + std::to_string(e.lfp));
-		v.push_back(columns[92] + " = " + std::to_string(e.lfp));
+		v.push_back(columns[92] + " = " + std::to_string(e.lfg));
-		v.push_back(columns[93] + " = " + std::to_string(e.lfg));
+		v.push_back(columns[93] + " = '" + Strings::Escape(e.mailkey) + "'");
-		v.push_back(columns[94] + " = '" + Strings::Escape(e.mailkey) + "'");
+		v.push_back(columns[94] + " = " + std::to_string(e.xtargets));
-		v.push_back(columns[95] + " = " + std::to_string(e.xtargets));
+		v.push_back(columns[95] + " = " + std::to_string(e.firstlogon));
-		v.push_back(columns[96] + " = " + std::to_string(e.firstlogon));
+		v.push_back(columns[96] + " = " + std::to_string(e.e_aa_effects));
-		v.push_back(columns[97] + " = " + std::to_string(e.e_aa_effects));
+		v.push_back(columns[97] + " = " + std::to_string(e.e_percent_to_aa));
-		v.push_back(columns[98] + " = " + std::to_string(e.e_percent_to_aa));
+		v.push_back(columns[98] + " = " + std::to_string(e.e_expended_aa_spent));
-		v.push_back(columns[99] + " = " + std::to_string(e.e_expended_aa_spent));
+		v.push_back(columns[99] + " = " + std::to_string(e.aa_points_spent_old));
-		v.push_back(columns[100] + " = " + std::to_string(e.aa_points_spent_old));
+		v.push_back(columns[100] + " = " + std::to_string(e.aa_points_old));
-		v.push_back(columns[101] + " = " + std::to_string(e.aa_points_old));
+		v.push_back(columns[101] + " = " + std::to_string(e.e_last_invsnapshot));
-		v.push_back(columns[102] + " = " + std::to_string(e.e_last_invsnapshot));
+		v.push_back(columns[102] + " = FROM_UNIXTIME(" + (e.deleted_at > 0 ? std::to_string(e.deleted_at) : "null") + ")");
-		v.push_back(columns[103] + " = FROM_UNIXTIME(" + (e.deleted_at > 0 ? std::to_string(e.deleted_at) : "null") + ")");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -846,7 +840,6 @@ public:
 		v.push_back(std::to_string(e.int_));
 		v.push_back(std::to_string(e.agi));
 		v.push_back(std::to_string(e.wis));
-		v.push_back(std::to_string(e.extra_haste));
 		v.push_back(std::to_string(e.zone_change_count));
 		v.push_back(std::to_string(e.toxicity));
 		v.push_back(std::to_string(e.hunger_level));
@@ -979,7 +972,6 @@ public:
 			v.push_back(std::to_string(e.int_));
 			v.push_back(std::to_string(e.agi));
 			v.push_back(std::to_string(e.wis));
-			v.push_back(std::to_string(e.extra_haste));
 			v.push_back(std::to_string(e.zone_change_count));
 			v.push_back(std::to_string(e.toxicity));
 			v.push_back(std::to_string(e.hunger_level));
@@ -1116,52 +1108,51 @@ public:
 			e.int_                    = row[55] ? static_cast<uint32_t>(strtoul(row[55], nullptr, 10)) : 0;
 			e.agi                     = row[56] ? static_cast<uint32_t>(strtoul(row[56], nullptr, 10)) : 0;
 			e.wis                     = row[57] ? static_cast<uint32_t>(strtoul(row[57], nullptr, 10)) : 0;
-			e.extra_haste             = row[58] ? static_cast<int32_t>(atoi(row[58])) : 0;
+			e.zone_change_count       = row[58] ? static_cast<uint32_t>(strtoul(row[58], nullptr, 10)) : 0;
-			e.zone_change_count       = row[59] ? static_cast<uint32_t>(strtoul(row[59], nullptr, 10)) : 0;
+			e.toxicity                = row[59] ? static_cast<uint32_t>(strtoul(row[59], nullptr, 10)) : 0;
-			e.toxicity                = row[60] ? static_cast<uint32_t>(strtoul(row[60], nullptr, 10)) : 0;
+			e.hunger_level            = row[60] ? static_cast<uint32_t>(strtoul(row[60], nullptr, 10)) : 0;
-			e.hunger_level            = row[61] ? static_cast<uint32_t>(strtoul(row[61], nullptr, 10)) : 0;
+			e.thirst_level            = row[61] ? static_cast<uint32_t>(strtoul(row[61], nullptr, 10)) : 0;
-			e.thirst_level            = row[62] ? static_cast<uint32_t>(strtoul(row[62], nullptr, 10)) : 0;
+			e.ability_up              = row[62] ? static_cast<uint32_t>(strtoul(row[62], nullptr, 10)) : 0;
-			e.ability_up              = row[63] ? static_cast<uint32_t>(strtoul(row[63], nullptr, 10)) : 0;
+			e.ldon_points_guk         = row[63] ? static_cast<uint32_t>(strtoul(row[63], nullptr, 10)) : 0;
-			e.ldon_points_guk         = row[64] ? static_cast<uint32_t>(strtoul(row[64], nullptr, 10)) : 0;
+			e.ldon_points_mir         = row[64] ? static_cast<uint32_t>(strtoul(row[64], nullptr, 10)) : 0;
-			e.ldon_points_mir         = row[65] ? static_cast<uint32_t>(strtoul(row[65], nullptr, 10)) : 0;
+			e.ldon_points_mmc         = row[65] ? static_cast<uint32_t>(strtoul(row[65], nullptr, 10)) : 0;
-			e.ldon_points_mmc         = row[66] ? static_cast<uint32_t>(strtoul(row[66], nullptr, 10)) : 0;
+			e.ldon_points_ruj         = row[66] ? static_cast<uint32_t>(strtoul(row[66], nullptr, 10)) : 0;
-			e.ldon_points_ruj         = row[67] ? static_cast<uint32_t>(strtoul(row[67], nullptr, 10)) : 0;
+			e.ldon_points_tak         = row[67] ? static_cast<uint32_t>(strtoul(row[67], nullptr, 10)) : 0;
-			e.ldon_points_tak         = row[68] ? static_cast<uint32_t>(strtoul(row[68], nullptr, 10)) : 0;
+			e.ldon_points_available   = row[68] ? static_cast<uint32_t>(strtoul(row[68], nullptr, 10)) : 0;
-			e.ldon_points_available   = row[69] ? static_cast<uint32_t>(strtoul(row[69], nullptr, 10)) : 0;
+			e.tribute_time_remaining  = row[69] ? static_cast<uint32_t>(strtoul(row[69], nullptr, 10)) : 0;
-			e.tribute_time_remaining  = row[70] ? static_cast<uint32_t>(strtoul(row[70], nullptr, 10)) : 0;
+			e.career_tribute_points   = row[70] ? static_cast<uint32_t>(strtoul(row[70], nullptr, 10)) : 0;
-			e.career_tribute_points   = row[71] ? static_cast<uint32_t>(strtoul(row[71], nullptr, 10)) : 0;
+			e.tribute_points          = row[71] ? static_cast<uint32_t>(strtoul(row[71], nullptr, 10)) : 0;
-			e.tribute_points          = row[72] ? static_cast<uint32_t>(strtoul(row[72], nullptr, 10)) : 0;
+			e.tribute_active          = row[72] ? static_cast<uint32_t>(strtoul(row[72], nullptr, 10)) : 0;
-			e.tribute_active          = row[73] ? static_cast<uint32_t>(strtoul(row[73], nullptr, 10)) : 0;
+			e.pvp_status              = row[73] ? static_cast<uint8_t>(strtoul(row[73], nullptr, 10)) : 0;
-			e.pvp_status              = row[74] ? static_cast<uint8_t>(strtoul(row[74], nullptr, 10)) : 0;
+			e.pvp_kills               = row[74] ? static_cast<uint32_t>(strtoul(row[74], nullptr, 10)) : 0;
-			e.pvp_kills               = row[75] ? static_cast<uint32_t>(strtoul(row[75], nullptr, 10)) : 0;
+			e.pvp_deaths              = row[75] ? static_cast<uint32_t>(strtoul(row[75], nullptr, 10)) : 0;
-			e.pvp_deaths              = row[76] ? static_cast<uint32_t>(strtoul(row[76], nullptr, 10)) : 0;
+			e.pvp_current_points      = row[76] ? static_cast<uint32_t>(strtoul(row[76], nullptr, 10)) : 0;
-			e.pvp_current_points      = row[77] ? static_cast<uint32_t>(strtoul(row[77], nullptr, 10)) : 0;
+			e.pvp_career_points       = row[77] ? static_cast<uint32_t>(strtoul(row[77], nullptr, 10)) : 0;
-			e.pvp_career_points       = row[78] ? static_cast<uint32_t>(strtoul(row[78], nullptr, 10)) : 0;
+			e.pvp_best_kill_streak    = row[78] ? static_cast<uint32_t>(strtoul(row[78], nullptr, 10)) : 0;
-			e.pvp_best_kill_streak    = row[79] ? static_cast<uint32_t>(strtoul(row[79], nullptr, 10)) : 0;
+			e.pvp_worst_death_streak  = row[79] ? static_cast<uint32_t>(strtoul(row[79], nullptr, 10)) : 0;
-			e.pvp_worst_death_streak  = row[80] ? static_cast<uint32_t>(strtoul(row[80], nullptr, 10)) : 0;
+			e.pvp_current_kill_streak = row[80] ? static_cast<uint32_t>(strtoul(row[80], nullptr, 10)) : 0;
-			e.pvp_current_kill_streak = row[81] ? static_cast<uint32_t>(strtoul(row[81], nullptr, 10)) : 0;
+			e.pvp2                    = row[81] ? static_cast<uint32_t>(strtoul(row[81], nullptr, 10)) : 0;
-			e.pvp2                    = row[82] ? static_cast<uint32_t>(strtoul(row[82], nullptr, 10)) : 0;
+			e.pvp_type                = row[82] ? static_cast<uint32_t>(strtoul(row[82], nullptr, 10)) : 0;
-			e.pvp_type                = row[83] ? static_cast<uint32_t>(strtoul(row[83], nullptr, 10)) : 0;
+			e.show_helm               = row[83] ? static_cast<uint32_t>(strtoul(row[83], nullptr, 10)) : 0;
-			e.show_helm               = row[84] ? static_cast<uint32_t>(strtoul(row[84], nullptr, 10)) : 0;
+			e.group_auto_consent      = row[84] ? static_cast<uint8_t>(strtoul(row[84], nullptr, 10)) : 0;
-			e.group_auto_consent      = row[85] ? static_cast<uint8_t>(strtoul(row[85], nullptr, 10)) : 0;
+			e.raid_auto_consent       = row[85] ? static_cast<uint8_t>(strtoul(row[85], nullptr, 10)) : 0;
-			e.raid_auto_consent       = row[86] ? static_cast<uint8_t>(strtoul(row[86], nullptr, 10)) : 0;
+			e.guild_auto_consent      = row[86] ? static_cast<uint8_t>(strtoul(row[86], nullptr, 10)) : 0;
-			e.guild_auto_consent      = row[87] ? static_cast<uint8_t>(strtoul(row[87], nullptr, 10)) : 0;
+			e.leadership_exp_on       = row[87] ? static_cast<uint8_t>(strtoul(row[87], nullptr, 10)) : 0;
-			e.leadership_exp_on       = row[88] ? static_cast<uint8_t>(strtoul(row[88], nullptr, 10)) : 0;
+			e.RestTimer               = row[88] ? static_cast<uint32_t>(strtoul(row[88], nullptr, 10)) : 0;
-			e.RestTimer               = row[89] ? static_cast<uint32_t>(strtoul(row[89], nullptr, 10)) : 0;
+			e.air_remaining           = row[89] ? static_cast<uint32_t>(strtoul(row[89], nullptr, 10)) : 0;
-			e.air_remaining           = row[90] ? static_cast<uint32_t>(strtoul(row[90], nullptr, 10)) : 0;
+			e.autosplit_enabled       = row[90] ? static_cast<uint32_t>(strtoul(row[90], nullptr, 10)) : 0;
-			e.autosplit_enabled       = row[91] ? static_cast<uint32_t>(strtoul(row[91], nullptr, 10)) : 0;
+			e.lfp                     = row[91] ? static_cast<uint8_t>(strtoul(row[91], nullptr, 10)) : 0;
-			e.lfp                     = row[92] ? static_cast<uint8_t>(strtoul(row[92], nullptr, 10)) : 0;
+			e.lfg                     = row[92] ? static_cast<uint8_t>(strtoul(row[92], nullptr, 10)) : 0;
-			e.lfg                     = row[93] ? static_cast<uint8_t>(strtoul(row[93], nullptr, 10)) : 0;
+			e.mailkey                 = row[93] ? row[93] : "";
-			e.mailkey                 = row[94] ? row[94] : "";
+			e.xtargets                = row[94] ? static_cast<uint8_t>(strtoul(row[94], nullptr, 10)) : 5;
-			e.xtargets                = row[95] ? static_cast<uint8_t>(strtoul(row[95], nullptr, 10)) : 5;
+			e.firstlogon              = row[95] ? static_cast<int8_t>(atoi(row[95])) : 0;
-			e.firstlogon              = row[96] ? static_cast<int8_t>(atoi(row[96])) : 0;
+			e.e_aa_effects            = row[96] ? static_cast<uint32_t>(strtoul(row[96], nullptr, 10)) : 0;
-			e.e_aa_effects            = row[97] ? static_cast<uint32_t>(strtoul(row[97], nullptr, 10)) : 0;
+			e.e_percent_to_aa         = row[97] ? static_cast<uint32_t>(strtoul(row[97], nullptr, 10)) : 0;
-			e.e_percent_to_aa         = row[98] ? static_cast<uint32_t>(strtoul(row[98], nullptr, 10)) : 0;
+			e.e_expended_aa_spent     = row[98] ? static_cast<uint32_t>(strtoul(row[98], nullptr, 10)) : 0;
-			e.e_expended_aa_spent     = row[99] ? static_cast<uint32_t>(strtoul(row[99], nullptr, 10)) : 0;
+			e.aa_points_spent_old     = row[99] ? static_cast<uint32_t>(strtoul(row[99], nullptr, 10)) : 0;
-			e.aa_points_spent_old     = row[100] ? static_cast<uint32_t>(strtoul(row[100], nullptr, 10)) : 0;
+			e.aa_points_old           = row[100] ? static_cast<uint32_t>(strtoul(row[100], nullptr, 10)) : 0;
-			e.aa_points_old           = row[101] ? static_cast<uint32_t>(strtoul(row[101], nullptr, 10)) : 0;
+			e.e_last_invsnapshot      = row[101] ? static_cast<uint32_t>(strtoul(row[101], nullptr, 10)) : 0;
-			e.e_last_invsnapshot      = row[102] ? static_cast<uint32_t>(strtoul(row[102], nullptr, 10)) : 0;
+			e.deleted_at              = strtoll(row[102] ? row[102] : "-1", nullptr, 10);
-			e.deleted_at              = strtoll(row[103] ? row[103] : "-1", nullptr, 10);
 
 			all_entries.push_back(e);
 		}
@@ -1244,52 +1235,51 @@ public:
 			e.int_                    = row[55] ? static_cast<uint32_t>(strtoul(row[55], nullptr, 10)) : 0;
 			e.agi                     = row[56] ? static_cast<uint32_t>(strtoul(row[56], nullptr, 10)) : 0;
 			e.wis                     = row[57] ? static_cast<uint32_t>(strtoul(row[57], nullptr, 10)) : 0;
-			e.extra_haste             = row[58] ? static_cast<int32_t>(atoi(row[58])) : 0;
+			e.zone_change_count       = row[58] ? static_cast<uint32_t>(strtoul(row[58], nullptr, 10)) : 0;
-			e.zone_change_count       = row[59] ? static_cast<uint32_t>(strtoul(row[59], nullptr, 10)) : 0;
+			e.toxicity                = row[59] ? static_cast<uint32_t>(strtoul(row[59], nullptr, 10)) : 0;
-			e.toxicity                = row[60] ? static_cast<uint32_t>(strtoul(row[60], nullptr, 10)) : 0;
+			e.hunger_level            = row[60] ? static_cast<uint32_t>(strtoul(row[60], nullptr, 10)) : 0;
-			e.hunger_level            = row[61] ? static_cast<uint32_t>(strtoul(row[61], nullptr, 10)) : 0;
+			e.thirst_level            = row[61] ? static_cast<uint32_t>(strtoul(row[61], nullptr, 10)) : 0;
-			e.thirst_level            = row[62] ? static_cast<uint32_t>(strtoul(row[62], nullptr, 10)) : 0;
+			e.ability_up              = row[62] ? static_cast<uint32_t>(strtoul(row[62], nullptr, 10)) : 0;
-			e.ability_up              = row[63] ? static_cast<uint32_t>(strtoul(row[63], nullptr, 10)) : 0;
+			e.ldon_points_guk         = row[63] ? static_cast<uint32_t>(strtoul(row[63], nullptr, 10)) : 0;
-			e.ldon_points_guk         = row[64] ? static_cast<uint32_t>(strtoul(row[64], nullptr, 10)) : 0;
+			e.ldon_points_mir         = row[64] ? static_cast<uint32_t>(strtoul(row[64], nullptr, 10)) : 0;
-			e.ldon_points_mir         = row[65] ? static_cast<uint32_t>(strtoul(row[65], nullptr, 10)) : 0;
+			e.ldon_points_mmc         = row[65] ? static_cast<uint32_t>(strtoul(row[65], nullptr, 10)) : 0;
-			e.ldon_points_mmc         = row[66] ? static_cast<uint32_t>(strtoul(row[66], nullptr, 10)) : 0;
+			e.ldon_points_ruj         = row[66] ? static_cast<uint32_t>(strtoul(row[66], nullptr, 10)) : 0;
-			e.ldon_points_ruj         = row[67] ? static_cast<uint32_t>(strtoul(row[67], nullptr, 10)) : 0;
+			e.ldon_points_tak         = row[67] ? static_cast<uint32_t>(strtoul(row[67], nullptr, 10)) : 0;
-			e.ldon_points_tak         = row[68] ? static_cast<uint32_t>(strtoul(row[68], nullptr, 10)) : 0;
+			e.ldon_points_available   = row[68] ? static_cast<uint32_t>(strtoul(row[68], nullptr, 10)) : 0;
-			e.ldon_points_available   = row[69] ? static_cast<uint32_t>(strtoul(row[69], nullptr, 10)) : 0;
+			e.tribute_time_remaining  = row[69] ? static_cast<uint32_t>(strtoul(row[69], nullptr, 10)) : 0;
-			e.tribute_time_remaining  = row[70] ? static_cast<uint32_t>(strtoul(row[70], nullptr, 10)) : 0;
+			e.career_tribute_points   = row[70] ? static_cast<uint32_t>(strtoul(row[70], nullptr, 10)) : 0;
-			e.career_tribute_points   = row[71] ? static_cast<uint32_t>(strtoul(row[71], nullptr, 10)) : 0;
+			e.tribute_points          = row[71] ? static_cast<uint32_t>(strtoul(row[71], nullptr, 10)) : 0;
-			e.tribute_points          = row[72] ? static_cast<uint32_t>(strtoul(row[72], nullptr, 10)) : 0;
+			e.tribute_active          = row[72] ? static_cast<uint32_t>(strtoul(row[72], nullptr, 10)) : 0;
-			e.tribute_active          = row[73] ? static_cast<uint32_t>(strtoul(row[73], nullptr, 10)) : 0;
+			e.pvp_status              = row[73] ? static_cast<uint8_t>(strtoul(row[73], nullptr, 10)) : 0;
-			e.pvp_status              = row[74] ? static_cast<uint8_t>(strtoul(row[74], nullptr, 10)) : 0;
+			e.pvp_kills               = row[74] ? static_cast<uint32_t>(strtoul(row[74], nullptr, 10)) : 0;
-			e.pvp_kills               = row[75] ? static_cast<uint32_t>(strtoul(row[75], nullptr, 10)) : 0;
+			e.pvp_deaths              = row[75] ? static_cast<uint32_t>(strtoul(row[75], nullptr, 10)) : 0;
-			e.pvp_deaths              = row[76] ? static_cast<uint32_t>(strtoul(row[76], nullptr, 10)) : 0;
+			e.pvp_current_points      = row[76] ? static_cast<uint32_t>(strtoul(row[76], nullptr, 10)) : 0;
-			e.pvp_current_points      = row[77] ? static_cast<uint32_t>(strtoul(row[77], nullptr, 10)) : 0;
+			e.pvp_career_points       = row[77] ? static_cast<uint32_t>(strtoul(row[77], nullptr, 10)) : 0;
-			e.pvp_career_points       = row[78] ? static_cast<uint32_t>(strtoul(row[78], nullptr, 10)) : 0;
+			e.pvp_best_kill_streak    = row[78] ? static_cast<uint32_t>(strtoul(row[78], nullptr, 10)) : 0;
-			e.pvp_best_kill_streak    = row[79] ? static_cast<uint32_t>(strtoul(row[79], nullptr, 10)) : 0;
+			e.pvp_worst_death_streak  = row[79] ? static_cast<uint32_t>(strtoul(row[79], nullptr, 10)) : 0;
-			e.pvp_worst_death_streak  = row[80] ? static_cast<uint32_t>(strtoul(row[80], nullptr, 10)) : 0;
+			e.pvp_current_kill_streak = row[80] ? static_cast<uint32_t>(strtoul(row[80], nullptr, 10)) : 0;
-			e.pvp_current_kill_streak = row[81] ? static_cast<uint32_t>(strtoul(row[81], nullptr, 10)) : 0;
+			e.pvp2                    = row[81] ? static_cast<uint32_t>(strtoul(row[81], nullptr, 10)) : 0;
-			e.pvp2                    = row[82] ? static_cast<uint32_t>(strtoul(row[82], nullptr, 10)) : 0;
+			e.pvp_type                = row[82] ? static_cast<uint32_t>(strtoul(row[82], nullptr, 10)) : 0;
-			e.pvp_type                = row[83] ? static_cast<uint32_t>(strtoul(row[83], nullptr, 10)) : 0;
+			e.show_helm               = row[83] ? static_cast<uint32_t>(strtoul(row[83], nullptr, 10)) : 0;
-			e.show_helm               = row[84] ? static_cast<uint32_t>(strtoul(row[84], nullptr, 10)) : 0;
+			e.group_auto_consent      = row[84] ? static_cast<uint8_t>(strtoul(row[84], nullptr, 10)) : 0;
-			e.group_auto_consent      = row[85] ? static_cast<uint8_t>(strtoul(row[85], nullptr, 10)) : 0;
+			e.raid_auto_consent       = row[85] ? static_cast<uint8_t>(strtoul(row[85], nullptr, 10)) : 0;
-			e.raid_auto_consent       = row[86] ? static_cast<uint8_t>(strtoul(row[86], nullptr, 10)) : 0;
+			e.guild_auto_consent      = row[86] ? static_cast<uint8_t>(strtoul(row[86], nullptr, 10)) : 0;
-			e.guild_auto_consent      = row[87] ? static_cast<uint8_t>(strtoul(row[87], nullptr, 10)) : 0;
+			e.leadership_exp_on       = row[87] ? static_cast<uint8_t>(strtoul(row[87], nullptr, 10)) : 0;
-			e.leadership_exp_on       = row[88] ? static_cast<uint8_t>(strtoul(row[88], nullptr, 10)) : 0;
+			e.RestTimer               = row[88] ? static_cast<uint32_t>(strtoul(row[88], nullptr, 10)) : 0;
-			e.RestTimer               = row[89] ? static_cast<uint32_t>(strtoul(row[89], nullptr, 10)) : 0;
+			e.air_remaining           = row[89] ? static_cast<uint32_t>(strtoul(row[89], nullptr, 10)) : 0;
-			e.air_remaining           = row[90] ? static_cast<uint32_t>(strtoul(row[90], nullptr, 10)) : 0;
+			e.autosplit_enabled       = row[90] ? static_cast<uint32_t>(strtoul(row[90], nullptr, 10)) : 0;
-			e.autosplit_enabled       = row[91] ? static_cast<uint32_t>(strtoul(row[91], nullptr, 10)) : 0;
+			e.lfp                     = row[91] ? static_cast<uint8_t>(strtoul(row[91], nullptr, 10)) : 0;
-			e.lfp                     = row[92] ? static_cast<uint8_t>(strtoul(row[92], nullptr, 10)) : 0;
+			e.lfg                     = row[92] ? static_cast<uint8_t>(strtoul(row[92], nullptr, 10)) : 0;
-			e.lfg                     = row[93] ? static_cast<uint8_t>(strtoul(row[93], nullptr, 10)) : 0;
+			e.mailkey                 = row[93] ? row[93] : "";
-			e.mailkey                 = row[94] ? row[94] : "";
+			e.xtargets                = row[94] ? static_cast<uint8_t>(strtoul(row[94], nullptr, 10)) : 5;
-			e.xtargets                = row[95] ? static_cast<uint8_t>(strtoul(row[95], nullptr, 10)) : 5;
+			e.firstlogon              = row[95] ? static_cast<int8_t>(atoi(row[95])) : 0;
-			e.firstlogon              = row[96] ? static_cast<int8_t>(atoi(row[96])) : 0;
+			e.e_aa_effects            = row[96] ? static_cast<uint32_t>(strtoul(row[96], nullptr, 10)) : 0;
-			e.e_aa_effects            = row[97] ? static_cast<uint32_t>(strtoul(row[97], nullptr, 10)) : 0;
+			e.e_percent_to_aa         = row[97] ? static_cast<uint32_t>(strtoul(row[97], nullptr, 10)) : 0;
-			e.e_percent_to_aa         = row[98] ? static_cast<uint32_t>(strtoul(row[98], nullptr, 10)) : 0;
+			e.e_expended_aa_spent     = row[98] ? static_cast<uint32_t>(strtoul(row[98], nullptr, 10)) : 0;
-			e.e_expended_aa_spent     = row[99] ? static_cast<uint32_t>(strtoul(row[99], nullptr, 10)) : 0;
+			e.aa_points_spent_old     = row[99] ? static_cast<uint32_t>(strtoul(row[99], nullptr, 10)) : 0;
-			e.aa_points_spent_old     = row[100] ? static_cast<uint32_t>(strtoul(row[100], nullptr, 10)) : 0;
+			e.aa_points_old           = row[100] ? static_cast<uint32_t>(strtoul(row[100], nullptr, 10)) : 0;
-			e.aa_points_old           = row[101] ? static_cast<uint32_t>(strtoul(row[101], nullptr, 10)) : 0;
+			e.e_last_invsnapshot      = row[101] ? static_cast<uint32_t>(strtoul(row[101], nullptr, 10)) : 0;
-			e.e_last_invsnapshot      = row[102] ? static_cast<uint32_t>(strtoul(row[102], nullptr, 10)) : 0;
+			e.deleted_at              = strtoll(row[102] ? row[102] : "-1", nullptr, 10);
-			e.deleted_at              = strtoll(row[103] ? row[103] : "-1", nullptr, 10);
 
 			all_entries.push_back(e);
 		}
@@ -1422,7 +1412,6 @@ public:
 		v.push_back(std::to_string(e.int_));
 		v.push_back(std::to_string(e.agi));
 		v.push_back(std::to_string(e.wis));
-		v.push_back(std::to_string(e.extra_haste));
 		v.push_back(std::to_string(e.zone_change_count));
 		v.push_back(std::to_string(e.toxicity));
 		v.push_back(std::to_string(e.hunger_level));
@@ -1548,7 +1537,6 @@ public:
 			v.push_back(std::to_string(e.int_));
 			v.push_back(std::to_string(e.agi));
 			v.push_back(std::to_string(e.wis));
-			v.push_back(std::to_string(e.extra_haste));
 			v.push_back(std::to_string(e.zone_change_count));
 			v.push_back(std::to_string(e.toxicity));
 			v.push_back(std::to_string(e.hunger_level));

common/repositories/base/base_character_parcels_containers_repository.h

@@ -1,499 +0,0 @@
-/**
- * DO NOT MODIFY THIS FILE
- *
- * This repository was automatically generated and is NOT to be modified directly.
- * Any repository modifications are meant to be made to the repository extending the base.
- * Any modifications to base repositories are to be made by the generator only
- *
- * @generator ./utils/scripts/generators/repository-generator.pl
- * @docs https://docs.eqemu.io/developer/repositories
- */
-
-#ifndef EQEMU_BASE_CHARACTER_PARCELS_CONTAINERS_REPOSITORY_H
-#define EQEMU_BASE_CHARACTER_PARCELS_CONTAINERS_REPOSITORY_H
-
-#include "../../database.h"
-#include "../../strings.h"
-#include <ctime>
-
-class BaseCharacterParcelsContainersRepository {
-public:
-	struct CharacterParcelsContainers {
-		uint32_t id;
-		uint32_t parcels_id;
-		uint32_t slot_id;
-		uint32_t item_id;
-		uint32_t aug_slot_1;
-		uint32_t aug_slot_2;
-		uint32_t aug_slot_3;
-		uint32_t aug_slot_4;
-		uint32_t aug_slot_5;
-		uint32_t aug_slot_6;
-		uint32_t quantity;
-	};
-
-	static std::string PrimaryKey()
-	{
-		return std::string("id");
-	}
-
-	static std::vector<std::string> Columns()
-	{
-		return {
-			"id",
-			"parcels_id",
-			"slot_id",
-			"item_id",
-			"aug_slot_1",
-			"aug_slot_2",
-			"aug_slot_3",
-			"aug_slot_4",
-			"aug_slot_5",
-			"aug_slot_6",
-			"quantity",
-		};
-	}
-
-	static std::vector<std::string> SelectColumns()
-	{
-		return {
-			"id",
-			"parcels_id",
-			"slot_id",
-			"item_id",
-			"aug_slot_1",
-			"aug_slot_2",
-			"aug_slot_3",
-			"aug_slot_4",
-			"aug_slot_5",
-			"aug_slot_6",
-			"quantity",
-		};
-	}
-
-	static std::string ColumnsRaw()
-	{
-		return std::string(Strings::Implode(", ", Columns()));
-	}
-
-	static std::string SelectColumnsRaw()
-	{
-		return std::string(Strings::Implode(", ", SelectColumns()));
-	}
-
-	static std::string TableName()
-	{
-		return std::string("character_parcels_containers");
-	}
-
-	static std::string BaseSelect()
-	{
-		return fmt::format(
-			"SELECT {} FROM {}",
-			SelectColumnsRaw(),
-			TableName()
-		);
-	}
-
-	static std::string BaseInsert()
-	{
-		return fmt::format(
-			"INSERT INTO {} ({}) ",
-			TableName(),
-			ColumnsRaw()
-		);
-	}
-
-	static CharacterParcelsContainers NewEntity()
-	{
-		CharacterParcelsContainers e{};
-
-		e.id         = 0;
-		e.parcels_id = 0;
-		e.slot_id    = 0;
-		e.item_id    = 0;
-		e.aug_slot_1 = 0;
-		e.aug_slot_2 = 0;
-		e.aug_slot_3 = 0;
-		e.aug_slot_4 = 0;
-		e.aug_slot_5 = 0;
-		e.aug_slot_6 = 0;
-		e.quantity   = 0;
-
-		return e;
-	}
-
-	static CharacterParcelsContainers GetCharacterParcelsContainers(
-		const std::vector<CharacterParcelsContainers> &character_parcels_containerss,
-		int character_parcels_containers_id
-	)
-	{
-		for (auto &character_parcels_containers : character_parcels_containerss) {
-			if (character_parcels_containers.id == character_parcels_containers_id) {
-				return character_parcels_containers;
-			}
-		}
-
-		return NewEntity();
-	}
-
-	static CharacterParcelsContainers FindOne(
-		Database& db,
-		int character_parcels_containers_id
-	)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} WHERE {} = {} LIMIT 1",
-				BaseSelect(),
-				PrimaryKey(),
-				character_parcels_containers_id
-			)
-		);
-
-		auto row = results.begin();
-		if (results.RowCount() == 1) {
-			CharacterParcelsContainers e{};
-
-			e.id         = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.parcels_id = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.slot_id    = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.item_id    = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.aug_slot_1 = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_2 = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_3 = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_4 = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_5 = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.aug_slot_6 = row[9] ? static_cast<uint32_t>(strtoul(row[9], nullptr, 10)) : 0;
-			e.quantity   = row[10] ? static_cast<uint32_t>(strtoul(row[10], nullptr, 10)) : 0;
-
-			return e;
-		}
-
-		return NewEntity();
-	}
-
-	static int DeleteOne(
-		Database& db,
-		int character_parcels_containers_id
-	)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"DELETE FROM {} WHERE {} = {}",
-				TableName(),
-				PrimaryKey(),
-				character_parcels_containers_id
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int UpdateOne(
-		Database& db,
-		const CharacterParcelsContainers &e
-	)
-	{
-		std::vector<std::string> v;
-
-		auto columns = Columns();
-
-		v.push_back(columns[1] + " = " + std::to_string(e.parcels_id));
-		v.push_back(columns[2] + " = " + std::to_string(e.slot_id));
-		v.push_back(columns[3] + " = " + std::to_string(e.item_id));
-		v.push_back(columns[4] + " = " + std::to_string(e.aug_slot_1));
-		v.push_back(columns[5] + " = " + std::to_string(e.aug_slot_2));
-		v.push_back(columns[6] + " = " + std::to_string(e.aug_slot_3));
-		v.push_back(columns[7] + " = " + std::to_string(e.aug_slot_4));
-		v.push_back(columns[8] + " = " + std::to_string(e.aug_slot_5));
-		v.push_back(columns[9] + " = " + std::to_string(e.aug_slot_6));
-		v.push_back(columns[10] + " = " + std::to_string(e.quantity));
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"UPDATE {} SET {} WHERE {} = {}",
-				TableName(),
-				Strings::Implode(", ", v),
-				PrimaryKey(),
-				e.id
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static CharacterParcelsContainers InsertOne(
-		Database& db,
-		CharacterParcelsContainers e
-	)
-	{
-		std::vector<std::string> v;
-
-		v.push_back(std::to_string(e.id));
-		v.push_back(std::to_string(e.parcels_id));
-		v.push_back(std::to_string(e.slot_id));
-		v.push_back(std::to_string(e.item_id));
-		v.push_back(std::to_string(e.aug_slot_1));
-		v.push_back(std::to_string(e.aug_slot_2));
-		v.push_back(std::to_string(e.aug_slot_3));
-		v.push_back(std::to_string(e.aug_slot_4));
-		v.push_back(std::to_string(e.aug_slot_5));
-		v.push_back(std::to_string(e.aug_slot_6));
-		v.push_back(std::to_string(e.quantity));
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES ({})",
-				BaseInsert(),
-				Strings::Implode(",", v)
-			)
-		);
-
-		if (results.Success()) {
-			e.id = results.LastInsertedID();
-			return e;
-		}
-
-		e = NewEntity();
-
-		return e;
-	}
-
-	static int InsertMany(
-		Database& db,
-		const std::vector<CharacterParcelsContainers> &entries
-	)
-	{
-		std::vector<std::string> insert_chunks;
-
-		for (auto &e: entries) {
-			std::vector<std::string> v;
-
-			v.push_back(std::to_string(e.id));
-			v.push_back(std::to_string(e.parcels_id));
-			v.push_back(std::to_string(e.slot_id));
-			v.push_back(std::to_string(e.item_id));
-			v.push_back(std::to_string(e.aug_slot_1));
-			v.push_back(std::to_string(e.aug_slot_2));
-			v.push_back(std::to_string(e.aug_slot_3));
-			v.push_back(std::to_string(e.aug_slot_4));
-			v.push_back(std::to_string(e.aug_slot_5));
-			v.push_back(std::to_string(e.aug_slot_6));
-			v.push_back(std::to_string(e.quantity));
-
-			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
-		}
-
-		std::vector<std::string> v;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES {}",
-				BaseInsert(),
-				Strings::Implode(",", insert_chunks)
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static std::vector<CharacterParcelsContainers> All(Database& db)
-	{
-		std::vector<CharacterParcelsContainers> all_entries;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{}",
-				BaseSelect()
-			)
-		);
-
-		all_entries.reserve(results.RowCount());
-
-		for (auto row = results.begin(); row != results.end(); ++row) {
-			CharacterParcelsContainers e{};
-
-			e.id         = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.parcels_id = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.slot_id    = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.item_id    = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.aug_slot_1 = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_2 = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_3 = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_4 = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_5 = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.aug_slot_6 = row[9] ? static_cast<uint32_t>(strtoul(row[9], nullptr, 10)) : 0;
-			e.quantity   = row[10] ? static_cast<uint32_t>(strtoul(row[10], nullptr, 10)) : 0;
-
-			all_entries.push_back(e);
-		}
-
-		return all_entries;
-	}
-
-	static std::vector<CharacterParcelsContainers> GetWhere(Database& db, const std::string &where_filter)
-	{
-		std::vector<CharacterParcelsContainers> all_entries;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} WHERE {}",
-				BaseSelect(),
-				where_filter
-			)
-		);
-
-		all_entries.reserve(results.RowCount());
-
-		for (auto row = results.begin(); row != results.end(); ++row) {
-			CharacterParcelsContainers e{};
-
-			e.id         = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.parcels_id = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.slot_id    = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.item_id    = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.aug_slot_1 = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_2 = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_3 = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_4 = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_5 = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.aug_slot_6 = row[9] ? static_cast<uint32_t>(strtoul(row[9], nullptr, 10)) : 0;
-			e.quantity   = row[10] ? static_cast<uint32_t>(strtoul(row[10], nullptr, 10)) : 0;
-
-			all_entries.push_back(e);
-		}
-
-		return all_entries;
-	}
-
-	static int DeleteWhere(Database& db, const std::string &where_filter)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"DELETE FROM {} WHERE {}",
-				TableName(),
-				where_filter
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int Truncate(Database& db)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"TRUNCATE TABLE {}",
-				TableName()
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int64 GetMaxId(Database& db)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"SELECT COALESCE(MAX({}), 0) FROM {}",
-				PrimaryKey(),
-				TableName()
-			)
-		);
-
-		return (results.Success() && results.begin()[0] ? strtoll(results.begin()[0], nullptr, 10) : 0);
-	}
-
-	static int64 Count(Database& db, const std::string &where_filter = "")
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"SELECT COUNT(*) FROM {} {}",
-				TableName(),
-				(where_filter.empty() ? "" : "WHERE " + where_filter)
-			)
-		);
-
-		return (results.Success() && results.begin()[0] ? strtoll(results.begin()[0], nullptr, 10) : 0);
-	}
-
-	static std::string BaseReplace()
-	{
-		return fmt::format(
-			"REPLACE INTO {} ({}) ",
-			TableName(),
-			ColumnsRaw()
-		);
-	}
-
-	static int ReplaceOne(
-		Database& db,
-		const CharacterParcelsContainers &e
-	)
-	{
-		std::vector<std::string> v;
-
-		v.push_back(std::to_string(e.id));
-		v.push_back(std::to_string(e.parcels_id));
-		v.push_back(std::to_string(e.slot_id));
-		v.push_back(std::to_string(e.item_id));
-		v.push_back(std::to_string(e.aug_slot_1));
-		v.push_back(std::to_string(e.aug_slot_2));
-		v.push_back(std::to_string(e.aug_slot_3));
-		v.push_back(std::to_string(e.aug_slot_4));
-		v.push_back(std::to_string(e.aug_slot_5));
-		v.push_back(std::to_string(e.aug_slot_6));
-		v.push_back(std::to_string(e.quantity));
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES ({})",
-				BaseReplace(),
-				Strings::Implode(",", v)
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int ReplaceMany(
-		Database& db,
-		const std::vector<CharacterParcelsContainers> &entries
-	)
-	{
-		std::vector<std::string> insert_chunks;
-
-		for (auto &e: entries) {
-			std::vector<std::string> v;
-
-			v.push_back(std::to_string(e.id));
-			v.push_back(std::to_string(e.parcels_id));
-			v.push_back(std::to_string(e.slot_id));
-			v.push_back(std::to_string(e.item_id));
-			v.push_back(std::to_string(e.aug_slot_1));
-			v.push_back(std::to_string(e.aug_slot_2));
-			v.push_back(std::to_string(e.aug_slot_3));
-			v.push_back(std::to_string(e.aug_slot_4));
-			v.push_back(std::to_string(e.aug_slot_5));
-			v.push_back(std::to_string(e.aug_slot_6));
-			v.push_back(std::to_string(e.quantity));
-
-			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
-		}
-
-		std::vector<std::string> v;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES {}",
-				BaseReplace(),
-				Strings::Implode(",", insert_chunks)
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-};
-
-#endif //EQEMU_BASE_CHARACTER_PARCELS_CONTAINERS_REPOSITORY_H

common/repositories/base/base_character_parcels_repository.h

@@ -1,535 +0,0 @@
-/**
- * DO NOT MODIFY THIS FILE
- *
- * This repository was automatically generated and is NOT to be modified directly.
- * Any repository modifications are meant to be made to the repository extending the base.
- * Any modifications to base repositories are to be made by the generator only
- *
- * @generator ./utils/scripts/generators/repository-generator.pl
- * @docs https://docs.eqemu.io/developer/repositories
- */
-
-#ifndef EQEMU_BASE_CHARACTER_PARCELS_REPOSITORY_H
-#define EQEMU_BASE_CHARACTER_PARCELS_REPOSITORY_H
-
-#include "../../database.h"
-#include "../../strings.h"
-#include <ctime>
-
-class BaseCharacterParcelsRepository {
-public:
-	struct CharacterParcels {
-		uint32_t    id;
-		uint32_t    char_id;
-		uint32_t    item_id;
-		uint32_t    aug_slot_1;
-		uint32_t    aug_slot_2;
-		uint32_t    aug_slot_3;
-		uint32_t    aug_slot_4;
-		uint32_t    aug_slot_5;
-		uint32_t    aug_slot_6;
-		uint32_t    slot_id;
-		uint32_t    quantity;
-		std::string from_name;
-		std::string note;
-		time_t      sent_date;
-	};
-
-	static std::string PrimaryKey()
-	{
-		return std::string("id");
-	}
-
-	static std::vector<std::string> Columns()
-	{
-		return {
-			"id",
-			"char_id",
-			"item_id",
-			"aug_slot_1",
-			"aug_slot_2",
-			"aug_slot_3",
-			"aug_slot_4",
-			"aug_slot_5",
-			"aug_slot_6",
-			"slot_id",
-			"quantity",
-			"from_name",
-			"note",
-			"sent_date",
-		};
-	}
-
-	static std::vector<std::string> SelectColumns()
-	{
-		return {
-			"id",
-			"char_id",
-			"item_id",
-			"aug_slot_1",
-			"aug_slot_2",
-			"aug_slot_3",
-			"aug_slot_4",
-			"aug_slot_5",
-			"aug_slot_6",
-			"slot_id",
-			"quantity",
-			"from_name",
-			"note",
-			"UNIX_TIMESTAMP(sent_date)",
-		};
-	}
-
-	static std::string ColumnsRaw()
-	{
-		return std::string(Strings::Implode(", ", Columns()));
-	}
-
-	static std::string SelectColumnsRaw()
-	{
-		return std::string(Strings::Implode(", ", SelectColumns()));
-	}
-
-	static std::string TableName()
-	{
-		return std::string("character_parcels");
-	}
-
-	static std::string BaseSelect()
-	{
-		return fmt::format(
-			"SELECT {} FROM {}",
-			SelectColumnsRaw(),
-			TableName()
-		);
-	}
-
-	static std::string BaseInsert()
-	{
-		return fmt::format(
-			"INSERT INTO {} ({}) ",
-			TableName(),
-			ColumnsRaw()
-		);
-	}
-
-	static CharacterParcels NewEntity()
-	{
-		CharacterParcels e{};
-
-		e.id         = 0;
-		e.char_id    = 0;
-		e.item_id    = 0;
-		e.aug_slot_1 = 0;
-		e.aug_slot_2 = 0;
-		e.aug_slot_3 = 0;
-		e.aug_slot_4 = 0;
-		e.aug_slot_5 = 0;
-		e.aug_slot_6 = 0;
-		e.slot_id    = 0;
-		e.quantity   = 0;
-		e.from_name  = "";
-		e.note       = "";
-		e.sent_date  = 0;
-
-		return e;
-	}
-
-	static CharacterParcels GetCharacterParcels(
-		const std::vector<CharacterParcels> &character_parcelss,
-		int character_parcels_id
-	)
-	{
-		for (auto &character_parcels : character_parcelss) {
-			if (character_parcels.id == character_parcels_id) {
-				return character_parcels;
-			}
-		}
-
-		return NewEntity();
-	}
-
-	static CharacterParcels FindOne(
-		Database& db,
-		int character_parcels_id
-	)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} WHERE {} = {} LIMIT 1",
-				BaseSelect(),
-				PrimaryKey(),
-				character_parcels_id
-			)
-		);
-
-		auto row = results.begin();
-		if (results.RowCount() == 1) {
-			CharacterParcels e{};
-
-			e.id         = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.char_id    = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.item_id    = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.aug_slot_1 = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.aug_slot_2 = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_3 = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_4 = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_5 = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_6 = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.slot_id    = row[9] ? static_cast<uint32_t>(strtoul(row[9], nullptr, 10)) : 0;
-			e.quantity   = row[10] ? static_cast<uint32_t>(strtoul(row[10], nullptr, 10)) : 0;
-			e.from_name  = row[11] ? row[11] : "";
-			e.note       = row[12] ? row[12] : "";
-			e.sent_date  = strtoll(row[13] ? row[13] : "-1", nullptr, 10);
-
-			return e;
-		}
-
-		return NewEntity();
-	}
-
-	static int DeleteOne(
-		Database& db,
-		int character_parcels_id
-	)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"DELETE FROM {} WHERE {} = {}",
-				TableName(),
-				PrimaryKey(),
-				character_parcels_id
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int UpdateOne(
-		Database& db,
-		const CharacterParcels &e
-	)
-	{
-		std::vector<std::string> v;
-
-		auto columns = Columns();
-
-		v.push_back(columns[1] + " = " + std::to_string(e.char_id));
-		v.push_back(columns[2] + " = " + std::to_string(e.item_id));
-		v.push_back(columns[3] + " = " + std::to_string(e.aug_slot_1));
-		v.push_back(columns[4] + " = " + std::to_string(e.aug_slot_2));
-		v.push_back(columns[5] + " = " + std::to_string(e.aug_slot_3));
-		v.push_back(columns[6] + " = " + std::to_string(e.aug_slot_4));
-		v.push_back(columns[7] + " = " + std::to_string(e.aug_slot_5));
-		v.push_back(columns[8] + " = " + std::to_string(e.aug_slot_6));
-		v.push_back(columns[9] + " = " + std::to_string(e.slot_id));
-		v.push_back(columns[10] + " = " + std::to_string(e.quantity));
-		v.push_back(columns[11] + " = '" + Strings::Escape(e.from_name) + "'");
-		v.push_back(columns[12] + " = '" + Strings::Escape(e.note) + "'");
-		v.push_back(columns[13] + " = FROM_UNIXTIME(" + (e.sent_date > 0 ? std::to_string(e.sent_date) : "null") + ")");
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"UPDATE {} SET {} WHERE {} = {}",
-				TableName(),
-				Strings::Implode(", ", v),
-				PrimaryKey(),
-				e.id
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static CharacterParcels InsertOne(
-		Database& db,
-		CharacterParcels e
-	)
-	{
-		std::vector<std::string> v;
-
-		v.push_back(std::to_string(e.id));
-		v.push_back(std::to_string(e.char_id));
-		v.push_back(std::to_string(e.item_id));
-		v.push_back(std::to_string(e.aug_slot_1));
-		v.push_back(std::to_string(e.aug_slot_2));
-		v.push_back(std::to_string(e.aug_slot_3));
-		v.push_back(std::to_string(e.aug_slot_4));
-		v.push_back(std::to_string(e.aug_slot_5));
-		v.push_back(std::to_string(e.aug_slot_6));
-		v.push_back(std::to_string(e.slot_id));
-		v.push_back(std::to_string(e.quantity));
-		v.push_back("'" + Strings::Escape(e.from_name) + "'");
-		v.push_back("'" + Strings::Escape(e.note) + "'");
-		v.push_back("FROM_UNIXTIME(" + (e.sent_date > 0 ? std::to_string(e.sent_date) : "null") + ")");
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES ({})",
-				BaseInsert(),
-				Strings::Implode(",", v)
-			)
-		);
-
-		if (results.Success()) {
-			e.id = results.LastInsertedID();
-			return e;
-		}
-
-		e = NewEntity();
-
-		return e;
-	}
-
-	static int InsertMany(
-		Database& db,
-		const std::vector<CharacterParcels> &entries
-	)
-	{
-		std::vector<std::string> insert_chunks;
-
-		for (auto &e: entries) {
-			std::vector<std::string> v;
-
-			v.push_back(std::to_string(e.id));
-			v.push_back(std::to_string(e.char_id));
-			v.push_back(std::to_string(e.item_id));
-			v.push_back(std::to_string(e.aug_slot_1));
-			v.push_back(std::to_string(e.aug_slot_2));
-			v.push_back(std::to_string(e.aug_slot_3));
-			v.push_back(std::to_string(e.aug_slot_4));
-			v.push_back(std::to_string(e.aug_slot_5));
-			v.push_back(std::to_string(e.aug_slot_6));
-			v.push_back(std::to_string(e.slot_id));
-			v.push_back(std::to_string(e.quantity));
-			v.push_back("'" + Strings::Escape(e.from_name) + "'");
-			v.push_back("'" + Strings::Escape(e.note) + "'");
-			v.push_back("FROM_UNIXTIME(" + (e.sent_date > 0 ? std::to_string(e.sent_date) : "null") + ")");
-
-			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
-		}
-
-		std::vector<std::string> v;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES {}",
-				BaseInsert(),
-				Strings::Implode(",", insert_chunks)
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static std::vector<CharacterParcels> All(Database& db)
-	{
-		std::vector<CharacterParcels> all_entries;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{}",
-				BaseSelect()
-			)
-		);
-
-		all_entries.reserve(results.RowCount());
-
-		for (auto row = results.begin(); row != results.end(); ++row) {
-			CharacterParcels e{};
-
-			e.id         = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.char_id    = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.item_id    = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.aug_slot_1 = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.aug_slot_2 = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_3 = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_4 = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_5 = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_6 = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.slot_id    = row[9] ? static_cast<uint32_t>(strtoul(row[9], nullptr, 10)) : 0;
-			e.quantity   = row[10] ? static_cast<uint32_t>(strtoul(row[10], nullptr, 10)) : 0;
-			e.from_name  = row[11] ? row[11] : "";
-			e.note       = row[12] ? row[12] : "";
-			e.sent_date  = strtoll(row[13] ? row[13] : "-1", nullptr, 10);
-
-			all_entries.push_back(e);
-		}
-
-		return all_entries;
-	}
-
-	static std::vector<CharacterParcels> GetWhere(Database& db, const std::string &where_filter)
-	{
-		std::vector<CharacterParcels> all_entries;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} WHERE {}",
-				BaseSelect(),
-				where_filter
-			)
-		);
-
-		all_entries.reserve(results.RowCount());
-
-		for (auto row = results.begin(); row != results.end(); ++row) {
-			CharacterParcels e{};
-
-			e.id         = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.char_id    = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.item_id    = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.aug_slot_1 = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
-			e.aug_slot_2 = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_3 = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_4 = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_5 = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_6 = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.slot_id    = row[9] ? static_cast<uint32_t>(strtoul(row[9], nullptr, 10)) : 0;
-			e.quantity   = row[10] ? static_cast<uint32_t>(strtoul(row[10], nullptr, 10)) : 0;
-			e.from_name  = row[11] ? row[11] : "";
-			e.note       = row[12] ? row[12] : "";
-			e.sent_date  = strtoll(row[13] ? row[13] : "-1", nullptr, 10);
-
-			all_entries.push_back(e);
-		}
-
-		return all_entries;
-	}
-
-	static int DeleteWhere(Database& db, const std::string &where_filter)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"DELETE FROM {} WHERE {}",
-				TableName(),
-				where_filter
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int Truncate(Database& db)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"TRUNCATE TABLE {}",
-				TableName()
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int64 GetMaxId(Database& db)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"SELECT COALESCE(MAX({}), 0) FROM {}",
-				PrimaryKey(),
-				TableName()
-			)
-		);
-
-		return (results.Success() && results.begin()[0] ? strtoll(results.begin()[0], nullptr, 10) : 0);
-	}
-
-	static int64 Count(Database& db, const std::string &where_filter = "")
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"SELECT COUNT(*) FROM {} {}",
-				TableName(),
-				(where_filter.empty() ? "" : "WHERE " + where_filter)
-			)
-		);
-
-		return (results.Success() && results.begin()[0] ? strtoll(results.begin()[0], nullptr, 10) : 0);
-	}
-
-	static std::string BaseReplace()
-	{
-		return fmt::format(
-			"REPLACE INTO {} ({}) ",
-			TableName(),
-			ColumnsRaw()
-		);
-	}
-
-	static int ReplaceOne(
-		Database& db,
-		const CharacterParcels &e
-	)
-	{
-		std::vector<std::string> v;
-
-		v.push_back(std::to_string(e.id));
-		v.push_back(std::to_string(e.char_id));
-		v.push_back(std::to_string(e.item_id));
-		v.push_back(std::to_string(e.aug_slot_1));
-		v.push_back(std::to_string(e.aug_slot_2));
-		v.push_back(std::to_string(e.aug_slot_3));
-		v.push_back(std::to_string(e.aug_slot_4));
-		v.push_back(std::to_string(e.aug_slot_5));
-		v.push_back(std::to_string(e.aug_slot_6));
-		v.push_back(std::to_string(e.slot_id));
-		v.push_back(std::to_string(e.quantity));
-		v.push_back("'" + Strings::Escape(e.from_name) + "'");
-		v.push_back("'" + Strings::Escape(e.note) + "'");
-		v.push_back("FROM_UNIXTIME(" + (e.sent_date > 0 ? std::to_string(e.sent_date) : "null") + ")");
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES ({})",
-				BaseReplace(),
-				Strings::Implode(",", v)
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-
-	static int ReplaceMany(
-		Database& db,
-		const std::vector<CharacterParcels> &entries
-	)
-	{
-		std::vector<std::string> insert_chunks;
-
-		for (auto &e: entries) {
-			std::vector<std::string> v;
-
-			v.push_back(std::to_string(e.id));
-			v.push_back(std::to_string(e.char_id));
-			v.push_back(std::to_string(e.item_id));
-			v.push_back(std::to_string(e.aug_slot_1));
-			v.push_back(std::to_string(e.aug_slot_2));
-			v.push_back(std::to_string(e.aug_slot_3));
-			v.push_back(std::to_string(e.aug_slot_4));
-			v.push_back(std::to_string(e.aug_slot_5));
-			v.push_back(std::to_string(e.aug_slot_6));
-			v.push_back(std::to_string(e.slot_id));
-			v.push_back(std::to_string(e.quantity));
-			v.push_back("'" + Strings::Escape(e.from_name) + "'");
-			v.push_back("'" + Strings::Escape(e.note) + "'");
-			v.push_back("FROM_UNIXTIME(" + (e.sent_date > 0 ? std::to_string(e.sent_date) : "null") + ")");
-
-			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
-		}
-
-		std::vector<std::string> v;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} VALUES {}",
-				BaseReplace(),
-				Strings::Implode(",", insert_chunks)
-			)
-		);
-
-		return (results.Success() ? results.RowsAffected() : 0);
-	}
-};
-
-#endif //EQEMU_BASE_CHARACTER_PARCELS_REPOSITORY_H

common/repositories/base/base_doors_repository.h

@@ -50,7 +50,6 @@ public:
 		float       buffer;
 		uint32_t    client_version_mask;
 		int16_t     is_ldon_door;
-		int16_t     close_timer_ms;
 		int32_t     dz_switch_id;
 		int8_t      min_expansion;
 		int8_t      max_expansion;
@@ -97,7 +96,6 @@ public:
 			"buffer",
 			"client_version_mask",
 			"is_ldon_door",
-			"close_timer_ms",
 			"dz_switch_id",
 			"min_expansion",
 			"max_expansion",
@@ -140,7 +138,6 @@ public:
 			"buffer",
 			"client_version_mask",
 			"is_ldon_door",
-			"close_timer_ms",
 			"dz_switch_id",
 			"min_expansion",
 			"max_expansion",
@@ -217,7 +214,6 @@ public:
 		e.buffer                 = 0;
 		e.client_version_mask    = 4294967295;
 		e.is_ldon_door           = 0;
-		e.close_timer_ms         = 5000;
 		e.dz_switch_id           = 0;
 		e.min_expansion          = -1;
 		e.max_expansion          = -1;
@@ -290,12 +286,11 @@ public:
 			e.buffer                 = row[28] ? strtof(row[28], nullptr) : 0;
 			e.client_version_mask    = row[29] ? static_cast<uint32_t>(strtoul(row[29], nullptr, 10)) : 4294967295;
 			e.is_ldon_door           = row[30] ? static_cast<int16_t>(atoi(row[30])) : 0;
-			e.close_timer_ms         = row[31] ? static_cast<int16_t>(atoi(row[31])) : 5000;
+			e.dz_switch_id           = row[31] ? static_cast<int32_t>(atoi(row[31])) : 0;
-			e.dz_switch_id           = row[32] ? static_cast<int32_t>(atoi(row[32])) : 0;
+			e.min_expansion          = row[32] ? static_cast<int8_t>(atoi(row[32])) : -1;
-			e.min_expansion          = row[33] ? static_cast<int8_t>(atoi(row[33])) : -1;
+			e.max_expansion          = row[33] ? static_cast<int8_t>(atoi(row[33])) : -1;
-			e.max_expansion          = row[34] ? static_cast<int8_t>(atoi(row[34])) : -1;
+			e.content_flags          = row[34] ? row[34] : "";
-			e.content_flags          = row[35] ? row[35] : "";
+			e.content_flags_disabled = row[35] ? row[35] : "";
-			e.content_flags_disabled = row[36] ? row[36] : "";
 
 			return e;
 		}
@@ -359,12 +354,11 @@ public:
 		v.push_back(columns[28] + " = " + std::to_string(e.buffer));
 		v.push_back(columns[29] + " = " + std::to_string(e.client_version_mask));
 		v.push_back(columns[30] + " = " + std::to_string(e.is_ldon_door));
-		v.push_back(columns[31] + " = " + std::to_string(e.close_timer_ms));
+		v.push_back(columns[31] + " = " + std::to_string(e.dz_switch_id));
-		v.push_back(columns[32] + " = " + std::to_string(e.dz_switch_id));
+		v.push_back(columns[32] + " = " + std::to_string(e.min_expansion));
-		v.push_back(columns[33] + " = " + std::to_string(e.min_expansion));
+		v.push_back(columns[33] + " = " + std::to_string(e.max_expansion));
-		v.push_back(columns[34] + " = " + std::to_string(e.max_expansion));
+		v.push_back(columns[34] + " = '" + Strings::Escape(e.content_flags) + "'");
-		v.push_back(columns[35] + " = '" + Strings::Escape(e.content_flags) + "'");
+		v.push_back(columns[35] + " = '" + Strings::Escape(e.content_flags_disabled) + "'");
-		v.push_back(columns[36] + " = '" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -417,7 +411,6 @@ public:
 		v.push_back(std::to_string(e.buffer));
 		v.push_back(std::to_string(e.client_version_mask));
 		v.push_back(std::to_string(e.is_ldon_door));
-		v.push_back(std::to_string(e.close_timer_ms));
 		v.push_back(std::to_string(e.dz_switch_id));
 		v.push_back(std::to_string(e.min_expansion));
 		v.push_back(std::to_string(e.max_expansion));
@@ -483,7 +476,6 @@ public:
 			v.push_back(std::to_string(e.buffer));
 			v.push_back(std::to_string(e.client_version_mask));
 			v.push_back(std::to_string(e.is_ldon_door));
-			v.push_back(std::to_string(e.close_timer_ms));
 			v.push_back(std::to_string(e.dz_switch_id));
 			v.push_back(std::to_string(e.min_expansion));
 			v.push_back(std::to_string(e.max_expansion));
@@ -553,12 +545,11 @@ public:
 			e.buffer                 = row[28] ? strtof(row[28], nullptr) : 0;
 			e.client_version_mask    = row[29] ? static_cast<uint32_t>(strtoul(row[29], nullptr, 10)) : 4294967295;
 			e.is_ldon_door           = row[30] ? static_cast<int16_t>(atoi(row[30])) : 0;
-			e.close_timer_ms         = row[31] ? static_cast<int16_t>(atoi(row[31])) : 5000;
+			e.dz_switch_id           = row[31] ? static_cast<int32_t>(atoi(row[31])) : 0;
-			e.dz_switch_id           = row[32] ? static_cast<int32_t>(atoi(row[32])) : 0;
+			e.min_expansion          = row[32] ? static_cast<int8_t>(atoi(row[32])) : -1;
-			e.min_expansion          = row[33] ? static_cast<int8_t>(atoi(row[33])) : -1;
+			e.max_expansion          = row[33] ? static_cast<int8_t>(atoi(row[33])) : -1;
-			e.max_expansion          = row[34] ? static_cast<int8_t>(atoi(row[34])) : -1;
+			e.content_flags          = row[34] ? row[34] : "";
-			e.content_flags          = row[35] ? row[35] : "";
+			e.content_flags_disabled = row[35] ? row[35] : "";
-			e.content_flags_disabled = row[36] ? row[36] : "";
 
 			all_entries.push_back(e);
 		}
@@ -614,12 +605,11 @@ public:
 			e.buffer                 = row[28] ? strtof(row[28], nullptr) : 0;
 			e.client_version_mask    = row[29] ? static_cast<uint32_t>(strtoul(row[29], nullptr, 10)) : 4294967295;
 			e.is_ldon_door           = row[30] ? static_cast<int16_t>(atoi(row[30])) : 0;
-			e.close_timer_ms         = row[31] ? static_cast<int16_t>(atoi(row[31])) : 5000;
+			e.dz_switch_id           = row[31] ? static_cast<int32_t>(atoi(row[31])) : 0;
-			e.dz_switch_id           = row[32] ? static_cast<int32_t>(atoi(row[32])) : 0;
+			e.min_expansion          = row[32] ? static_cast<int8_t>(atoi(row[32])) : -1;
-			e.min_expansion          = row[33] ? static_cast<int8_t>(atoi(row[33])) : -1;
+			e.max_expansion          = row[33] ? static_cast<int8_t>(atoi(row[33])) : -1;
-			e.max_expansion          = row[34] ? static_cast<int8_t>(atoi(row[34])) : -1;
+			e.content_flags          = row[34] ? row[34] : "";
-			e.content_flags          = row[35] ? row[35] : "";
+			e.content_flags_disabled = row[35] ? row[35] : "";
-			e.content_flags_disabled = row[36] ? row[36] : "";
 
 			all_entries.push_back(e);
 		}
@@ -725,7 +715,6 @@ public:
 		v.push_back(std::to_string(e.buffer));
 		v.push_back(std::to_string(e.client_version_mask));
 		v.push_back(std::to_string(e.is_ldon_door));
-		v.push_back(std::to_string(e.close_timer_ms));
 		v.push_back(std::to_string(e.dz_switch_id));
 		v.push_back(std::to_string(e.min_expansion));
 		v.push_back(std::to_string(e.max_expansion));
@@ -784,7 +773,6 @@ public:
 			v.push_back(std::to_string(e.buffer));
 			v.push_back(std::to_string(e.client_version_mask));
 			v.push_back(std::to_string(e.is_ldon_door));
-			v.push_back(std::to_string(e.close_timer_ms));
 			v.push_back(std::to_string(e.dz_switch_id));
 			v.push_back(std::to_string(e.min_expansion));
 			v.push_back(std::to_string(e.max_expansion));

common/repositories/base/base_group_leaders_repository.h

@@ -192,7 +192,7 @@ public:
 		v.push_back(columns[0] + " = " + std::to_string(e.gid));
 		v.push_back(columns[1] + " = '" + Strings::Escape(e.leadername) + "'");
 		v.push_back(columns[2] + " = '" + Strings::Escape(e.marknpc) + "'");
-		v.push_back(columns[3] + " = '" + e.leadershipaa + "'");
+		v.push_back(columns[3] + " = '" + Strings::Escape(e.leadershipaa) + "'");
 		v.push_back(columns[4] + " = '" + Strings::Escape(e.maintank) + "'");
 		v.push_back(columns[5] + " = '" + Strings::Escape(e.assist) + "'");
 		v.push_back(columns[6] + " = '" + Strings::Escape(e.puller) + "'");
@@ -222,7 +222,7 @@ public:
 		v.push_back(std::to_string(e.gid));
 		v.push_back("'" + Strings::Escape(e.leadername) + "'");
 		v.push_back("'" + Strings::Escape(e.marknpc) + "'");
-		v.push_back("'" + e.leadershipaa + "'");
+		v.push_back("'" + Strings::Escape(e.leadershipaa) + "'");
 		v.push_back("'" + Strings::Escape(e.maintank) + "'");
 		v.push_back("'" + Strings::Escape(e.assist) + "'");
 		v.push_back("'" + Strings::Escape(e.puller) + "'");
@@ -260,7 +260,7 @@ public:
 			v.push_back(std::to_string(e.gid));
 			v.push_back("'" + Strings::Escape(e.leadername) + "'");
 			v.push_back("'" + Strings::Escape(e.marknpc) + "'");
-			v.push_back("'" + e.leadershipaa + "'");
+			v.push_back("'" + Strings::Escape(e.leadershipaa) + "'");
 			v.push_back("'" + Strings::Escape(e.maintank) + "'");
 			v.push_back("'" + Strings::Escape(e.assist) + "'");
 			v.push_back("'" + Strings::Escape(e.puller) + "'");
@@ -418,7 +418,7 @@ public:
 		v.push_back(std::to_string(e.gid));
 		v.push_back("'" + Strings::Escape(e.leadername) + "'");
 		v.push_back("'" + Strings::Escape(e.marknpc) + "'");
-		v.push_back("'" + e.leadershipaa + "'");
+		v.push_back("'" + Strings::Escape(e.leadershipaa) + "'");
 		v.push_back("'" + Strings::Escape(e.maintank) + "'");
 		v.push_back("'" + Strings::Escape(e.assist) + "'");
 		v.push_back("'" + Strings::Escape(e.puller) + "'");
@@ -449,7 +449,7 @@ public:
 			v.push_back(std::to_string(e.gid));
 			v.push_back("'" + Strings::Escape(e.leadername) + "'");
 			v.push_back("'" + Strings::Escape(e.marknpc) + "'");
-			v.push_back("'" + e.leadershipaa + "'");
+			v.push_back("'" + Strings::Escape(e.leadershipaa) + "'");
 			v.push_back("'" + Strings::Escape(e.maintank) + "'");
 			v.push_back("'" + Strings::Escape(e.assist) + "'");
 			v.push_back("'" + Strings::Escape(e.puller) + "'");

common/repositories/base/base_lootdrop_entries_repository.h

@@ -30,10 +30,6 @@ public:
 		uint8_t  multiplier;
 		uint16_t npc_min_level;
 		uint16_t npc_max_level;
-		int8_t      min_expansion;
-		int8_t      max_expansion;
-		std::string content_flags;
-		std::string content_flags_disabled;
 	};
 
 	static std::string PrimaryKey()
@@ -55,10 +51,6 @@ public:
 			"multiplier",
 			"npc_min_level",
 			"npc_max_level",
-			"min_expansion",
-			"max_expansion",
-			"content_flags",
-			"content_flags_disabled",
 		};
 	}
 
@@ -76,10 +68,6 @@ public:
 			"multiplier",
 			"npc_min_level",
 			"npc_max_level",
-			"min_expansion",
-			"max_expansion",
-			"content_flags",
-			"content_flags_disabled",
 		};
 	}
 
@@ -131,10 +119,6 @@ public:
 		e.multiplier        = 1;
 		e.npc_min_level     = 0;
 		e.npc_max_level     = 0;
-		e.min_expansion          = -1;
-		e.max_expansion          = -1;
-		e.content_flags          = "";
-		e.content_flags_disabled = "";
 
 		return e;
 	}
@@ -182,10 +166,6 @@ public:
 			e.multiplier        = row[8] ? static_cast<uint8_t>(strtoul(row[8], nullptr, 10)) : 1;
 			e.npc_min_level     = row[9] ? static_cast<uint16_t>(strtoul(row[9], nullptr, 10)) : 0;
 			e.npc_max_level     = row[10] ? static_cast<uint16_t>(strtoul(row[10], nullptr, 10)) : 0;
-			e.min_expansion          = row[11] ? static_cast<int8_t>(atoi(row[11])) : -1;
-			e.max_expansion          = row[12] ? static_cast<int8_t>(atoi(row[12])) : -1;
-			e.content_flags          = row[13] ? row[13] : "";
-			e.content_flags_disabled = row[14] ? row[14] : "";
 
 			return e;
 		}
@@ -230,10 +210,6 @@ public:
 		v.push_back(columns[8] + " = " + std::to_string(e.multiplier));
 		v.push_back(columns[9] + " = " + std::to_string(e.npc_min_level));
 		v.push_back(columns[10] + " = " + std::to_string(e.npc_max_level));
-		v.push_back(columns[11] + " = " + std::to_string(e.min_expansion));
-		v.push_back(columns[12] + " = " + std::to_string(e.max_expansion));
-		v.push_back(columns[13] + " = '" + Strings::Escape(e.content_flags) + "'");
-		v.push_back(columns[14] + " = '" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -266,10 +242,6 @@ public:
 		v.push_back(std::to_string(e.multiplier));
 		v.push_back(std::to_string(e.npc_min_level));
 		v.push_back(std::to_string(e.npc_max_level));
-		v.push_back(std::to_string(e.min_expansion));
-		v.push_back(std::to_string(e.max_expansion));
-		v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-		v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -310,10 +282,6 @@ public:
 			v.push_back(std::to_string(e.multiplier));
 			v.push_back(std::to_string(e.npc_min_level));
 			v.push_back(std::to_string(e.npc_max_level));
-			v.push_back(std::to_string(e.min_expansion));
-			v.push_back(std::to_string(e.max_expansion));
-			v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-			v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
 		}
@@ -358,10 +326,6 @@ public:
 			e.multiplier        = row[8] ? static_cast<uint8_t>(strtoul(row[8], nullptr, 10)) : 1;
 			e.npc_min_level     = row[9] ? static_cast<uint16_t>(strtoul(row[9], nullptr, 10)) : 0;
 			e.npc_max_level     = row[10] ? static_cast<uint16_t>(strtoul(row[10], nullptr, 10)) : 0;
-			e.min_expansion          = row[11] ? static_cast<int8_t>(atoi(row[11])) : -1;
-			e.max_expansion          = row[12] ? static_cast<int8_t>(atoi(row[12])) : -1;
-			e.content_flags          = row[13] ? row[13] : "";
-			e.content_flags_disabled = row[14] ? row[14] : "";
 
 			all_entries.push_back(e);
 		}
@@ -397,10 +361,6 @@ public:
 			e.multiplier        = row[8] ? static_cast<uint8_t>(strtoul(row[8], nullptr, 10)) : 1;
 			e.npc_min_level     = row[9] ? static_cast<uint16_t>(strtoul(row[9], nullptr, 10)) : 0;
 			e.npc_max_level     = row[10] ? static_cast<uint16_t>(strtoul(row[10], nullptr, 10)) : 0;
-			e.min_expansion          = row[11] ? static_cast<int8_t>(atoi(row[11])) : -1;
-			e.max_expansion          = row[12] ? static_cast<int8_t>(atoi(row[12])) : -1;
-			e.content_flags          = row[13] ? row[13] : "";
-			e.content_flags_disabled = row[14] ? row[14] : "";
 
 			all_entries.push_back(e);
 		}
@@ -486,10 +446,6 @@ public:
 		v.push_back(std::to_string(e.multiplier));
 		v.push_back(std::to_string(e.npc_min_level));
 		v.push_back(std::to_string(e.npc_max_level));
-		v.push_back(std::to_string(e.min_expansion));
-		v.push_back(std::to_string(e.max_expansion));
-		v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-		v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -523,10 +479,6 @@ public:
 			v.push_back(std::to_string(e.multiplier));
 			v.push_back(std::to_string(e.npc_min_level));
 			v.push_back(std::to_string(e.npc_max_level));
-			v.push_back(std::to_string(e.min_expansion));
-			v.push_back(std::to_string(e.max_expansion));
-			v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-			v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
 		}

common/repositories/base/base_npc_spells_entries_repository.h

@@ -31,10 +31,6 @@ public:
 		int32_t  resist_adjust;
 		int16_t  min_hp;
 		int16_t  max_hp;
-		int8_t      min_expansion;
-		int8_t      max_expansion;
-		std::string content_flags;
-		std::string content_flags_disabled;
 	};
 
 	static std::string PrimaryKey()
@@ -57,10 +53,6 @@ public:
 			"resist_adjust",
 			"min_hp",
 			"max_hp",
-			"min_expansion",
-			"max_expansion",
-			"content_flags",
-			"content_flags_disabled",
 		};
 	}
 
@@ -79,10 +71,6 @@ public:
 			"resist_adjust",
 			"min_hp",
 			"max_hp",
-			"min_expansion",
-			"max_expansion",
-			"content_flags",
-			"content_flags_disabled",
 		};
 	}
 
@@ -135,10 +123,6 @@ public:
 		e.resist_adjust = 0;
 		e.min_hp        = 0;
 		e.max_hp        = 0;
-		e.min_expansion          = -1;
-		e.max_expansion          = -1;
-		e.content_flags          = "";
-		e.content_flags_disabled = "";
 
 		return e;
 	}
@@ -187,10 +171,6 @@ public:
 			e.resist_adjust = row[9] ? static_cast<int32_t>(atoi(row[9])) : 0;
 			e.min_hp        = row[10] ? static_cast<int16_t>(atoi(row[10])) : 0;
 			e.max_hp        = row[11] ? static_cast<int16_t>(atoi(row[11])) : 0;
-			e.min_expansion          = row[12] ? static_cast<int8_t>(atoi(row[12])) : -1;
-			e.max_expansion          = row[13] ? static_cast<int8_t>(atoi(row[13])) : -1;
-			e.content_flags          = row[14] ? row[14] : "";
-			e.content_flags_disabled = row[15] ? row[15] : "";
 
 			return e;
 		}
@@ -235,10 +215,6 @@ public:
 		v.push_back(columns[9] + " = " + std::to_string(e.resist_adjust));
 		v.push_back(columns[10] + " = " + std::to_string(e.min_hp));
 		v.push_back(columns[11] + " = " + std::to_string(e.max_hp));
-		v.push_back(columns[12] + " = " + std::to_string(e.min_expansion));
-		v.push_back(columns[13] + " = " + std::to_string(e.max_expansion));
-		v.push_back(columns[14] + " = '" + Strings::Escape(e.content_flags) + "'");
-		v.push_back(columns[15] + " = '" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -272,10 +248,6 @@ public:
 		v.push_back(std::to_string(e.resist_adjust));
 		v.push_back(std::to_string(e.min_hp));
 		v.push_back(std::to_string(e.max_hp));
-		v.push_back(std::to_string(e.min_expansion));
-		v.push_back(std::to_string(e.max_expansion));
-		v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-		v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -317,10 +289,6 @@ public:
 			v.push_back(std::to_string(e.resist_adjust));
 			v.push_back(std::to_string(e.min_hp));
 			v.push_back(std::to_string(e.max_hp));
-			v.push_back(std::to_string(e.min_expansion));
-			v.push_back(std::to_string(e.max_expansion));
-			v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-			v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
 		}
@@ -366,10 +334,6 @@ public:
 			e.resist_adjust = row[9] ? static_cast<int32_t>(atoi(row[9])) : 0;
 			e.min_hp        = row[10] ? static_cast<int16_t>(atoi(row[10])) : 0;
 			e.max_hp        = row[11] ? static_cast<int16_t>(atoi(row[11])) : 0;
-			e.min_expansion          = row[12] ? static_cast<int8_t>(atoi(row[12])) : -1;
-			e.max_expansion          = row[13] ? static_cast<int8_t>(atoi(row[13])) : -1;
-			e.content_flags          = row[14] ? row[14] : "";
-			e.content_flags_disabled = row[15] ? row[15] : "";
 
 			all_entries.push_back(e);
 		}
@@ -406,10 +370,6 @@ public:
 			e.resist_adjust = row[9] ? static_cast<int32_t>(atoi(row[9])) : 0;
 			e.min_hp        = row[10] ? static_cast<int16_t>(atoi(row[10])) : 0;
 			e.max_hp        = row[11] ? static_cast<int16_t>(atoi(row[11])) : 0;
-			e.min_expansion          = row[12] ? static_cast<int8_t>(atoi(row[12])) : -1;
-			e.max_expansion          = row[13] ? static_cast<int8_t>(atoi(row[13])) : -1;
-			e.content_flags          = row[14] ? row[14] : "";
-			e.content_flags_disabled = row[15] ? row[15] : "";
 
 			all_entries.push_back(e);
 		}
@@ -496,10 +456,6 @@ public:
 		v.push_back(std::to_string(e.resist_adjust));
 		v.push_back(std::to_string(e.min_hp));
 		v.push_back(std::to_string(e.max_hp));
-		v.push_back(std::to_string(e.min_expansion));
-		v.push_back(std::to_string(e.max_expansion));
-		v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-		v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -534,10 +490,6 @@ public:
 			v.push_back(std::to_string(e.resist_adjust));
 			v.push_back(std::to_string(e.min_hp));
 			v.push_back(std::to_string(e.max_hp));
-			v.push_back(std::to_string(e.min_expansion));
-			v.push_back(std::to_string(e.max_expansion));
-			v.push_back("'" + Strings::Escape(e.content_flags) + "'");
-			v.push_back("'" + Strings::Escape(e.content_flags_disabled) + "'");
 
 			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
 		}

common/repositories/base/base_trader_repository.h

@@ -19,70 +19,40 @@
 class BaseTraderRepository {
 public:
 	struct Trader {
-		uint64_t id;
 		uint32_t char_id;
 		uint32_t item_id;
-		uint32_t aug_slot_1;
+		uint32_t serialnumber;
-		uint32_t aug_slot_2;
+		int32_t  charges;
-		uint32_t aug_slot_3;
+		uint32_t item_cost;
-		uint32_t aug_slot_4;
-		uint32_t aug_slot_5;
-		uint32_t aug_slot_6;
-		int32_t  item_sn;
-		int32_t  item_charges;
-		uint64_t item_cost;
 		uint8_t  slot_id;
-		uint32_t char_entity_id;
-		uint32_t char_zone_id;
-		int8_t   active_transaction;
 	};
 
 	static std::string PrimaryKey()
 	{
-		return std::string("id");
+		return std::string("char_id");
 	}
 
 	static std::vector<std::string> Columns()
 	{
 		return {
-			"id",
 			"char_id",
 			"item_id",
-			"aug_slot_1",
+			"serialnumber",
-			"aug_slot_2",
+			"charges",
-			"aug_slot_3",
-			"aug_slot_4",
-			"aug_slot_5",
-			"aug_slot_6",
-			"item_sn",
-			"item_charges",
 			"item_cost",
 			"slot_id",
-			"char_entity_id",
-			"char_zone_id",
-			"active_transaction",
 		};
 	}
 
 	static std::vector<std::string> SelectColumns()
 	{
 		return {
-			"id",
 			"char_id",
 			"item_id",
-			"aug_slot_1",
+			"serialnumber",
-			"aug_slot_2",
+			"charges",
-			"aug_slot_3",
-			"aug_slot_4",
-			"aug_slot_5",
-			"aug_slot_6",
-			"item_sn",
-			"item_charges",
 			"item_cost",
 			"slot_id",
-			"char_entity_id",
-			"char_zone_id",
-			"active_transaction",
 		};
 	}
 
@@ -123,22 +93,12 @@ public:
 	{
 		Trader e{};
 
-		e.id                 = 0;
 		e.char_id      = 0;
 		e.item_id      = 0;
-		e.aug_slot_1         = 0;
+		e.serialnumber = 0;
-		e.aug_slot_2         = 0;
+		e.charges      = 0;
-		e.aug_slot_3         = 0;
-		e.aug_slot_4         = 0;
-		e.aug_slot_5         = 0;
-		e.aug_slot_6         = 0;
-		e.item_sn            = 0;
-		e.item_charges       = 0;
 		e.item_cost    = 0;
 		e.slot_id      = 0;
-		e.char_entity_id     = 0;
-		e.char_zone_id       = 0;
-		e.active_transaction = 0;
 
 		return e;
 	}
@@ -149,7 +109,7 @@ public:
 	)
 	{
 		for (auto &trader : traders) {
-			if (trader.id == trader_id) {
+			if (trader.char_id == trader_id) {
 				return trader;
 			}
 		}
@@ -175,22 +135,12 @@ public:
 		if (results.RowCount() == 1) {
 			Trader e{};
 
-			e.id                 = row[0] ? strtoull(row[0], nullptr, 10) : 0;
+			e.char_id      = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.char_id            = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
+			e.item_id      = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.item_id            = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
+			e.serialnumber = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.aug_slot_1         = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
+			e.charges      = row[3] ? static_cast<int32_t>(atoi(row[3])) : 0;
-			e.aug_slot_2         = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
+			e.item_cost    = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_3         = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
+			e.slot_id      = row[5] ? static_cast<uint8_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_4         = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_5         = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_6         = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.item_sn            = row[9] ? static_cast<int32_t>(atoi(row[9])) : 0;
-			e.item_charges       = row[10] ? static_cast<int32_t>(atoi(row[10])) : 0;
-			e.item_cost          = row[11] ? strtoull(row[11], nullptr, 10) : 0;
-			e.slot_id            = row[12] ? static_cast<uint8_t>(strtoul(row[12], nullptr, 10)) : 0;
-			e.char_entity_id     = row[13] ? static_cast<uint32_t>(strtoul(row[13], nullptr, 10)) : 0;
-			e.char_zone_id       = row[14] ? static_cast<uint32_t>(strtoul(row[14], nullptr, 10)) : 0;
-			e.active_transaction = row[15] ? static_cast<int8_t>(atoi(row[15])) : 0;
 
 			return e;
 		}
@@ -224,21 +174,12 @@ public:
 
 		auto columns = Columns();
 
-		v.push_back(columns[1] + " = " + std::to_string(e.char_id));
+		v.push_back(columns[0] + " = " + std::to_string(e.char_id));
-		v.push_back(columns[2] + " = " + std::to_string(e.item_id));
+		v.push_back(columns[1] + " = " + std::to_string(e.item_id));
-		v.push_back(columns[3] + " = " + std::to_string(e.aug_slot_1));
+		v.push_back(columns[2] + " = " + std::to_string(e.serialnumber));
-		v.push_back(columns[4] + " = " + std::to_string(e.aug_slot_2));
+		v.push_back(columns[3] + " = " + std::to_string(e.charges));
-		v.push_back(columns[5] + " = " + std::to_string(e.aug_slot_3));
+		v.push_back(columns[4] + " = " + std::to_string(e.item_cost));
-		v.push_back(columns[6] + " = " + std::to_string(e.aug_slot_4));
+		v.push_back(columns[5] + " = " + std::to_string(e.slot_id));
-		v.push_back(columns[7] + " = " + std::to_string(e.aug_slot_5));
-		v.push_back(columns[8] + " = " + std::to_string(e.aug_slot_6));
-		v.push_back(columns[9] + " = " + std::to_string(e.item_sn));
-		v.push_back(columns[10] + " = " + std::to_string(e.item_charges));
-		v.push_back(columns[11] + " = " + std::to_string(e.item_cost));
-		v.push_back(columns[12] + " = " + std::to_string(e.slot_id));
-		v.push_back(columns[13] + " = " + std::to_string(e.char_entity_id));
-		v.push_back(columns[14] + " = " + std::to_string(e.char_zone_id));
-		v.push_back(columns[15] + " = " + std::to_string(e.active_transaction));
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -246,7 +187,7 @@ public:
 				TableName(),
 				Strings::Implode(", ", v),
 				PrimaryKey(),
-				e.id
+				e.char_id
 			)
 		);
 
@@ -260,22 +201,12 @@ public:
 	{
 		std::vector<std::string> v;
 
-		v.push_back(std::to_string(e.id));
 		v.push_back(std::to_string(e.char_id));
 		v.push_back(std::to_string(e.item_id));
-		v.push_back(std::to_string(e.aug_slot_1));
+		v.push_back(std::to_string(e.serialnumber));
-		v.push_back(std::to_string(e.aug_slot_2));
+		v.push_back(std::to_string(e.charges));
-		v.push_back(std::to_string(e.aug_slot_3));
-		v.push_back(std::to_string(e.aug_slot_4));
-		v.push_back(std::to_string(e.aug_slot_5));
-		v.push_back(std::to_string(e.aug_slot_6));
-		v.push_back(std::to_string(e.item_sn));
-		v.push_back(std::to_string(e.item_charges));
 		v.push_back(std::to_string(e.item_cost));
 		v.push_back(std::to_string(e.slot_id));
-		v.push_back(std::to_string(e.char_entity_id));
-		v.push_back(std::to_string(e.char_zone_id));
-		v.push_back(std::to_string(e.active_transaction));
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -286,7 +217,7 @@ public:
 		);
 
 		if (results.Success()) {
-			e.id = results.LastInsertedID();
+			e.char_id = results.LastInsertedID();
 			return e;
 		}
 
@@ -305,22 +236,12 @@ public:
 		for (auto &e: entries) {
 			std::vector<std::string> v;
 
-			v.push_back(std::to_string(e.id));
 			v.push_back(std::to_string(e.char_id));
 			v.push_back(std::to_string(e.item_id));
-			v.push_back(std::to_string(e.aug_slot_1));
+			v.push_back(std::to_string(e.serialnumber));
-			v.push_back(std::to_string(e.aug_slot_2));
+			v.push_back(std::to_string(e.charges));
-			v.push_back(std::to_string(e.aug_slot_3));
-			v.push_back(std::to_string(e.aug_slot_4));
-			v.push_back(std::to_string(e.aug_slot_5));
-			v.push_back(std::to_string(e.aug_slot_6));
-			v.push_back(std::to_string(e.item_sn));
-			v.push_back(std::to_string(e.item_charges));
 			v.push_back(std::to_string(e.item_cost));
 			v.push_back(std::to_string(e.slot_id));
-			v.push_back(std::to_string(e.char_entity_id));
-			v.push_back(std::to_string(e.char_zone_id));
-			v.push_back(std::to_string(e.active_transaction));
 
 			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
 		}
@@ -354,22 +275,12 @@ public:
 		for (auto row = results.begin(); row != results.end(); ++row) {
 			Trader e{};
 
-			e.id                 = row[0] ? strtoull(row[0], nullptr, 10) : 0;
+			e.char_id      = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.char_id            = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
+			e.item_id      = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.item_id            = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
+			e.serialnumber = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.aug_slot_1         = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
+			e.charges      = row[3] ? static_cast<int32_t>(atoi(row[3])) : 0;
-			e.aug_slot_2         = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
+			e.item_cost    = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_3         = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
+			e.slot_id      = row[5] ? static_cast<uint8_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_4         = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_5         = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_6         = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.item_sn            = row[9] ? static_cast<int32_t>(atoi(row[9])) : 0;
-			e.item_charges       = row[10] ? static_cast<int32_t>(atoi(row[10])) : 0;
-			e.item_cost          = row[11] ? strtoull(row[11], nullptr, 10) : 0;
-			e.slot_id            = row[12] ? static_cast<uint8_t>(strtoul(row[12], nullptr, 10)) : 0;
-			e.char_entity_id     = row[13] ? static_cast<uint32_t>(strtoul(row[13], nullptr, 10)) : 0;
-			e.char_zone_id       = row[14] ? static_cast<uint32_t>(strtoul(row[14], nullptr, 10)) : 0;
-			e.active_transaction = row[15] ? static_cast<int8_t>(atoi(row[15])) : 0;
 
 			all_entries.push_back(e);
 		}
@@ -394,22 +305,12 @@ public:
 		for (auto row = results.begin(); row != results.end(); ++row) {
 			Trader e{};
 
-			e.id                 = row[0] ? strtoull(row[0], nullptr, 10) : 0;
+			e.char_id      = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.char_id            = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
+			e.item_id      = row[1] ? static_cast<uint32_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.item_id            = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
+			e.serialnumber = row[2] ? static_cast<uint32_t>(strtoul(row[2], nullptr, 10)) : 0;
-			e.aug_slot_1         = row[3] ? static_cast<uint32_t>(strtoul(row[3], nullptr, 10)) : 0;
+			e.charges      = row[3] ? static_cast<int32_t>(atoi(row[3])) : 0;
-			e.aug_slot_2         = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
+			e.item_cost    = row[4] ? static_cast<uint32_t>(strtoul(row[4], nullptr, 10)) : 0;
-			e.aug_slot_3         = row[5] ? static_cast<uint32_t>(strtoul(row[5], nullptr, 10)) : 0;
+			e.slot_id      = row[5] ? static_cast<uint8_t>(strtoul(row[5], nullptr, 10)) : 0;
-			e.aug_slot_4         = row[6] ? static_cast<uint32_t>(strtoul(row[6], nullptr, 10)) : 0;
-			e.aug_slot_5         = row[7] ? static_cast<uint32_t>(strtoul(row[7], nullptr, 10)) : 0;
-			e.aug_slot_6         = row[8] ? static_cast<uint32_t>(strtoul(row[8], nullptr, 10)) : 0;
-			e.item_sn            = row[9] ? static_cast<int32_t>(atoi(row[9])) : 0;
-			e.item_charges       = row[10] ? static_cast<int32_t>(atoi(row[10])) : 0;
-			e.item_cost          = row[11] ? strtoull(row[11], nullptr, 10) : 0;
-			e.slot_id            = row[12] ? static_cast<uint8_t>(strtoul(row[12], nullptr, 10)) : 0;
-			e.char_entity_id     = row[13] ? static_cast<uint32_t>(strtoul(row[13], nullptr, 10)) : 0;
-			e.char_zone_id       = row[14] ? static_cast<uint32_t>(strtoul(row[14], nullptr, 10)) : 0;
-			e.active_transaction = row[15] ? static_cast<int8_t>(atoi(row[15])) : 0;
 
 			all_entries.push_back(e);
 		}
@@ -484,22 +385,12 @@ public:
 	{
 		std::vector<std::string> v;
 
-		v.push_back(std::to_string(e.id));
 		v.push_back(std::to_string(e.char_id));
 		v.push_back(std::to_string(e.item_id));
-		v.push_back(std::to_string(e.aug_slot_1));
+		v.push_back(std::to_string(e.serialnumber));
-		v.push_back(std::to_string(e.aug_slot_2));
+		v.push_back(std::to_string(e.charges));
-		v.push_back(std::to_string(e.aug_slot_3));
-		v.push_back(std::to_string(e.aug_slot_4));
-		v.push_back(std::to_string(e.aug_slot_5));
-		v.push_back(std::to_string(e.aug_slot_6));
-		v.push_back(std::to_string(e.item_sn));
-		v.push_back(std::to_string(e.item_charges));
 		v.push_back(std::to_string(e.item_cost));
 		v.push_back(std::to_string(e.slot_id));
-		v.push_back(std::to_string(e.char_entity_id));
-		v.push_back(std::to_string(e.char_zone_id));
-		v.push_back(std::to_string(e.active_transaction));
 
 		auto results = db.QueryDatabase(
 			fmt::format(
@@ -522,22 +413,12 @@ public:
 		for (auto &e: entries) {
 			std::vector<std::string> v;
 
-			v.push_back(std::to_string(e.id));
 			v.push_back(std::to_string(e.char_id));
 			v.push_back(std::to_string(e.item_id));
-			v.push_back(std::to_string(e.aug_slot_1));
+			v.push_back(std::to_string(e.serialnumber));
-			v.push_back(std::to_string(e.aug_slot_2));
+			v.push_back(std::to_string(e.charges));
-			v.push_back(std::to_string(e.aug_slot_3));
-			v.push_back(std::to_string(e.aug_slot_4));
-			v.push_back(std::to_string(e.aug_slot_5));
-			v.push_back(std::to_string(e.aug_slot_6));
-			v.push_back(std::to_string(e.item_sn));
-			v.push_back(std::to_string(e.item_charges));
 			v.push_back(std::to_string(e.item_cost));
 			v.push_back(std::to_string(e.slot_id));
-			v.push_back(std::to_string(e.char_entity_id));
-			v.push_back(std::to_string(e.char_zone_id));
-			v.push_back(std::to_string(e.active_transaction));
 
 			insert_chunks.push_back("(" + Strings::Implode(",", v) + ")");
 		}

common/repositories/character_data_repository.h

@@ -64,22 +64,6 @@ public:
 
 		return Strings::ToUnsignedInt(row[0]);
 	}
-
-	static CharacterData FindByName(
-		Database& db,
-		const std::string& character_name
-	)
-	{
-		auto l = CharacterDataRepository::GetWhere(
-			db,
-			fmt::format(
-				"`name` = '{}' LIMIT 1",
-				Strings::Escape(character_name)
-			)
-		);
-
-		return l.empty() ? CharacterDataRepository::NewEntity() : l.front();
-	}
 };
 
 #endif //EQEMU_CHARACTER_DATA_REPOSITORY_H

common/repositories/character_parcels_containers_repository.h

@@ -1,50 +0,0 @@
-#ifndef EQEMU_CHARACTER_PARCELS_CONTAINERS_REPOSITORY_H
-#define EQEMU_CHARACTER_PARCELS_CONTAINERS_REPOSITORY_H
-
-#include "../database.h"
-#include "../strings.h"
-#include "base/base_character_parcels_containers_repository.h"
-
-class CharacterParcelsContainersRepository: public BaseCharacterParcelsContainersRepository {
-public:
-
-    /**
-     * This file was auto generated and can be modified and extended upon
-     *
-     * Base repository methods are automatically
-     * generated in the "base" version of this repository. The base repository
-     * is immutable and to be left untouched, while methods in this class
-     * are used as extension methods for more specific persistence-layer
-     * accessors or mutators.
-     *
-     * Base Methods (Subject to be expanded upon in time)
-     *
-     * Note: Not all tables are designed appropriately to fit functionality with all base methods
-     *
-     * InsertOne
-     * UpdateOne
-     * DeleteOne
-     * FindOne
-     * GetWhere(std::string where_filter)
-     * DeleteWhere(std::string where_filter)
-     * InsertMany
-     * All
-     *
-     * Example custom methods in a repository
-     *
-     * CharacterParcelsContainersRepository::GetByZoneAndVersion(int zone_id, int zone_version)
-     * CharacterParcelsContainersRepository::GetWhereNeverExpires()
-     * CharacterParcelsContainersRepository::GetWhereXAndY()
-     * CharacterParcelsContainersRepository::DeleteWhereXAndY()
-     *
-     * Most of the above could be covered by base methods, but if you as a developer
-     * find yourself re-using logic for other parts of the code, its best to just make a
-     * method that can be re-used easily elsewhere especially if it can use a base repository
-     * method and encapsulate filters there
-     */
-
-	// Custom extended repository methods here
-
-};
-
-#endif //EQEMU_CHARACTER_PARCELS_CONTAINERS_REPOSITORY_H

common/repositories/character_parcels_repository.h

@@ -1,114 +0,0 @@
-#ifndef EQEMU_CHARACTER_PARCELS_REPOSITORY_H
-#define EQEMU_CHARACTER_PARCELS_REPOSITORY_H
-
-#include "../database.h"
-#include "../strings.h"
-#include "base/base_character_parcels_repository.h"
-
-class CharacterParcelsRepository: public BaseCharacterParcelsRepository {
-public:
-
-	/**
-	 * This file was auto generated and can be modified and extended upon
-	 *
-	 * Base repository methods are automatically
-	 * generated in the "base" version of this repository. The base repository
-	 * is immutable and to be left untouched, while methods in this class
-	 * are used as extension methods for more specific persistence-layer
-	 * accessors or mutators.
-	 *
-	 * Base Methods (Subject to be expanded upon in time)
-	 *
-	 * Note: Not all tables are designed appropriately to fit functionality with all base methods
-	 *
-	 * InsertOne
-	 * UpdateOne
-	 * DeleteOne
-	 * FindOne
-	 * GetWhere(std::string where_filter)
-	 * DeleteWhere(std::string where_filter)
-	 * InsertMany
-	 * All
-	 *
-	 * Example custom methods in a repository
-	 *
-	 * ParcelsRepository::GetByZoneAndVersion(int zone_id, int zone_version)
-	 * ParcelsRepository::GetWhereNeverExpires()
-	 * ParcelsRepository::GetWhereXAndY()
-	 * ParcelsRepository::DeleteWhereXAndY()
-	 *
-	 * Most of the above could be covered by base methods, but if you as a developer
-	 * find yourself re-using logic for other parts of the code, its best to just make a
-	 * method that can be re-used easily elsewhere especially if it can use a base repository
-	 * method and encapsulate filters there
-	 */
-
-	// Custom extended repository methods here
-	struct ParcelCountAndCharacterName
-	{
-		std::string character_name;
-		uint32      char_id;
-		uint32      parcel_count;
-	};
-
-	static std::vector<ParcelCountAndCharacterName> GetParcelCountAndCharacterName(Database &db, const std::string &character_name)
-	{
-		std::vector<ParcelCountAndCharacterName> all_entries;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"SELECT c.name, COUNT(p.id), c.id FROM character_data c "
-				"LEFT JOIN character_parcels p ON p.char_id = c.id "
-				"WHERE c.name = '{}' "
-				"LIMIT 1",
-				character_name)
-		);
-
-		all_entries.reserve(results.RowCount());
-
-		for(auto row = results.begin(); row != results.end(); ++row) {
-			ParcelCountAndCharacterName e {};
-
-			e.character_name = row[0] ? row[0] : "";
-			e.parcel_count   = row[1] ? Strings::ToUnsignedInt(row[1]) : 0;
-			e.char_id        = row[2] ? Strings::ToUnsignedInt(row[2]) : 0;
-
-			all_entries.push_back(e);
-		}
-
-		return all_entries;
-	}
-
-	static int GetNextFreeParcelSlot(Database& db, const uint32 character_id, const uint32 max_slots)
-	{
-		const auto& l = CharacterParcelsRepository::GetWhere(
-			db,
-			fmt::format(
-				"char_id = '{}' ORDER BY slot_id ASC",
-				character_id
-			)
-		);
-
-		if (l.empty()) {
-			return PARCEL_BEGIN_SLOT;
-		}
-
-		for (uint32 i = PARCEL_BEGIN_SLOT; i <= max_slots; i++) {
-			auto it = std::find_if(
-				l.cbegin(),
-				l.cend(),
-				[&](const auto &x) {
-					return x.slot_id == i;
-				}
-			);
-
-			if (it == l.end()) {
-				return i;
-			}
-		}
-
-		return INVALID_INDEX;
-	}
-};
-
-#endif //EQEMU_CHARACTER_PARCELS_REPOSITORY_H

common/repositories/command_subsettings_repository.h

@@ -49,11 +49,8 @@ public:
 		// these are the base definitions for command_subsettings and can be over-ridden by the database
 		std::vector<CommandSubsettingsRepository::CommandSubsettings> static_records = {
 			{.parent_command = "find", .sub_command = "aa", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findaa"},
-			{.parent_command = "find", .sub_command = "body_type", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findbodytype"},
-			{.parent_command = "find", .sub_command = "bug_category", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findbugcategory"},
 			{.parent_command = "find", .sub_command = "character", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findcharacter"},
 			{.parent_command = "find", .sub_command = "class", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findclass"},
-			{.parent_command = "find", .sub_command = "comparison_type", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findcomparisontype"},
 			{.parent_command = "find", .sub_command = "currency", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findcurrency"},
 			{.parent_command = "find", .sub_command = "deity", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "finddeity"},
 			{.parent_command = "find", .sub_command = "emote", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findemote"},
@@ -61,11 +58,9 @@ public:
 			{.parent_command = "find", .sub_command = "item", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "fi|finditem|itemsearch"},
 			{.parent_command = "find", .sub_command = "language", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findlanguage"},
 			{.parent_command = "find", .sub_command = "npc_type", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "fn|findnpc|findnpctype"},
-			{.parent_command = "find", .sub_command = "object_type", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findobjecttype"},
 			{.parent_command = "find", .sub_command = "race", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findrace"},
 			{.parent_command = "find", .sub_command = "recipe", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findrecipe"},
 			{.parent_command = "find", .sub_command = "skill", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findskill"},
-			{.parent_command = "find", .sub_command = "special_ability", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "fsa|findspecialability"},
 			{.parent_command = "find", .sub_command = "spell", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "fs|findspell"},
 			{.parent_command = "find", .sub_command = "task", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "findtask"},
 			{.parent_command = "find", .sub_command = "zone", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "fz|findzone"},
@@ -75,7 +70,6 @@ public:
 			{.parent_command = "set", .sub_command = "alternate_currency", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "setaltcurrency"},
 			{.parent_command = "set", .sub_command = "animation", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "setanim"},
 			{.parent_command = "set", .sub_command = "anon", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "setanon"},
-			{.parent_command = "set", .sub_command = "auto_login", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "setautologin"},
 			{.parent_command = "set", .sub_command = "bind", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "bind"},
 			{.parent_command = "set", .sub_command = "checksum", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "updatechecksum"},
 			{.parent_command = "set", .sub_command = "class_permanent", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "permaclass"},
@@ -128,7 +122,6 @@ public:
 			{.parent_command = "set", .sub_command = "zone", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "zclip|zcolor|zheader|zonelock|zsafecoords|zsky|zunderworld"},
 			{.parent_command = "show", .sub_command = "aas", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "showaas"},
 			{.parent_command = "show", .sub_command = "aa_points", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "showaapoints|showaapts"},
-			{.parent_command = "show", .sub_command = "auto_login", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "showautologin"},
 			{.parent_command = "show", .sub_command = "aggro", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "aggro"},
 			{.parent_command = "show", .sub_command = "buffs", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "showbuffs"},
 			{.parent_command = "show", .sub_command = "buried_corpse_count", .access_level = AccountStatus::QuestTroupe, .top_level_aliases = "getplayerburiedcorpsecount"},

common/repositories/group_leaders_repository.h

@@ -7,6 +7,7 @@
 
 class GroupLeadersRepository: public BaseGroupLeadersRepository {
 public:
+
     /**
      * This file was auto generated and can be modified and extended upon
      *
@@ -52,20 +53,6 @@ public:
 			)
 		);
 	}
-
-	static int UpdateLeadershipAA(Database &db, std::string &aa, uint32 group_id)
-	{
-		const auto group_leader = GetWhere(db, fmt::format("gid = '{}' LIMIT 1", group_id));
-		if(group_leader.empty()) {
-			return 0;
-		}
-
-		db.Encode(aa);
-		auto m = group_leader[0];
-		m.leadershipaa = aa;
-
-		return UpdateOne(db, m);
-	}
 };
 
 #endif //EQEMU_GROUP_LEADERS_REPOSITORY_H

common/repositories/guild_members_repository.h

@@ -190,17 +190,6 @@ public:
 
 		return UpdateOne(db, m);
 	}
-
-	static void ClearOnlineStatus(Database &db)
-	{
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"UPDATE {} SET `online` = 0 "
-				"WHERE `online` = 1;",
-				TableName()
-			)
-		);
-	}
 };
 
 #endif //EQEMU_GUILD_MEMBERS_REPOSITORY_H

common/repositories/guild_permissions_repository.h

@@ -45,31 +45,6 @@ public:
 
 	// Custom extended repository methods here
 
-	static std::map<std::string, GuildPermissions> LoadAll(Database &db)
-	{
-		std::map<std::string, GuildPermissions> all_entries;
-
-		auto results = db.QueryDatabase(
-			fmt::format(
-				"{} WHERE `guild_id` < {}",
-				BaseSelect(),
-				RoF2::constants::MAX_GUILD_ID
-			));
-
-		for (auto row = results.begin(); row != results.end(); ++row) {
-			GuildPermissions e{};
-
-			e.id         = static_cast<int32_t>(atoi(row[0]));
-			e.perm_id    = static_cast<int32_t>(atoi(row[1]));
-			e.guild_id   = static_cast<int32_t>(atoi(row[2]));
-			e.permission = static_cast<int32_t>(atoi(row[3]));
-
-			auto key = fmt::format("{}-{}", e.guild_id, e.perm_id);
-			all_entries.emplace(key, e);
-		}
-
-		return all_entries;
-	}
 };
 
 #endif //EQEMU_GUILD_PERMISSIONS_REPOSITORY_H

common/repositories/guild_ranks_repository.h

@@ -60,30 +60,6 @@ public:
 
 		return 1;
 	}
-
-	static std::map<std::string, std::string> LoadAll(Database &db)
-	{
-		std::map<std::string, std::string> all_entries;
-
-		auto results = db.QueryDatabase(fmt::format(
-			"{} WHERE `guild_id` < {}",
-			BaseSelect(),
-			RoF2::constants::MAX_GUILD_ID)
-		);
-
-		for (auto row = results.begin(); row != results.end(); ++row) {
-			GuildRanks e{};
-
-			e.guild_id = row[0] ? static_cast<uint32_t>(strtoul(row[0], nullptr, 10)) : 0;
-			e.rank_    = row[1] ? static_cast<uint8_t>(strtoul(row[1], nullptr, 10)) : 0;
-			e.title    = row[2] ? row[2] : "";
-
-			auto key = fmt::format("{}-{}", e.guild_id, e.rank_);
-			all_entries.emplace(key, e.title);
-		}
-
-		return all_entries;
-	}
 };
 
 #endif //EQEMU_GUILD_RANKS_REPOSITORY_H

common/repositories/items_repository.h

@@ -7,6 +7,43 @@
 
 class ItemsRepository: public BaseItemsRepository {
 public:
+
+    /**
+     * This file was auto generated and can be modified and extended upon
+     *
+     * Base repository methods are automatically
+     * generated in the "base" version of this repository. The base repository
+     * is immutable and to be left untouched, while methods in this class
+     * are used as extension methods for more specific persistence-layer
+     * accessors or mutators.
+     *
+     * Base Methods (Subject to be expanded upon in time)
+     *
+     * Note: Not all tables are designed appropriately to fit functionality with all base methods
+     *
+     * InsertOne
+     * UpdateOne
+     * DeleteOne
+     * FindOne
+     * GetWhere(std::string where_filter)
+     * DeleteWhere(std::string where_filter)
+     * InsertMany
+     * All
+     *
+     * Example custom methods in a repository
+     *
+     * ItemsRepository::GetByZoneAndVersion(int zone_id, int zone_version)
+     * ItemsRepository::GetWhereNeverExpires()
+     * ItemsRepository::GetWhereXAndY()
+     * ItemsRepository::DeleteWhereXAndY()
+     *
+     * Most of the above could be covered by base methods, but if you as a developer
+     * find yourself re-using logic for other parts of the code, its best to just make a
+     * method that can be re-used easily elsewhere especially if it can use a base repository
+     * method and encapsulate filters there
+     */
+
+	// Custom extended repository methods here
 	static std::vector<int32> GetItemIDsBySearchCriteria(
 		Database& db,
 		std::string search_string,
@@ -36,8 +73,6 @@ public:
 
 		return item_id_list;
 	}
-
-
 };
 
 #endif //EQEMU_ITEMS_REPOSITORY_H

common/repositories/trader_repository.h

@@ -1,224 +1,50 @@
 #ifndef EQEMU_TRADER_REPOSITORY_H
 #define EQEMU_TRADER_REPOSITORY_H
 
-#include "../../common/shareddb.h"
+#include "../database.h"
 #include "../strings.h"
 #include "base/base_trader_repository.h"
-#include "items_repository.h"
-#include "../../common/item_data.h"
-#include "../../common/races.h"
-#include "../cereal/include/cereal/archives/binary.hpp"
-#include "../cereal/include/cereal/types/string.hpp"
 
-class TraderRepository : public BaseTraderRepository {
+class TraderRepository: public BaseTraderRepository {
 public:
 
-	struct DistinctTraders_Struct {
+    /**
-		uint32      trader_id;
+     * This file was auto generated and can be modified and extended upon
-		uint32      zone_id;
+     *
-		uint32      entity_id;
+     * Base repository methods are automatically
-		std::string trader_name;
+     * generated in the "base" version of this repository. The base repository
-	};
+     * is immutable and to be left untouched, while methods in this class
+     * are used as extension methods for more specific persistence-layer
+     * accessors or mutators.
+     *
+     * Base Methods (Subject to be expanded upon in time)
+     *
+     * Note: Not all tables are designed appropriately to fit functionality with all base methods
+     *
+     * InsertOne
+     * UpdateOne
+     * DeleteOne
+     * FindOne
+     * GetWhere(std::string where_filter)
+     * DeleteWhere(std::string where_filter)
+     * InsertMany
+     * All
+     *
+     * Example custom methods in a repository
+     *
+     * TraderRepository::GetByZoneAndVersion(int zone_id, int zone_version)
+     * TraderRepository::GetWhereNeverExpires()
+     * TraderRepository::GetWhereXAndY()
+     * TraderRepository::DeleteWhereXAndY()
+     *
+     * Most of the above could be covered by base methods, but if you as a developer
+     * find yourself re-using logic for other parts of the code, its best to just make a
+     * method that can be re-used easily elsewhere especially if it can use a base repository
+     * method and encapsulate filters there
+     */
 
-	struct BulkTraders_Struct {
+	// Custom extended repository methods here
-		uint32                              count{0};
-		uint32                              name_length{0};
-		std::vector<DistinctTraders_Struct> traders{};
-	};
 
-	struct WelcomeData_Struct {
-		uint32 count_of_traders;
-		uint32 count_of_items;
-	};
-
-	static std::vector<BazaarSearchResultsFromDB_Struct>
-	GetBazaarSearchResults(
-		SharedDatabase &db,
-		BazaarSearchCriteria_Struct search,
-		uint32 char_zone_id
-	);
-
-	static BulkTraders_Struct GetDistinctTraders(Database &db)
-	{
-		BulkTraders_Struct                  all_entries{};
-		std::vector<DistinctTraders_Struct> distinct_traders;
-
-		auto results = db.QueryDatabase(
-			"SELECT DISTINCT(t.char_id), t.char_zone_id, t.char_entity_id, c.name "
-			"FROM trader AS t "
-			"JOIN character_data AS c ON t.char_id = c.id;"
-		);
-
-		distinct_traders.reserve(results.RowCount());
-
-		for (auto row: results) {
-			DistinctTraders_Struct e{};
-
-			e.trader_id   = Strings::ToInt(row[0]);
-			e.zone_id     = Strings::ToInt(row[1]);
-			e.entity_id   = Strings::ToInt(row[2]);
-			e.trader_name = row[3] ? row[3] : "";
-			all_entries.name_length += e.trader_name.length() + 1;
-
-			all_entries.traders.push_back(e);
-		}
-		all_entries.count = results.RowCount();
-		return all_entries;
-	}
-
-	static WelcomeData_Struct GetWelcomeData(Database &db)
-	{
-		WelcomeData_Struct e{};
-
-		auto results = db.QueryDatabase("SELECT COUNT(DISTINCT char_id), count(char_id) FROM trader;");
-
-		if (!results.RowCount()) {
-			return e;
-		}
-
-		auto r = results.begin();
-		e.count_of_traders = Strings::ToInt(r[0]);
-		e.count_of_items   = Strings::ToInt(r[1]);
-		return e;
-	}
-
-	static int UpdateItem(Database &db, uint32 char_id, uint32 new_price, uint32 item_id, uint32 item_charges)
-	{
-		std::vector<BaseTraderRepository::Trader> items{};
-		if (item_charges == 0) {
-			items = GetWhere(
-				db,
-				fmt::format(
-					"char_id = '{}' AND item_id = '{}'",
-					char_id,
-					item_id
-				)
-			);
-		}
-		else {
-			items = GetWhere(
-				db,
-				fmt::format(
-					"char_id = '{}' AND item_id = '{}' AND item_charges = '{}'",
-					char_id,
-					item_id,
-					item_charges
-				)
-			);
-		}
-
-		if (items.empty()) {
-			return 0;
-		}
-
-		for (auto &i: items) {
-			i.item_cost = new_price;
-		}
-
-		return ReplaceMany(db, items);
-	}
-
-	static Trader GetTraderItem(Database &db, uint32 trader_id, uint32 item_id, uint32 item_cost)
-	{
-		Trader item{};
-
-		auto query   = fmt::format(
-			"SELECT t.char_id, t.item_id, t.serialnumber, t.charges, t.item_cost, t.slot_id, t.entity_id FROM trader AS t "
-			"WHERE t.entity_id = {} AND t.item_id = {} AND t.item_cost = {} "
-			"LIMIT 1;",
-			trader_id,
-			item_id,
-			item_cost
-		);
-		auto results = db.QueryDatabase(query);
-
-		if (results.RowCount() == 0) {
-			return item;
-		}
-
-		auto row = results.begin();
-		item.char_id      = Strings::ToInt(row[0]);
-		item.item_id      = Strings::ToInt(row[1]);
-		item.item_sn      = Strings::ToInt(row[2]);
-		item.item_charges = Strings::ToInt(row[3]);
-		item.item_cost    = Strings::ToInt(row[4]);
-		item.slot_id      = Strings::ToInt(row[5]);
-
-		return item;
-	}
-
-	static int UpdateQuantity(Database &db, uint32 char_id, uint32 serial_number, int16 quantity)
-	{
-		const auto trader_item = GetWhere(
-			db,
-			fmt::format("char_id = '{}' AND item_sn = '{}' ", char_id, serial_number)
-		);
-
-		if (trader_item.empty() || trader_item.size() > 1) {
-			return 0;
-		}
-
-		auto m = trader_item[0];
-		m.item_charges = quantity;
-
-		return UpdateOne(db, m);
-	}
-
-	static Trader GetItemBySerialNumber(Database &db, uint32 serial_number)
-	{
-		Trader     e{};
-		const auto trader_item = GetWhere(
-			db,
-			fmt::format("`item_sn` = '{}' LIMIT 1", serial_number)
-		);
-
-		if (trader_item.empty()) {
-			return e;
-		}
-		else {
-			return trader_item.at(0);
-		}
-	}
-
-	static Trader GetItemBySerialNumber(Database &db, std::string serial_number)
-	{
-		Trader     e{};
-		auto       sn          = Strings::ToUnsignedBigInt(serial_number);
-		const auto trader_item = GetWhere(
-			db,
-			fmt::format("`item_sn` = '{}' LIMIT 1", sn)
-		);
-
-		if (trader_item.empty()) {
-			return e;
-		}
-		else {
-			return trader_item.at(0);
-		}
-	}
-
-	static int UpdateActiveTransaction(Database &db, uint32 id, bool status)
-	{
-		auto e = FindOne(db, id);
-		if (!e.id) {
-			return 0;
-		}
-
-		e.active_transaction = status == true ? 1 : 0;
-
-		return UpdateOne(db, e);
-	}
-
-	static int DeleteMany(Database &db, const std::vector<Trader> &entries)
-	{
-		std::vector<std::string> delete_ids;
-
-		for (auto const &e: entries) {
-			delete_ids.push_back(std::to_string(e.id));
-		}
-
-		return DeleteWhere(db, fmt::format("`id` IN({})", Strings::Implode(",", delete_ids)));
-	}
 };
 
 #endif //EQEMU_TRADER_REPOSITORY_H

common/ruletypes.h

@@ -226,8 +226,6 @@ RULE_INT(Character, ClearXTargetDelay, 10, "Seconds between uses of the #clearxt
 RULE_BOOL(Character, PreventMountsFromZoning, false, "Enable to prevent mounts from zoning - Prior to December 15, 2004 this is enabled.")
 RULE_BOOL(Character, GroupInvitesRequireTarget, false, "Enable to require players to have invitee on target (Disables /invite name) - Classic Style")
 RULE_BOOL(Character, PlayerTradingLoreFeedback, true, "If enabled, during a player to player trade, if lore items exist, it will output which items.")
-RULE_INT(Character, MendAlwaysSucceedValue, 199, "Value at which mend will always succeed its skill check. Default: 199")
-RULE_BOOL(Character, SneakAlwaysSucceedOver100, false, "When sneak skill is over 100, always succeed sneak/hide. Default: false")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(Mercs)
@@ -332,7 +330,6 @@ RULE_BOOL(World, UseOldShadowKnightClassExport, true, "Disable to have Shadowkni
 RULE_STRING(World, IPExemptionZones, "", "Comma-delimited list of zones to exclude from IP-limit checks. Empty string to disable.")
 RULE_STRING(World, MOTD, "", "Server MOTD sent on login, change from empty to have this be used instead of variables table 'motd' value")
 RULE_STRING(World, Rules, "", "Server Rules, change from empty to have this be used instead of variables table 'rules' value, lines are pipe (|) separated, example: A|B|C")
-RULE_BOOL(World, EnableAutoLogin, false, "Enables or disables auto login of characters, allowing people to log characters in directly from loginserver to ingame")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(Zone)
@@ -505,19 +502,14 @@ RULE_BOOL(Spells, RequireMnemonicRetention, true, "Enabling will require spell s
 RULE_BOOL(Spells, EvacClearCharmPet, false, "Enable to have evac in zone clear charm from charm pets and detach buffs.")
 RULE_BOOL(Spells, ManaTapsRequireNPCMana, false, "Enabling will require target to have mana to tap. Default off as many npc's are caster class with 0 mana and need fixed.")
 RULE_INT(Spells, HarmTouchCritRatio, 200, "Harmtouch crit bonus, on top of BaseCritRatio")
-RULE_BOOL(Spells, UseClassicHarmTouchDamage, false, "Use pre 2007 Harm Touch calculations - Default: False")
 RULE_BOOL(Spells, UseClassicSpellFocus, false, "Enabling will tell the server to handle random focus damage as classic spell imports lack the limit values.")
 RULE_BOOL(Spells, ManaTapsOnAnyClass, false, "Enabling this will allow you to cast mana taps on any class, this will bypass ManaTapsRequireNPCMana rule.")
-RULE_INT(Spells, HealAmountMessageFilterThreshold, 100, "Lifetaps below this threshold will not have a message sent to the client (Heal will still process) 0 to Disable.")
-RULE_BOOL(Spells, SnareOverridesSpeedBonuses, false, "Enabling will allow snares to override any speed bonuses the entity may have. Default: False")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(Combat)
 RULE_REAL(Combat, AERampageMaxDistance, 70, "Max AERampage range (% of max combat distance)")
 RULE_INT(Combat, PetBaseCritChance, 0, "Pet base crit chance")
 RULE_INT(Combat, NPCBashKickLevel, 6, "The level that NPCcan KICK/BASH")
-RULE_INT(Combat, NPCKickStunLevel, 1, "The level that NPC has a chance to stun with kick.")
-RULE_INT(Combat, PCKickStunLevel, 56, "The level that PC has a chance to stun with kick.")
 RULE_INT(Combat, MeleeCritDifficulty, 8900, "Value against which is rolled to check if a melee crit is triggered. Lower is easier")
 RULE_INT(Combat, ArcheryCritDifficulty, 3400, "Value against which is rolled to check if an archery crit is triggered. Lower is easier")
 RULE_INT(Combat, ThrowingCritDifficulty, 1100, "Value against which is rolled to check if a throwing crit is triggered. Lower is easier")
@@ -525,8 +517,6 @@ RULE_BOOL(Combat, NPCCanCrit, false, "Setting whether an NPC can land critical h
 RULE_BOOL(Combat, UseIntervalAC, true, "Switch whether bonuses, armour class, multipliers, classes and caps should be considered in the calculation of damage values")
 RULE_INT(Combat, PetAttackMagicLevel, 10, "Level at which pets can cause magic damage, no longer used")
 RULE_INT(Combat, NPCAttackMagicLevel, 10, "Level at which NPC and pets can cause magic damage")
-RULE_INT(Combat, LevelDifferenceRollCheck, -1, "Level Difference to enable LeverDifferenceRollBonus for MeleeMitigation - Default: -1 is disabled, 20 is common")
-RULE_REAL(Combat, LevelDifferenceRollBonus, 0.5, "Roll Bonus/Detrement if using LevelDifferenceRollCheck")
 RULE_BOOL(Combat, EnableFearPathing, true, "Setting whether to use pathing during fear")
 RULE_BOOL(Combat, FleeGray, true, "If true FleeGrayHPRatio will be used")
 RULE_INT(Combat, FleeGrayHPRatio, 50, "HP percentage when a Gray NPC begins to flee")
@@ -596,8 +586,6 @@ RULE_BOOL(Combat, BackstabIgnoresElemental, false, "Enable or disable Elemental
 RULE_BOOL(Combat, BackstabIgnoresBane, false, "Enable or disable Bane weapon damage affecting backstab damage, false by default.")
 RULE_INT(Combat, DoubleBackstabLevelRequirement, 55, "Level requirement to enable double backstab attempts. The default is 55.")
 RULE_BOOL(Combat, SummonMeleeRange, true, "Enable or disable summoning of a player when already in melee range of the summoner.")
-RULE_REAL(Combat, ArcheryHitPenalty, 0, "Archery has a hit penalty to try to help balance it with the plethora of long term +hit modifiers for it - Default: 0")
-RULE_REAL(Combat, ArcheryBaseDamageBonus, 1, "Percentage modifier to base archery Damage 0.5=50% base damage, 1=100%,2=200% - Default: 1")
 RULE_BOOL(Combat, WaterMatchRequiredForAutoFireLoS, true, "Enable/Disable the requirement of both the attacker/victim being both in or out of water for AutoFire LoS to pass.")
 RULE_INT(Combat, ExtraAllowedKickClassesBitmask, 0, "Bitmask for allowing extra classes beyond Warrior, Ranger, Beastlord, and Berserker to kick, No Extra Classes (0) by default")
 RULE_INT(Combat, MaxProcs, 4, "Adjustable maximum number of procs per round, the hard cap is MAX_PROCS (11). Requires mob repop or client zone when changed")
@@ -608,30 +596,8 @@ RULE_INT(Combat, ClassicTripleAttackChanceMonk, 100, "Innate Chance for Monk to
 RULE_INT(Combat, ClassicTripleAttackChanceBerserker, 100, "Innate Chance for Berserker to Triple Attack after a Double Attack (200 = 20%). DEFAULT: 100")
 RULE_INT(Combat, ClassicTripleAttackChanceRanger, 100, "Innate Chance for Ranger to Triple Attack after a Double Attack (200 = 20%). DEFAULT: 100")
 RULE_INT(Combat, StunChance, 12, "Percent chance that client will be stunned when mob is behind player. DEFAULT: 12")
-RULE_INT(Combat, StunDuration, 2000, "Duration of stuns in ms. DEFAULT: 2000")
-RULE_BOOL(Combat, ClientStunMessage, false, "Client stunning NPC produces message. DEFAULT false")
 RULE_BOOL(Combat, BashTwoHanderUseShoulderAC, false, "Enable to use shoulder AC for bash calculations when two hander is equipped. Unproven if accurate DEFAULT: false")
 RULE_REAL(Combat, BashACBonusDivisor, 25.0, "this divides the AC value contribution to bash damage, lower to increase damage")
-RULE_BOOL(Combat, UseMobStaticOffenseSkill, false, "Toggle to enabled the use of a static offense skill for Mobs.  DEFAULT: false")
-RULE_BOOL(Combat, UseEnhancedMobStaticWeaponSkill, false, "Toggle to enabled the use of an enhanced (slightly higher hit rate) static weapon skill for Mobs.  DEFAULT: false")
-RULE_INT(Combat, PCAttackPowerScaling, 100, "Applies scaling to PC Attack Power (75 = 75%).  DEFAULT: 100 to not adjust existing Servers")
-RULE_INT(Combat, PCAccuracyAvoidanceMod2Scale, 100, "Scale Factor for PC Accuracy and Avoidance (Mod2, found on items).  Found a value of 100 to make both too strong (75 = x0.75).  DEFAULT: 100 to not adjust existing Servers")
-RULE_BOOL(Combat, AllowRaidTargetBlind, false, "Toggle to allow raid targets to be blinded, default is false (Live-like)")
-RULE_BOOL(Combat, RogueBackstabHasteCorrection, false, "Toggle to enable correction for Haste impacting Backstab DPS too much.  DEFAULT: false")
-RULE_BOOL(Combat, LegacyComputeDefense, false, "Trim AGI Scaling of defense mostly for lower levels to help compensate for the newer agi based defense system. Default: False")
-RULE_REAL(Combat, SlayDamageAdjustment, 0.5, "Slay Damage Adjustment - Multiply final slay damage by this value. Default: 0.5")
-RULE_INT(Combat, MaximumLevelStunsCripplingBlow, 55, "Maximum level that Crippling Blows will stun a npc. Default: 55")
-RULE_INT(Combat, ArcheryBaseDamage, 0, "Archery base damage, default is 0")
-RULE_INT(Combat, BackstabBaseDamage, 0, "Backstab base damage, default is 0")
-RULE_INT(Combat, BashBaseDamage, 2, "Bash base damage, default is 2")
-RULE_INT(Combat, DragonPunchBaseDamage, 12, "Dragon Punch base damage, default is 12")
-RULE_INT(Combat, EagleStrikeBaseDamage, 7, "Eagle Strike base damage, default is 7")
-RULE_INT(Combat, FlyingKickBaseDamage, 25, "Flying Kick base damage, default is 25")
-RULE_INT(Combat, FrenzyBaseDamage, 10, "Frenzy base damage, default is 10")
-RULE_INT(Combat, KickBaseDamage, 3, "Kick base damage, default is 3")
-RULE_INT(Combat, RoundKickBaseDamage, 5, "Round Kick base damage, default is 5")
-RULE_INT(Combat, ThrowingBaseDamage, 0, "Throwing base damage, default is 0")
-RULE_INT(Combat, TigerClawBaseDamage, 4, "Tiger Claw base damage, default is 4")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(NPC)
@@ -690,8 +656,6 @@ RULE_BOOL(Aggro, NPCAggroMaxDistanceEnabled, true, "If enabled, NPC's will drop
 RULE_BOOL(Aggro, AggroPlayerPets, false, "If enabled, NPCs will aggro player pets")
 RULE_BOOL(Aggro, UndeadAlwaysAggro, true, "should undead always aggro?")
 RULE_INT(Aggro, BardAggroCap, 40, "per song bard aggro cap.")
-RULE_INT(Aggro, InitialAggroBonus, 100, "Initial Aggro Bonus, Default: 100")
-RULE_INT(Aggro, InitialPetAggroBonus, 100, "Initial Pet Aggro Bonus, Default 100")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(TaskSystem)
@@ -756,7 +720,7 @@ RULE_BOOL(Bots, BotHealOnLevel, false, "Setting whether a bot should heal comple
 RULE_INT(Bots, AutosaveIntervalSeconds, 300, "Number of seconds after which a timer is triggered which stores the bot data. The value 0 means no periodic automatic saving.")
 RULE_BOOL(Bots, CazicTouchBotsOwner, true, "Default True. Cazic Touch/DT will hit bot owner rather than bot.")
 RULE_INT(Bots, BotsClickItemsMinLvl, 1, "Minimum level for bots to be able to use ^clickitem. Default 1.")
-RULE_BOOL(Bots, BotsCanClickItems, true, "Enables the ability for bots to click items they have equipped. Default TRUE")
+RULE_BOOL(Bots, BotsCanClickItems, true, "Enabled the ability for bots to click items they have equipped. Default TRUE")
 RULE_BOOL(Bots, CanClickMageEpicV1, true, "Whether or not bots are allowed to click Mage Epic 1.0. Default TRUE")
 RULE_CATEGORY_END()
 
@@ -785,7 +749,6 @@ RULE_CATEGORY_END()
 
 RULE_CATEGORY(Merchant)
 RULE_BOOL(Merchant, UsePriceMod, true, "Use faction/charisma price modifiers")
-RULE_BOOL(Merchant, UseClassicPriceMod, false, "Must also set UsePriceMod. Negates other rules for vendor price mods.")
 RULE_REAL(Merchant, SellCostMod, 1.05, "Modifier for NPC sell price")
 RULE_REAL(Merchant, BuyCostMod, 0.95, "Modifier for NPC buy price")
 RULE_INT(Merchant, PriceBonusPct, 4, "Determines maximum price bonus from having good faction/CHA. Value is a percent")
@@ -801,9 +764,6 @@ RULE_BOOL(Bazaar, AuditTrail, false, "Setting whether a path to the trader shoul
 RULE_INT(Bazaar, MaxSearchResults, 50, "Maximum number of search results in Bazaar")
 RULE_BOOL(Bazaar, EnableWarpToTrader, true, "Setting whether teleport to the selected trader should be active")
 RULE_INT(Bazaar, MaxBarterSearchResults, 200, "The maximum results returned in the /barter search")
-RULE_REAL(Bazaar, ParcelDeliveryCostMod, 0.20, "Cost of parcel delivery for a bazaar purchase as a percentage of item cost. Default is 20% of item cost. RoF+ Only.")
-RULE_INT(Bazaar, VoucherDeliveryCost, 200, "Number of vouchers for direct delivery for a bazaar purchase. Default is 200 vouchers. RoF+ Only.")
-RULE_BOOL(Bazaar, EnableParcelDelivery, true, "Enable bazaar purchases via parcel delivery.  Default is True.")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(Mail)
@@ -848,7 +808,6 @@ RULE_INT(AA, ModernAAScalingAAMinimum, 0, "The minimum number of earned AA befor
 RULE_INT(AA, ModernAAScalingAALimit, 4000, "The number of earned AA when AA experience scaling ends")
 RULE_BOOL(AA, SoundForAAEarned, false, "Play sound when AA point earned")
 RULE_INT(AA, UnusedAAPointCap, -1, "Cap for Unused AA Points.  Default: -1.  NOTE: DO NOT LOWER THIS WITHOUT KNOWING WHAT YOU ARE DOING. MAY RESULT IN PLAYERS LOSING AAs.")
-RULE_INT(AA, MaxAAEXPPerKill, -1, "Maximum AA EXP per Kill (3425214 is about 7%) - Default: -1 will disable the check")
 RULE_CATEGORY_END()
 
 RULE_CATEGORY(Console)
@@ -997,18 +956,6 @@ RULE_BOOL(Items, DisableNoRent, false, "Enable this to disable No Rent Items")
 RULE_BOOL(Items, DisableNoTransfer, false, "Enable this to disable No Transfer Items")
 RULE_BOOL(Items, DisablePotionBelt, false, "Enable this to disable Potion Belt Items")
 RULE_BOOL(Items, DisableSpellFocusEffects, false, "Enable this to disable Spell Focus Effects on Items")
-RULE_BOOL(Items, SummonItemAllowInvisibleAugments, false, "Enable this to allow augments to be put in invisible augment slots of items in Client::SummonItem")
-RULE_BOOL(Items, AugmentItemAllowInvisibleAugments, false, "Enable this to allow augments to be put in invisible augment slots by players")
-RULE_CATEGORY_END()
-
-RULE_CATEGORY(Parcel)
-RULE_BOOL(Parcel, EnableParcelMerchants, true, "Enable or Disable Parcel Merchants.  Requires RoF+ Clients.")
-RULE_BOOL(Parcel, EnableDirectToInventoryDelivery, false, "Enable or Disable RoF2 bazaar purchases to be delivered directly to the buyer's inventory.")
-RULE_BOOL(Parcel, DeleteOnDuplicate, false, "Delete retrieved item if it creates a lore conflict.")
-RULE_BOOL(Parcel, EnablePruning, false, "Enable the automatic pruning of sent parcels.  Uses rule ParcelPruneDelay for prune delay.")
-RULE_INT(Parcel, ParcelDeliveryDelay, 30000, "Sets the time that a player must wait between sending parcels.")
-RULE_INT(Parcel, ParcelMaxItems, 50, "The maximum number of parcels a player is allowed to have in their mailbox.")
-RULE_INT(Parcel, ParcelPruneDelay, 30, "The number of days after which a parcel is deleted. Items are lost!")
 RULE_CATEGORY_END()
 
 #undef RULE_CATEGORY

common/server_event_scheduler.h

@@ -11,7 +11,7 @@ namespace ServerEvents {
 	static const std::string EVENT_TYPE_RELOAD_WORLD        = "reload_world";
 	static const std::string EVENT_TYPE_RULE_CHANGE         = "rule_change";
 	static const std::string EVENT_TYPE_CONTENT_FLAG_CHANGE = "content_flag_change";
-} // namespace ServerEvents
+}
 
 class ServerEventScheduler {
 public:

common/servertalk.h

@@ -43,7 +43,7 @@
 #define ServerOP_OnlineGuildMembersResponse	0x0016
 #define ServerOP_LFGuildUpdate		0x0017
 
-#define ServerOP_FlagUpdate			0x0018	// GM flag updated for character, refresh the memory cache
+#define ServerOP_FlagUpdate			0x0018	// GM Flag updated for character, refresh the memory cache
 #define ServerOP_GMGoto				0x0019
 #define ServerOP_MultiLineMsg		0x001A
 #define ServerOP_Lock				0x001B	// For #lock/#unlock inside server
@@ -113,9 +113,6 @@
 #define ServerOP_GuildSendGuildList				  0x007E
 #define ServerOP_GuildMembersList                 0x007F
 
-#define ServerOP_ParcelDelivery                   0x0090
-#define ServerOP_ParcelPrune                      0x0091
-
 #define ServerOP_RaidAdd			0x0100 //in use
 #define ServerOP_RaidRemove			0x0101 //in use
 #define	ServerOP_RaidDisband		0x0102 //in use
@@ -138,9 +135,6 @@
 #define ServerOP_RaidMOTD			0x0113
 #define ServerOP_RaidNote           0x0114
 
-#define ServerOP_TraderMessaging    0x0120
-#define ServerOP_BazaarPurchase     0x0121
-
 #define ServerOP_InstanceUpdateTime			0x014F
 #define ServerOP_AdventureRequest			0x0150
 #define ServerOP_AdventureRequestAccept		0x0151
@@ -280,7 +274,6 @@
 #define ServerOP_ReloadLoot 0x4127
 #define ServerOP_ReloadBaseData 0x4128
 #define ServerOP_ReloadSkillCaps 0x4129
-#define ServerOP_ReloadNPCSpells 0x4130
 
 #define ServerOP_CZDialogueWindow 0x4500
 #define ServerOP_CZLDoNUpdate 0x4501
@@ -1941,27 +1934,6 @@ struct ServerOP_GuildMessage_Struct {
     char   url[2048]{0};
 };
 
-struct TraderMessaging_Struct {
-	uint32 action;
-	uint32 zone_id;
-	uint32 trader_id;
-	uint32 entity_id;
-	char   trader_name[64];
-};
-
-struct BazaarPurchaseMessaging_Struct {
-	TraderBuy_Struct trader_buy_struct;
-	uint32           item_aug_1;
-	uint32           item_aug_2;
-	uint32           item_aug_3;
-	uint32           item_aug_4;
-	uint32           item_aug_5;
-	uint32           item_aug_6;
-	uint32           buyer_id;
-	uint32           item_quantity_available;
-	uint32           id;
-};
-
 #pragma pack()
 
 #endif

common/skill_caps.cpp

@@ -1,14 +1,4 @@
 #include "skill_caps.h"
-#include "timer.h"
-
-// cache the skill cap max level in the database
-std::map<uint8_t, int32_t> skill_max_level = {};
-
-uint8 skill_cap_max_level = (
-	RuleI(Character, SkillCapMaxLevel) > 0 ?
-		RuleI(Character, SkillCapMaxLevel) :
-		RuleI(Character, MaxLevel)
-);
 
 SkillCaps *SkillCaps::SetContentDatabase(Database *db)
 {
@@ -17,38 +7,26 @@ SkillCaps *SkillCaps::SetContentDatabase(Database *db)
 	return this;
 }
 
-int32_t SkillCaps::GetSkillCapMaxLevel(uint8 class_id, EQ::skills::SkillType skill_id)
-{
-	// pull the max value defined in the database if it exists
-	auto it = skill_max_level.find((class_id * 1000000) + skill_id);
-	if (it != skill_max_level.end()) {
-		return it->second;
-	}
-
-	return skill_cap_max_level;
-}
-
 SkillCapsRepository::SkillCaps SkillCaps::GetSkillCap(uint8 class_id, EQ::skills::SkillType skill_id, uint8 level)
 {
-	if (!IsPlayerClass(class_id) || static_cast<uint32>(skill_id) > EQ::skills::HIGHEST_SKILL + 1) {
+	if (!IsPlayerClass(class_id)) {
 		return SkillCapsRepository::NewEntity();
 	}
 
-	const uint8 max_level = GetSkillCapMaxLevel(class_id, skill_id);
+	for (const auto &e: m_skill_caps) {
-	if (level > max_level) {
+		if (
-		level = max_level;
+			e.class_id == class_id &&
+			e.level == level &&
+			static_cast<EQ::skills::SkillType>(e.skill_id) == skill_id
+			) {
+			return e;
 		}
-
-	const uint64_t key = (class_id * 1000000) + (level * 1000) + static_cast<uint32>(skill_id);
-	auto           pos = m_skill_caps.find(key);
-	if (pos != m_skill_caps.end()) {
-		return pos->second;
 	}
 
 	return SkillCapsRepository::NewEntity();
 }
 
-uint8 SkillCaps::GetSkillTrainLevel(uint8 class_id, EQ::skills::SkillType skill_id, uint8 level)
+uint8 SkillCaps::GetTrainLevel(uint8 class_id, EQ::skills::SkillType skill_id, uint8 level)
 {
 	if (
 		!IsPlayerClass(class_id) ||
@@ -58,14 +36,25 @@ uint8 SkillCaps::GetSkillTrainLevel(uint8 class_id, EQ::skills::SkillType skill_
 		return 0;
 	}
 
+	const uint8 skill_cap_max_level = (
+		RuleI(Character, SkillCapMaxLevel) > 0 ?
+			RuleI(Character, SkillCapMaxLevel) :
+			RuleI(Character, MaxLevel)
+	);
+
 	const uint8 max_level = level > skill_cap_max_level ? level : skill_cap_max_level;
-	const uint64_t key       = (class_id * 1000000) + (level * 1000) + static_cast<uint32>(skill_id);
+
+	for (const auto &e: m_skill_caps) {
 		for (uint8 current_level = 1; current_level <= max_level; current_level++) {
-		auto pos = m_skill_caps.find(key);
+			if (
-		if (pos != m_skill_caps.end()) {
+				e.class_id == class_id &&
+				static_cast<EQ::skills::SkillType>(e.skill_id) == skill_id &&
+				e.level == current_level
+				) {
 				return current_level;
 			}
 		}
+	}
 
 	return 0;
 }
@@ -74,7 +63,7 @@ void SkillCaps::LoadSkillCaps()
 {
 	const auto &l = SkillCapsRepository::All(*m_content_database);
 
-	m_skill_caps.clear();
+	m_skill_caps.reserve(l.size());
 
 	for (const auto &e: l) {
 		if (
@@ -85,25 +74,7 @@ void SkillCaps::LoadSkillCaps()
 			continue;
 		}
 
-		const uint64_t key = (e.class_id * 1000000) + (e.level * 1000) + e.skill_id;
+		m_skill_caps.emplace_back(e);
-		m_skill_caps[key] = e;
-
-		const int max_level_key = (e.class_id * 1000000) + e.skill_id;
-		auto      it            = skill_max_level.find(max_level_key);
-		if (it != skill_max_level.end()) {
-			// Key found, update the value if the new level is higher
-			if (e.level > it->second) {
-				it->second = e.level;
-			}
-			// we never want to exceed the defined rule skill cap max level
-			if (it->second > skill_cap_max_level) {
-				it->second = skill_cap_max_level;
-			}
-		}
-		else {
-			// Key not found, insert the new key-value pair
-			skill_max_level[max_level_key] = e.level;
-		}
 	}
 
 	LogInfo(

common/skill_caps.h

@@ -10,15 +10,14 @@ class SkillCaps {
 public:
 	inline void ClearSkillCaps() { m_skill_caps.clear(); }
 	SkillCapsRepository::SkillCaps GetSkillCap(uint8 class_id, EQ::skills::SkillType skill_id, uint8 level);
-	uint8 GetSkillTrainLevel(uint8 class_id, EQ::skills::SkillType skill_id, uint8 level);
+	uint8 GetTrainLevel(uint8 class_id, EQ::skills::SkillType skill_id, uint8 level);
 	void LoadSkillCaps();
 	void ReloadSkillCaps();
-	static int32_t GetSkillCapMaxLevel(uint8 class_id, EQ::skills::SkillType skill_id);
 
 	SkillCaps *SetContentDatabase(Database *db);
 private:
 	Database                                    *m_content_database{};
-	std::map<uint64, SkillCapsRepository::SkillCaps> m_skill_caps = {};
+	std::vector<SkillCapsRepository::SkillCaps> m_skill_caps = {};
 };
 
 extern SkillCaps skill_caps;

common/skills.cpp

@@ -127,28 +127,22 @@ bool EQ::skills::IsCastingSkill(SkillType skill)
 int32 EQ::skills::GetBaseDamage(SkillType skill)
 {
 	switch (skill) {
-		case SkillArchery:
-			return RuleI(Combat, ArcheryBaseDamage);
-		case SkillBackstab:
-			return RuleI(Combat, BackstabBaseDamage);
 	case SkillBash:
-			return RuleI(Combat, BashBaseDamage);
+		return 2;
 	case SkillDragonPunch:
-			return RuleI(Combat, DragonPunchBaseDamage);
+		return 12;
 	case SkillEagleStrike:
-			return RuleI(Combat, EagleStrikeBaseDamage);
+		return 7;
 	case SkillFlyingKick:
-			return RuleI(Combat, FlyingKickBaseDamage);
+		return 25;
-		case SkillFrenzy:
-			return RuleI(Combat, FrenzyBaseDamage);
 	case SkillKick:
-			return RuleI(Combat, KickBaseDamage);
+		return 3;
 	case SkillRoundKick:
-			return RuleI(Combat, RoundKickBaseDamage);
+		return 5;
-		case SkillThrowing:
-			return RuleI(Combat, ThrowingBaseDamage);
 	case SkillTigerClaw:
-			return RuleI(Combat, TigerClawBaseDamage);
+		return 4;
+	case SkillFrenzy:
+		return 10;
 	default:
 		return 0;
 	}

common/spdat.cpp

@@ -431,16 +431,6 @@ bool IsCharmSpell(uint16 spell_id)
 	return IsEffectInSpell(spell_id, SE_Charm);
 }
 
-bool IsResurrectionSicknessSpell(uint16 spell_id) {
-	return (
-		spell_id == SPELL_RESURRECTION_SICKNESS ||
-		spell_id == SPELL_RESURRECTION_SICKNESS2 ||
-		spell_id == SPELL_RESURRECTION_SICKNESS3 ||
-		spell_id == SPELL_RESURRECTION_SICKNESS4 ||
-		spell_id == SPELL_REVIVAL_SICKNESS
-	);
-}
-
 bool IsBlindSpell(uint16 spell_id)
 {
 	return IsEffectInSpell(spell_id, SE_Blind);

common/spdat.h

@@ -904,7 +904,7 @@ typedef enum {
 #define SE_AlterNPCLevel				107	// implemented - not used on live
 #define SE_Familiar						108	// implemented
 #define SE_SummonItemIntoBag			109	// implemented - summons stuff into container
-#define SE_IncreaseArchery				110	// implemented
+//#define SE_IncreaseArchery			110	// not used
 #define SE_ResistAll					111	// implemented - Note: Physical Resists are not modified by this effect.
 #define SE_CastingLevel					112	// implemented
 #define	SE_SummonHorse					113	// implemented
@@ -916,7 +916,7 @@ typedef enum {
 #define SE_AttackSpeed3					119	// implemented
 #define SE_HealRate						120	// implemented - reduces healing by a %
 #define SE_ReverseDS					121 // implemented
-#define SE_ReduceSkill					122	// implemented - base: skill id, limit: none, max: none, formula: % skill is reduced (positive)
+//#define SE_ReduceSkill				122	// not implemented    TODO: Now used on live, decreases skills by percent
 #define SE_Screech						123	// implemented Spell Blocker(If have buff with value +1 will block any effect with -1)
 #define SE_ImprovedDamage				124 // implemented
 #define SE_ImprovedHeal					125 // implemented
@@ -1522,7 +1522,6 @@ bool IsSummonPetSpell(uint16 spell_id);
 bool IsSummonPCSpell(uint16 spell_id);
 bool IsPetSpell(uint16 spell_id);
 bool IsCharmSpell(uint16 spell_id);
-bool IsResurrectionSicknessSpell(uint16 spell_id);
 bool IsBlindSpell(uint16 spell_id);
 bool IsHealthSpell(uint16 spell_id);
 bool IsCastTimeReductionSpell(uint16 spell_id);

common/strings.cpp

@@ -745,15 +745,6 @@ bool Strings::Contains(const std::string& subject, const std::string& search)
 	return subject.find(search) != std::string::npos;
 }
 
-bool Strings::ContainsLower(const std::string& subject, const std::string& search)
-{
-	if (subject.length() < search.length()) {
-		return false;
-	}
-
-	return ToLower(subject).find(ToLower(search)) != std::string::npos;
-}
-
 uint32 Strings::TimeToSeconds(std::string time_string)
 {
 	if (time_string.empty()) {

common/strings.h

@@ -86,7 +86,6 @@ class Strings {
 public:
 	static bool Contains(std::vector<std::string> container, const std::string& element);
 	static bool Contains(const std::string& subject, const std::string& search);
-	static bool ContainsLower(const std::string& subject, const std::string& search);
 	static int ToInt(const std::string &s, int fallback = 0);
 	static int64 ToBigInt(const std::string &s, int64 fallback = 0);
 	static uint32 ToUnsignedInt(const std::string &s, uint32 fallback = 0);

common/version.h

@@ -25,7 +25,7 @@
 
 // Build variables
 // these get injected during the build pipeline
-#define CURRENT_VERSION "22.53.1-dev" // always append -dev to the current version for custom-builds
+#define CURRENT_VERSION "22.48.0-dev" // always append -dev to the current version for custom-builds
 #define LOGIN_VERSION "0.8.0"
 #define COMPILE_DATE    __DATE__
 #define COMPILE_TIME    __TIME__
@@ -42,8 +42,8 @@
  * Manifest: https://github.com/EQEmu/Server/blob/master/utils/sql/db_update_manifest.txt
  */
 
-#define CURRENT_BINARY_DATABASE_VERSION 9280
+#define CURRENT_BINARY_DATABASE_VERSION 9268
-#define CURRENT_BINARY_BOTS_DATABASE_VERSION 9044
+#define CURRENT_BINARY_BOTS_DATABASE_VERSION 9043
 
 #endif
 

common/zone_store.cpp

@@ -162,32 +162,6 @@ std::string ZoneStore::GetZoneLongName(uint32 zone_id)
 	return {};
 }
 
-std::string ZoneStore::GetZoneShortNameByLongName(const std::string& zone_long_name)
-{
-	for (const auto& z : m_zones) {
-		if (z.long_name == zone_long_name) {
-			return z.short_name;
-		}
-	}
-
-	LogInfo("Failed to get zone short name by zone_long_name [{}]", zone_long_name);
-
-	return {};
-}
-
-uint32 ZoneStore::GetZoneIDByLongName(const std::string& zone_long_name)
-{
-	for (const auto& z : m_zones) {
-		if (z.long_name == zone_long_name) {
-			return z.zoneidnumber;
-		}
-	}
-
-	LogInfo("Failed to get zone ID by zone_long_name [{}]", zone_long_name);
-
-	return 0;
-}
-
 /**
  * @param zone_id
  * @param version

common/zone_store.h

@@ -42,8 +42,6 @@ public:
 	uint32 GetZoneID(std::string zone_name);
 	std::string GetZoneName(uint32 zone_id);
 	std::string GetZoneLongName(uint32 zone_id);
-	std::string GetZoneShortNameByLongName(const std::string& zone_long_name);
-	uint32 GetZoneIDByLongName(const std::string& zone_long_name);
 	const char *GetZoneName(uint32 zone_id, bool error_unknown = false);
 	const char *GetZoneLongName(uint32 zone_id, bool error_unknown = false);
 	ZoneRepository::Zone *GetZoneWithFallback(uint32 zone_id, int version = 0);