From f9923ffda0ff87cbb73ccf0338601b5e2bc494a4 Mon Sep 17 00:00:00 2001
From: "Michael Cook (mackal)" <mcook@mackal.net>
Date: Fri, 12 Feb 2021 03:07:47 -0500
Subject: [PATCH] Fix va_list leaks in MakeAnyLenString/AppendAnyLenString
 (#1240)

Slowly leaking memory for ages!

clang-tidy complained about it
---
 common/string_util.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/string_util.cpp b/common/string_util.cpp
index 4b3b59eb1..7cd19c829 100644
--- a/common/string_util.cpp
+++ b/common/string_util.cpp
@@ -356,6 +356,7 @@ int MakeAnyLenString(char** ret, const char* format, ...) {
 		*ret = new char[buf_len];
 		va_copy(tmpargptr, argptr);
 		chars = vsnprintf(*ret, buf_len, format, tmpargptr);
+		va_end(tmpargptr);
 	}
 	va_end(argptr);
 	return chars;
@@ -384,6 +385,7 @@ uint32 AppendAnyLenString(char** ret, uint32* bufsize, uint32* strlen, const cha
 		}
 		va_copy(tmpargptr, argptr);
 		chars = vsnprintf(&(*ret)[*strlen], (*bufsize - *strlen), format, tmpargptr);
+		va_end(tmpargptr);
 	}
 	va_end(argptr);
 	*strlen += chars;