[Cleanup] Cleanup uses of insert/push_back when a temp object is used. (#3170)

This commit is contained in:
Aeadoin
2023-04-03 16:45:01 -04:00
committed by GitHub
parent 2bb15271c5
commit f752b57a55
42 changed files with 104 additions and 104 deletions
+4 -4
View File
@@ -6052,14 +6052,14 @@ void Mob::AddFactionBonus(uint32 pFactionID,int32 bonus) {
faction_bonus = faction_bonuses.find(pFactionID);
if(faction_bonus == faction_bonuses.end())
{
faction_bonuses.insert(NewFactionBonus(pFactionID,bonus));
faction_bonuses.emplace(NewFactionBonus(pFactionID,bonus));
}
else
{
if(faction_bonus->second<bonus)
{
faction_bonuses.erase(pFactionID);
faction_bonuses.insert(NewFactionBonus(pFactionID,bonus));
faction_bonuses.emplace(NewFactionBonus(pFactionID,bonus));
}
}
}
@@ -6072,14 +6072,14 @@ void Mob::AddItemFactionBonus(uint32 pFactionID,int32 bonus) {
faction_bonus = item_faction_bonuses.find(pFactionID);
if(faction_bonus == item_faction_bonuses.end())
{
item_faction_bonuses.insert(NewFactionBonus(pFactionID,bonus));
item_faction_bonuses.emplace(NewFactionBonus(pFactionID,bonus));
}
else
{
if((bonus > 0 && faction_bonus->second < bonus) || (bonus < 0 && faction_bonus->second > bonus))
{
item_faction_bonuses.erase(pFactionID);
item_faction_bonuses.insert(NewFactionBonus(pFactionID,bonus));
item_faction_bonuses.emplace(NewFactionBonus(pFactionID,bonus));
}
}
}