[Spells] Implemented SPA 512 SE_Proc_Timer_Modifier, Fixed AA procs not working (#1646)

* update for SPA 511

* remove debugs, AA implemented

* update

* twinprocfix

* AA procs added

* format update

* update

* proctimer limits

* update

* rename function

renamed function
only check for buffs value > 0, don't need to check for AA's which are negative ID's

* pre merge

* variable updates

* Update spell_effects.cpp

* var rename

update var name to better represent its function.

* updated proc struct

added reuse timer

* reuse timer to spell procs

* updates

* debug remove

* Update mob.cpp

* fix

* merge

common/spdat.cpp

@@ -1597,3 +1597,38 @@ int32 GetViralSpreadRange(int32 spell_id)
 {
 	return spells[spell_id].viral_range;
 }
+
+uint32 GetProcLimitTimer(int32 spell_id, int proc_type) {
+
+	//This allows for support for effects that may have multiple different proc types and timers.
+	if (!IsValidSpell(spell_id)) {
+		return 0;
+	}
+		
+	bool use_next_timer = false;
+	for (int i = 0; i < EFFECT_COUNT; ++i) {
+
+		if (proc_type == SE_WeaponProc) {
+			if (spells[spell_id].effect_id[i] == SE_WeaponProc || spells[spell_id].effect_id[i] == SE_AddMeleeProc) {
+				use_next_timer = true;
+			}
+		}
+
+		if (proc_type == SE_RangedProc) {
+			if (spells[spell_id].effect_id[i] == SE_RangedProc) {
+				use_next_timer = true;
+			}
+		}
+
+		if (proc_type == SE_DefensiveProc) {
+			if (spells[spell_id].effect_id[i] == SE_DefensiveProc) {
+				use_next_timer = true;
+			}
+		}
+
+		if (use_next_timer && spells[spell_id].effect_id[i] == SE_Proc_Timer_Modifier) {
+			return spells[spell_id].limit_value[i];
+		}
+	}
+	return 0;
+}

common/spdat.h

@@ -179,8 +179,11 @@
 #define MAX_RESISTABLE_EFFECTS 12	// Number of effects that are typcially checked agianst resists.
 #define MaxLimitInclude 16 //Number(x 0.5) of focus Limiters that have inclusive checks used when calcing focus effects
 #define MAX_SKILL_PROCS 4 //Number of spells to check skill procs from. (This is arbitrary) [Single spell can have multiple proc checks]
+#define MAX_AA_PROCS 16 //(Actual Proc Amount is MAX_AA_PROCS/4) Number of spells to check AA procs from. (This is arbitrary)
 #define MAX_SYMPATHETIC_PROCS 10 // Number of sympathetic procs a client can have (This is arbitrary)
-#define MAX_FOCUS_PROC_LIMIT_TIMERS 20 //Number of proc limiting timers that can be going at same time (This is arbitrary)
+#define MAX_FOCUS_PROC_LIMIT_TIMERS 20 //Number of focus recast timers that can be going at same time (This is arbitrary)
+#define MAX_PROC_LIMIT_TIMERS 8 //Number of proc delay timers that can be going at same time, different proc types get their own timer array. (This is arbitrary)
+
 
 
 const int Z_AGGRO=10;
@@ -1209,7 +1212,7 @@ typedef enum {
 #define SE_Health_Transfer				509 // implemented - exchange health for damage or healing on a target. ie Lifeburn/Act of Valor
 #define SE_Fc_ResistIncoming			510 // implemented, @Fc, On Target, resist modifier, base: amt
 #define SE_Ff_FocusTimerMin				511 // implemented, @Ff, sets a recast time until focus can be used again, base: 1, limit: time ms, Note:  ie. limit to 1 trigger every 1.5 seconds 
-#define SE_Proc_Timer_Modifier 			512 // not implemented - limits procs per amount of a time based on timer value (ie limit to 1 proc every 55 seconds)
+#define SE_Proc_Timer_Modifier 			512 // implemented - limits procs per amount of a time based on timer value, base: 1, limit: time ms, Note:, ie limit to 1 proc every 55 seconds)
 //#define SE_Mana_Max_Percent			513 //
 //#define SE_Endurance_Max_Percent		514 //
 #define SE_AC_Avoidance_Max_Percent		515 // implemented - stackable avoidance modifier
@@ -1514,6 +1517,7 @@ int GetViralMinSpreadTime(int32 spell_id);
 int GetViralMaxSpreadTime(int32 spell_id);
 int GetViralSpreadRange(int32 spell_id);
 bool IsInstrumentModAppliedToSpellEffect(int32 spell_id, int effect);
+uint32 GetProcLimitTimer(int32 spell_id, int proc_type);
 
 int CalcPetHp(int levelb, int classb, int STA = 75);
 int GetSpellEffectDescNum(uint16 spell_id);