pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-11 21:01:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Bug Fix] Guild Message Limits (#3724)

Browse Source 
Mail to 'Guild' was failing after after 50ish members.
The buffer was set at 512, which cut truncated the message and caused the issue.
Refactored to adjust the size of the buffer based on the inbound message size.
This commit is contained in:
Mitch Freeman 2023-11-28 20:03:32 -04:00 committed by GitHub
parent cf1f8d5460
commit e75c31d524
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
zone/worldserver.cpp
View File

@ -3393,17 +3393,20 @@ void WorldServer::HandleMessage(uint16 opcode, const EQ::Net::Packet &p)
}
bool WorldServer::SendChannelMessage(Client* from, const char* to, uint8 chan_num, uint32 guilddbid, uint8 language, uint8 lang_skill, const char* message, ...) {
if (!worldserver.Connected())
if (!worldserver.Connected()) {
return false;
}
va_list argptr;
char buffer[512];
auto length = strlen(message) + 1;
char* buffer = new char[length];
va_start(argptr, message);
vsnprintf(buffer, 512, message, argptr);
vsnprintf(buffer, length, message, argptr);
va_end(argptr);
buffer[511] = '\0';
buffer[length - 1] = '\0';
auto pack = new ServerPacket(ServerOP_ChannelMessage, sizeof(ServerChannelMessage_Struct) + strlen(buffer) + 1);
auto pack = new ServerPacket(ServerOP_ChannelMessage, sizeof(ServerChannelMessage_Struct) + length);
ServerChannelMessage_Struct* scm = (ServerChannelMessage_Struct*)pack->pBuffer;
if (from == 0) {
@ -3432,6 +3435,7 @@ bool WorldServer::SendChannelMessage(Client* from, const char* to, uint8 chan_nu
bool ret = SendPacket(pack);
safe_delete(pack);
safe_delete_array(buffer);
return ret;
}