[Bug Fix] Harm Touch Critical Ratio (#3915)

* [Bug] HT Crit Ratio

This is used to tune and bring HT Crits more in line with the correct values as proven in screenshots.

* requested changes

* mistakenly kept mob::
This commit is contained in:
Fryguy
2024-01-08 23:27:56 -05:00
committed by GitHub
parent ec465616b4
commit e6dc980315
5 changed files with 19 additions and 12 deletions
+1
View File
@@ -478,6 +478,7 @@ RULE_BOOL(Spells, CharmAggroOverLevel, false, "Enabling this rule will cause Cha
RULE_BOOL(Spells, RequireMnemonicRetention, true, "Enabling will require spell slots 9-12 to have the appropriate Mnemonic Retention AA learned.")
RULE_BOOL(Spells, EvacClearCharmPet, false, "Enable to have evac in zone clear charm from charm pets and detach buffs.")
RULE_BOOL(Spells, ManaTapsRequireNPCMana, false, "Enabling will require target to have mana to tap. Default off as many npc's are caster class with 0 mana and need fixed.")
RULE_INT(Spells, HarmTouchCritRatio, 200, "Harmtouch crit bonus, on top of BaseCritRatio")
RULE_CATEGORY_END()
RULE_CATEGORY(Combat)
+7
View File
@@ -769,6 +769,13 @@ bool IsValidSpell(uint32 spell_id)
return false;
}
bool IsHarmTouchSpell(uint16 spell_id)
{
return spell_id == SPELL_HARM_TOUCH ||
spell_id == SPELL_HARM_TOUCH2 ||
spell_id == SPELL_IMP_HARM_TOUCH;
}
// returns the lowest level of any caster which can use the spell
uint8 GetSpellMinimumLevel(uint16 spell_id)
{
+1
View File
@@ -1547,6 +1547,7 @@ bool IsSummonSpell(uint16 spell_id);
bool IsDamageSpell(uint16 spell_id);
bool IsFearSpell(uint16 spell_id);
bool IsCureSpell(uint16 spell_id);
bool IsHarmTouchSpell(uint16 spell_id);
int GetSpellEffectIndex(uint16 spell_id, int effect_id);
uint8 GetSpellMinimumLevel(uint16 spell_id);
uint8 GetSpellLevel(uint16 spell_id, uint8 class_id);