pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-21 10:11:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[BugFix] Charm Targeting and other issues. (#1655)

Browse Source 
* fix for target change bug on client

* Update spell_effects.cpp
This commit is contained in:
KayenEQ 2021-10-30 17:48:55 -04:00 committed by GitHub
parent 4389f84ea5
commit df3161455a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zone/entity.cpp
View File

@ -1514,9 +1514,11 @@ void EntityList::RemoveFromTargets(Mob *mob, bool RemoveFromXTargets)
mob->CastToClient()->RemoveXTarget(m, false); mob->CastToClient()->RemoveXTarget(m, false);
} }
if (m->IsAIControlled()) {
m->RemoveFromHateList(mob); m->RemoveFromHateList(mob);
} }
} }
}
void EntityList::RemoveFromXTargets(Mob *mob) void EntityList::RemoveFromXTargets(Mob *mob)
{ {

2
zone/mob.cpp
View File

@ -2875,7 +2875,7 @@ bool Mob::RemoveFromHateList(Mob* mob)
ResetAssistCap(); ResetAssistCap();
} }
} }
if(GetTarget() == mob) if(IsAIControlled() && GetTarget() == mob)
{ {
SetTarget(hate_list.GetEntWithMostHateOnList(this)); SetTarget(hate_list.GetEntWithMostHateOnList(this));
} }

39
zone/spell_effects.cpp
View File

@ -731,6 +731,27 @@ bool Mob::SpellEffect(Mob* caster, uint16 spell_id, float partial, int level_ove
if (!caster) // can't be someone's pet unless we know who that someone is if (!caster) // can't be someone's pet unless we know who that someone is
break; break;
if (IsClient() && caster->IsClient()) {
caster->Message(Chat::White, "Unable to cast charm on a fellow player.");
BuffFadeByEffect(SE_Charm);
break;
}
else if (IsCorpse()) {
caster->Message(Chat::White, "Unable to cast charm on a corpse.");
BuffFadeByEffect(SE_Charm);
break;
}
else if (caster->GetPet() != nullptr && caster->IsClient()) {
caster->Message(Chat::White, "You cannot charm something when you already have a pet.");
BuffFadeByEffect(SE_Charm);
break;
}
else if (GetOwner()) {
caster->Message(Chat::White, "You cannot charm someone else's pet!");
BuffFadeByEffect(SE_Charm);
break;
}
if(IsNPC()) if(IsNPC())
{ {
CastToNPC()->SaveGuardSpotCharm(); CastToNPC()->SaveGuardSpotCharm();
@ -740,24 +761,6 @@ bool Mob::SpellEffect(Mob* caster, uint16 spell_id, float partial, int level_ove
entity_list.RemoveFromTargets(this); entity_list.RemoveFromTargets(this);
WipeHateList(); WipeHateList();
if (IsClient() && caster->IsClient()) {
caster->Message(Chat::White, "Unable to cast charm on a fellow player.");
BuffFadeByEffect(SE_Charm);
break;
} else if(IsCorpse()) {
caster->Message(Chat::White, "Unable to cast charm on a corpse.");
BuffFadeByEffect(SE_Charm);
break;
} else if(caster->GetPet() != nullptr && caster->IsClient()) {
caster->Message(Chat::White, "You cannot charm something when you already have a pet.");
BuffFadeByEffect(SE_Charm);
break;
} else if(GetOwner()) {
caster->Message(Chat::White, "You cannot charm someone else's pet!");
BuffFadeByEffect(SE_Charm);
break;
}
Mob *my_pet = GetPet(); Mob *my_pet = GetPet();
if(my_pet) if(my_pet)
{ {