From db9fe0f284ce181785df69880ef614287188d8fc Mon Sep 17 00:00:00 2001 From: nytmyr <53322305+nytmyr@users.noreply.github.com> Date: Sun, 2 Feb 2025 08:21:07 -0600 Subject: [PATCH] Simplify case SE_Illusion and SE_IllusionCopy for GetIllusionBlock --- zone/spell_effects.cpp | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/zone/spell_effects.cpp b/zone/spell_effects.cpp index 910298ce1..b148d6cff 100644 --- a/zone/spell_effects.cpp +++ b/zone/spell_effects.cpp @@ -1481,15 +1481,10 @@ bool Mob::SpellEffect(Mob* caster, uint16 spell_id, float partial, int level_ove snprintf(effect_desc, _EDLEN, "Illusion: race %d", effect_value); #endif if (caster && caster->IsOfClientBot()) { - if (IsClient()) { - if (CastToClient()->GetIllusionBlock()) { - break; - } - } - else { - if (CastToBot()->GetIllusionBlock()) { - break; - } + auto target = IsClient() ? CastToClient() : CastToBot(); + + if (target && target->GetIllusionBlock()) { + break; } } @@ -1503,15 +1498,10 @@ bool Mob::SpellEffect(Mob* caster, uint16 spell_id, float partial, int level_ove snprintf(effect_desc, _EDLEN, "Illusion Copy"); #endif if (caster && caster->IsOfClientBot()) { - if (IsClient()) { - if (CastToClient()->GetIllusionBlock()) { - break; - } - } - else { - if (CastToBot()->GetIllusionBlock()) { - break; - } + auto target = IsClient() ? CastToClient() : CastToBot(); + + if (target && target->GetIllusionBlock()) { + break; } }