pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-06-13 02:38:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Address review: consistent TransactionBegin, remove DDL rollback test, revert build.yaml vcpkg steps

Browse Source 
Co-authored-by: Valorith <76063792+Valorith@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-03-09 01:11:23 +00:00
parent f73f1d8262
commit d8edd960f9
3 changed files with 4 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/zonedb.cpp
+4 -10
View File
@@ -2925,16 +2925,7 @@ void ZoneDatabase::SaveBuffs(Client *client)
v.emplace_back(e);
}
const auto begin_result = database.QueryDatabase("START TRANSACTION");
if (!begin_result.Success()) {
LogError(
"Failed to begin buff save transaction for character [{}] [{}]: {}",
client->GetCleanName(),
client->CharacterID(),
begin_result.ErrorMessage()
);
return;
}
database.TransactionBegin();
const auto delete_result = database.QueryDatabase(
fmt::format(
@@ -2954,6 +2945,9 @@ void ZoneDatabase::SaveBuffs(Client *client)
}
if (!v.empty()) {
// Use < rather than != because REPLACE INTO can report 2× affected rows when it replaces
// an existing row (delete + insert). Since we DELETE first in the same transaction, these
// are always pure inserts, but < is more defensive and avoids false-positive failures.
const auto saved_count = CharacterBuffsRepository::ReplaceMany(database, v);
if (saved_count < static_cast<int>(v.size())) {
database.TransactionRollback();