pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-05-16 22:58:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Change emptiness checks to empty() from size() [clang-tidy]

Browse Source 
This has two benefits, it's clear what we are checking and
size() isn't always constant time, where empty is (performance!)
This commit is contained in:
Michael Cook (mackal)
2016-05-25 14:57:47 -04:00
parent c43d436b1f
commit cdbeb24a05
16 changed files with 45 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ucs/clientlist.cpp
+2 -2
View File
@@ -2326,7 +2326,7 @@ void Client::SendFriends() {
std::string Client::MailBoxName() {
if((Characters.size() == 0) || (CurrentMailBox > (Characters.size() - 1)))
if((Characters.empty()) || (CurrentMailBox > (Characters.size() - 1)))
{
Log.Out(Logs::Detail, Logs::UCS_Server, "MailBoxName() called with CurrentMailBox set to %i and Characters.size() is %i",
CurrentMailBox, Characters.size());
@@ -2343,7 +2343,7 @@ std::string Client::MailBoxName() {
int Client::GetCharID() {
if(Characters.size() == 0)
if(Characters.empty())
return 0;
return Characters[0].CharID;