From c2e40820452aee5c0822d91ef3099f4405dcd13a Mon Sep 17 00:00:00 2001
From: Mitch Freeman <65987027+neckkola@users.noreply.github.com>
Date: Sun, 25 Feb 2024 00:46:42 -0400
Subject: [PATCH] [Bug Fix] Crash on Ubuntu 22.04 (#4119)

Ubuntu 22.04 as of Feb 25 2024 was crashing when sending guild tributes on zone in.  Issue was caused by an overrun on string copies.
Updated to use strn0cpy, crash was resolved.
---
 zone/tribute.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/zone/tribute.cpp b/zone/tribute.cpp
index 49d93b0ff..abac9a88f 100644
--- a/zone/tribute.cpp
+++ b/zone/tribute.cpp
@@ -411,7 +411,7 @@ void Client::SendGuildTributes()
 			gtas->ability.tiers[ti].tribute_item_id = htonl(t.second.tiers[ti].tribute_item_id);
 			gtas->ability.tiers[ti].level = htonl(t.second.tiers[ti].level);
 		}
-		strcpy(gtas->ability.name, t.second.name.data());
+		strn0cpy(gtas->ability.name, t.second.name.data(), t.second.name.length());
 		FastQueuePacket(&outapp);
 	}
 }
@@ -432,7 +432,7 @@ void Client::SendGuildTributeDetails(uint32 tribute_id, uint32 tier)
 	t->tribute_id = tribute_id;
 	t->tier = tier;
 	t->tribute_id2 = tribute_id;
-	strncpy(&t->description, td.description.c_str(), len);
+	strn0cpy(&t->description, td.description.c_str(), len);
 
 	QueuePacket(outapp);
 	safe_delete(outapp);
@@ -556,7 +556,7 @@ void Client::SendGuildTributeOptInToggle(const GuildTributeMemberToggle* in)
 	EQApplicationPacket* outapp = new EQApplicationPacket(OP_GuildOptInOut, sizeof(GuildTributeOptInOutReply_Struct));
 	GuildTributeOptInOutReply_Struct* data = (GuildTributeOptInOutReply_Struct*)outapp->pBuffer;
 
-	strncpy(data->player_name, in->player_name, 64);
+	strn0cpy(data->player_name, in->player_name, sizeof(data->player_name));
 	data->guild_id              = in->guild_id;
 	data->no_donations          = in->no_donations;
 	data->tribute_toggle        = in->tribute_toggle;