From c1d4cb90b9355637acb7135758890cdf004b6e15 Mon Sep 17 00:00:00 2001 From: Alex King <89047260+Kinglykrab@users.noreply.github.com> Date: Wed, 5 Apr 2023 12:14:01 -0400 Subject: [PATCH] [Cleanup] Cleanup cheap-to-copy reference to use value instead in eq_stream_ident.cpp/eq_stream_ident.h (#3209) # Notes - More performant to pass by value than by reference. --- common/eq_stream_ident.cpp | 2 +- common/eq_stream_ident.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/eq_stream_ident.cpp b/common/eq_stream_ident.cpp index 764c77143..8668b7220 100644 --- a/common/eq_stream_ident.cpp +++ b/common/eq_stream_ident.cpp @@ -26,7 +26,7 @@ EQStreamIdentifier::~EQStreamIdentifier() { } } -void EQStreamIdentifier::RegisterPatch(const EQStreamInterface::Signature &sig, const char *name, OpcodeManager ** opcodes, const StructStrategy *structs) { +void EQStreamIdentifier::RegisterPatch(EQStreamInterface::Signature sig, const char *name, OpcodeManager ** opcodes, const StructStrategy *structs) { auto p = new Patch; p->signature = sig; p->name = name; diff --git a/common/eq_stream_ident.h b/common/eq_stream_ident.h index 483d48372..e34db5879 100644 --- a/common/eq_stream_ident.h +++ b/common/eq_stream_ident.h @@ -18,7 +18,7 @@ public: ~EQStreamIdentifier(); //registration interface. - void RegisterPatch(const EQStreamInterface::Signature &sig, const char *name, OpcodeManager ** opcodes, const StructStrategy *structs); + void RegisterPatch(EQStreamInterface::Signature sig, const char *name, OpcodeManager ** opcodes, const StructStrategy *structs); //main processing interface void Process();