[Repositories] Cleanup and Convert Character Creation to Repositories (#4053)

* [Repositories] Cleanup and Convert Character Creation to Repositories

# Notes
- Converts `Database::GetCharacterID()`, `Database::SaveCharacterCreate()`, and `Client::OPCharCreate` to repositories.
- Cleanup a spot we were doing a queries in a loop.

* Cleanup

* Update database.cpp

* Update database.cpp
This commit is contained in:
Alex King
2024-02-19 21:45:18 -05:00
committed by GitHub
parent d182fc3613
commit c13ec5a06d
10 changed files with 303 additions and 491 deletions
+1 -1
View File
@@ -126,7 +126,7 @@ bool ExpeditionRequest::CanGroupRequest(Group* group)
// Group::GetLeaderName() is broken if group formed across zones, ask database instead
m_leader_name = m_leader ? m_leader->GetName() : GetGroupLeaderName(group->GetID()); // group->GetLeaderName();
m_leader_id = m_leader ? m_leader->CharacterID() : database.GetCharacterID(m_leader_name.c_str());
m_leader_id = m_leader ? m_leader->CharacterID() : database.GetCharacterID(m_leader_name);
std::vector<std::string> member_names;
member_names.emplace_back(m_leader_name); // leader always added first