mirror of
https://github.com/EQEmu/Server.git
synced 2026-05-16 18:52:22 +00:00
[Bug Fix] Fix _PutItem having a slot_id of -1 on mobs with no items (#3474)
# Notes - This was causing an insane amount of error logs because we were always using `PutItem`, even with a `slot_id` of `-1`.
This commit is contained in:
+10
-3
@@ -299,7 +299,7 @@ void NPC::AddLootDrop(
|
||||
uint32 aug6
|
||||
)
|
||||
{
|
||||
if (item2 == nullptr) {
|
||||
if (!item2) {
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -363,7 +363,7 @@ void NPC::AddLootDrop(
|
||||
|
||||
bool found = false; // track if we found an empty slot we fit into
|
||||
|
||||
int foundslot = -1; // for multi-slot items
|
||||
int foundslot = INVALID_INDEX; // for multi-slot items
|
||||
|
||||
const auto* inst = database.CreateItem(
|
||||
item2->ID,
|
||||
@@ -376,6 +376,10 @@ void NPC::AddLootDrop(
|
||||
aug6
|
||||
);
|
||||
|
||||
if (!inst) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (loot_drop.equip_item > 0) {
|
||||
uint8 eslot = 0xFF;
|
||||
char newid[20];
|
||||
@@ -524,7 +528,10 @@ void NPC::AddLootDrop(
|
||||
}
|
||||
|
||||
if (itemlist) {
|
||||
GetInv().PutItem(foundslot, *inst);
|
||||
if (foundslot != INVALID_INDEX) {
|
||||
GetInv().PutItem(foundslot, *inst);
|
||||
}
|
||||
|
||||
itemlist->push_back(item);
|
||||
} else {
|
||||
safe_delete(item);
|
||||
|
||||
Reference in New Issue
Block a user