From a40e1cf8939bde158278fa661331728e3c430d31 Mon Sep 17 00:00:00 2001 From: Alex King <89047260+Kinglykrab@users.noreply.github.com> Date: Wed, 5 Apr 2023 11:15:22 -0400 Subject: [PATCH] [Cleanup] Add missing breaks and returns in bonuses.cpp (#3231) # Notes - Many spots were missing a `break;` or a `return` for their value. --- zone/bonuses.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/zone/bonuses.cpp b/zone/bonuses.cpp index a14af8f58..64512ade5 100644 --- a/zone/bonuses.cpp +++ b/zone/bonuses.cpp @@ -1225,6 +1225,7 @@ void Mob::ApplyAABonuses(const AA::Rank &rank, StatBonuses *newbon) newbon->HitChanceEffect[EQ::skills::HIGHEST_SKILL + 1] += base_value; else newbon->HitChanceEffect[limit_value] += base_value; + break; } case SE_ProcOnKillShot: @@ -1405,6 +1406,7 @@ void Mob::ApplyAABonuses(const AA::Rank &rank, StatBonuses *newbon) break; } } + break; } case SE_DamageModifier: { @@ -3532,6 +3534,7 @@ void Mob::ApplySpellsBonuses(uint16 spell_id, uint8 casterlevel, StatBonuses *ne case SE_DoubleRiposte: { new_bonus->DoubleRiposte += effect_value; + break; } case SE_GiveDoubleRiposte: @@ -3817,6 +3820,7 @@ void Mob::ApplySpellsBonuses(uint16 spell_id, uint8 casterlevel, StatBonuses *ne break; } } + break; } case SE_PC_Pet_Rampage: { @@ -4320,11 +4324,11 @@ uint8 Mob::IsFocusEffect(uint16 spell_id,int effect_index, bool AA,uint32 aa_eff case SE_SpellResistReduction: return focusResistRate; case SE_Fc_ResistIncoming: - focusFcResistIncoming; + return focusFcResistIncoming; case SE_Fc_Amplify_Mod: - focusFcAmplifyMod; + return focusFcAmplifyMod; case SE_Fc_Amplify_Amt: - focusFcAmplifyAmt; + return focusFcAmplifyAmt; case SE_SpellHateMod: return focusSpellHateMod; case SE_ReduceReuseTimer: