[Shared Tasks] Task Kill Update Fix (#1573)

* Revert "Revert "Shared task kill update fix""

This reverts commit 859751f74d.

* Swap return for continue in this context

* Slight tweak

* Slight tweak

* Remove no longer needed task methods

* Update scope for IncrementDoneCount

* Create helper method Client::GetPartyMembers() and add client->HasTaskState()

* Move HandleUpdateTasksOnKill responsibility to TaskManager

* Remove unnecessary pointer
This commit is contained in:
Chris Miles
2021-10-01 22:57:00 -05:00
committed by GitHub
parent bb5c491794
commit 9a413cf553
8 changed files with 140 additions and 126 deletions
-3
View File
@@ -34,7 +34,6 @@ public:
void RemoveTask(Client *client, int sequence_number, TaskType task_type);
void RemoveTaskByTaskID(Client *client, uint32 task_id);
bool UpdateTasksByNPC(Client *client, TaskActivityType activity_type, int npc_type_id);
void UpdateTasksOnKill(Client *client, int npc_type_id);
void UpdateTasksForItem(Client *client, TaskActivityType activity_type, int item_id, int count = 1);
void UpdateTasksOnExplore(Client *client, int explore_id);
bool UpdateTasksOnSpeakWith(Client *client, int npc_type_id);
@@ -74,8 +73,6 @@ public:
const ClientTaskInformation &GetActiveSharedTask() const;
bool HasActiveSharedTask();
void HandleUpdateTasksOnKill(Client *client, uint32 npc_type_id);
private:
void AddReplayTimer(Client *client, ClientTaskInformation& client_task, TaskInformation& task);